- Aug 23, 2023
-
-
Sybille Peters authored
The following problems are now fixed: 1. do not check links on hidden pages (if checkhidden=0) 2. show links on hidden pages (if checkhidden=1) Also, unit tests are introduced for PagesRepository. More functional tests can be added in additional patches. Resolves: #93895 Releases: main, 12.4 Change-Id: Id8fc2ea6df4d0c8d1adbaee114d5a4a6d556b8d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80661 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
core-ci <typo3@b13.com>
-
Ingo Fabbri authored
This commit adds two new keys to table sys_log: - channel - level Resolves: #101707 Releases: main, 12.4 Change-Id: Iddc61daf268573c658a068a655b97c482e438c31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80660 Tested-by:
-
Andreas Fernandez authored
When a backend user is created via the Install Tool, a notification is rendered to tell the system maintainer that the action was successful. However, the original patch mixed up the title and the message, which is now fixed. Resolves: #101741 Related: #91461 Releases: main, 12.4, 11.5 Change-Id: Ie25efa0476a118cfaa99a54d3cb4fe27ca5ef8e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80675 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Garvin Hicking authored
The 'uuid' FormEngine TCA element misses the call to render registered field controls. Add it and merge it into rendered HTML. Resolves: #101740 Related: #101703 Related: #100171 Releases: main, 12.4 Change-Id: I18983883d2ae4460929a40aa3ccee1a7c261ab63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80656 Tested-by:
-
Andreas Fernandez authored
This patch makes use of `PathUtility::getAbsoluteWebPath()` in EXT:indexed_search's SearchController which is suitable for calculating asset paths in both, Composer and non-Composer scenarios. Resolves: #101727 Releases: main, 12.4, 11.5 Change-Id: I88f487b1fdf88b404fc51a3d5d6131dba5483cdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80673 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Dominic Petit authored
Allow to save a phone link with a comma or a semicolon. Resolves: #101721 Releases: main, 12.4, 11.5 Change-Id: I54e19fbfb2b1b184db4454a19728f08e70cddc4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80654 Tested-by:
-
Stefan Bürk authored
This change reduces the column length for `tablenames` and `fieldname` for TCA based auto-creation to the max possible length of 64. This reduces the needed size for the auto-created primary key and ensure a working index for instances using mysql or mariadb server backends without increased maximum innodb index key length. Resolves: #101731 Related: #101425 Releases: main, 12.4 Change-Id: Iba40730687a7033ea2f43c0aa6049f9df1212683 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80672 Tested-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
-
Garvin Hicking authored
FormEngine fieldControl "passwordGenerator" can be handy with TCA type="input" as well. The patch removes a restriction in PasswordGenerator that binds this fieldControl exclusively to TCA type="password". Resolves: #101703 Related: #98540 Releases: main, 12.4 Change-Id: Ice09e0af2269d5f0aad5afa2d08215d51a04e394 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80653 Tested-by:
-
Sybille Peters authored
If there is not a newline before and after the list, the list may not be formatted correctly. A newline was added before and after lists in .rst files. Additionally, some lines beginning with "- " (which would result in false positives when checking) were modified so that list checking can be performed more easily in the future. Lists can be checked for example by using the following regular expressions: find typo3/sysext/*/Documentation -name "*.rst" | while read i;do grep -B1 -H -E "^(\-|\*)\s" "$i" | grep "\.rst-" \ | grep -v -E "\.rst-($|\-|\*|\s)" grep -A1 -H -E "^(\-|\*)\s" "$i" | grep "\.rst-" \ | grep -v -E "\.rst-($|\-|\*|\s)" done https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/ \ WritingReST/CommonPitfalls/Lists.html Resolves: #101715 Releases: main, 12.4, 11.5 Change-Id: I8dca5634ae3dcd7e702197cb72b43d79a05f3f5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80631 Tested-by:
-
- Aug 22, 2023
-
-
Christian Kuhn authored
ext:form tends to use email addresses as TypoScript identifier. The old TS parser did not deal with this, the new one does. The patch adds tests to the TS tokenizer to verify this works. Resolves: #101732 Related: #97816 Related: #92902 Releases: main, 12.4 Change-Id: If1ee1dfe9c136316e67c05c4f1c1740018c1fd60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80620 Tested-by:
-
Timo Gurr authored
On recent MariaDB versions >= 10.6 utf8 is an alias for utf8mb3 while until MariaDB 10.5 utf8mb3 was an alias for utf8. https://mariadb.com/kb/en/unicode/ Resolves: #101719 Releases: main, 12.4, 11.5 Change-Id: Ida8a5b89fd99f9ff196d496ddb34d55c9657daf5 Reviewed-by:
Timo Gurr <timo.gurr@gmail.com> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80615 Tested-by:
-
Benni Mack authored
Even though the <f:translate> ViewHelper has a "languageKey" argument, the parameter was only evaluated for Extbase requests. However, it should also be possible for non-Extbase Fluid parts - such as Fluid emails. The patch adds the "languageKey" handling and refactors the tests to rely on a fixture extension. Tests are added for "languageKey" scenarios including fallback chains. The new tests reveal a bug in extbase LocalizationUtility with fallback chains along the way, keeps according tests as skipped, and adds `@todo` for further investigation. Resolves: #101710 Related: #98377 Releases: main, 12.4 Change-Id: I5251a69c385b50d844d8e24b363109e03596cc6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80614 Tested-by:
-
- Aug 18, 2023
-
-
Nikita Hovratov authored
The Filelist module got renamed to "media_management" from "file_FilelistList" in TYPO3 v12. Hence, the module storage identifier needs to be changed to "media" as well. Resolves: #101685 Related: #100279 Releases: main, 12.4 Change-Id: Ic2e5b06426411f122551b0745fb43b18497b247c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80594 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Simon Gilli authored
see https://github.com/TYPO3/html-sanitizer/releases/tag/v2.1.3 composer req typo3/html-sanitizer:^2.1.3 composer req typo3/html-sanitizer:^2.1.3 \ -d typo3/sysext/core --no-update Resolves: #101705 Releases: main, 12.4, 11.5 Change-Id: I3e3152663b7b7804b01c8cd9b28393132efab628 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80571 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Sybille Peters authored
Fix handling link attributes (such as target, title) in link browser. The attributes were formerly not always applied to the link currently being edited. The problem appeared to be that the current selection in the editor lost focus and when link attributes were handled for this case, only the href attribute was applied. This is a follow-up patch for patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/80034 which did not fully resolve problems with setting the link attributes. Resolves: #101638 Related: #101360 Related: #101205 Releases: main, 12.4 Change-Id: Id5aeaae11341169b7a7bda15f62aeb2937486f88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80576 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
- Aug 17, 2023
-
-
Torben Hansen authored
If the CKEditor configuration has a language configuration, but does not define the `ui` language setting, no fallback language is added to the editor configuration and an undefined array key exception is thrown. This change ensures, that the `ui` language is properly set when the editor configuration has a language configuration and the `ui` language is missing. Resolves: #101401 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Id8bc03fd832413cf6ed1f9c5d443fa9f3387811c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80575 Tested-by:
-
Chris Müller authored
Resolves: #101672 Releases: main, 12.4 Change-Id: If00942d0876e36be53d745e099b8507c26f66cfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80574 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Aug 16, 2023
-
-
Andreas Fernandez authored
The methods `createRenderRoot()` and `render()` are considered being protected, but were public in some cases my mistake. This doesn't have any functional impact, but is now fixed nonetheless. Resolves: #101689 Releases: main, 12.4 Change-Id: I6bb88f90a8a44e0118dd8203433a54517b5dfa2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80561 Tested-by:
-
Nikita Hovratov authored
Since the major refactoring of ElementBrowsers into the file list module the order in which the currently selected folder from the user is loaded got messed up. The retrieval of the folder was moved from the render method to the initialization chain. However, at this point the session data is not processed yet. To fix this, the folder retrieval is moved back to the start of the render method. Resolves: #100837 Related: #99861 Releases: main, 12.4 Change-Id: I410306c8c1641e538367d6773474a660e9f383e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80573 Tested-by:
-
Andreas Fernandez authored
Google Chrome (and other browser vendors will probably follow) deprecates the unload event with Chrome 117 [1] and encourages using the Page Lifecycle API [2] instead. This patch replaces any usage of the `unload` event with the `pagehide` event that is available for all supported browsers [3]. [1] https://developer.chrome.com/en/blog/deprecating-unload/ [2] https://developer.chrome.com/blog/page-lifecycle-api/ [3] https://caniuse.com/mdn-api_window_pagehide_event Resolves: #101662 Releases: main, 12.4, 11.5 Change-Id: I675b180e855d8fb1070a84f5ba865e9250b2c0aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80559 Tested-by:
-
- Aug 15, 2023
-
-
Benni Mack authored
This change adds a test for localized pages that have a l10n_source "custom" value (e.g. "pages.author"). When copying the page and its translation, the l10n_state field is then set to "source", which is wrong. copyRecord() sets l10n_source=0, however DataMapItem expects "null". The patch makes DataMapItem understand 0 as value for l10n_source as well. Resolves: #88974 Releases: main, 12.4 Change-Id: I326765d92ea52bb49d94bc4965b998b993b5e673 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80572 Reviewed-by:
-
- Aug 14, 2023
-
-
Thomas Hohn authored
Fix undefined array key "pages" in FileContentParser by adding a null coalescing operator. Resolves: #101450 Releases: main, 12.4, 11.5 Change-Id: Idc3bba5d5ab5516689925fadec86e6fac5978e73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80545 Tested-by:
-
- Aug 12, 2023
-
-
Christian Kuhn authored
The low level service SchemaMigrator is used in ext:install and testing-framework. To allow DI in SchemaMigrator, testing-framework needs a pre-patch, which needs this pre-patch in core. Resolves: #101669 Releases: main, 12.4 Change-Id: Ie1f7e9ece05e4fa12c0fd27c1e3f871d4870b99b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80531 Tested-by:
Jasmina Lie�mann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
- Aug 11, 2023
-
-
Andreas Fernandez authored
There's currently a bug in the DataHandler that kicks in when copying a localized page that uses a "Custom" translation behavior on text fields. Due to the bug, state is broken and the JavaScript part cannot determine expected state, leading to a JavaScript error that leads to an endless spinner. This patch only fixes the JavaScript issue and renders a warning in the console, but FormEngine is usable again. Resolves: #101658 Releases: main, 12.4 Change-Id: I4fab1dae49928423c53906b0ae4fe5b4bddfaacd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80523 Tested-by:
-
Nikita Hovratov authored
The csp.yaml shouldn't be taken into account when merging current and new site configuration via the GUI. Resolves: #101626 Releases: main, 12.4 Change-Id: Ib08b7707cfb43733985b0c7aa5bf12bcc5fa603c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80480 Tested-by:
-
Torben Hansen authored
With the update from CKEditor 4 to CKEditor 5, parts of the extension documentation got outdated. This patch includes the following changes: * Updated external links to CKEditor 5 documentation * Updated screenshots to show CKEditor 5 * Updated configuration examples and removed unsupported options * Updated configuration reference * Added "Grouping toolbar items in drop-downs" example * Added "How do I create a custom plugin?" example Resolves: #101465 Releases: main, 12.4 Signed-off-by:
-
- Aug 10, 2023
-
-
Andreas Fernandez authored
If the "Add media by URL" button is used in FormEngine, a modal appears with an input field, allowing the user to enter a media URL. If an error occurs, the modal now stays open and the error is rendered via a notification. Previously, the modal was closed and another modal was opened informing about the error. Resolves: #101650 Releases: 12.4 Change-Id: I3b0852bb485e041e1d008a6842cff6de1c27bb98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80508 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Tomasz Woldański authored
This implements a rather unexpected detail when combining reference "=<" and copy "<" operator from old TypoScript parser. Copy operator: lib.source1 = TEXT lib.source1.value = source1Value lib.source2.otherValue = source2OtherValue tt_content.target < lib.source1 tt_content.target < lib.source2 Result: tt_content.target = TEXT tt_content.target.otherValue = source2OtherValue The tt_content.target existing value from lib.source1 is kept, but children are reset - lib.source1.value is not within tt_content.target anymore. Now reference first, then copy: lib.source1 = TEXT lib.source1.value = source1Value lib.source2.otherValue = source2OtherValue tt_content.target =< lib.source1 tt_content.target < lib.source2 Old parser after resolving reference in FE: tt_content.target = TEXT tt_content.target.value = source1Value tt_content.target.otherValue = source2OtherValue New parser after resolving reference in FE: tt_content.target = TEXT tt_content.target.otherValue = source2OtherValue The old parser keeps existing references when the copy operator does not reset the value to something else. The patch adapts the new parser to behave identical and refactors the AST copy method to better documented, more easy and eventually also quicker code. Resolves: #100115 Releases: main, 12.4 Change-Id: Ia03cefd6e550833bdc9120a179881d04bf70d117 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80509 Reviewed-by:
-
Andreas Fernandez authored
This patch removes jQuery from the `@typo3/scheduler/scheduler` module in favor of native APIs. Extra fields are now hidden via the `hidden` attribute and not via CSS styling anymore. Resolves: #101619 Releases: main, 12.4 Change-Id: Ida87f82cde264785c8cd5b0d3619304bc6dfadfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80478 Tested-by:
-
Benjamin Franzke authored
Also raise the fixed linters to error level in order to not introduce similar errors again. The linter @typescript-eslint/no-explicit-any is disabled for now, in order for errors to be visible at first glance. Resolves: #101645 Releases: main, 12.4 Change-Id: I48229f148298ac13acd6d12deb55d606a3c7ef59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80504 Tested-by:
-
Benjamin Franzke authored
Missing declarations caused some method calls and assignments to not be type checked, as all members of the (top.|window.)TYPO3 object were declared to `any`. This actually revealed some invalid API usage. which is fixed as a drive-by. (No real bugs were found, as type checking in the APIs caught/ignored such cases) Resolves: #101644 Releases: main, 12.4 Change-Id: I2e188e53a02d9e0ae875084cadc28600c7a59aa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80502 Reviewed-by:
-
Andreas Fernandez authored
Executed commands: npm install --save bootstrap@^5.3.1 npm run build Resolves: #101629 Releases: main, 12.4 Change-Id: Idcb9f78543e945e0e948a19bb2574827b15806b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80493 Tested-by:
-
- Aug 09, 2023
-
-
Ernesto Baschny authored
In case you add a new TCA field of type "slug" in the pages table but without a config "eval", you get an exception in the backend. Resolves: #101640 Related: #93640 Releases: main, 12.4, 11.5 Change-Id: Ia9fc65707c581c288101eb9d54957aa9d025b98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80497 Tested-by:
-
Oliver Klee authored
Fix a case where the name of the testcase did not follow the name of the tested class. Resolves: #101631 Releases: main, 12.4 Change-Id: Ic5225f692c8610b18769bbceb5acdb427ef4c5d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80477 Reviewed-by:
-
- Aug 08, 2023
-
-
Oliver Klee authored
This change fixes places where the code violates the contract. Also, the change will avoid type errors when the `GeneralUtility` array functions are switched to native type declarations. All of these changes fix places where the acceptance test break with the GU array methods using native type declarations. Resolves: #101616 Related: #101453 Releases: main, 12.4 Change-Id: I6f86f7a371d50b20a34275ebc771604d407917bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80476 Tested-by:
-
Stephan Bauer authored
Releases: main, 12.4, 11.5 Resolves: #101620 Change-Id: I18563030fd382331a1389c500f313e28383901d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80475 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow current best practices. This changes tackles the classes where we can mock an interface instead of an abstract class, allowing us to use `createMock` instead of `getMockForAbstractClass`. Resolves: #101609 Related: #101601 Releases: main, 12.4 Change-Id: I995f70d779a1bc6251bc4479c3dcb2ee548314f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80458 Reviewed-by:
-
Jürgen Venne authored
The "global" extbase/Tests/Fixtures folder is unfortunate: Fixtures should be located in more dedicated folders and should not be shareable between unit and functional tests. The patch moves a couple of fixtures to more dedicated locations to avoid confusion. Resolves: #101530 Releases: main, 12.4 Change-Id: I3faad97ca05e7790da8443d615309da03ff91201 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80457 Tested-by:
-
Daniel Hettler authored
The URL param '_stg_debug' is needed to call the debug mode on-site Resolves: #101613 Releases: main, 11.5, 12.4 Change-Id: Iff94ede5c3d388fe8b130e10e5b48658511a0bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80472 Tested-by:
-
Benjamin Franzke authored
New runTests.sh option "-g" opens a tab in a local browser pointing to http://localhost:7900/?autoconnect=1. This allows watching acceptance tests clicking around. Releases: main, 12.4, 11.5 Resolves: #101611 Change-Id: I53cbb861d7df6daac96dfcc382183f46847d7894 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80367 Tested-by:
-
