- Jul 25, 2022
-
-
Christian Kuhn authored
Second main usage of the new TypoScript parser is the ext:tstemplate Object Browser. In contrast to the Template Analyzer patch that brought a fully revamped view with new features, this Object Browser patch is mostly just a modernization of the view, so this patch is not marked as feature. The Object Browser now renders both setup and constant tree at the same time. Other than that, most existing features are kept and streamlined along the way. As example, searching for a constant name now reveals constant usages in setup, plus similar small gems. The only missing features are currently the comments rendering, plus rendering of parser errors. Comments are a bigger issue that will be implemented with a revamped Constant Editor, Object Browser will then add comment rendering as side effect. Parts of the parser errors (detecting invalid lines) will be added to Template Analyzer with a dedicated patch soon, further details will be added to Object Browser when suitable. Change-Id: I08b2d7a1c1f60d2ab2184fb005dc1132b261f1aa Resolves: #98013 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75259 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Not setting $GLOBALS['TCA']['myTable']['ctrl']['crdate'] or $GLOBALS['TCA']['myTable']['ctrl']['cruser_id'] or $GLOBALS['TCA']['myTable']['ctrl']['tstamp'] leads to rather obvious PHP 8 "Undefined array key" warnings in DataHandler. Sanitize them. Resolves: #98018 Releases: main, 11.5 Change-Id: Ia3e94ac65feede4668fd1247cd29562f3215f328 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75283 Tested-by:
-
Christian Kuhn authored
Some of the more advanced fields of sys_template records are rather hard to understand without additional description. The patch moves all more complex fields to an "Advanced Options" tab and uses the TCA "description" feature to add some explanations and hints if and when integrators should bother with them in typical scenarios. Resolves: #98017 Related: #97816 Releases: main, 11.5 Change-Id: Ifb4166dd225ec1c74339726f97ec7d7391e6996e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75281 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Jul 24, 2022
-
-
Christian Kuhn authored
The issue has been resolved in sysbox, we don't need the patch level pin anymore. Resolves: #98015 Related: #97570 Releases: main, 11.5, 10.4 Change-Id: I1a2080ec3e8609350c9975bad8f65e69513d5f48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75277 Tested-by:
-
Christian Kuhn authored
phpstan almost always triggers a full recalculation ignoring cache in CI. We switch phpstan CI cache config to /tmp which is not cached by CI to save some memory. Resolves: #98014 Releases: main, 11.5 Change-Id: I0bf2c72f529e9f179eb4becaac4d164cad8c318a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75275 Tested-by:
-
- Jul 23, 2022
-
-
Christian Kuhn authored
Scenario: * Create a live page that has a 'media' resource * Create a localization of that page * Go to workspace * Edit the localized page * Save * Save again -> crash "Array to string conversion" in DataHandler isSubmittedValueEqualToStoredValue() Investigating this, the issue is not in isSubmittedValueEqualToStoredValue() itself, but within DataMapProcessor, which fails to apply a workspace overlay due to #92209: The default WorkspaceRestriction is not sufficient in this case. The patch changes DataMapProcessor to apply workspace overlays in a different way for this special case. Resolves: #97989 Related: #92209 Releases: main, 11.5 Change-Id: I176aa2d2e209224b48517b872ea39b1e01f06af7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75256 Tested-by:
-
- Jul 22, 2022
-
-
Stefan Bürk authored
Localized page preview links in page layout module or view module display page in default language. With #97544 preview uri generation hooks has been replaced with corresponding PSR-14 events. Language information has been divided from the paramaters array to have it as direct property in the new PSR-14 events. `PageRouter->generateUri()` needs proper language information as `$parameter` argument, which is not properly reassembled before generating the preview uri in `PreviewUriBuilder()`, using event information. ext:workspace uses the before event to change the preview uri only added the language id as query argument `_language`, if additional query arguments are provided. This failing to show localized workspaced page in workspace preview. This change reassemble language information back into the `$parameters` array to build localized preview uri again, for live workspace preview and for workspace preview. This is also done in corresponding ext:workspace eventlistener to always provide non-default language query argument with the newer `_language` parameter, even if there are no other additional query arguments. Resolves: #98000 Related: #97544 Releases: main Change-Id: Ie02ee0437da4c692a50dc3b7802301af519793ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75260 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
Scenario: * Create a live page, add two images to media field * Go to workspaces, edit page, resort the two images, save * Go to workspace module of that page -> Crash in main ajax call "DiffUtility::makeDiffDisplay(): Argument #1 ($str1) must be of type string, int given" Fix with proper cast. Resolves: #97997 Related: #97598 Related: #97373 Releases: main Change-Id: I1764cab043e9a8c3fd8718c08d13549c9c590f98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75258 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Andreas Fernandez authored
There were a few usages of `btn-checkbox` left in TYPO3 code base which can be savely replaced with Bootstrap's `form-check`. To make it more recognizable in the constants editor, the unchecked state is represented by a square icon, representing an unchecked box. Resolves: #97980 Releases: main Change-Id: I4e0db3d1ce1eba220de5902e5ac15a4b2a356b1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75250 Tested-by:
-
Nikita Hovratov authored
Also, update the comment above. Resolves: #97992 Releases: main Change-Id: I019ba4079857f021828c83658f950ed908990d34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75257 Tested-by:
-
Georg Ringer authored
Avoid notices in PageLinkBuilder Resolves: #97968 Releases: main, 11.5 Change-Id: Icc55f4b9fdd6e53333d5337d65b9971a74e956b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75246 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Larry Garfield authored
The > operator binds higher than ??, meaning these are always comparing null to 0. That is clearly not the intent. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97978 Releases: main, 11.5 Change-Id: I3410e087fe7fa214c4cb43312a551d8ca3047e70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75248 Tested-by:
-
- Jul 21, 2022
-
-
Christian Kuhn authored
Relations in 'custom value' mode may not have translation parents. This raises a PHP 8 array access issue in workspace module when for instance a page translation defines own relations for 'media': The workspace module main ajax call crashes. Sanitize this. Resolves: #97988 Releases: main, 11.5 Change-Id: Ie28d3db43a0e425a909d78355e4ecd64e1aedf8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75255 Tested-by:
-
Christian Kuhn authored
When the TCA colon feature for ['ctrl']['type'] is used in inline parent child relations, the target record may not yet be persisted and getRecord() returns null. This triggers a PHP 8 array warning. Sanitize this access. Resolves: #97985 Releases: main, 11.5 Change-Id: If26e7aecdfc9504fbf1727813bc825de6522b9f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75253 Tested-by:
Michael Semle <michael.semle@b13.com> Tested-by:
-
Larry Garfield authored
This check likely predates types being specified, which makes it unnecessary. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97979 Releases: main, 11.5 Change-Id: I78af547b9b3c1412c50cc36373973b160f3a82d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75249 Tested-by:
-
- Jul 19, 2022
-
-
Anja Leichsenring authored
With PHP 8.2, dynamically declared properties raise a deprecation warning, leading to test fails. Resolve these. Resolves: #97969 Releases: main, 11.5 Change-Id: Idb1ad46415fcfa2c2c562863004c9f2b88cff58c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75243 Tested-by:
-
Torben Hansen authored
The initialization of the variable `$conditionMatcher` with a `null` value can safely be removed, since the following condition always overwrites the initial variable value. Resolves: #97970 Releases: main, 11.5 Change-Id: Ia7a555c9ac480f2af1e13089edffd6105f37cdc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75244 Tested-by:
-
Anja Leichsenring authored
These raises fix the bulk of PHP 8.2 unit test fails. We need to make webmozart/assert:^1.11.0 explicit to pin it as minimum version for PHP 8.2 composer update --prefer-lowest in nightlies. We don't strictly need the phpunit raise, but pick it as casual dev update along the way. $ composer require --dev phpunit/phpunit:^9.5.21 $ composer require --dev webmozart/assert:^1.11.0 Resolves: #97967 Releases: master, 11.5 Change-Id: I5c79a8577c5eb836566cb5c00bb6b63aa1b7ea1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75241 Tested-by:
-
ToGetATockenOnly authored
Releases: main, 11.5 Resolves: #97965 Change-Id: I6e03354925b4ecb9c3f72554862a01057851f48b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75239 Tested-by:
-
- Jul 18, 2022
-
-
Sascha Egerer authored
If a page of type external link does not have a "target" defined the fallback should be used. This behavior has been changed in #96470 so the fallback is not used anymore as an empty string is also respected as a valid value but should not. Resolves: #97964 Related: #96470 Releases: main, 11.5 Change-Id: I8270aec774a342151eee47000386546e3d5ac70c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75234 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
With the new TypoScript parser, we should start phasing out TemplateService (tsfe->tmpl in FE). One of it's usages in Frontend is tmpl->rootLine. This property looks as if it's identical to tsfe->rootLine, but it isn't, since it's in a different order and stops at sys_template records with root flag. However, tmpl->rootLine is also assigned in Frontend as tsfe->config['rootLine']. The patch changes all usages of tmpl->rootLine to this and sanitizes access along the way. Additional comments now document the subtle differences. We do not add a deprecation at this point, since the entire class will be fully deprecated later. Note the new TypoScript parser construct can not expose this "local" or "partial" rootLine yet. The TypoScript/IncludeTree/TreeBuilder class will be refactored a bit with an additional patch when the new parser is being used in the Frontend. Change-Id: Ic97d0c7344711d07d2ff672ca3b2968ef9383c14 Resolves: #97963 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75232 Tested-by:
-
Chris Müller authored
Resolves: #97966 Related: #96515 Releases: main Change-Id: I057a73cc00ad5789aa998c845c16e04965c99ead Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75238 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Lina Wolf authored
Fix case and some additional syntax Releases: main Resolves: #97734 Change-Id: Iee717894e5d35255163e6cd4a665c3c75d90e6a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74819 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
- Jul 16, 2022
-
-
Oliver Klee authored
This allows us to see whether a new PHPStan version causes any baseline changes, or whether an update of any other dependency brings some interface changes that affect our type checks. Resolves: #97955 Releases: main Change-Id: I436acc5f25331db6783aebdc12c94edbe85f1eed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75203 Tested-by:
-
Oliver Klee authored
Used commands: > composer req -W doctrine/annotations:^1.13.3 doctrine/dbal:^3.3.7 \ doctrine/event-manager:^1.1.1 > composer req doctrine/annotations:^1.13.3 doctrine/dbal:^3.3.7 \ doctrine/event-manager:^1.1.1 -d typo3/sysext/core --no-update > composer req doctrine/dbal:^3.3.7 -d typo3/sysext/install --no-update > composer req doctrine/dbal:^3.3.7 -d typo3/sysext/redirects --no-update Also make use of a Doctrine-DBAL-provided PHPStan/Psalm type to satisfy the required types for the new DBAL version. Resolves: #97956 Releases: main Change-Id: Ia193947df78c67c60f5861ca1f9912eacbf5b980 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75204 Tested-by:
-
Stefan Bürk authored
With #80398 support to set `tableoptions` to proper charset and collate has been added. This setting has been passed through the `doctrine/dbal` connection params and manually set to the schema config for database compare, if it has been set. The choosen key `tableoptions` however is not a valid key for `doctrine/dbal` connection params. `doctrine/dbal` ships proper PHPStan/Psalm type definitions for the param array now, and mumbles about this key. This patch transform the `tableoptions` to the proper `doctrine/dbal` `defaultTableOptions` in the `ConnectionPool`, only transporting the valid params with the connection. Places which handled the invalid `tableoptions` are changed to use `defaultTableOptions` instead. This prepares the ability to raise `doctrine/dbal` dependencies and phpstan with #97956. Full migration with configuration cleanup may be done in a dedicated patch with proper documentation of that change in v12 only. Resolves: #97961 Related: #80398 Related: #97956 Releases: main, 11.5 Change-Id: I33ddc1ae1bebb77e5d64d17e5fbc19eb0e2dc495 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75211 Tested-by:
-
Christian Kuhn authored
This establishes the first usage of the new TypoScript parser and leverages some of its improved functionality: A rewrite of the template analyzer backend module based on the new parser gives a series of new features. Most importantly, the TypoScript include tree now resolves all @import and INCLUDE_TYPOSCRIPT includes and shows them as single nodes within the include tree. Additionally, the template analyzer is now condition aware: It finds all conditions within the include tree and allows to simulate include tree restrictions based on condition verdicts. The major outcome of this is that the analyzer now shows in-depth includes and allows much more fine grained analysis of all includes that play a role on a single page. Known issue: t3editor (codemirror) sometimes fails to initialize properly to render TypoScript source when clicking a node in the include tree. This is probably some JavaScript load-order race condition and will be tackled with a dedicated patch. Change-Id: I2761e1dfc9e511904b73d48de41198b84aee6447 Resolves: #97941 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75178 Tested-by:
-
Christian Kuhn authored
This resolves a mixup in ext:recordlist: The "Browser" classes are the "element browser" modals, used when adding FAL images to records and when adding relations for type="group". The "LinkHandler" classes are a distinct construct used to create the "t3://" syntax when linking record fields and RTE text to a page, telephone, external URL and so on. They are rendered as single tabs in the link handler modal. Class LinkHandler/RecordLinkHandler allows linking to arbitrary records. Typical example is linking to single ext:news records, which can be configured using PageTsConfig TCEMAIN.linkHandler. Class LinkHandler/RecordLinkHandler misuses the element browser abstraction to list records. This materializes in class Browser/RecordBrowser, which is not used as element browser as such, but is just a client class of LinkHandler/RecordLinkHandler. The two class namespaces however shouldn't interfere with each other. The patch resolves this by moving the code from Browser/RecordBrowser into LinkHandler/RecordLinkHandler and streamlining it to what is really needed. A series of changed and added comments should improve the overall constructs along the way. Resolves: #97957 Related: #66373 Related: #97188 Related: #96639 Releases: main Change-Id: I3028ce439e6ae68c4ed34c0c560b4980dad6ac29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75205 Tested-by:
-
Oliver Klee authored
PHPStan 1.8.1 removes one warning. Used commands: > composer req --dev phpstan/phpstan:^1.8.1 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97959 Releases: main, 11.5 Change-Id: Ifaaf37add767f98d16b3e847447a2882c3c77ee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75208 Tested-by:
-
Christian Kuhn authored
Patch level raise of a monorepo --dev dependency as yet another raise to unblock psr/container:^2. $ composer req --dev bnf/phpstan-psr-container:^1.0.1 Change-Id: I73da5737bfbad6dfb739f5f56732d5d283e3e372 Resolves: #97958 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75206 Tested-by:
-
Oliver Klee authored
Resolves: #97892 Releases: main Change-Id: Ib704bd1dbf8fb1be71ff80748c379273ded6552b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75096 Tested-by:
-
Oliver Bartsch authored
Replace wrong null fallback for "width" and "height" with empty string and also cast the values before passing to GraphicalFunctions->getImageScale() which expects them to be string. Resolves: #97952 Releases: main, 11.5 Change-Id: I80174038e54ce41dfbde5e5e35339b0a7429be4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75199 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Nikita Hovratov authored
Resolves: #97953 Releases: main, 11.5 Change-Id: Ie152dfdb8c08f20a835ac9a1c8cf56f1206c4fa1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75201 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #97767 Releases: main, 11.5 Change-Id: I1c874770ad1201e22a95d0af67e7caf4b09a8aa3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75198 Tested-by:
-
- Jul 15, 2022
-
-
Oliver Bartsch authored
The new PSR-14 AfterPageTreeItemsPreparedEvent is added. The Event gets dispatched in the TreeController and allows to further modify the resolved and already prepared page tree items before being returned. The new event is directly used by EXT:workspaces to apply the highlighting of versioned pages. Using this new event allows to remove another cross dependency of EXT:backend. Additionally, the hooks $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Workspaces\Service\WorkspaceService']['hasPageRecordVersions'] and $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Workspaces\Service\WorkspaceService']['fetchPagesWithVersionsInTable'] are now removed, since this can now be done using the new PSR-14 Event. Resolves: #97945 Releases: main Change-Id: I2fa8df42f1820c9d6592d5a0654de9ada050e71c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75184 Tested-by:
-
Oliver Bartsch authored
This reverts commit 88a8a246. Reason for revert: Accidentally merged without enough votes. Mixed up with a backport. Change-Id: Ice9ccc3cf27758673358f1b6501c3f71130e732d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75149 Tested-by:
-
Oliver Bartsch authored
Replace wrong null fallback for "width" and "height" with empty string and also cast the values before passing to GraphicalFunctions->getImageScale() which expects them to be string. Resolves: #97952 Releases: main, 11.5 Change-Id: I3c2eafd89f81f0b5d606a1c936c43a8bca57659c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75197 Tested-by:
-
Georg Ringer authored
The provided width and height must be cast to a string to avoid notices. Resolves: #97911 Releases: main, 11.5 Change-Id: Ifa7428571026fbd0b0905729ea8ad699ab080bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75196 Reviewed-by:
-
Andreas Fernandez authored
The templates used for the element browser are now separated into several templates, based on their usage. The element browser used in combination with FAL does not share the template with the folder-based element browser anymore. Resolves: #97933 Releases: main Change-Id: Ia1c4278c8fb656c8979dec9b60f2f892af18bd4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75172 Tested-by:
-
Benni Mack authored
When AbstractContentObject is fetching ->getPageRepository() but TSFE hasn't been fully initialized yet, the Context from TSFE should be used, and not the global one. Resolves: #97951 Releases: main, 11.5 Change-Id: I99880839f5458469e7181467de6a8fb667ef9828 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75194 Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Tested-by:
-
