- Dec 09, 2017
-
-
Georg Ringer authored
If the access to the element information is not allowed, show some information to the user instead of returning an empty string. Resolves: #83067 Releases: master, 8.7 Change-Id: Ie4ca3ba41556813a44802fc60befe164a17c4178 Reviewed-on: https://review.typo3.org/54811 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Susanne Moog authored
Offset and limit in a count query do not make sense. Additionally the hook deprecation was incomplete as the core also threw deprecation warnings on list module pagination. Change-Id: I8435d15c981f47e2940dbbf470e2de84fc3d5055 Resolves: #83269 Releases: master Reviewed-on: https://review.typo3.org/54999 Tested-by:
-
Matthias Vogel authored
Objects containing a LazyLoadingProxy will be marked dirty even if the lazy proxy is untouched. For more details see IsDirtyTest. Resolves: #82065 Releases: master, 8.7 Change-Id: I579a275bb7d22af836be2497064ed09ea0203df6 Reviewed-on: https://review.typo3.org/53665 Tested-by:
Tomas Norre Mikkelsen <tomasnorre@gmail.com> Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
Claus Due <claus@phpmind.net> Tested-by:
-
Ruud Silvrants authored
Since unified URL routing is in place for TYPO3 v9 now, a new pair of linking to routes is added. Change-Id: Ied1a67aee173a9a1dc00eaadc9676ded1276076f Resolves: #75161 Releases: master Reviewed-on: https://review.typo3.org/47306 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Christian Wolff authored
This allows extensions to hide their own credentials in the Configuration module. Resolves: #82999 Releases: master Change-Id: Idb25ab98c7986fb6f7471948b684834b608a0f0d Reviewed-on: https://review.typo3.org/54644 Tested-by:
-
Elmar Hinz authored
The properties are meant to be used only inside the class (and the extended classes) itself. Resolves: #83273 Releases: master Change-Id: I550012bc377c6bb577747490fac3100d378a6fd6 Reviewed-on: https://review.typo3.org/52901 Tested-by:
-
Philipp Kitzberger authored
Display value of TS constants on "UN-substituted constants in green" mode and constant name when on "Substituted constant in green" mode. Before this patch toggling between both modes was necessary to simply get an idea of what the value/variable name was while being on the 'other' mode. As a side effect this patch improves the search feature of the object browser when searching for a constant value or name, i.e. 'maxWInText' while being on "Substituted" mode. Resolves: #40729 Releases: master Change-Id: Ic8c3f1b96b3b440a3ed4d098604e29d018129451 Reviewed-on: https://review.typo3.org/50190 Reviewed-by:
-
Christoph Lehmann authored
Check if TCEFORM.pages.categories.config.treeConfig.rootUid itself is in the users category mounts (no need for a pseudo parent category) Resolves: #83257 Releases: master,8.7,7.6 Change-Id: I8a60860ee3a22d68964f4e44018f0962f7f0f278 Reviewed-on: https://review.typo3.org/54975 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Claus Due authored
Instead of annotating and type-hinting specific cache frontend implementations, TYPO3 should program to the FrontendInterface instead. This patch corrects that. Change-Id: Ibc8d31cf78459e700ab9fe3448a53cbe83bccc61 Resolves: #81461 References: #81432 Releases: master Reviewed-on: https://review.typo3.org/53116 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Georg Ringer authored
Resolves: #82414 Releases: master Change-Id: I5152b9929d8755adfb8d2d77c03178178c8a8742 Reviewed-on: https://review.typo3.org/55002 Reviewed-by:
-
Benni Mack authored
The page translation selector in the page module has the label outside of the dropdown, where as the List module has the label as the first option. This patch puts the label inside the first option of the dropdown selector in the page module. This way, the selector box is aligned to the left, and thus, does not look like it's placed "somewhere" in the HTML code. Resolves: #83271 Releases: master Change-Id: Idbedf2f6cfb9056e0c89a69029f31b4b47673a02 Reviewed-on: https://review.typo3.org/55001 Tested-by:
-
Tymoteusz Motylewski authored
Instead of doing manual queries for each tree level, and checking for children on each tree level, the page tree now fetches all pages the user has access to, and checks if this works out. Resolves: #83233 Releases: master Change-Id: I45a6b834ef1fe71e5748dfc8de9bcf6dad8172c9 Reviewed-on: https://review.typo3.org/54887 Reviewed-by:
-
Frank Naegler authored
Resolves: #83248 Releases: master Change-Id: I1a61178131b358e4cc309bd11fc77278d9220a55 Reviewed-on: https://review.typo3.org/54958 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Tobias Hüske authored
Sometimes the database user has a password that is larger than 50 characters. At the moment TYPO3 throws an error message when entering this password. Microsoft SQL Server passwords can contain up to 128 characters, MySQL & PostgreSQL have no limitations. For this reason, the maximum password length has been increased to 128 characters. Resolves: #82479 Releases: master, 8.7 Change-Id: I4ff5ef85ec74f1ff87bfe5d3f6658196b67f8330 Reviewed-on: https://review.typo3.org/54137 Reviewed-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Tested-by:
-
Stefan Neufeind authored
@transient was deprecated with #54760. But those usages don't make sense in TYPO3 Core here and might be leftovers from Flow. Related: #83092 Resolves: #83259 Releases: master Change-Id: I51427ac48176fbfa2e3e2dbf09090fc872bf95a2 Reviewed-on: https://review.typo3.org/54984 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benni Mack authored
TYPO3 previously allowed to hand over the typeNum parameter via index.php?id=pageId.typeNum which is dropped now, as "index.php?id=pageId&type=typeNum" should be used, no more hidden magic. Resolves: #83265 Releases: master Change-Id: I218812b462d3ccb3ee0c35f0c8507957f0002ac8 Reviewed-on: https://review.typo3.org/54980 Tested-by:
-
Benni Mack authored
Symfony4 was released today, and using Symfony 4 components should not be restricted. The current used Symfony components (YAML, Finder, Console) mainly concentrated on cleanup for the code. For the bundled zip/tar.gz archives, nothing changes. Resolves: #83180 Releases: master, 8.7 Change-Id: Ic518f3b7d3a94bd3b89587d4c8a07ed37c71cb38 Reviewed-on: https://review.typo3.org/54893 Reviewed-by:
-
Mathias Brodala authored
Resolves: #83260 Releases: master, 8.7 Change-Id: I04c0bfa08ceb19ed0f797107ac307b06a77b4dcb Reviewed-on: https://review.typo3.org/54991 Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Benni Mack authored
The new JsonResponse object should be used throughout the TYPO3 Backend in order to properly call json_encode() with the right flags automatically, making the code inside the controllers simpler. Resolves: #83267 Releases: master Change-Id: Ie03fb1414a965a61632897f0e25645a67f3225a5 Reviewed-on: https://review.typo3.org/54995 Tested-by:
-
- Dec 08, 2017
-
-
Benni Mack authored
When using the stdWrap.filelist functionality, the lockFilePath only allowed to be used for a certain directory (usually, if not set, it was set to fileadmin/), however, this is both very unsecure and inflexible. Thus, stdWrap.filelist is extended to be used with all local FAL storages. Add the same time, the public property TSFE->lockFilePath and the TypoScript option "config.lockFilePath" is removed. Resolves: #83256 Releases: master Change-Id: Ia86c6686128dae4c0870cd15e019f4d53a4b28b6 Reviewed-on: https://review.typo3.org/54974 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Stephan Großberndt authored
Clicking the close button in a editing popup accesses Close.html in Resources/Public/Html/ which is a folder accessible by a web user instead of Resources/Private/Templates/ which lead to a HTTP 403 error on closing the popup. Releases: master, 8.7, 7.6 Resolves: #83258 Related: #68108 Change-Id: Ibe7e328936240df436a3c9585e53122f1577dc6e Reviewed-on: https://review.typo3.org/54983 Tested-by:
-
Mathias Brodala authored
Add missing YAML for TypoLink example. Resolves: #81363 Releases: master Change-Id: I1efc0ab812f96883a938326fb229f1536b7345e0 Reviewed-on: https://review.typo3.org/54989 Tested-by:
-
Anja Leichsenring authored
The documentation file states now clearly which parts of public API have been removed / marked as deprecated. Resolves: #79972 Releases: master, 8.7 Change-Id: I48420de5a96681d218f98268223b5cb6a198fda9 Reviewed-on: https://review.typo3.org/54963 Tested-by:
-
Anja Leichsenring authored
The documentation file misses the class name of the method that has been deprecated. Resolves: #78872 Releases: master, 8.7 Change-Id: I3e6b2fd576f4d4ac85ea096ae3406e6df972a97b Reviewed-on: https://review.typo3.org/54957 Tested-by:
-
Anja Leichsenring authored
Due to a copy-paste error, the description of the documentation file does not reflect the other parts. Resolves: #76259 Releases: master, 8.7 Change-Id: Iea069cae225523d3d35eb6b41b4ab618f2c25e76 Reviewed-on: https://review.typo3.org/54947 Tested-by:
-
Oliver Hader authored
Due to invalid PHP type hints updating a previously uploaded file reference in a mail form fails in the frontend. Resolves: #83112 Releases: master, 8.7 Change-Id: Ibf98267a60f076b5654fb0d0d9181a4caeed49b3 Reviewed-on: https://review.typo3.org/54784 Tested-by:
-
Tymoteusz Motylewski authored
- drag and drop doesn't work on firefox - when request returns error or 500 code loader is still visible - loader isn't visible on start - SVG tree page is duplicate on change left actions menu - loader is duplicate on change left action menu - nodes on drag & drop are too sensitive Releases: master Resolves: #83224 Resolves: #83176 Resolves: #83177 Change-Id: I03acf2244fe860b7fafd6067d8dfb31ef5bca064 Reviewed-on: https://review.typo3.org/54933 Reviewed-by:
-
Markus Hoelzle authored
With #82254 LocalConfiguration serialized array EXT/extConf has been changed to a not serialized array in EXTENSIONS. This patch follows up on this task an finishes various tasks: * An install tool silent upgrader upmerges given EXT/extConf settings to EXTENSIONS array. The resulting EXTENSIONS array does not contain dots for sub paths in its array key anymore and is accessible with a new ExtensionConfiguration->get() API to fetch values and whole extension config. * A new API is introduced to get() and set() extension specific configuration, is documented and used throughout the core to not unserialize old EXT/extConf anymore. Setting values updates legacy EXT/extConf to new values including compatible 'dot' ending on nested array configurations. * If extensions come with new configuration items in ext_conf_template.txt a silent upgrader of the install tool synchronizes these to the EXTENSIONS and old extConf array. Extension authors can rely on that and always fetch new keys from the new ExtensionConfiguration->get() API right away. The synchronization is also triggered when new extensions are loaded or extensions are updated via the extension manager. * Core usages are adapted to the new API. * Next to the main get() / set() API, the extension configuration form is extracted from the extension manager and put into the install tool as a new card in "Settings". The code below is streamlined and encapsulated with just a couple of public methods in class 'ExtensionConfigurationService' as internal class for use in install tool and extension manager. Resolves: #82368 Related: #82254 Releases: master Change-Id: I88568fa355f8f6fd5acc9850dcdd718fdd9a1b2e Reviewed-on: https://review.typo3.org/54034 Tested-by:
-
Georg Ringer authored
The option `TCAselectItem` is rarely used and also does not cover all possibilities of the core like manipulating entries with TSconfig and the mentioned support of database relations. Resolves: #83122 Releases: master Change-Id: Ic5ca02d72627a87dc1827bfb4f3c414bc810eef8 Reviewed-on: https://review.typo3.org/54799 Tested-by:
-
Andreas Fernandez authored
The „list“ wizard now checks whether the redirectUrl was given with the request and uses this, otherwise it falls back to REQUEST_URI. Resolves: #83146 Releases: master, 8.7 Change-Id: I0572e6f20c89f77bf11a1c7c2257e4a2c10f4f12 Reviewed-on: https://review.typo3.org/54841 Tested-by:
Wolfgang Klinger <wolfgang@wazum.com> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Benni Mack authored
DataMapper's hidden functionality of having a callback functionality to modify a string before storing it in the database. This was used for database abstraction with $TYPO3_DB ("fullQuoteStr"), which is now obsolete for Extbase in general. Thus, the code can be removed. Resolves: #83241 Releases: master Change-Id: Ic09c7572a19da570aebee969dd836371cddb5d43 Reviewed-on: https://review.typo3.org/54837 Tested-by:
-
- Dec 07, 2017
-
-
Andreas Fernandez authored
This ensures that e.g. unchecked checkboxes are not tried to be stored in the database as empty strings causing an error on int fields. Resolves: #82938 Releases: master, 8.7 Change-Id: I6f1811b8fdf17de4c0dd1fac4dec8076600924c6 Reviewed-on: https://review.typo3.org/54577 Tested-by:
Daniel Lorenz <daniel.lorenz@extco.de> Tested-by:
-
Ralf Zimmermann authored
Properly store boolean form definition values. Also boolean finisher options are returned as boolean now. Resolves: #82569 Releases: master, 8.7 Change-Id: I1eee0c6d8eaf07534d31622025f3c954d608627b Reviewed-on: https://review.typo3.org/54226 Tested-by:
Carlos Meyer <cm@davitec.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Mathias Brodala authored
Form element properties and finisher options can now use arguments in their translations. This is especially useful to pass values created dynamically via formDefinitionOverrides in TypoScript. Resolves: #81363 Releases: master Change-Id: Ie205ebc62bcf807e6740c54bbda0115435317604 Reviewed-on: https://review.typo3.org/52951 Reviewed-by:
-
Ralf Zimmermann authored
A new ExtbaseValidator called "FileSizeValidator" has been added which is able to validate a file resource regarding its file size. The validator is also available within the form editor. Resolves: #82177 Releases: master Change-Id: I04ae755b8632c473769fc7ae859c97d88c60b390 Reviewed-on: https://review.typo3.org/54135 Reviewed-by:
-
Elmar Hinz authored
Mark the public properties as protected and deprecate them within PageRepository: - workspaceCache - error_getRootLine - error_getRootLine_failPid Change-Id: I4ed101794dcfc7fa054d42d9e58ad8b5718bcc5d Releases: master Resolves: #81318 Reviewed-on: https://review.typo3.org/52918 Reviewed-by:
-
Oliver Hader authored
In case the list module is used for a particular page and then removing the very same page in the pagetree will lead to an SQL error since $this->id is null. Using proper parameter type solves this issue. Resolves: #83016 Releases: master Change-Id: I07265ed5590062ff043cf0f73b9dbe42f70e9764 Reviewed-on: https://review.typo3.org/54953 Tested-by:
-
Benni Mack authored
Resolves: #82414 Releases: master Change-Id: I375bfd92e0b7eb58aa68f5a50e18b854d8fc6bdb Reviewed-on: https://review.typo3.org/54946 Reviewed-by:
-
Ralf Zimmermann authored
Merge the properties set through the formDefinition with the predefined properties from the base configuration. Add tests for property part of FormElementInterface implementation. Resolves: #82243 Releases: master, 8.7 Change-Id: Ia6a4428aa52508ec6756eaa6a9d9c471e932baf8 Reviewed-on: https://review.typo3.org/54124 Reviewed-by:
-
Anja Leichsenring authored
Namespace and classname have not been separated by a backslash, making that class not easy to identify. Resolves: #79341 Releases: master, 8.7 Change-Id: Ic86086524cb10c470296facef25759f14c35cc11 Reviewed-on: https://review.typo3.org/54960 Tested-by:
-
