- Feb 22, 2017
-
-
Georg Ringer authored
- Use a div instead of an input field to avoid issues like tooltip not shown because of the disabled attribute. - Trigger onchange from LinkBrowser popup - If no value found, show the input field, which makes it easier to e.g. enter an external url. - Show helpful title for toggle button on hover Resolves: #79667 Related: #79670 Releases: master Change-Id: If00d892d0ae7aebe0dfc5f17f5d43af16d0ee730 Reviewed-on: https://review.typo3.org/51592 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Feb 21, 2017
-
-
Christian Kuhn authored
Fix for issue #78628 fixed "addItems" for TCA trees, but broke them for select drop downs. Juggle icon providing around a bit to fix. Change-Id: I3a1077992a7db0d72bc2d7d0247292763cc25958 Resolves: #78747 Related: #78628 Releases: master Reviewed-on: https://review.typo3.org/51766 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Johannes Kasberger authored
This change fixes a regression after the doctrine migration and additionally fixes a wrong join condition which is also present in version 7 Resolves: #79931 Resolves: #79932 Releases: master Change-Id: I04a4ce174fb1da3baca9af8ba771a7db70d9a884 Reviewed-on: https://review.typo3.org/51782 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
There are some methods and properties which are conceptually in the wrong place or are outdated. $TSFE->compensateFieldWith (and config.compensateFieldWidth) are not in use anymore (since TYPO3 7), as this belonged to the very very old FORM cObject. $TSFE->excludeCHashVars was superseeded with cHash calculation in v6, but never removed. $TSFE->scriptParseTime (and $TSFE->setParseTime()) is a public property and solely there for one use, storing the calculated time between the request start and end. This does not need to be located inside TSFE, as the functionality can be the same, but built in the request handler, removing a cross-dependency. $TSFE->generatePage_whichScript() This alternative method to be used for including raw PHP include files via requireOnce and config.pageGenScript dates back to the plain PHP files index_ts.php and pagegen.php which can safely be marked as outdated now via better PHP class abstraction and hooks. The overall goal is to achieve better separation of concerns, and thus TSFE should only contain what it needs (dealing with rendering a page based on TypoScript settings). PageGenerator:: pagegenInit() Unlike the other methods in PageGenerator this method has one simple job: Setting $TSFE public properties based on TypoScript settings. This surely needs to be merged into TSFE, as this is one of the core jobs of TSFE. It also helps to avoid very unsuccessful attempts to override certain parts of the Frontend Request as the static calls to PageGenerator cannot be overriden at all. TSFE->encryptCharcode and TSFE->encryptEmail() Both are only needed in ContentObejctRenderer and are there moved as protected methods and used solely there. Resolves: #79858 Releases: master Change-Id: Iabd351a0b5fd7c8cc242f66ba1e9799377fb9390 Reviewed-on: https://review.typo3.org/51717 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Tomita Militaru authored
Notice message for lockDomain option that it can be circumvented by faking HTTP_HOST Resolves: #75104 Releases: master Change-Id: I9b83ab7380123a78a2b99b8ab8127a4fcc69beb4 Reviewed-on: https://review.typo3.org/49751 Tested-by:
-
Frans Saris authored
The internals of the LinkBrowser and LinkHandler depend on all the field specific info to be in the P parameter. Further the DatabaseBrowser used by the RecordBrowser fetches the table parameter form global url query scope what collides with the params set by the CKEditor RichTextElement. To prevent the parameter collision the params set by the RichTextElement are moved to the P prefix what is also more inline with the other LinkBrowser implementations. This patch also resolves the lasts issues related to the new recordHandler + CKEditor. Resolves: #79645 Releases: master Change-Id: Id7cab0f0a012c5de11a2038e1d579d87599d47cd Reviewed-on: https://review.typo3.org/51760 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Feb 20, 2017
-
-
Nicole Cordes authored
This patch re-adds the possibility to manually trigger a reload of static database data an extension might ships. In the EM list view, an inconspicuous button is added for each extension which has an own ext_tables_static+adt.sql file. Furthermore the import is changed, so that a md5 hash of the file content is stored in the database. If the extension is updated and the content if the file changes, a more visible button is shown to indicate an update should be considered. Resolves: #60748 Releases: master, 7.6 Change-Id: I8ccb01d7e1f98a4adfc70a4d1aa80db4e76bbc9d Reviewed-on: https://review.typo3.org/51310 Tested-by:
Joerg Kummer <service@enobe.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Thomas Hohn authored
Fix that run-time error will be thrown if $dataStructureArray['sheets'] is not an array. Fixes: #79426 Releases: master Change-Id: I9b7549a5b79d0d5b8b2e27df407879812c1aa491 Reviewed-on: https://review.typo3.org/51399 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Sascha Egerer authored
There is a break statement missing in a switch case statement. Currently this does not have any side effects but to prevent wrong behavior in the future this should be fixed. Resolves: #79906 Releases: master Change-Id: I2adf40adb1f8df5dcfcdb31f8e9ccddd2b885961 Reviewed-on: https://review.typo3.org/51759 Tested-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
-
Sascha Egerer authored
There is a css rule containing a `:has()` rule. This rule is not supported in any browser yet and there must be also no whitespace between the `:has` and the opening brace. Resolves: #79890 Releases: master Change-Id: Ief60c287f1bd0f95c6b61fde0e6f50704978357f Reviewed-on: https://review.typo3.org/51739 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Markus Klein authored
Since TYPO3_CONF_VARS may contain nested arrays and the array keys for those subarrays may collide with first-level citizens (e.g. BE) the current description parsing (parsing of PHP source code file) fail hard for those cases. The problem is not solvable without writing a dedicated full PHP parser in order to have proper notion of nesting levels. For this reason the regex-based parsing is completely removed and a new and dedicated file for the option descriptions is introduced, which stores the description into a PHP array. This frees us from the buggy PHP code parsing with regex and enables us in the future to enhance this array with more information. (e.g. extract data type into a dedicated subarray element) Resolves: #79920 Releases: master Change-Id: Idb5d3fdd2dee5f3150b52c66e65d06c028750893 Reviewed-on: https://review.typo3.org/51772 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Josef Glatz authored
Improve visual differentiation of content and copyright notice. A visual hruler is added. Font-size and color is slightly adopted. Resolves: #79895 Releases: master Change-Id: Idd7190d860c6083d3333b82dba9a796a0bce0e2c Reviewed-on: https://review.typo3.org/51746 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Frans Saris authored
Resolves: #79836 Releases: master Change-Id: I29fb6f0f31a54b6f20c937881a8b523b844dde69 Reviewed-on: https://review.typo3.org/51749 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Thomas Hohn authored
Setting the property $checkStoredRecords in DataHandler to false leads to missing information in sys_log for new records since the $newRecord array is empty. This patch fills the $newRecord array with the newly inserted or updated data - however the only thing that can't be retrieved is the title since this is fetched through the call to checkStoredRecord that is not executed. Resolves: #79669 Releases: master Change-Id: I2a53bc2880402fbb42fad859c9fef2dd7c5ae167 Reviewed-on: https://review.typo3.org/51568 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Tested-by:
Claus Due <claus@phpmind.net> Tested-by:
-
Morton Jonuschat authored
Fix ExpressionBuilder::inSet() to allow working with columns on a seondary table on Non-MySQL databases. Fix the usage of inSet() within Typo3DbQueryParser to properly quote the table identifier and ensure that all places that use inSet() use it to compare a string value or a field on a table. Fix assertions to take string/int differences into account and ensure consistent order when asserting lists of records. Change-Id: I9fecd228cde1a7d5a6202702616d806b4354eb4f Resolves: #79796 Releases: master Reviewed-on: https://review.typo3.org/51733 Tested-by:
-
Morton Jonuschat authored
MySQL has support for backslash escape sequences. Change the tests to have the expected results without the additional escaping and add the additional slashes to the expected result if the database platform running the tests is MySQL. Change-Id: Ib2e30e95db507501aaea095eb3764a0d37135ec9 Resolves: #79799 Releases: master Reviewed-on: https://review.typo3.org/51765 Tested-by:
-
Tymoteusz Motylewski authored
Since context menu refactoring the file deletion did not work. This patch fixes the issue, by adding missing line in JS. Resolves: #79916 Releases: master Change-Id: I939f153aa1d5eae22f821ede98329774e63a3757 Reviewed-on: https://review.typo3.org/51768 Reviewed-by:
Malte Koitka <malte@cytrus.de> Tested-by:
-
Morton Jonuschat authored
Replace the MySQL specific backtick quoting with the actual quote character in test checking for SQL fragments/quoting of fields. Change assertions that assume integer return values from the database driver to also accept string types using assertEquals(). Resolves: #79797 Releases: master Change-Id: I1f78b0b65cdcceeaefa23902d14fa0988198d849 Reviewed-on: https://review.typo3.org/51764 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
Christian Kuhn authored
The "addAndDeletePage" acceptance test is still unstable, even with multiple people trying to stabilize that thing already. To raise acceptance of acceptance tests during core development, this one is skipped for now. Resolves: #79913 Releases: master Change-Id: I55ac9ede4b241a737046d1c0ee16618c314f9d79 Reviewed-on: https://review.typo3.org/51767 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Frans Saris authored
Resolves: #79854 Releases: master Change-Id: Ib7cc81efda1c59d54ab30af00622456955cf7397 Reviewed-on: https://review.typo3.org/51752 Reviewed-by:
-
Andreas Fernandez authored
To prevent PHP errors in L10nModeUpdater caused by faulty extensions whose `transOrigPointerField` field is not an integer, the parentId is now always cast to an int. Resolves: #79824 Releases: master Change-Id: I238b89b6fec476731f16807125eb89e9198f50c4 Reviewed-on: https://review.typo3.org/51757 Reviewed-by:
-
Oliver Hader authored
* add more tests for allowLanguageSynchronization & l10n_mode=exclude * enhance inline children synchronization for non-translatable tables using $GLOBALS['TCA'][$tableName]['ctrl']['origUid'] if defined * bugfix for copying records instead of localizing them - the target page-id was missing * integrate handling of l10n_mode=prefixLangTitle for cloning data in memory - DataHandler hooks are not process in that regard Resolves: #79856 Releases: master Change-Id: I7f5ef7edba9e80deba6025fe1394d10ee8e2d78c Reviewed-on: https://review.typo3.org/51714 Reviewed-by:
-
Frans Saris authored
Resolves: #79902 Releases: master Change-Id: I42a126369108434e33d3b00d4fe6b556592dc2c9 Reviewed-on: https://review.typo3.org/51750 Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Morton Jonuschat authored
Detect errors during execution of SQL statements using the exceptions thrown by Doctrine DBAL instead of trying to use Connection::errorCode(). The previous code doesn't work on MySQL if an actual error occurs since an exception would be thrown earlier in the process and the relevant code path would not be reached. The happy path worked before because MySQL returns 0 as the code when a statement executed successfully while PostgreSQL returns '00000' which PHP does not consider to be empty. Resolves: #79801 Releases: master Change-Id: I508966b6731d256d1edff2267669d158a8d647bf Reviewed-on: https://review.typo3.org/51731 Tested-by:
-
- Feb 19, 2017
-
-
Thomas Hohn authored
Currently it's hard to read the progress of tasks in the scheduler due to the combination of blue, white and light grey. Change of background color for progress from f5f5f5 to dedede makes it more readable. Resolves: #79844 Releases: master Change-Id: I896e66452e3093d729522c9ca7da6b597e0451c7 Reviewed-on: https://review.typo3.org/51710 Tested-by:
Tomas Norre Mikkelsen <tomasnorre@gmail.com> Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Reviewed-by:
-
Georg Ringer authored
The change #79857 introduced a wrong check to find the site root pages. Instead of checking pid == 0, the field is_siteroot must be used. Resolves: #79897 Releases: master Change-Id: Ibfff703fc9506505f860c051f65dc3d31083eb1e Reviewed-on: https://review.typo3.org/51756 Reviewed-by:
-
Philipp Kerling authored
Resolves: #79904 Related: #77385 Related: #77137 Releases: master Change-Id: I2036ecfcf380d864438d3e5480ce3aecc96b2634 Reviewed-on: https://review.typo3.org/51754 Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Philipp Kerling authored
This is a simple typo in the lib.parseFunc of both fluid_styled_content and css_styled_content. The ATagParams attribute for the typolink function needs to be written with a capital A in order to work, otherwise all additional parameters on <a> tags will be dropped in the rendered output. Resolves: #79896 Releases: master Change-Id: I54d5c18fe6934c03b97ae197aba56055394916e5 Reviewed-on: https://review.typo3.org/51755 Reviewed-by:
-
- Feb 18, 2017
-
-
Christian Kuhn authored
Change acceptance tests log directories for better artifact building in bamboo with screenshots and adapt two tests to be less flacky. Change-Id: Ib86531db23617f8205e5099532249653959662cf Resolves: #79898 Releases: master Reviewed-on: https://review.typo3.org/51747 Tested-by:
-
Sascha Egerer authored
There are 2 places in the local driver test where a true assertion is expected. But instead of the correct usage of `assertTrue()` the method `isTrue()` is being used which does no assertion. Resolves: #79891 Releases: master Change-Id: I68f5e43cb1011dd7aadd2c67479d64810ef88bf3 Reviewed-on: https://review.typo3.org/51741 Tested-by:
-
Christian Kuhn authored
Simplify styleguide "elements basic" acceptance tests to be easier understandable, split them into two Cest files. Change-Id: I37ba7a043134e7b2d2291d517c6d0e6aa4c239ae Resolves: #79893 Releases: master Reviewed-on: https://review.typo3.org/51743 Tested-by:
-
- Feb 17, 2017
-
-
Gianluigi Martino authored
Hide the empty button in the create multiple pages function if TYPO3 Manual extension is not loaded. Resolves: #79884 Releases: master Change-Id: Ib72ddae96512c982e634280ddf888f490289af01 Reviewed-on: https://review.typo3.org/51736 Tested-by:
-
Wouter Wolters authored
Resolves: #79880 Releases: master Change-Id: Ia4b240614ee2c1c1a220fcea7d0f7d13ad518acb Reviewed-on: https://review.typo3.org/51734 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
Sascha Egerer authored
* Initialize some uninitialized variables * Fix invalid argument count on function calls * Fix case typo in function call * Fix some phpdoc issues Resolves: #79865 Releases: master Change-Id: I4e41940d849daa818735f75169e7cc686ee908c9 Reviewed-on: https://review.typo3.org/51725 Tested-by:
-
Morton Jonuschat authored
Enforce consistent ordering of deleted records. Change-Id: Ibcb5e61c8cf848b2e25702aef3a2d4ca6bd1cfe6 Resolves: #79800 Releases: master Reviewed-on: https://review.typo3.org/51732 Tested-by:
-
Christian Kuhn authored
Fix travis Change-Id: I3be72d1f892167c884a4ca533dd37633139ef879 Resolves: #79869 Releases: master Reviewed-on: https://review.typo3.org/51730 Tested-by:
-
Christian Kuhn authored
This moves all maintenance / check / test scripts from typo3/sysext/core/Build/Scripts to Build/Scripts. This is possible now after the test framework extraction. The artifical Build folder of typo3/sysext/core vanishes and all core related integrity and code sanitation scripts are now located next to all other main core build relevant stuff. This patch is only breaking for core devs who executed one of the scripts, most notably the "cglFixMyCommit.sh" script. Path is now: ./Build/Scripts/cglFixMyCommit.sh Change-Id: I8272d3d18c5e4164d67df8831168476f315db285 Resolves: #79869 Releases: master Reviewed-on: https://review.typo3.org/51729 Tested-by:
-
Tymoteusz Motylewski authored
Provide script for generating files with acceptance tests groups to allow running them in parallel on different hosts. Very useful for bamboo. Usage: Generating 5 dynamic group files: ./components/testing_framework/Resources/Core/Build/Scripts/splitAcceptanceTests.sh 5 Run tests of group 1: ./bin/codecept run Acceptance -g AcceptanceTests-Job-1 -c ... Note group numbers start from 1, not 0. Resolves: #79845 Releases: master Change-Id: Ib74ec0b457ee927a906a77e648041ae15dc727d2 Reviewed-on: https://review.typo3.org/51713 Tested-by:
-
Sascha Egerer authored
Resolves: #79866 Releases: master Change-Id: Iffb59947ae8a2790736352c473637ac184796b36 Reviewed-on: https://review.typo3.org/51726 Tested-by:
-
Sascha Egerer authored
The function GeneralUtility::quoteJSvalue is sometimes called with a second parameter but it does only have on parameter. Resolves: #79867 Releases: master Change-Id: I994501574b798026f43a0e463a633e05ffc1cff3 Reviewed-on: https://review.typo3.org/51727 Tested-by:
-
