- Mar 05, 2024
-
-
Benjamin Franzke authored
This reverts commit 4fda3505. Reason for revert: The patch has been merged with too few votes. Change-Id: I50e4b27adad119fdd9634276a60f1d6200838f8a Releases: main, 12.4 Resolves: #103287 Reverts: #103240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83233 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
Andreas Kienast authored
This commit enables the usage of `Element` and `DocumentFragment` types in the `@typo3/backend/multi-step-wizard` module. Resolves: #103268 Releases: main Change-Id: I29e755ea799298f8c13e6bea3369f5d3eed76c50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83193 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Chris Müller authored
The example has been adjusted to give an example how this feature can use for setting the new status information: with a PSR-14 event listener. Additionally, use named arguments in the example for tree node labels for instantiating the DTO. Resolves: #103276 Related: #103186 Releases: main Change-Id: I4441f58041ef6cfe0571e591e97b8d8374b39d4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83205 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Willi Wehmeier authored
The thumbCode method in the BackendUtility sets the filename as the alt text for images. That's why the backend representation of content elements like textmedia doesn't respect any set alternative text, whether it's set in the file_reference or the sys_file record itself. This change uses the alternative text and only sets the filename as a fallback if there's no alternative text provided for the file. Resolves: #103285 Releases: main, 12.4 Change-Id: I3c11bb7a56f001e37eafdd1f0a998cb51fb2b460 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83213 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Benjamin Franzke authored
A local instance can sometimes be easier to debug and browser issues can be introspected, when acceptance tests are possible to be run on the host instead of in containers only. Allow to run acceptance tests against a local server using a local chromedriver. Also avoid the usage of precalculated session hashes, which has no clear advantage, but requires codecept to perform database connections directly: The tests now login via the backend login form instead and store the session cookies between test runs. As a side effect the codeception suites are cleaned up, to use more efficient module config, instead of redundantly repeating all WebDriver settings for headless and non-headless environment. To execute codeception with local chromedriver against a custom server URL run: chromedriver --silent & # use `killall chromedriver` when done typo3TestingAcceptanceBaseUrl=https://mycore.example.com/ \ typo3TestingAcceptanceAdminPassword="MyAdminPa$$w0rd" \ typo3TestingAcceptanceEditorPassword="MyEditorPa$$w0rd" \ bin/codecept -c typo3/sysext/core/Tests/codeception.yml -d \ run Application Resolves: #103086 Releases: main, 12.4, 11.5 Change-Id: Id1210706147e0d66c4a905a53e6cc13b15bf00e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82866 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Andreas Kienast authored
The module `@typo3/backend/multi-step-wizard` now has two additional methods to allow switching to the previous or next step programatically: * `previous()` * `next()` The current jQuery hack in EXT:form's wizard is now using the introduced `next()` version. Resolves: #103280 Releases: main Change-Id: I50e6e3f499ddbf50a912bc6f5b7d2c557c45e9b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83210 Tested-by:
-
Andreas Nedbal authored
Resolves: #103279 Releases: main Change-Id: I27d5ec131ded8d2e52104590419ad70af2ab8011 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83207 Tested-by:
-
Andreas Nedbal authored
Resolves: #103271 Related: #102431 Releases: main Change-Id: I914572688df0809d0ff1d7303291aff1acb64a17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83197 Tested-by:
-
- Mar 04, 2024
-
-
Torben Hansen authored
The `hmac` function in the `HashService` class should not throw a custom `EmptyAdditionalSecretException` when the `$additionalSecret` parameter is an empty string. Instead, a top level exception should be used, as the issue is caused from incorrect parameter usage by the developer. This change replaces the `EmptyAdditionalSecretException` with a `LogicException` to better indicate the misuse of the method's parameters. Resolves: #103277 Releases: main Change-Id: Ib6b049ee9c233868684af58ebd0e018bc97ef167 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83206 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Simon Praetorius authored
With Fluid 2.10.0, which is a required dependency, ViewHelpers from TYPO3 without any TYPO3 dependency have been extracted to Fluid Standalone. This patch removes the now duplicate ViewHelpers from TYPO3. This patch is non-breaking since: * The affected ViewHelpers are final classes * The global f: namespace falls back already to ViewHelpers from Fluid Standalone Resolves: #103265 Releases: main Change-Id: Ib17c2d9f0cae045e809065e63551e0d0d6396cc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83192 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Andreas Nedbal authored
Resolves: #103260 Related: #102431 Releases: main Change-Id: I728675edce24dbad6344e16193ba8d4487d4146b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83188 Reviewed-by:
-
Marvin Buchmann authored
The logic of PageLayoutController->getExistingPageTranslations() was moved to BackendUtility::getExistingPageTranslations() to make the code reusable in other places. Resolves: #103274 Releases: main Change-Id: I2fbc596ff33356e1dd4c39c11a7ccea409af945e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83201 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Oliver Bartsch authored
The trigger to open the context menu is now a proper `button` element. Resolves: #103269 Releases: main, 12.4 Change-Id: Ia3932e4932ccd347b6816e08ee763420c70fbbba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83195 Reviewed-by:
-
Oliver Bartsch authored
The FileLinkHandler, used to select a file in the link wizard does now also allow to search for files, like it's also possible in the FileBrowser already. Resolves: #103241 Releases: main, 12.4 Change-Id: Icf3ded3d317e5fbdbd4bc17db0e5969f7b2a055f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83191 Reviewed-by:
Susi Moog <look@susi.dev> Tested-by:
-
Oliver Bartsch authored
Resolves: #103254 Releases: main Change-Id: Ibdba6d76507c0889d42e7d42247f22eebaecbd1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83181 Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Oliver Hader authored
Resolves: #103190 Releases: main, 12.4 Change-Id: Icb71b994b3ca14463dbb86b91551af6d60918096 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83173 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Andreas Kienast authored
With #102432, the property `indentationPadding` became unused but wasn't removed, which is now taken care of. Resolves: #103261 Related: #102432 Releases: main Change-Id: Ice7e63bc87c101d12e0d0e454d15b610e6469ff9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83189 Reviewed-by:
-
Andreas Kienast authored
Google gradually rolls out the `gad_source` parameter as a replacement for the already excluded `gad` parameter. This patch modifies the exclude list. Resolves: #103264 Releases: main, 12.4, 11.5 Change-Id: I4feacd48ed2cd1640e4d7a4ba95470e8702303d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83194 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
-
Lina Wolf authored
Releases: main, 12.4 Resolves: #103262 Change-Id: I30f4c1c7fd0f27b1712bbead42ceea6bf5f5e0f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83190 Reviewed-by:
-
Chris Müller authored
Use a full example of an event listener and enclose the RGB value in quotes. The example also omits named arguments. Additionally, we have currently no "tsconfig" language in the Sphinx-based rendering, "typoscript" is used therefore. Also, captions are added for the code blocks for easier adoption. Resolves: #103257 Related: #103257 Releases: main Change-Id: Ifd3bb51352011223470de988e6153252869d982b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83184 Tested-by:
-
Torben Hansen authored
With #102761, the new `HashService` has been introduced to ensure that HMAC generation will always use an additional secret. As a follow-up patch, `GeneralUtility::hmac` will be deprecated when all usages in the core have been replaced with the new `HashService`. With this change, usages of `GeneralUtility::hmac` in ext:fluid are replaced by the new HashService. Resolves: #103246 Releases: main Change-Id: I7090d13590dc0c5d871eadf73aa9c1278cda1f88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83178 Reviewed-by:
-
André Buchmann authored
The documentation is updated to reflect that pages.no_index=1 also removes a page from the XML Sitemap. Releases: main, 12.4 Resolves: #103259 Change-Id: Ifab520afad4afca29e7fa20bbc342e384a6d65b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83186 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Andreas Nedbal authored
Resolves: #102436 Related: #102431 Releases: main Change-Id: Ib2e3393232587c23a62d4d44f9dc92fd0591a5c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81835 Tested-by:
-
Andreas Kienast authored
This commit changes the rendering behavior of context menus. Previously, the context menu became visible once the server requests were handled successfully. This is an issue in scenarios where either the server is under load and may need some time to send a response, or the network connectivity of the backend user is not optimal. Now, when requesting a context menu, it's container is shown before any data is received and a spinner is rendered. Resolves: #103197 Releases: main, 12.4 Change-Id: I0cd36976a407bce7ce45520d86d7d28a5719cd92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83127 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benjamin Franzke authored
Read mouse position from the triggering event instead of relying on values from a throttled mousemove event, which caused race conditions where mouse position was not updated at all when moving the mouse from iframe to outer frame. Resolves: #103044 Releases: main, 12.4 Change-Id: If22aee7eea958969fb3e7e24b15523897b70e1ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82995 Tested-by:
-
Andreas Kienast authored
When (de-)mounting pages in the page tree, always two requests are sent to the server that fetch the tree data: * when the `mountPointPath` path property is changed as it's a state property * explicitly after changing said property Especially when de-mounting a page, this tends to race conditions, as the mount state is additionally stored in the backend user's UC that needs to get unset as well. This bugfix now changes the handling when the state property, that triggers a re-rendering of the tree component, is updated. The de-mounting process now unsets the backend user's UC first and then changes the property to make sure that 1. the state is updated once the configuration is flushed 2. the tree nodes are fetched only once In the mounting process, the UC is correctly updated first. However, the state was updated and then the nodes were reloaded explicitly. The latter is not required at all. Resolves: #103185 Releases: main, 12.4 Change-Id: I7a06852c6af40e1a41691a7cc7acd41db4f84adc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83126 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
- Mar 03, 2024
-
-
Simon Schaufelberger authored
For some fluid templates, the namespace has been migrated from the "{namespace}" notation to the html tag notation. Additionally, some formatting was applied. Resolves: #103240 Releases: main, 12.4 Change-Id: Ia6873fa0707df0b0c95b6933f7e9bac26442cae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83174 Tested-by: -
Christian Kuhn authored
DataHandler related class SlugEnricher is a scary sounding class name for a simple operation that sets incoming TCA type=slug fields to empty string if not provided, to trigger slug calculation later. The patch inlines that operation into DataHandler, avoiding the class with three methods, a property, and a set of array_* function calls, substituting it with three foreach(), two if() and a helper method that can be re-used. Change-Id: I4452d9c50b43832db3cd4b7f538395054a3d67ab Resolves: #103244 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83176 Tested-by:
-
- Mar 02, 2024
-
-
Andreas Kienast authored
The `RotatingFileWriterTest` previously used a timestamp-based calculation to mock file names. This approach conflicts with the `DateInterval`-based calculation and might lead to false-negative test results. This commit updates the test cases by using the interval-based calculation now. Resolves: #103243 Releases: main Change-Id: I9b08b797377eb504af7707acf520fae896b6cbb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83177 Reviewed-by:
-
- Mar 01, 2024
-
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Replace sphinx-only syntax * remove superfluous genindex, it is not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backports need manual changes to the guides.xml. Resolves: #103238 Releases: main, 12.4, 11.5 Change-Id: I5d9239a9217d8d6c2faa08cef58436971ee83113 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83171 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #102451 Releases: main, 12.4 Change-Id: I50944fe4eb4aa1557c6289f9ae8eefe67717fb75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83175 Tested-by:
-
Willi Wehmeier authored
To deliver a meaningful tooltip text for screenreaders the title of the page is added to the tooltip message in the pagetree view. Resolves: #102451 Releases: main, 12.4 Change-Id: I8af2e3652d38abb6b2a090c2f8bd0e4427ab255a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81854 Reviewed-by:
-
Torben Hansen authored
jQuery autocomplete has been removed with #98455 and jQuery UI has been removed with #100966. In ext:core, there are however leftover JavaScript module registration to both libraries. This change removes the JavaScript module registration for `jquery/autocomplete.js` and `jquery-ui` Resolves: #103236 Releases: main Change-Id: Ib0b96399d1da5794bef183286c5d58ec5c21fd16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83166 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Benjamin Kott authored
If you are managing backend users, it is now also possible to view the assigned groups directly. The hardcoded edit labels are now also replaced with the respecting translatable variants. Resolves: #103231 Releases: main Change-Id: Icbf16f420689b288d5f334c94872b71112ac83f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83162 Reviewed-by:
-
Benjamin Kott authored
We've upgraded the backend tree component by extending tree nodes to incorporate labels, offering enhanced functionality and additional information. Before the implementation of labels, developers and integrators relied on `pageTree.backgroundColor.<pageid>` for visual cues. However, these background colors lacked accessibility and meaningful context, catering only to users with perfect eyesight and excluding those dependent on screen readers or contrast modes. With labels, we now cater to all editors. These labels not only offer customizable color markings for tree nodes but also require an associated label for improved accessibility. Each node can support multiple labels, sorted by priority, with the highest priority label taking precedence over others. Users can assign a label to a node via tsconfig, noting that only one label can be set through this method. ``` options.pageTree.label.<pageid> { label = Campaign A color = #ff8700 } ``` The labels can also be added by using the event `\TYPO3\CMS\Backend\Controller\Event\AfterPageTreeItemsPreparedEvent`. ``` $items = $event->getItems(); foreach ($items as &$item) { $item['labels'][] = new Label( label: 'Campaign B', color: #00658f, priority: 1, ); } ``` Please note that only the marker for the label with the highest priority is rendered. All additional labels will only be added to the title of the node. Resolves: #103211 Releases: main Change-Id: I5daaa1efe6e11c506bd5f5f86770bf9895bb6789 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83143 Tested-by: -
Andreas Kienast authored
The TYPO3 backend module `@typo3/backend/wizard.js` that offers simple wizards has been marked as deprecated in favor of the richer `@typo3/backend/multi-step-wizard.js` module. Resolves: #103230 Releases: main Change-Id: I653f8c746f8f7f2b48899a0a78ea759fd5eb95da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83161 Tested-by:
-
- Feb 29, 2024
-
-
Christian Kuhn authored
When a record localization is changed in workspaces, `transOrigPointerField` ("l10n_parent") can point to either the default language -live-, OR default language -workspace- record, depending on workspace action chains as detailed below. FormEngine did not deal with that properly when `showPossibleLocalizationRecords` for inline (or file) children is enabled, and did tend to show a possible localization child even though a record has been localized already ("shown twice"). This issue exists for a long time already, but became more obvious with #94623, which enabled `showPossibleLocalizationRecords` for tt_content image. The main fix of the patch is to make FormEngine aware of this scenario and suppress listing a localized workspace record as "can be synchronized" when its l10n_parent field points to live. As drive-by, the patch fixes a missing reference index update call in DH when "synchronizing" a relation in workspaces. The patch also adds some `@todo`s to point out situations where the "parent count" fields are incorrect. The added tests show scenarios where a localized workspace record points to either its live, or its workspace default language "parent" in the "l10n_parent" field. We're adding the tests for FAL, but the situation is similar with parent (here: tt_content), with inline csv and inline foreign field: a) modifyContentLocalizeAddDefaultLangRelationSynchronize() Having a content element and a localization in live. Add an image in workspace default language and synchronize into workspace localized record: l10n_parent of new localized sys_file_reference points to the workspace sys_file_reference record. This is quite obvious, since there is no live record to point to. b) localizeLiveModifyWsLocalizationAddLiveWsSync() Having a content element and a localization in live. Modify the localization in workspaces, by for instance changing the title of the content element. This creates a workspace overlay of that localized element in workspaces. Then add an image to the default language live content element, and synchronize this in the localized workspace element. Now, l10n_parent of the new localized sys_file_reference points to the live sys_file_reference record. This is because an overlay of the default language record does not exist. c) localizeLiveModifyWsDefaultLang() Having a content element with image and a localization in live. Modify the default content element in workspaces, by for instance changing the title of the content element. This creates workspace overlays of the default language record, *and* overlays of the localized content elements. It also creates overlays of the attached images in both the default language record and its localizations. l10n_parent of the sys_file_reference localized records now point to the live version. This scenario is debatable since overlays of the default language record exist. We decided to keep this behavior, since we'd otherwise have to deal with updating these pointers when publishing localizations. Change-Id: Iaab27586ff19cdc5f491324ca6dbc2cceff73373 Resolves: #97548 Resolves: #89858 Related: #94623 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82996 Tested-by: -
Andreas Kienast authored
The Lit element `typo3-backend-spinner` uses a hard-coded SVG string, which has to be the same as the `spinner-circle` asset file. However, the SVG string was outdated as it neither respected the `currentColor`, nor respected the configured icon size. Both issues are fixed in this commit. Since `currentColor` is now taken into account, the variant styling has been removed. Resolves: #103198 Releases: main, 12.4 Change-Id: I24eababb8716076eb4db55a6bcd3eb43e98ea1fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83128 Reviewed-by:
-
- Feb 28, 2024
-
-
Benjamin Kott authored
Correctly extend and show the children of the parentnode when a node is added. Clean up the parent node status when a node is removed and no longer contains child nodes. Resolves: #103226 Releases: main Change-Id: I269380c322cad06902e87406732d8f708c8f9614 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83158 Tested-by:
-
Christian Kuhn authored
With all phpunit 11 deprecations being fixed, we can raise from phpunit 10 to current major. > composer req --dev phpunit/phpunit:^11.0.3 -w Change-Id: Idc9774c9d5b0f0b170c870e04d8eb09df61363f0 Resolves: #103229 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83144 Reviewed-by:
-
