- Feb 04, 2022
-
-
Christian Kuhn authored
This brings a couple of fixes for false positives that shrink the baseline by around 90 errors. > composer req --dev phpstan/phpstan:^1.4.5 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: I47ba88117866a59f2b7760539f1be217d1bcde34 Resolves: #96747 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73295 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Klee authored
Resolves: #96734 Releases: main, 11.5 Change-Id: I5dfe1c853d65c6798bcadd1d2624bbcb81616bd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73273 Tested-by:
-
Georg Ringer authored
Resolves: #96735 Releases: main, 11.5 Change-Id: Idc5343bbc42a01138b82df27f39ff1893c9d1469 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73292 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Feb 03, 2022
-
-
Oliver Bartsch authored
Resolves: #96740 Releases: main, 11.5 Change-Id: I25247317f375bef1130560b5164224fb609cbe81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73269 Tested-by:
-
Peter Kraume authored
Resolves: #96736 Releases: main, 11.5 Change-Id: I74ba6a0eab2827d8faf136e32212c084e152fac1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73171 Tested-by:
-
Benjamin Franzke authored
With #96713 all type annotations on class properties in tests have been reduced to ObjectProphecy only, removing the information which class or interface is mocked. This means that phpstan no longer throws errors for valid cases but also ignored invalid calls as the type effectively is considered a mixed type. The jangregor/phpstan-prophecy plugin defines ObjectProphecy as a generic tag, allowing generics to be used and resolved by PHPStan. Therefore the type annotations on class properties or function results are now re-added using generic syntax. Resolves: #96725 Related: #96713 Releases: main, 11.5 Change-Id: I2aa2f4b83675e831b42b940914ac5830a48f2994 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73263 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Feb 01, 2022
-
-
Oliver Klee authored
With the following changes, we can get rid of a whole bunch of warnings from the PHPStan baseline: 1. Now that we are using the Prophecy plugin for PHPStan, we don't need type annotations for prophecies anymore. 2. Prophecies are not instances of the prophesized classes. So we need to fix/remove type annotations that incorrectly state this, and also move accesses on properties from the prophecies to the revelations. 3. Revelations are not instances of ObjectProphecy. They implement ProphecySubjectInterface, but that usually is of no relevance to our test classes. So we can simplify the type annotations and usually convert those to native type annotations. 4. Have PHPStan ignore false positive related to class aliasing (that probably is outside of what PHPStan can do). 5. Drop extraneous arguments to Argument::any(). Resolves: #96713 Releases: main, 11.5 Change-Id: Icfe3ddef89c6bd6edf331c103211ac2ac18f2ef7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73257 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
- Jan 31, 2022
-
-
Nikita Hovratov authored
Event.target identifies the element on which the event occurred and may a descendant of the element to which the event handler has been attached. Event.currentTarget instead always refers to the element to which the event handler has been attached and is therefore now used as source for the datasets. Resolves: #96668 Releases: main, 11.5 Change-Id: Ic0231194a488feba8aaf9379d95b07b80d6a7e02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73170 Tested-by:
-
Benjamin Franzke authored
PHPStan static analysis revealed that the method exceptionForInvalidFactories() did not contain a proper test setup, which went undetected as the expected TypeError was thrown for the invalid test setup. This could have been fixed but the test actually only tried to assert whether a callable type declaration is set, in order to test whether a PHP error is thrown when an invalid factory is provided. This is useless as such factory will result in an error once called anyway. Releases: main, 11.5 Resolves: #96706 Change-Id: Ife52768c82a9c2c394ac1d580e57c990e53a7830 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73249 Tested-by:
-
Benjamin Franzke authored
Do only auto-resolve the event name if the reflection type of the first parameter is a ReflectionNamedType [1] as only this subclass of ReflectionType defines the getName() method. [1] https://www.php.net/manual/en/class.reflectionnamedtype.php Commands executed: Build/Scripts/runTests.sh -s phpstanGenerateBaseline Releases: main, 11.5 Resolves: #96704 Change-Id: If30b04d68f182920a3736fa5333b9d996e989528 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73248 Tested-by:
-
Benjamin Franzke authored
Releases: main, 11.5 Resolves: #96707 Change-Id: I0d5808a48d8ed56d5688235feeb465499dd74c5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73247 Tested-by:
-
Benjamin Franzke authored
findDefinition() doesn't actually return a boolean (or null) value on failure but throws an exception instead. As an alternative $container->hasDefintion may be used to check for definition availability. Also adapt the corresponding dashboard test. Executed commands: Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #96703 Releases main, 11.5 Change-Id: Iab7b9ce098daf685c258f428a4aa241cb0411504 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73244 Tested-by:
-
Christian Kuhn authored
By adding a couple of dedicated type hints here and there, phpstan and phpstorm understand _call() and _set() much better. Resolves: #96701 Releases: main, 11.5 Change-Id: Ic3f6e3f6abf897bba7144c682a64da04aa4144eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73243 Tested-by:
-
Andreas Fernandez authored
This patch adds a few null-coalesce conditions in the LiveSearch in case a field not defined in TCA (in most cases uid and pid) is queried, which is the case when using the "page jump" feature. As a drive-by, these issues are fixed as well: * Pass `$queryBuilder` as a reference, which makes no sense for objects * Adding SQL constraints twice Resolves: #96689 Releases: main, 11.5 Change-Id: Ie9470011581ef3f539cdd4c03e6d901285e5eb0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73169 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Kuhn authored
Increase level from 3 to 5 and generate baseline. Level 5 is a nice goal to fix around on for a while, since it finds a huge list of actual code smells worth fixing. Level 6 adds a very huge amount of array findings, this is too much for a while. Resolves: #96696 Releases: main, 11.5 Change-Id: I48055ab0bdc7de38f37ea4446554a2247755a9fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73235 Tested-by:
-
- Jan 30, 2022
-
-
Stefan Bürk authored
Annotations are sometimes: /** @param $foo */ /** @param $foo MyType */ But should be (at least): /** @param MyType $foo */ Using argument typehints are the preferred solution. '@param' docblock annotations are removed if argument type hints can be set or has been already set. Two test classes with broken syntax are added to phpstan exclude configuration as this is for testing purposes and can not be disabled otherwise. Having them as ignore patterns should be avoided. Generated baseline with: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #96698 Releases: main, 11.5 Change-Id: I3a8eec5ea8dabf93a19b68a92f5d4bbe7bc2249d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73233 Tested-by:
-
Christian Kuhn authored
Various tests add subjects or mocks as class property without declaring the property. Resolves: #96695 Releases: main, 11.5 Change-Id: I97333cb3d79cbda2405aad6cabb997986eb670bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73234 Tested-by:
-
Christian Kuhn authored
The global config "wait" is a max timout for various "implicit wait" operations WebDriver performs. Depending on load and some runtime things, one second can be too low and we hope to further stabilize ac tests a bit by raising this. Change-Id: I1bf7c912d4e4690fcdab9bdc21831c3cd55f81bf Resolves: #96699 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73168 Tested-by:
-
Torben Hansen authored
The function getErrorFlashMessage() in ActionController can either return a string or a boolean. This patch adds bool as allowed return type in the doc comment. Resolves: #96697 Releases: main, 11.5 Change-Id: Ibd9bce942280c48fd82960aeaa9b6f691b6730e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73232 Tested-by:
-
Torben Hansen authored
Fixes the doc comment for processRequest in BlogController by removing annotations that are already explained by the method signature. Resolves: #96694 Releases: main, 11.5 Change-Id: I208fd8d541f9bf863672bc3ee6aca0cc9748186c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73167 Tested-by:
-
Torben Hansen authored
Remove a superfluous null coalescing operator in AbstractConfigurationManager since the $conf variable is always an array. Resolves: #96693 Releases: main, 11.5 Change-Id: I95aab1d1213731b8cb63f95bb7e0869d53d3444f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73226 Tested-by:
-
Christian Kuhn authored
Annotations are sometimes: /** @var $foo MyType */ But should be: /** @var MyType $foo */ The patch fixes this in all tests: getMock() and createMock() need no annotation at all (both phpstan and phpstorm understand this), getAccessibleMock() currently needs an annotation and then sometimes mumbles about obsolete arguments for _call(), which can be adapted with another patch. Resolves: #96692 Releases: main, 11.5 Change-Id: I07032e60805a1dc80dc048ae6996d8bb53b0c2e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73224 Reviewed-by:
-
Benjamin Franzke authored
The plugins adds a dynamic return type resolver for the ContainerInterface::get() method and is especially useful in core ServiceProviders once we enable phpstan level 5 as invalid parameter usage will then be detected. The plugin already revealed wrong interface usage in functional MFA tests which are fixed as a drive by. Commands executed: composer req --dev bnf/phpstan-psr-container:^1.0 Build/Scripts/runTests.sh -s phpstanGenerateBaseline Releases: main, 11.5 Resolves: #96691 Change-Id: I4149a75e9a94ba61218e18c0639c03a06a7c53c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73222 Reviewed-by:
-
Oliver Klee authored
Adding phpstan/phpstan-phpunit makes phpstan "understand" mocking and a couple of related things. Loading the extension in phpstan.neon reduces removes a bunch of PHPStan warnings, makes others more specific, and adds new warnings for some PHPUnit-specific issues. > composer require --dev phpstan/phpstan-phpunit:^1.0 Resolves: #96690 Releases: main, 11.5 Change-Id: Ib77f18f9492c3891b46d213b4f3981be1ac21c1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73221 Reviewed-by:
-
Michael Schams authored
This patch fixes a typo in the label for the dropdown box "scheduler_ipAnonymization_table" where backend users can select the table to anonymize. The correct word now reads "anonymize". Resolves: #96686 Releases: main, 11.5 Change-Id: If7122123e7e56ef8ca2fcb6a729c7c7ad0a1ca25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73166 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Kuhn authored
There is often no point in having test class state which may lead to undefined class properties and more complex test setups. The patch simplifies a test to show this is more easy to grasp and solve a phpstan error along the way. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #96685 Releases: main, 11.5 Change-Id: I271fa1b71d9ac234249c786af14da4e72a03ee7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73214 Tested-by:
-
Stefan Bürk authored
This patch removes docblock typehints for FunctionalTestCase properties in functional tests, thus using the docblock type hint of base class: * $coreExtensionsToLoad * $testExtensionsToLoad * $pathsToLinkInTestInstance * $pathsToProvideInTestInstance This resolves a couple of issues from phpstan baseline. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #96678 Releases: main, 11.5 Change-Id: If30529ac47f9cf329343154df96b7e6d63a23e00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73203 Tested-by:
-
Christian Kuhn authored
Having jangregor/phpstan-prophecy and including it in the phpstan config cuts the baseline by ~half. Details can now be sorted out with single patches. > composer req --dev jangregor/phpstan-prophecy:^1.0 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #96684 Releases: main, 11.5 Change-Id: I7a2a8fd4a40a1a791d7622b506680a53e73187f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73212 Reviewed-by:
-
- Jan 29, 2022
-
-
Christian Kuhn authored
Resolves: #96681 Releases: main, 11.5 Change-Id: I71ff411cd4cd639ad8d68dfcf02e46ac8818705d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73208 Tested-by:
-
Christian Kuhn authored
* Too many arguments to __construct() * Inconsistent naming * Undeclared properties Change-Id: I16ac778db7afdeaa9348e01ef777598a48bc0d05 Resolves: #96682 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73210 Tested-by:
-
Christian Kuhn authored
Constant LANGUAGE_PRESETS must be defined in tests using SiteBasedTestTrait and needs to be accessible. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: Ie31a2d1fba88aabc182b3c477ff96cfb3f13c6c2 Resolves: #96679 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73205 Tested-by:
-
Christian Kuhn authored
The index.php entry point handling and package handling core scripts are composer plugins. As such, they rely on composer. To resolve dependencies in IDE's and phpstan, composer should be a core monorepo dev dependency. This resolves about 50 issues from phpstan baseline. > composer req --dev composer/composer:^2.2 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: Iaaa4d327b7e82ca1e377d66cb1846a1699a20254 Resolves: #96676 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73201 Tested-by:
-
Stefan Bürk authored
We currently have the situation that phpstan is hard to update and maintain due to the phpstan config file that sets very specific rulesets. This is unfortunate since phpstan tends to change and rename rules at will. The general usage API of phpstan is basically as follows: Have a slim config file that sets the basic level. Then maintain a 'baseline' file that lists violations, using the --generate-baseline command option. The todo job for people working on phpstan errors is then to look at the baseline file, pick up some issues, fix them, then re-generate baseline. When baseline is small enough, the level is raised, a new baseline is generated, and the fix-job starts again. The patch does exactly this: The existing config is dropped and runTests.sh receives a command to generate baseline. With this in place, we can easily raise phpstan to a PHP 8.1 compatible version: > composer req friendsoftypo3/phpstan-typo3:"^0.9.0" --dev > composer req phpstan/phpstan:"^1.4.3" --dev > Build/Script/runTests.sh -s phpstanGenerateBaseline This initialy adds about 4000 ignores to the baseline with level 3, but we can reduce this drastically with just a couple of dedicated patches, soon. The config is heavily streamlined and for instance does *not* ignore tests anymore, which actually finds a ton of misuses and bugs within tests and classes. Resolves: #96675 Releases: main, 11.5 Change-Id: I0e7ff7aa796e59a2c5eedde0b673f741f8b87dea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73198 Tested-by:
-
- Jan 28, 2022
-
-
Robert Kärner authored
Since the element information window can also be opened from an IRRE within a Flexform element, the table name might be empty and a fallback has to be added when accessing TCA. Resolves: #96649 Releases: main, 11.5 Change-Id: I5d98e838290ff21b46c764a687703f010f1a50aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73165 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Stefan Bürk authored
'LanguageService->sL()' could be called with an empty input string, thus reading language files and caching the result is superflous. This patch adds an early check and return to 'sL()' to mitigate that. Resolves: #96666 Releases: main, 11.5 Change-Id: Ib97958be6f4ffbd96cdfc158c9307f5007d31f2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73163 Tested-by:
-
Oliver Hader authored
Method JavaScriptModuleInstruction::addFlags used plain arithmetic calculation on bit-masks. In case corresponding flags were just given once, that would not have lead to problems. However, enabling the same bits multiple times would have lead to side-effects like disabling the added bit or enabling others. Resolves: #96662 Releases: main, 11.5 Change-Id: Id4d61884b116b07891ac99d0cc2814969529b7fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73164 Tested-by:
-
Benni Mack authored
TYPO3 should never expose its EventDispatcher implementation but only work with the PSR-14 interface (SOLID principle). Also avoid GeneralUtility::getContainer() as that's internal and non recommended API in favor of makeInstance where dependency injection is not yet possible. Resolves: #96665 Releases: main, 11.5 Change-Id: Ifacb7e64bc55bcfdf58a8de454a3cebc4e602817 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73190 Tested-by:
-
Stephan Großberndt authored
This change removes the `@internal` declaration from two exceptions thrown by `ExtensionConfiguration->get()` which is used by extension authors when fetching the extension configuration as those may be caught by extension code. Releases: master, 11.5 Resolves: #96657 Change-Id: I8c90cd62c5558487cd32a7b7bf4c0dec7bb5efb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73162 Tested-by:
-
- Jan 25, 2022
-
-
Christian Kuhn authored
The form tag in 'User Settings' is never closed since that tag is added too late to $this->content. Resolves: #96645 Releases: main, 11.5 Change-Id: Ief759bce5011fd404c02cbdf35dbfcfe120bc5c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73159 Tested-by:
-
Benni Mack authored
Resolves: #96643 Releases: main, 11.5 Change-Id: I561b4ccfc3722778c102460d4e79732be020a41a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73158 Tested-by:
-
