Skip to content
Snippets Groups Projects
Commit 2c359feb authored by Benjamin Franzke's avatar Benjamin Franzke Committed by Christian Kuhn
Browse files

[TASK] Add PHPStan plugin for psr/container

The plugins adds a dynamic return type resolver for the
ContainerInterface::get() method and is especially useful
in core ServiceProviders once we enable phpstan level 5
as invalid parameter usage will then be detected.

The plugin already revealed wrong interface usage in
functional MFA tests which are fixed as a drive by.

Commands executed:

  composer req --dev bnf/phpstan-psr-container:^1.0
  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Releases: main, 11.5
Resolves: #96691
Change-Id: I4149a75e9a94ba61218e18c0639c03a06a7c53c1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73222


Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent edbcda8d
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment