[TASK] Add PHPStan plugin for psr/container
The plugins adds a dynamic return type resolver for the ContainerInterface::get() method and is especially useful in core ServiceProviders once we enable phpstan level 5 as invalid parameter usage will then be detected. The plugin already revealed wrong interface usage in functional MFA tests which are fixed as a drive by. Commands executed: composer req --dev bnf/phpstan-psr-container:^1.0 Build/Scripts/runTests.sh -s phpstanGenerateBaseline Releases: main, 11.5 Resolves: #96691 Change-Id: I4149a75e9a94ba61218e18c0639c03a06a7c53c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73222 Reviewed-by:Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- Build/phpstan/phpstan-baseline.neon 19 additions, 14 deletionsBuild/phpstan/phpstan-baseline.neon
- Build/phpstan/phpstan.neon 1 addition, 0 deletionsBuild/phpstan/phpstan.neon
- composer.json 1 addition, 0 deletionscomposer.json
- composer.lock 58 additions, 1 deletioncomposer.lock
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/Provider/RecoveryCodesProviderTest.php 2 additions, 2 deletions...Authentication/Mfa/Provider/RecoveryCodesProviderTest.php
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/Provider/TotpProviderTest.php 2 additions, 2 deletions...nctional/Authentication/Mfa/Provider/TotpProviderTest.php
Please register or sign in to comment