[TASK] Avoid phpstan 'PHPDoc tag @var has invalid value' errors
Annotations are sometimes: /** @var $foo MyType */ But should be: /** @var MyType $foo */ The patch fixes this in all tests: getMock() and createMock() need no annotation at all (both phpstan and phpstorm understand this), getAccessibleMock() currently needs an annotation and then sometimes mumbles about obsolete arguments for _call(), which can be adapted with another patch. Resolves: #96692 Releases: main, 11.5 Change-Id: I07032e60805a1dc80dc048ae6996d8bb53b0c2e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73224 Reviewed-by:Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- Build/phpstan/phpstan-baseline.neon 34 additions, 914 deletionsBuild/phpstan/phpstan-baseline.neon
- typo3/sysext/core/Tests/Functional/Authentication/BackendUserAuthenticationTest.php 3 additions, 7 deletions...nctional/Authentication/BackendUserAuthenticationTest.php
- typo3/sysext/core/Tests/Functional/Category/Collection/CategoryCollectionTest.php 2 additions, 5 deletions...Functional/Category/Collection/CategoryCollectionTest.php
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php 2 additions, 2 deletions...core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php
- typo3/sysext/core/Tests/Unit/Authentication/AbstractUserAuthenticationTest.php 1 addition, 1 deletion...ts/Unit/Authentication/AbstractUserAuthenticationTest.php
- typo3/sysext/core/Tests/Unit/Configuration/ConfigurationManagerTest.php 8 additions, 9 deletions...ore/Tests/Unit/Configuration/ConfigurationManagerTest.php
- typo3/sysext/core/Tests/Unit/Error/ProductionExceptionHandlerTest.php 2 additions, 2 deletions.../core/Tests/Unit/Error/ProductionExceptionHandlerTest.php
- typo3/sysext/core/Tests/Unit/Log/LogRecordTest.php 0 additions, 1 deletiontypo3/sysext/core/Tests/Unit/Log/LogRecordTest.php
- typo3/sysext/core/Tests/Unit/Log/LoggerTest.php 0 additions, 2 deletionstypo3/sysext/core/Tests/Unit/Log/LoggerTest.php
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractMemoryTest.php 0 additions, 2 deletions...sext/core/Tests/Unit/Log/Processor/AbstractMemoryTest.php
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php 3 additions, 3 deletions...ysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php 4 additions, 2 deletions...3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php 3 additions, 8 deletions...3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php 4 additions, 12 deletions...s/Unit/Configuration/FrontendConfigurationManagerTest.php
- typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php 0 additions, 1 deletiontypo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php 4 additions, 3 deletions...ts/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php 9 additions, 13 deletions.../Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php 1 addition, 1 deletion...sext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php
- typo3/sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php 0 additions, 1 deletion...sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php
- typo3/sysext/extbase/Tests/UnitDeprecated/Domain/Repository/BackendUserGroupRepositoryTest.php 0 additions, 1 deletion...ated/Domain/Repository/BackendUserGroupRepositoryTest.php
Please register or sign in to comment