- Feb 12, 2022
-
-
Christian Kuhn authored
Our LICENSE.txt files contain a custom header mentioning details of a 3rd party library. The patch resets LICENSE.txt files to the default GPLv2 version [1] and moves the 3rd party credits to the backend about module, which already lists other credits. This obeys the authors whish to set a link to his work. The default LICENSE.txt files have the additional advantage that services like github should recognize the project as GPLv2 licensed project. [1] https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt Resolves: #96837 Releases: main, 11.5, 10.4 Change-Id: I63a4cd286ea3714667688d12347034b9ae67f276 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73432 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Feb 11, 2022
-
-
Benni Mack authored
This issue solves a few phpstan related errors. Resolves: #96834 Releases: main, 11.5 Change-Id: I4b6c9d6ef618c5a791e0e40b10ef2d2e81bdd27e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73427 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Chris Müller authored
Resolves: #96833 Releases: main, 11.5 Change-Id: I69a3a15e9ca694456fcaf24abeef84318d9e5d6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73426 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
In case the "f:format.html" ViewHelper is called in the install tool or via CLI, there might be either no request object or one without an application type. This led to an exception on checking the application type. This is now fixed by checking the request before calling the static ApplicationType check. Resolves: #96788 Releases: main, 11.5 Change-Id: I1e48a3556d510d2af82d4f95828d44c182db0663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73422 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Christian Kuhn authored
This patch finishes the migration to the new backend templating strategy. Affected are the backend page module and the dashboard extension: * Bigger refactoring of PageLayoutController towards more modern and streamlined code with much less class state. * Transition of fillDefaultsByPackageName() in the page module for the "grid" layout towards TsConfig based template overrides. * Refactoring of the dashboard main controller to avoid fillDefaultsByPackageName(). The new template override API based on TsConfig is now documented with a feature ReST file. The new template override strategy is breaking for existing overrides based on FE TypoScript and documented with a breaking ReST file including a detailed migration path. The ext:dashboard documentation is adapted accordingly. As a result, all backend controllers that do not rely on extbase no longer parse FE TypoScript. This is especially useful for the central page module: Clicking around on a v12 bootstrap_package page tree in the page module without the patch leads to around 80 to 120 milliseconds parsetime on my machine - depending on the number and complexity of content elements and the cache state. This systematically shrinks to around 50 to 70 milliseconds with the patch: The system no longer loads tons of extbase related classes, dependency injection is more effective, and the entire FE TypoScript parsing is gone. With cold caches ("Flush all caches" backend button), the difference is around 100 milliseconds for the first call on my system - in general, the bigger the instance, the higher the improvement. Change-Id: Ia244495db592526633d01e7f504502e297bd2ef9 Resolves: #96812 Related: #96730 Related: #96614 Related: #90348 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73366 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Kuhn authored
BackendUtility::getFuncInput() is a (core) unused utility method that violates Content-Security-Policy headers due to onclick attribute. It is of very limited help anyways and should be removed. Resolves: #96829 Releases: main Change-Id: I371a5eb922c4c4b28bc67fc67e2293fe19988d15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73424 Tested-by:
-
Christian Kuhn authored
The NewContentElementController (+content button in page or list) view handling is odd: The single items are rendered with a view. Those are channeled through ModuleTemplate->getDynamicTabMenu() which creates another view to render the 'tab' panel. That panel is then put into a third view to render the rest of the modal content. The patch streamlines this by avoiding getDynamicTabMenu() and putting all needed variables into one view instance. Resolves: #96819 Releases: main Change-Id: Ib5c6790611286c054722e3652e6d5224c3ec827a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73388 Tested-by:
-
Benni Mack authored
This change adapts some comments and makes the usage of "uc" clearer in various places. In addition, one change is removed where the session data was checked against a non-hashed identifier, which can now safely be removed in TYPO3 v12.0. Resolves: #96825 Releases: main Change-Id: Ib142168bd8fc248fc030d0f486d51a6fdbf23212 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73418 Tested-by:
-
Christian Kuhn authored
Protected controller method getErrorMessageForAJAX() is unused since v7 and can be safely removed. Resolves: #96828 Releases: main Change-Id: I39e1229c8600ced151ddafdb982167b9d2ba2975 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73421 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Chris Müller authored
Fix some typos and visual glitches. Additionally, correct the headings in Index.rst. Resolves: #96827 Related: #96733 Releases: main Change-Id: Ic32b6ad7dc677547853e0b681eff9d6cf3148467 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73420 Tested-by:
-
Oliver Bartsch authored
Resolves: #96826 Related: #96776 Releases: main Change-Id: I8f4f0cd2efdf815c6f0d9d2ab146ce4859d1ecad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73419 Tested-by:
-
Oliver Hader authored
Test cases for shortcut redirects are extended to make the actual behavior more explicit there. Resolves: #96821 Releases: main Change-Id: If10fb800756d30ac348d21e52055e88353c17605 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73391 Tested-by:
-
Maik Schneider authored
A record is rendered that has an inline record. That record is rendered collapsed (only header rendered). If such a child now has a renderType="hidden" field, and the record is opened, the hidden field HTML is missing in the ajax response. The patch now adds the hidden field html when opening the record via ajax (trigger renderFieldsOnly). Resolves: #96781 Related: #87614 Releases: main, 11.5 Change-Id: Ic887712287bd3ce2903e79cc6f44a01f87ad11f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73350 Tested-by:
-
- Feb 10, 2022
-
-
Nikita Hovratov authored
This UnitTest makes some heavy usage of mocking and way too smart logic for a test. By migrating it to a functional test, all this can disappear and can be recreated with real data. Resolves: #96822 Releases: main, 11.5 Change-Id: I552317b922e6b9f6f7db838f740a2b099c727fc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73412 Tested-by:
-
Benjamin Franzke authored
With #96597 custom evaluations registered via FormEngineValidation.registerCustomEvaluation() have no longer been evaluated as a condition related to the unrelated and no longer always defined object TBE_EDITOR.customEvalFunctions shadowed the condition for JavaScriptModuleInstruction-style customEvaluations. Resolves: #96782 Related: #96597 Releases: main Change-Id: Iff9816af73d1584b41d7163f804dce7a6b2547b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73351 Tested-by:
-
Benni Mack authored
Since TYPO3 v11, the PSR-7 Request Object is always available in ContentObjectRenderer, so it can be used to access GET/POST parameters instead of GeneralUtility::_GET() and GeneralUtility::_POST() Resolves: #96802 Releases: main Change-Id: Ided7c53b5466be0bea07b69ef533037ed084a8a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73372 Reviewed-by:
-
Anja Leichsenring authored
With empty permissions in a user to be compared, this error does not appear anymore. Resolves: #96793 Releases: main, 11.5 Change-Id: If6b632f67ce59e7cca0273b7672af87ed2ee257d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73361 Tested-by:
-
Oliver Hader authored
Avoid repeating the `type` query parameter when redirecting shortcuts in the frontend rendering process - the page type is already part of the `parameter` property handed over to `typolink`. Resolves: #96820 Releases: main, 11.5 Change-Id: Ic5e718cefce2a34ad0b2f262e4ac44bbc71880f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73389 Tested-by:
-
Oliver Hader authored
Variable `extraHidden` was used in legacy pi-based plugins (which have been removed in TYPO3 v11). Actually this variable was never used in the modernized variant, based on Extbase and Fluid. Resolves: #96815 Releases: main, 11.5 Change-Id: I63ef795fd8f44b0822eb081aa322549756706e14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73386 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Bartsch authored
Resolves: #96816 Releases: main, 11.5 Change-Id: Id869a55136c6985e3fa609428099e5682c0eee12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73384 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
Oliver Bartsch authored
The new PSR-14 event ModifyButtonBarEvent is added as a direct replacement for the now removed hook $TYPO3_CONF_VARS[SC_OPTIONS][Backend\Template\Components\ButtonBar][getButtonsHook] Resolves: #96806 Releases: main Change-Id: Ib743cc532a78a3e38c96e7a89ba2e3856d8cbd0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73380 Tested-by:
-
linawolf authored
This enables developers to search for "PackageArtifact" in the changelog and documentation search. References: https://github.com/TYPO3-Documentation/T3DocTeam/issues/177 Resolves: #96711 Releases: main, 11.5 Change-Id: I9d45bbf45584bdaa682969484b141919b0c7f318 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73337 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Annett Jähnichen authored
This adds an aria-current="page" attribute to link tag of current menu-item in fluid_styled_content menu content elements. Resolves: #90994 Releases: main Change-Id: Icbb8f90a27f5fd2042921b11ddad5b6b2c251d53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73048 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
Just a tiny test change to sort out more details regarding GeneralUtility::intExplode(). Change-Id: I9df58610ff5b5c79f5b85c13b0ff323f3f988bc3 Resolves: #96811 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73382 Tested-by:
-
- Feb 09, 2022
-
-
Benni Mack authored
ExtendedTemplateService functionality is moved into the actual controllers in EXT:tstemplate that use the functionality (and are the only ones) Resolves: #96808 Releases: main Change-Id: I92521de1534e88ece6e0b857fd9bb780ace28a83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73378 Tested-by:
-
Georg Ringer authored
The SiteLanguageProcessor retrieves the current siteLanguage entity as it can be useful to have this information available in the templates. Resolves: #96800 Releases: main Change-Id: Idf59dfb6f644f116ece710e5a296c8e8524a21f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73370 Tested-by:
-
Christian Kuhn authored
Apply a basic cleanup to the RecordListController (list module) and apply new backend templating strategy. Resolves: #96784 Related: #96730 Releases: main Change-Id: I041e26a127ed1368dfd2aed01ceefc64ca662eb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73353 Tested-by:
-
Oliver Bartsch authored
This is a followup for #96777, which uses the factory method instead of instantiating the PreviewUriBuilder via makeInstance(). Resolves: #96804 Related: #96777 Releases: main Change-Id: I2224b118490d0fff917f96df3b6c1b80b548d901 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73374 Tested-by:
-
Anja Leichsenring authored
Set all missing files to declare(strict_types=1); Resolves: #96790 Releases: main Change-Id: I347263bf182200c304c5f4d841e93738f759ba0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73358 Reviewed-by:
-
Stefan Bürk authored
Resolves: #96786 Releases: main, 11.5 Change-Id: I69742ee10a6704cd43f8c68733bf13302200b975 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73356 Tested-by:
-
Anja Leichsenring authored
Set all missing files to declare(strict_types=1); Resolves: #96791 Releases: main Change-Id: I7bec6ced5e284232cba0e5cc813ad29766ec0e30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73359 Tested-by:
-
Benni Mack authored
This change uses the fluent API for generating preview URLs. This way, we can replace BackendUtility::getPreviewUri() in a next step. Resolves: #96777 Releases: main Change-Id: If4e30d3958f3117e3800077799d97505903f382c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73333 Tested-by:
-
Benni Mack authored
Default values should be integer for the newly introduced MAIL options in https://review.typo3.org/c/Packages/TYPO3.CMS/+/69907 Resolves: #96803 Related: #94544 Releases: main Change-Id: I1cbced77304e3015e5d5c64fde7257d46f037eb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73373 Tested-by:
-
Georg Ringer authored
Remove usage of TSFE and access the site entity via `cObj->getRequest()`. Resolves: #96801 Releases: main Change-Id: Ie16f72a6d7bc3b49ba00ab8eb404dc4db935a88e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73371 Tested-by:
-
Oliver Bartsch authored
Instead of referencing a language file, which has to contain three labels with predefined names, such as "mlang_labels_tabdescr", it's now also possible to configure the module title, description and short description individually. Resolves: #96799 Related: #96733 Releases: main Change-Id: I6fbe015fd18c6440a4bb0b49a5020045e08cf90e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73369 Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Christian Kuhn authored
Apply the new templating strategy to EditDocumentController (FormEngine record editing) by adding a first template and refactoring the class a bit. EditDocumentController is still a complex beast, the patch is quite conservative and cleans up only relatively obvious parts. Resolves: #96787 Related: #96730 Releases: main Change-Id: I30e340276a5687d96f04b11a567444272ec1d96c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73357 Tested-by:
-
Oliver Bartsch authored
Since introduction of the new module registration API (#96733), the TYPO3 backend route object might contain a Module object as "module" option. This option was then previously used in the RouteDispatcher to check, whether the current user has necessary access permissions for this module. However, the RouteDispatcher should not handle such validation tasks, but only dispatch to the defined target. Therefore, validation of the module access permissions, as well as further checks (e.g. for a given page id) are now moved into a dedicated PSR-15 middleware. To further improve the new API, the middleware also adds the module as attribute to the request. Additionally, the now obsolete "moduleName" route option is removed. It is always the same as the module identifier and can therefore be fetched via the object. Resolves: #96797 Related: #96733 Releases: main Change-Id: I2c580948399136a6ea9199f0872ae874ea99b8fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73367 Tested-by:
-
Anja Leichsenring authored
Set all missing files to declare(strict_types=1); Resolves: #96792 Releases: main Change-Id: I65946055f720830d2a431732d78846e0eac77a85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73360 Reviewed-by:
-
Oliver Bartsch authored
The InfoModuleController previously added the form action url as "moduleName" to the view. Since #96730, this variable name is overwritten by the ModuleTemplate. Since then, instead of the form action url, the variable only contained the module identifier. This lead to misbehavior on submitting the form. The form action url is therefore is now added, using the dedicated "formAction" variable. Resolves: #96798 Related: #96730 Releases: main Change-Id: Ic3c737cf1168bf2d6e887cc77d4d2a301037c9df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73368 Tested-by:
-
- Feb 08, 2022
-
-
Christian Kuhn authored
The match expression in PHP needs default as keyword, not as string literal. Change-Id: I8f242b47c74920034e046ce957cb5830d0584aa0 Resolves: #96794 Related: #96688 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73362 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
