- Jan 23, 2017
-
-
Gianluigi Martino authored
Prevent the escaping of pidRecordTitle in click menu move element. The escaping is already done in the MoveElementController due to the usage of the third (prep) parameter in BackendUtility::getRecordTitle. Resolves: #79088 Releases: master Change-Id: Ib35e9d5a3da7fc76085db910927ada17dbdd0b06 Reviewed-on: https://review.typo3.org/51041 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Georg Ringer authored
The select field of BackendUtility::getFuncMenu must be styled by the class "form-control". One example can be found in the template module if multiple template records are saved on one page. Resolves: #79417 Releases: master Change-Id: I84967474aadbd88bd844fe3cb7de0245abebd39f Reviewed-on: https://review.typo3.org/51384 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Georg Ringer authored
The information of a template (title, site title, description) is already escaped by using fluid. Therefore the htmlspecialchars() must be removed in the controller. This is a fix of the regression of the fluidification of #75031. Resolves: #79424 Releases: master Change-Id: Iead09ee8f8f0256eee10c2585408d549dbe5c44c Reviewed-on: https://review.typo3.org/51391 Tested-by:
-
Georg Ringer authored
If a template record does not contain any constants, the information should be rendered by a nice callout. Resolves: #79416 Releases: master Change-Id: I6af7b2676d4a7517bc392595948806df9ae7e042 Reviewed-on: https://review.typo3.org/51383 Tested-by:
-
Georg Ringer authored
As the description is a textarea, the rendering should support lines as well. Resolves: #79406 Releases: master, 7.6 Change-Id: I8774adb07c50aed24b3d3e94e0a0b913aedeb5a9 Reviewed-on: https://review.typo3.org/51379 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
-
Andreas Fernandez authored
An element with the class `btn-group` must not also have the class `btn`. Such occurences are fixed in this patch. Resolves: #79395 Related: #78199 Releases: master Change-Id: I4793afc984936c2fc7226feac24f03b6ec94794f Reviewed-on: https://review.typo3.org/51365 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Markus Klein authored
Multiline content is displayed in a textarea "as is" by the browser. There is no need to add <br> tags. Resolves: #79399 Releases: master, 7.6 Change-Id: Ia628457231a15318dff4fe36f5d3cd3d990d7dc7 Reviewed-on: https://review.typo3.org/51372 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Claus Due authored
This raises the required and locked version of Fluid to 2.2.0. The dependency is also bumped in the composer manifest to ensure that the new VH `f:variable` can be trusted to exist. The Fluid engine patches are as follows: * [FEATURE] Add variable assigning ViewHelper * [BUGFIX] Cache did not lfush when compiler disabled * [BUGFIX] Allow renderSection() to be called directly * [BUGFIX] Convert bool arguments into BooleanNodes * [BUGFIX] Disable variable extractors Change-Id: I4ca2ef35b1f82952ca6ef1932d5b2a7a764ff526 Releases: master Resolves: #79402 Resolves: #79375 Resolves: #77986 Reviewed-on: https://review.typo3.org/51375 Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
- Jan 21, 2017
-
-
Benjamin Kott authored
The backend icon set has been moved and is now under maintenance of the TYPO3 GitHub Department. https://github.com/TYPO3/TYPO3.Icons Resolves: #79404 Releases: master, 7.6 Change-Id: I9c4a78bbf52f681d61e69f2e7245fb1c2cac561f Reviewed-on: https://review.typo3.org/51377 Tested-by:
-
- Jan 20, 2017
-
-
Sascha Egerer authored
The TypoScriptFrontendController->config variable must be of type array but is initialized with an empty string. Since PHP 7.1 there is a different handling of invalid array usage. If a variable is accessed as an array but is not an array the value of that variable becomes a string 'A'. PHP 7 php > $config = ''; php > $config['foo'] = 'bar'; php > print_r($config) Array ( [foo] => bar ) PHP 7.1 php > $config = ''; php > $config['foo'] = 'bar'; > Warning: Illegal string offset 'foo' in php shell code on line 1 php > print_r($config) A Related PHP "Bug" (It's not a bug, it's a feature) https://bugs.php.net/bug.php?id=73081 Change-Id: I6d5b75ed60f0506ecacdead01a318fdc26757394 Resolves: #79052 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51302 Reviewed-by:Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Georg Ringer authored
To avoid exceptions, the proper type must be used. Resolves: #79166 Releases: master Change-Id: I00a6d65bee8b8807853461bfad681f354ae02045 Reviewed-on: https://review.typo3.org/51319 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Jan 19, 2017
-
-
Markus Klein authored
Resolves: #79393 Releases: master Change-Id: Ic8c0ec41b7421873c4dcbaaa89e483b09ad5608a Reviewed-on: https://review.typo3.org/51364 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Daniel Goerz authored
Remove a typo from phpdoc. Change-Id: If5b45a1124294c80fe3b36f8f1c829f293c9d621 Resolves: #79388 Releases: master Reviewed-on: https://review.typo3.org/51363 Reviewed-by:
-
Markus Klein authored
The query parser now throws an exception if the given value for an IN or CONTAINS expression is invalid, instead of silently converting it to a "1<>1" condition. This helps developers when searching for broken queries and prevents running queries with invalid/useless constraints. Resolves: #79388 Releases: master Change-Id: I9868325810ec11c72c994a0106a9e27141d95f3a Reviewed-on: https://review.typo3.org/51360 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Nicole Cordes authored
In \TYPO3\CMS\Extbase\Reflection\ObjectAccess there is a method to get all available property names of an object. Currently all get/is/has methods are joined as they can be fetch from Extbase as well. But for those methods it is necessary to respect their arguments as Extbase calls those functions without any argument. This can trigger PHP warnings. The patch uses a class reflection to get public properties and inspect the method arguments. Only those functions without arguments or only optional arguments are considered as valid property name. Resolves: #78270 Releases: master, 7.6 Change-Id: Ie286dca2a249b73d3dc58f7388dda593a678db3d Reviewed-on: https://review.typo3.org/50197 Tested-by:
-
Morton Jonuschat authored
The unified session handling for frontend and backend requires identical SQL column types to properly escape the input data. Using binary encoding for session data in combination with a TEXT type field in the BE fails on PostgreSQL. Change-Id: I3f3f379b43f873335207232e498f2e9e2c8b35e5 Resolves: #79324 Releases: master Reviewed-on: https://review.typo3.org/51314 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
- Jan 18, 2017
-
-
Georg Ringer authored
Tags must not be stripped away for creating diffs as those are essential for editors. Otherwise it is not possible to see changed links or changing a header from h1 to h2. Resolves: #78767 Resolves: #79205 Releases: master, 7.6 Change-Id: Icb174f3522354fa8ef5d2b8ccca039e33ef472e7 Reviewed-on: https://review.typo3.org/51220 Tested-by:
-
Wouter Wolters authored
Heven't replaced with haven't Resolves: #79376 Releases: master,7.6 Change-Id: I85b252514378eb4db1eb63f93d9b746ca332602e Reviewed-on: https://review.typo3.org/51346 Reviewed-by:
Robert van Kammen <rvkammen@hotmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Martin Kutschker authored
A new CLI command allows to imoprt t3d/xml files for EXT:impexp. Resolves: #72749 Releases: master Change-Id: I8775bcc1d39901c25f0c4613d1d5fc3ff3b8868a Reviewed-on: https://review.typo3.org/45977 Tested-by:
-
Georg Ringer authored
To improve usability the naming and sorting of content element types for the content element wizard and the select box are unified. Resolves: #77961 Releases: master Change-Id: I6a0aa4a824992e062ba14931a7712eaafadeb8ab Reviewed-on: https://review.typo3.org/49948 Reviewed-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
Georg Ringer authored
Instead of using $GLOBALS a runtime cache is used. Resolves: #79345 Releases: master Change-Id: I2273051c2d52efff5fa578a82ff636748fe7fdf6 Reviewed-on: https://review.typo3.org/51332 Tested-by:
-
- Jan 17, 2017
-
-
Wouter Wolters authored
Resolves: #79316 Releases: master Change-Id: Ieb54d51a6d6f15325fc4c1c88ad29c845200c68b Reviewed-on: https://review.typo3.org/51309 Reviewed-by:
-
Phat Hoang authored
This can be useful when using the unified referencing syntax. Resolves: #79349 Releases: master Change-Id: If822da7a6fd348f71c4f36ecf5f63f0a103bd2f7 Reviewed-on: https://review.typo3.org/51334 Tested-by:
Mattias Nilsson <tollepjaer@gmail.com> Tested-by:
-
Georg Ringer authored
By fixing a typo in the CacheManager empty tag arrays are detected and intercepted. Resolves: #79236 Releases: master Change-Id: I67fccda3755274f3334f0916d26beabbb28b8eb4 Reviewed-on: https://review.typo3.org/51234 Reviewed-by:
-
Benni Mack authored
Some obsolete options are found in the documentation, additionally the RTE.default.proc.exitHTMLparser_db is not enabled by default anymore, as the functionality to keep non matched tags is not needed. In case of a site extending the default exitHTMLparser_db configuration of HTMLArea, it has to be enabled like this: RTE.default.proc.exitHTMLparser_db = 1 RTE.default.proc.exitHTMLparser_db { ## KEEP ALL TAGS ## Unwanted tags were removed on entry. ## Without this rule, the parser will remove all tags! Presumably, this rule will be more efficient than repeating the allowTags rule keepNonMatchedTags = 1 } Resolves: #79346 Releases: master Change-Id: Ie7208a3fc751b2b712ec773a148c4404965abd99 Reviewed-on: https://review.typo3.org/51299 Tested-by: -
Christian Kuhn authored
Configuring a richtext field in TCA with the "defaultExtras" setting (which was formerly the 5th showitem parameter) has been ugly ever since: The DataHandler needed a special _TRANSFORM_ field to trigger required RTE transformations, further config depends on pageTs settings. The patch gets rid of "defaultExtras" for richtext elements and adds a new option "enableRichtext=true" within the config section for type=text TCA fields. This setting can be set via "columnsOverrides" for specific types, too. As an intermediate solution, the configuration class "Richtext" is added to fetch richtext configuration. This will be extended with another patch to provide ckeditor configuration on TCA level. Change-Id: I70f4cb26e2a45629b99680e532d376538afd2b90 Resolves: #79341 Releases: master Reviewed-on: https://review.typo3.org/51311 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Jan 16, 2017
-
-
Tymoteusz Motylewski authored
Since now all Backend urls have module token in place, the veriCode is not needed any more. Thus AbstractUserAuthentication::veriCode() is marked as deprecated, vC parameter is not checked any more and vC property is removed from some controllers. Resolves: #79327 Releases: master Change-Id: I47e459d95e8f561dcc933a832d22c86ed02aa707 Reviewed-on: https://review.typo3.org/51317 Tested-by:
-
Oliver Hader authored
The processing of data structures in DataHandler and RelationHandler are bound to each other. DataHandler allows to be initialized with a custom BE_USER instance and thus with a custom workspace, different to the actual value of the real instance of $GLOBALS['BE_USER']. This patch streamlines the workspace disposal by explicitly forwarding the provided workspace to RelationHandler and avoids fetching the current workspace for processing from global values. The consideration of workspace related fields in RelationHandler was bound to the current workspace of the global backend user - however, this backend user constraint has been removed now. Resolves: #79339 Releases: master Change-Id: I3973d55c5b9d99ed2e976b86136338fee79d5f6e Reviewed-on: https://review.typo3.org/51325 Tested-by:
-
Benni Mack authored
In order to work with available constants in TypoScript in Frontend the parsed TypoScript constants are included in the cache entries as well. This ensures a more consistent behaviour of available information for the TYPO3 Frontend. This was previously set via $this->backend_info which was set to "true" in the TYPO3 Backend. Resolves: #79307 Releases: master Change-Id: I5f5e024c8df51c4fd43b7bc607855b9b21ebb1dd Reviewed-on: https://review.typo3.org/51304 Tested-by:
-
- Jan 15, 2017
-
-
Morton Jonuschat authored
Databases that adhere to the SQL92 standard and enforce having all columns that are using in any part of the query be part of the SELECT/COUNT field list will throw an error when using COUNT(*) in combination with ORDER BY. Since ordering has no influence on the result of COUNT(*) the ORDER BY query part has been disabled in getObjectCountByQuery(). Change-Id: Idd7c73d172116a83feb653db6a0167fb0bea2023 Resolves: #79322 Releases: master Reviewed-on: https://review.typo3.org/51313 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Nicole Cordes authored
Currently the PackageManager loads installed package information by default only. This patch adds a new flag to ensure all packages are fetched before all available package information should be returned. Resolves: #79078 Releases: master Change-Id: I729c02f7b5c8303ee8d277aa88782274dff23591 Reviewed-on: https://review.typo3.org/51026 Tested-by:
-
- Jan 14, 2017
-
-
Kasper Ligaard authored
The Redis cache backend allows configuration of all connection setting, except setting persistent connections. This omission is fixed by this patch. Being unable to use persistent connections under high load can hurt performance in cloud setups. Persistent connections has been part of phpredis since 2010 and thus is broadly available, but is impossible to use with TYPO3. Resolves: #79005 Releases: master, 7.6 Change-Id: Ie5476e894072bb9979691f28bc7a1e10e86ef454 Reviewed-on: https://review.typo3.org/50978 Tested-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Reviewed-by:
David Greiner <hallo@davidgreiner.de> Tested-by:
-
- Jan 13, 2017
-
-
Claus Due authored
Avoids an issue where default View paths would be added LAST instead of FIRST as is intended. Change-Id: I00413b40e2df529b0c6673226b65924b034c2432 Resolves: #79290 Releases: master Reviewed-on: https://review.typo3.org/51283 Tested-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
-
Stefan Rotsch authored
The described behavior has been removed with TYPO3 7.6; the variable is treated as a boolean now. Resolves: #79314 Releases: master Change-Id: I456ad1884a9a40c22c2015d19aa5abdd623a1654 Reviewed-on: https://review.typo3.org/51308 Reviewed-by:
-
Georg Ringer authored
If a field is hidden by using TsConfig, it should also not be shown in the single table rendering in the record list. Resolves: #79289 Releases: master Change-Id: I0366c5ef5da260084367b9881f3a26ef60d5b319 Reviewed-on: https://review.typo3.org/51282 Tested-by:
-
Ralf Zimmermann authored
https://review.typo3.org/#/c/50285/ breaks the ext:form backend modul. Remove "class" tag attributes from flashMessages viewHelper tags. Resolves: #79306 Releases: master Change-Id: I753cc5bf4deabfa824179c5e025044c65df4e069 Reviewed-on: https://review.typo3.org/51303 Tested-by:
-
Benni Mack authored
Adding SSL support on a per-page basis is something that does not happen very much in 2017 anymore, rather doing this on a per-domain basis, and based on server-redirects makes more sense these days. The field and the functionality for links is moved to EXT:compatibility7. Resolves: #79302 Releases: master Change-Id: I7ae1c59533bee1d015b39811f39d590e5488aabe Reviewed-on: https://review.typo3.org/51077 Reviewed-by:
-
- Jan 12, 2017
-
-
Benni Mack authored
The option transformBoldAndItalicTags is there to convert <i> and <b> tags from the DB to <strong> and <em> for the RTE. When saving, all tags are converted back to <i> and <b> before storing the content in the database again. This is actually a (weird) shortcut due to historical reasons, and can easily be set up by the HTMLparser directly using the tags.[tagname].remap = [newtagname]. This syntax can be used directly to enable this functionality again RTE.default.proc { # make <strong> and <em> tags when sending to the RTE HTMLparser_rte { tags { b.remap = strong i.remap = em } } # make <b> and <i> tags when sending to the DB HTMLparser_db { tags { strong.remap = B em.remap = I } } } The option is removed and the explicit (and IMHO more understandable) syntax is used in the RTE configuration of HTMLArea. If the InlineElements functionality of HTMLarea is enabled, then the remapping is not done, as any tag (b, i, strong, em) is kept as is, becoming more flexible. In any case, any "unification" if necessary, can also be done the same way via the HTMLparser for the frontend when outputting the content. Resolving: #79300 Releases: master Change-Id: I354b0ccd1948ea7d018c7135c4694e0c0f9b72b8 Reviewed-on: https://review.typo3.org/51289 Reviewed-by: -
Christian Kuhn authored
The new DatabaseL10nModeUpdate install tool upgrade wizard that migrates row content for old "mergeIfNotBlank" fields is now implemented as the first consumer of the new row updater upgrade wizard. Change-Id: If7495ef09e06c5fd611fe95feff640c67d3a672b Resolves: #79281 Related: #79243 Related: #79279 Releases: master Reviewed-on: https://review.typo3.org/51277 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Tymoteusz Motylewski authored
A new field which is a ctrl-based field for any TCA table called "translationSource" set to a DB field name (used for the new field tt_content.l10n_source) is added and filled as it contains the uid of the record of where a translation record came from. This is different to "transOrigPointerField" as it contains not the record to a record in the default language or the one where a record was copied from, but rather the information what the translation source was made. Releases: master Resolves: #78169 Change-Id: I3ecfeedb656c64681e5e3021cad6b708482520dc Reviewed-on: https://review.typo3.org/51070 Tested-by:
-
