- Sep 17, 2018
-
-
Benni Mack authored
With PSR-15 it is not necessary to use any custom hooks during the frontend request setup process anymore, as middlewares are flexible enough to manipulate anything people want to do. On top, various middlewares are also declared internal as the usages are not really necessary to be publically exposed. - typo3/cms-core/normalized-params-attribute - typo3/cms-backend/legacy-document-template - typo3/cms-backend/output-compression - typo3/cms-backend/response-headers - typo3/cms-frontend/timetracker - typo3/cms-frontend/preprocessing - typo3/cms-frontend/eid - typo3/cms-frontend/content-length-headers - typo3/cms-frontend/tsfe - typo3/cms-frontend/output-compression - typo3/cms-frontend/prepare-tsfe-rendering - typo3/cms-frontend/shortcut-and-mountpoint-redirect Resolves: #86279 Releases: master Change-Id: I14fbd7b026acdc84fb23ca43cd395de5b7b9c4b6 Reviewed-on: https://review.typo3.org/58253 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Sep 16, 2018
-
-
Benni Mack authored
The following properties have changed their visibility to be protected from public. * pageAccessFailureHistory * workspacePreview (not in use anymore) * ADMCMD_preview_BEUSER_uid (not in use anymore) * debug (not in use anymore) * MP_defaults (not in use anymore outside of TSFE) * loginAllowedInBranch (use checkIfLoginAllowedInBranch()) The following methods have changed their signature to be protected, as their purpose is to be called from within TypoScriptFrontendController. - tempPageCacheContent() - realPageCacheContent() - setPageCacheContent() - clearPageCacheContent_pidList() - setSysLastChanged() - contentStrReplace() Resolves: #86047 Releases: master Change-Id: I98f54f4a75023b963b69c12457b73e5117469497 Reviewed-on: https://review.typo3.org/58083 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
If a system maintainer used the install tool from within the backend, the session is now destroyed on logout explicitely. Resolves: #86249 Resolves: #85404 Releases: master Change-Id: I6bf4f2a724ec85b60854e8f92c00a10e7614f140 Reviewed-on: https://review.typo3.org/58297 Reviewed-by:
-
Richard Haeser authored
Use the Uri class to check if a host is given in the url to determine if an absolute url should be generated. Resolves: #86253 Releases: master Change-Id: Ib84d391b0564f29352eda93a814f5d9b46696f37 Reviewed-on: https://review.typo3.org/58274 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Christian Kuhn authored
Suppress a where uid=0 call on sys_file table if the backend user has not avatar assigned. Resolves: #86273 Releases: master Change-Id: Id67e80dbb906ce27af3954f9c20ee49a5c7050ee Reviewed-on: https://review.typo3.org/58291 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
Page uid 0 has no rootline by definition. The patch adds an early return to RootlineUtility to suppress some cache->get() calls. This happens in BE quite often. Additionally, the SiteFinder does not query RootlineUtility for page uid 0 at all to save a series of instance creations. Resolves: #86271 Releases: master Change-Id: I63c819c6dcd5e5c7a0e226ae16b0ecd6cf391e30 Reviewed-on: https://review.typo3.org/58289 Tested-by:
-
Michael Schams authored
This change updates the text in the Core Upgrade dialog and fixes a typo as well as introduces some basic styles. Resolves: #86274 Releases: master Change-Id: Ie6433a9fa3a5f8b8d1c808955872dda91d10788a Reviewed-on: https://review.typo3.org/58292 Tested-by:
-
- Sep 15, 2018
-
-
Christian Kuhn authored
Some DB drivers like pdo_mysql and our postgres flavor return values from DB always as string. Classes with enabled strict_types then tend to fail if those values that should be integers but are strings are fed to functions that accept integers only. The patch fixes two places in SchedulerModuleController where a db value is directly sent to date(), which needs an int as second argument. Resolves: #86263 Releases: master Change-Id: I00ce0425774762fef235373f643f8b69bdd072bb Reviewed-on: https://review.typo3.org/58285 Reviewed-by:
-
Markus Klein authored
Resolves: #86259 Releases: master Change-Id: I0a5c7020d879250cf38ca1975a8f63e65f1a0649 Reviewed-on: https://review.typo3.org/58281 Reviewed-by:
-
Christian Kuhn authored
Resolves: #86200 Related: #86172 Releases: master Change-Id: I9f6412ed7a6adb8b00f62cbca7476a49bed6985d Reviewed-on: https://review.typo3.org/58278 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Frank Naegler authored
This patch introduces error handling to mitigate a missing type check in the Symfony Expression Language handler. In case a condition uses the "in" or "not in" check in combination with a non-array a PHP warning is thrown. Example: [1 in "foo"] or ["bar" in "foo,baz"] These conditions are broken, but they will break the complete installation including the backend. To mitigate the problem we do the following: 1) In FE an InvalidTypoScriptConditionException is thrown (if strictSyntax is enabled) 2) In FE catch this error silently and log it (if strictSyntax is disabled) 3) In BE catch this error silently and log it, but never break the backend. Resolves: #86257 Releases: master Change-Id: I2a54f819383775a300af6848cfc85e9f626bec21 Reviewed-on: https://review.typo3.org/58280 Tested-by:
-
Christian Kuhn authored
Maintenance > Remove temporary assets now properly lists statistics for FAL processed files and allows to clear them. Releases: master Resolves: #83034 Change-Id: Ic9238c88648d98a76a0cbd4015820d51bffde0fa Reviewed-on: https://review.typo3.org/57837 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- Sep 14, 2018
-
-
Christian Kuhn authored
Resolves: #86256 Releases: master Change-Id: I6b108342ebb7439657afec296c68de7ba45bf29e Reviewed-on: https://review.typo3.org/58279 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Frank Naegler authored
This patch fix broken TSConfig condition because of missing backend user aspect. Resolves: #86229 Releases: master Change-Id: I6528b5d48a5b5711cad8710d4bfcc6222f9fef9c Reviewed-on: https://review.typo3.org/58275 Reviewed-by:
-
Christian Kuhn authored
Issue #85092 introduced a copy & paste bug in TemplateService. Resolves: #86255 Related: #85092 Releases: master Change-Id: If0d92e0886e625db8793991f264628030ccfdad4 Reviewed-on: https://review.typo3.org/58277 Reviewed-by:
-
Georg Ringer authored
Instead of only checking the sys_domains with a database query the SiteFinder and PseudoSiteFinder should be used. Resolves: #86219 Releases: master Change-Id: I99f9367258f9b19ef3a1310cb2fd61076083333c Reviewed-on: https://review.typo3.org/58257 Tested-by:
-
Susanne Moog authored
Migrates all upgrade wizards based on the `AbstractDownloadExtensionUpdate` class to the new API. Related: #86172 Resolves: #86199 Releases: master Change-Id: I79ffa702a1448bb66324074ef2debf41922d95e8 Reviewed-on: https://review.typo3.org/58233 Reviewed-by:
-
Andreas Fernandez authored
The JavaScript for the SlugElement is partially designed to be a independent instance for each slug field. However, this does not work for mass editing the slug fields, as the `initialize()` method is always called on the same instance. This patch does multiple things: - The JavaScript is converted to a TypeScript basis, which allows better handling of each instance - The "Regenerate slug" button is disabled in case the "feeder" fields are not available to avoid getting bogus values Resolves: #86221 Releases: master Change-Id: I458247beb597c77407e94ce633314ae2e2d7095a Reviewed-on: https://review.typo3.org/58273 Tested-by:
-
Richard Haeser authored
Create absolute URL's for the hreflang links by using the configuration of the current site. Resolves: #86224 Releases: master Change-Id: Id3196542875862b20145418956fcfdfcc3834241 Reviewed-on: https://review.typo3.org/58262 Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Sep 13, 2018
-
-
Susanne Moog authored
Wizards marked as done are no longer displayed as executable in the install tool, the missing state check has been included. Resolves: #86246 Releases: master Change-Id: Ic86910379f3bc2994f87a8408e81e32d5f28729a Reviewed-on: https://review.typo3.org/58270 Tested-by:
-
Daniel Goerz authored
The check for pages.l18n_cfg is wrong now, as this is always done against pages.sys_language_uid=0 records (as "resolvePage" is called right before). So, these if-statements have to go further south. On top, the getPageOverlay call needs to be done - on top. resolvePage -> get default language of page getPageOverlay -> put the wanted translation on top A fix for pages.alias has to be in place, as DataHandler cannot handle pages.alias yet. Resolves: #86242 Releases: master Change-Id: Ief99e5f934f6e9d31973b9543cb9a6e599d2d33c Reviewed-on: https://review.typo3.org/58267 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Helmut Hummel authored
To make the registry for done wizards consistent and stay backwards compatible once all upgrade wizards are converted to use the new interface, always store the class name of the wizard instead of its identifier in the registry. Additionally we now add checks for valid identifiers to all API methods that receive one. Releases: master Resolves: #86165 Change-Id: I402852c90f5a8d3d0a05bacbd961a4bb4cb86d1e Reviewed-on: https://review.typo3.org/58197 Tested-by:
-
Christian Kuhn authored
With the install tool move to modals, various details on CSS level broke: The modal HTML is on top level in backend and thus not within the content-iframe, so styles defined in install.css loaded in the iframe do not kick in. Since the standalone install tool does not use iframes, there are various differences on view level between standalone and embedded-in-backend version, usually with the embedded version looking more ugly than standalone. The install.css is not very different from backend.css anyway, so we resolve various details with the patch, kick install.css entirely and rely soley on backend.css, even for the installer. Details: * <hr> shows a border again in modals in embedded, broken since modal patch * image processing view has borders and other details again in embedded verision, broken since modal patch * removed 'fixed save button location' for 'all configuration' code. This broke with the modal patch, the code does not do anything useful at the moment. A solution needs a change of the modal js to render the buttons to modal-footer instead. This is too complex for this patch and may be done with another patch. * A couple of classes to easily limit styles to installer and maintenance parts * Remove left overs from old install-tool menu approach that have not been cleanup up, yet. Resolves: #86245 Related: #84772 Releases: master Change-Id: I4d21677331112a48f84b0cf48a574999128a15b7 Reviewed-on: https://review.typo3.org/58269 Tested-by:
-
Christian Kuhn authored
With moving the language pack updater to the install tool, a signal got lost that allowed overriding the base download url of language packs per extension. The patch introduces this signal again. Resolves: #84691 Related: #84131 Releases: master Change-Id: I659a8829b292d9c268ee3ee9df851d971ba5ddd7 Reviewed-on: https://review.typo3.org/58265 Tested-by:
Jan Delius <me@jandelius.eu> Tested-by:
Rico Drexler <rico.drexler@gmx.de> Tested-by:
-
Georg Ringer authored
The SiteFinder retrieves the correct domain for root pages also for pages having a site configuration. Resolves: #86158 Releases: master Change-Id: If99da2deea08ca7bbe05c13f37472a070ffc6d62 Reviewed-on: https://review.typo3.org/58193 Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Benni Mack authored
The config.defaultGetVars is executed and $_GET is modified, but not the middleware where this method is called. In order to also modify the middleware's request object, the option config.defaultGetVars is also evaluted again in the PSR-15 middleware. Resolves: #86241 Related: #86046 Releases: master Change-Id: I2238d93b4974a40b2228c099cef7c8a04bd6cf74 Reviewed-on: https://review.typo3.org/58266 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
-
Susanne Moog authored
The recycler doktype should be allowed in rootline in BE. Resolves: #86209 Releases: master Change-Id: I173c2deca5cd395d566a6fd9d6499538ef20d2e6 Reviewed-on: https://review.typo3.org/58243 Tested-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
- Sep 12, 2018
-
-
Anja Leichsenring authored
If an exception identifies itself with a code, display it next to the Exception title. Change-Id: Ib24b7ce4e0bef426dd4e0f4b7f25c4f5338e02c6 Resolves: #86238 Releases: master Reviewed-on: https://review.typo3.org/58260 Tested-by:
-
Susanne Moog authored
Resolves: #86237 Releases: master Change-Id: Id139dcabb6367b03fb5584a6c7d4a673595eb88e Reviewed-on: https://review.typo3.org/58258 Reviewed-by:
-
Tymoteusz Motylewski authored
Resolves: #86235 Releases: master Change-Id: I1e75309abd8bc1aa38d861dae4a48a958b9750dd Reviewed-on: https://review.typo3.org/58256 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Tymoteusz Motylewski authored
Double backticks are now replace with single ones, fixed some typos like missing colon. Resolves: #86233 Releases: master Change-Id: I5889a285a5b9a7d65b8bcf7931801298d539e9df Reviewed-on: https://review.typo3.org/58254 Tested-by:
-
Christian Kuhn authored
With latest refactorings, the good old backend module classes BaseScriptClass (t3lib_SCbase) and AbstractFunctionModule (t3lib_extobjbase) are finally unused. These spaghetti classes have been a hindrance to refactor modules that used them for a long time already due to their hard to follow code flow, bad method namings, global variable usages and having everything declared public. It's time to get rid of them to unlock refactoring of controllers and allow dropping of various global variables in v10. Resolves: #86225 Releases: master Change-Id: I3b5bb35b693c7991052f4e0855c2aae4e39f02a1 Reviewed-on: https://review.typo3.org/58249 Tested-by:
-
Alexander Schnitzler authored
The @internal annotation – which is a regular phpDocumentor annotation that is used to denote that associated structural elements are elements internal to the application or library, has been misused by extbase to tell if a command is internal and thus should not be exposed through help texts, user documentation etc. – is deprecated without any replacement. TYPO3 does no longer support the use of the @internal annotation to influence the behaviour of the code. Releases: master Resolves: #85980 Change-Id: I7f3b998b56e270b30e5193d494d35329f5608603 Reviewed-on: https://review.typo3.org/58039 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Georg Ringer authored
Catch exceptions for non existing directories which are imported using the @import syntax for TypoScript and return those as warning in the template module. Resolves: #86230 Releases: master Change-Id: Ie4a6376407eeeaa7a717cb01ede5cabefa8a443f Reviewed-on: https://review.typo3.org/58251 Tested-by:
-
Georg Ringer authored
Resolves: #86226 Releases: master Change-Id: Idcffc65e6e040ab4f09e352f268aa4919c2abc59 Reviewed-on: https://review.typo3.org/58250 Tested-by:
-
Georg Ringer authored
During the refactoring of #85543 a line too much has been removed. Readd the initialisation of $tsfe. Resolves: #86223 Releases: master Change-Id: Icd7bf93fe1d04e845b4a8cc497f171c7429d0d55 Reviewed-on: https://review.typo3.org/58252 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
- Sep 11, 2018
-
-
Lienhart Woitok authored
If installing a new TYPO3 instance on mysql, utf8mb4 is now used as default charset for the database connection and as default collation. Upgraders may change LocalConfiguration to use utf8mb4, too. They however need to take care of changing their collations and setting according table detaults on their own. A reports status check verifies there is no mixed collation. Resolves: #80398 Resolves: #82080 Resolves: #82551 Releases: master Change-Id: I6bf464a22c6ed74631bf5aacff9c2cfe670077da Reviewed-on: https://review.typo3.org/56440 Reviewed-by:
Lienhart Woitok <lienhart.woitok@netlogix.de> Tested-by:
Georg Großberger <garfieldius67@gmail.com> Reviewed-by:
-
Benni Mack authored
The cObject FILE has a strange behaviour, and rather became low-level since Fluid's rise in rendering Frontend. FILE shows an image if the file is jpg,jpeg,gif,png (but not SVG), and if has a different file ending, it will check if the file is less than 1MB, it will get its contents and output that. If the file is 1 byte bigger, nothing is done. This _magic_ is sketchy, and obsolete, as Fluid offers more flexibility nowadays. Thus, cObject FILE will be removed from TYPO3 Core in v10.0, however due to the flexibility of custom cObject, an extension author could just re-implement the functionality in a custom extension within minutes. Resolves: #85970 Releases: master Change-Id: I792ec89486e29051da478c5ec0855d2f9cf913a1 Reviewed-on: https://review.typo3.org/58028 Reviewed-by:
-
- Sep 10, 2018
-
-
Oliver Hader authored
The expected behavior is that the copied record is not synchronized when modifying the language parent record (since it is not in connected mode). Resolves: #86215 Releases: master, 8.7 Change-Id: Ibf58dd6daf877b172aea5c31ead8ea1277834bfc Reviewed-on: https://review.typo3.org/58246 Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Christian Kuhn authored
Last patch in the protect controller patch series. This time the Web->Info module controller no longer extends BaseScriptClass and the single sub controller classed don't extend AbstractFunctionModule anymore. The patch sets as much as possible to protected to allow further refactoring of these classes in v10. Resolves: #86210 Releases: master Change-Id: I5c474e6cc0bc093c58b2e939e408b47020547a6b Reviewed-on: https://review.typo3.org/58241 Tested-by:
-
