- Jul 25, 2024
-
-
Christian Kuhn authored
phpstan "bleeding edge config" enables a feature that reduces memory usage significantly. We don't switch to "bleeding edge" per se, but enable that single toggle for now. phpstan does not do this by default since it may be breaking for existing rules, which is not a problem in our case. > rm -rf .cache/phpstan/; Build/Scripts/runTests.sh -s phpstan Before locally: 10.99 GB After locally: 5.82 GB Before CI: 15.15 GB After CI: 9.49 GB Numbers vary depending mainly on available number of CPUs: My local machine has less CPUs than CI - we *may* tune phpstan a bit further in this area, later. Resolves: #104476 Related: #104475 Releases: main, 12.4, 11.5 Change-Id: I32ca9a36b752ad52e8ac5fd433c3f929f86843af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85377 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Christian Kuhn authored
phpstan can be very memory hungry. Option --verbose adds a line about 'peak memory' usage to the output. Add this to get a better feeling of the memory usage. Resolves: #104475 Releases: main, 12.4, 11.5 Change-Id: I3fdaf7ddee7e003e7a8e75a508dd69161c804c8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85353 Reviewed-by:
-
- Jul 24, 2024
-
-
Andreas Kienast authored
This commit updates the package `requirejs` to version 2.3.7 to fix a prototype pollution vulnerability [1]. [1] https://github.com/requirejs/requirejs/compare/2.3.6...2.3.7 Resolves: #104459 Releases: 12.4, 11.5 Change-Id: I73a62c7e4e715954db5802d0a46d5758c407ac7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85334 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
- Jul 19, 2024
-
-
Stefan Bürk authored
Resolves: #104435 Releases: main, 12.4, 11.5 Change-Id: I5ff37f97f0d0a71420839c4d2b1bf8bde70afa7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85205 Tested-by:
-
Stefan Bürk authored
This change adds the predefined GitLab CI/CD variable `CI_JOB_ID` value to the suffix, used for containerized network and container names, with the goal to increase uniqueness in CI runs. Additionally, the value is now displayed in execution and the container cleanup notes at least the network name further information source to investage unusually container shutdowns. [1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html Resolves: #103928 Releases: main, 12.4, 11.5 Change-Id: I6cf8dddefd2b45ed6f5c8cca8aa5521319cc8c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85301 Reviewed-by:
-
Andreas Kienast authored
Historically, FormEngine UI mangles dates from one format to another and feeds the result back to the date picker, crossing fingers nothing goes wrong. This bites hard when it comes to non-standard date formats, basically everything but `d-m-Y`. To lay the groundwork on tackling the date format issue, FormEngine now always works with ISO8601 dates internally, allowing to get rid of some helper methods. Resolves: #104309 Releases: main, 12.4 Change-Id: Iafac126f8f02b6dba6f2623f1e7790c6c6fb9bb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85243 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Jul 18, 2024
-
-
Ayke Halder authored
This patch corrects the misusage of anchor elements instead of buttons for controlling sortable selects. In addition we are adding the existing labels to the buttons to support visually impaired users. Resolves: #104414 Related: #102783 Releases: main, 12.4 Change-Id: If80f62db06bda61250d09bc4727a7ec708f02757 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85282 Tested-by:
-
- Jul 15, 2024
-
-
Benjamin Franzke authored
Do not listen on the livereload port, as we do not ship the client-side[1] livereload integration anyway. This allows multiple grunt-watch (e.g. main and 12.4) to run in parallel instead of blocking each other because they try to allocate the same port. [1] https://github.com/gruntjs/grunt-contrib-watch/blob/main/docs/watch-examples.md#enabling-live-reload-in-your-html Resolves: #104390 Releases: main, 12.4, 11.5 Change-Id: I36f37178e1752015033d5b0f2746c49b2477c1a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85200 Tested-by:
-
- Jul 12, 2024
-
-
Christian Kuhn authored
PHP 8.4 linting is fine already. Let's add it to CI jobs. Resolves: #104386 Releases: main, 12.4, 11.5 Change-Id: Ie64f602aace5d816ae80ce502bdf054dde7b787a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85252 Tested-by:
-
Oliver Bartsch authored
When using boolean attributes there are two things to consider: 1. The default value must be FALSE 2. Presence of the attribute always means TRUE It's therefore not possible to have a boolean attribute, which defaults to TURE and it's also not possible to set an attribute to FALSE via its value (e.g. "0" or "false). See for reference: https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attributes Therefore, to properly handle the "is writeable" state in the language packs module, the default is set to FALSE an the attribute only gets added (which defines the TRUE state) in case corresponding data attribute is set in the template. Resolves: #104353 Releases: main, 12.4 Change-Id: I82f440ae4fbeba405c35bbfa859804e2bc0660c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85239 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jul 10, 2024
-
-
Andreas Kienast authored
The flatpickr integration in TYPO3 is configured to use luxon for date time formatting operations, which consumes different format tokens. This leads to the situation that aria labels generated by flatpickr are now broken. This commit changes the option `ariaDateFormat` to luxon's `DDDD` token, which renders a "localized date with full month and weekday", according to [1]. [1] https://moment.github.io/luxon/#/formatting?id=table-of-tokens Resolves: #104342 Releases: main, 12.4 Change-Id: I7902d39209ad59e0c3196db7f906b93533d7b7cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85192 Reviewed-by:
-
- Jul 09, 2024
-
-
Andreas Kienast authored
The date time picker module `@typo3/backend/date-time-picker` uses flatpickr, but wasn't aware of it due loose `any` usages. The code is modified to make use of the typings shipped with flatpickr. To solve this long-standing issue, the module identifier is changed from `flatpickr/flatpickr.min` to `flatpickr`, which requires an additional entry in the `JavaScriptModules.php` configuration, but allows to remove a module declaration. Resolves: #104338 Releases: main, 12.4 Change-Id: I3feed53627c639e21e4812855fd4ce2defe91c14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85188 Reviewed-by:
-
Stefan Bürk authored
This change adds PHP8.4 as allowed version to the `Build/Scripts/runTests.sh` script as preparation to validate and check the Core and 3rd party libs with PHP8.4 locally. Note that unit tests already revealing deprecation and errors for 3rd party extension which can now be reported and for checked upstream updates. Resolves: #104337 Releases: main, 12.4, 11.5 Change-Id: I76d3e37b393c347173fcdbe874d6a0737fb76d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85179 Tested-by:
-
Oliver Hader authored
Change-Id: I72e06646233894cfbd8017bef8a5620e17caf32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85174 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Hader authored
Change-Id: I20500c48221bf14b56baef7551a423571883c6a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85173 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Andreas Kienast authored
This commit fixes the event binding on the "Close" action to trigger the correct actions when e.g. the icons within the buttons are clicked. Resolves: #104333 Releases: main, 12.4 Change-Id: I448c0b68de376a1b0e8517cc58c5bf2d2576b662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85172 Tested-by:
-
- Jul 08, 2024
-
-
Georg Ringer authored
Version 7.15 officially supports TypeScript 5.5, which we use since #104189 and therefore eliminates a build-time warning. Also update TypeScript from 5.5.2 to 5.5.3, while at it. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.15 \ @typescript-eslint/parser@^7.15 \ @typescript-eslint/typescript-estree@^7.15 \ typescript@^5.5.3 npm run build-js Resolves: #104317 Related: #104189 Releases: main, 12.4 Change-Id: Ibe242b42ecf9c5e986217a85283174220ae18bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85151 Tested-by:
-
- Jul 02, 2024
-
-
Stefan Bürk authored
This change modifies the `php-cs-fixer` ruleset and activate two rules related to nullable types. Following options are added: 'nullable_type_declaration' => [ 'syntax' => 'question_mark', ], 'nullable_type_declaration_for_default_null_value' => true, `nullable_type_declaration` ensures to use `?<type>` declaration instead of union type `<type>|null` as a convention for properties, method and return types. For already union types the nullable is added as additional null union type `ObjectOne|ObjectInterface|null`. `nullable_type_declaration_for_default_null_value` ensures to use nullable type declarations to mitigate implicitly nullable method arguments [1] which has been already fixed with a series of dedicated changes. Used command(s): Build/Scripts/runTests.sh -s cgl [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #103751 Releases: main, 12.4, 11.5 Change-Id: Ia790a6757c5fbe92da45298333037c5b5d36575d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85089 Tested-by:
-
- Jul 01, 2024
-
-
Garvin Hicking authored
When multiple crop variants are defined (for example in EXT:styleguide "Form engine elements - imageManipulation" for "crop_5" with "mobile" and "desktop), the currently selected aspect ratio and the size of the cropping box was only computed based on the first crop variant. This patch uses a wrapping container for each variant and adjusts the JavaScript to operate on that context. The information for the current cropping box size is now also based on this context. Resolves: #103879 Releases: main, 12.4 Change-Id: I38e235ddb5ed5f7463a5f0931608944326097f9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84963 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Stefan Bürk authored
Apply the latest rules of php-cs-fixer for both fixer (code and header-comment) also in the `Build/Scripts` folder. The Build folder is now added to the usual php-cs-fixer execution for code and header fixer scripts to avoid code style drifitng in this folder for the future. Used command(s): Build/Scripts/runTests.sh -s cgl ; \ Build/Scripts/runTests.sh -s cglHeader Resolves: #104274 Releases: main, 12.4, 11.5 Change-Id: I7977e2254b9e271c45b840c6696cd7600ab0b1aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85035 Reviewed-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Jun 28, 2024
-
-
Torben Hansen authored
With symfony property-info 7.1.2, the type resolving for collections has been hardened. https://github.com/symfony/property-info/commit/d0bbc495f11ab99a1e2cbf04699331b88b3c1293 Our extbase ObjectConverter test for collections uses an anonymous class with an ObjectStorage property. The annotation for the property as well as the native property type is however not a FQCN. So the anonymous class has no information about, what FQCN the `ObjectStorage` class is. The change adds the FQCN for the ObjectStorage in the anonymous class, which resolves the failing test, and adds a test with a non-anymous class to test short namespaces still work. Resolves: #104254 Releases: main, 12.4, 11.5 Change-Id: Idc64e2533e0bc6d2dccc9724643247772f4f5d11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85001 Tested-by:
-
Christian Kuhn authored
Resolves: #104249 Releases: main, 12.4 Change-Id: I2e56c967ab27ddc855261ff53f654d5916f3dce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84999 Reviewed-by:
-
Oliver Bartsch authored
Some FormEngine related JS components, e.g. the slug element rely on input and text fields to have the field name set via either the special `data-formengine-input-name` - if pointing to a hidden input field - or via the standard `name` attribute. All those FormEngine elements support the readonly state, which renders only the field with the `disabled` attribute set by omitting any JS functionality. For this use case no `name` attribute is required. However, to use them in combination with other fields, e.g. as generator field for TCA type slug, the field name is now added as `name` attribute in readonly state. Resolves: #104178 Releases: main, 12.4 Change-Id: Ibd28c563c8184078805a64aa123f86d538077180 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84959 Reviewed-by:
-
- Jun 27, 2024
-
-
Georg Ringer authored
Resolves: #104216 Releases: main, 12.4 Change-Id: Ifbd5499fe8c50661cec4ec198b479978bd839084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84949 Tested-by:
-
- Jun 26, 2024
-
-
Georg Ringer authored
Apply the latest rules of cs-fixer also on the Build directory Resolves: #104227 Releases: main, 12.4 Change-Id: Ief38397cb0870e358caa43ca505f04fbb89a86c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84851 Tested-by:
-
- Jun 25, 2024
-
-
Stefan Bürk authored
This change modifies the `Build/Scripts/runTests.sh` dispatcher script to add new database version. Added versions: * MySQL 8.4 * MariaDB 11.2 * MariaDB 11.3 * MariaDB 11.4 Note that for TYPO3 v12 and v11 also missing versions up to these are added now. This is not a official supported version statement. [1] https://endoflife.date/mariadb [2] https://endoflife.date/mysql [3] https://endoflife.date/postgresql Resolves: #104200 Releases: main, 12.4, 11.5 Change-Id: I338a7f0973a46fb8bc6a582a5c478c4715a8000e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84894 Reviewed-by:
-
Stefan Bürk authored
This change modifies the `Build/Script/runTests.sh` command dispatcher to allow passing composer options to the `composer install` subcommand, for example Build/Scripts/runTests.sh -s composerInstall \ -- --prefer-source Note that this is already possible using the generic `-s composer` dispatcher but would resolve some user confusion. This is useful to install dependencies as git checkouts, for example when working on packages like `typo3/testing-framework` changes. Albeit the need to remove the vendor folder first is needed in case of the example. Resolves: #104186 Releases: main, 12.4, 11.5 Change-Id: Id07c90f3b6902ad8866249563eceeb2dafbc919b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84844 Tested-by:
-
- Jun 24, 2024
-
-
Marcin Sągol authored
The `typo3-backend-icon` component code contains a duplicated code fragment. This patch removes one occurrence. Resolves: #104199 Releases: main, 12.4 Change-Id: I0530f89f646c5c2fda8a170f3792a28a2c04243d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84840 Tested-by:
-
Andreas Kienast authored
This commit updates TypeScript to 5.5, along with its related friends. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.13.1 \ @typescript-eslint/parser@^7.13.1 \ @typescript-eslint/typescript-estree@^7.13.1 \ typescript@^5.5.2 npm run build Resolves: #104189 Releases: main, 12.4 Change-Id: Ic2b66c65485845ae62371228f6f8b62c8a320172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84878 Tested-by: -
Oliver Bartsch authored
Since #96515, is's possible to configure aliases for backend modules. Those are handled by the UriBuilder to allow using those aliases for building links to the corresponding module. Using the ActionDispatcher JS component for building module links via the "TYPO3.ModuleMenu.showModule" action, it's now also possible to use corresponding aliases. Therefore, the BackendController now adds the module aliases to the module information JS array and the module JS component properly checks for those aliases when resolving a given module name / identifier. Resolves: #104165 Related: #96515 Releases: main, 12.4 Change-Id: Ia8372a503f4973d81deb285a9945fa13ade24dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84839 Tested-by:
-
- Jun 21, 2024
-
-
Garvin Hicking authored
When filtering the page tree with characters that have special meaning for a regular expression (for example, ")" or "(" or "?" and some others), the filtering would return a "Page Tree error". JavaScript does not have something like "preg_quote", so this uses the escape string provided by the MDN with fixed special characters. Resolves: #104092 Releases: main, 12.4, 11.5 Change-Id: I4a29c62eaca8b7643c8ef78dda1d8337b3e1e53a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84722 Reviewed-by: -
Christian Rath-Ulrich authored
This commit fixes a minor issue where the header tag in PaletteAndSingleContainer was incorrectly set as h4. The tag has been changed to h3 for better readability and semantics. Simultaneously, visually hidden headers were also added to tabs to improve accessibility. Resolves: #104021 Releases: main, 12.4 Change-Id: Ic2301eabb23d1d17169056ec8e9ec40a5824c52c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84822 Tested-by:
-
Oliver Bartsch authored
Using the multi record selection, it's possible to change the state of checkboxes via multiple ways, e.g. by clicking on the table row. The central functionality for changing the connected checkbox state now also considers the disabled attribute and therefore only changes the checked state in case the checkbox is not disabled. Additionally, next to the custom event, which is triggered on checkbox state changes, the multi record selection now also dispatches the standard "change" event. FormEngine validation for example is listening on this event to mark the field as changed. Resolves: #104142 Releases: main, 12.4 Change-Id: I9854709ee624d88821757fff3baf38c892e5f11d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84823 Tested-by:
-
Leon Dietsch authored
When switching between cropVariants with multiple coverAreas, all of the previous coverAreas are properly removed, only showing those that belong to a specific cropVariant. See details and screenshots in the related ticket. (A new styleguide TCA element crop_9 is also added to showcase multiple coverAreas in multiple cropVariants) Resolves: #103389 Releases: main, 12.4 Change-Id: I7649aa0fe5bc01939326119b24dbdafd5f09a708 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84837 Tested-by:
-
- Jun 18, 2024
-
-
Benjamin Franzke authored
Improve document-service responsiveness by relying on `DOMContentLoaded` and `document.readyState` >= `interactive`. 1) Handle non-loading state as "ready" to avoid waiting for `complete`. `document.readyState` has three states: * `loading` The document is still loading. * `interactive` The document has finished loading and the document has been parsed but sub-resources such as scripts, images, stylesheets and frames are still loading. The state indicates that the DOMContentLoaded event is about to fire. * `complete` The document and all sub-resources have finished loading. The state indicates that the load event is about to fire. If DocumentService.ready was called in "interactive" state we have been skipping this state as we only considered `complete` to be the "ready" state in this case. This is wrong as we actually wait for the DOMContentLoaded if we are launched in the initial readyState (`loading`), that means an initial `interactive` must be understood as: `DOMContentLoaded` has already been fired as state is `interactive` We should actually avoid waiting for `complete` entirely, as document readyState `interactive` means "ready" in terms of document parsing. We're not interested in images or async scripts that are still loading and want event listeners to be registered as early as possible. With this improvement applied we can also drop the (now) unneeded `load` event-listener, as we are no longer skipping interactive state (this made the `load`-listener necessary previously). Note that the `load` workaround was previously needed for IE<=10 as those versions set `document.readyState` to `interactive` prior to the `DOMContentLoaded` event. This applied workaround becomes a race condition once `load` never happens and that is the case with a recent google chrome regression which causes iframe documents to never "complete": https://issues.chromium.org/issues/347724924 2) Drop the timeout logic. It is no longer needed now that we only need to wait for `DOMContentLoaded` – which will always fire (or already fired) – instead of the `load` event. 3) Avoid creation of new promises for every invocation of the ready-method. A promise can be reused without side effects by multiple consumers. This avoids creating a lot of event listeners (and previously timers). 4) Remove unneeded document and window references. Releases: main, 12.4, 11.5 Resolves: #104135 Related: #104139 Change-Id: I42c86961405f8a5c346c17ea429a288a85d58f8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84753 Tested-by: -
Georg Ringer authored
The backend layout wizard now uses a working example by using an existing icon. Resolves: #91910 Releases: main, 12.4 Change-Id: If6df3bd73d1ff6dc1a7a3e71cadf2e89b1a18bd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84752 Tested-by:
-
Christian Kuhn authored
Argument passing using `--` works well. It's time to remove the previous `-e` solution. Resolves: #104137 Related: #104131 Related: #102769 Releases: main, 12.4, 11.5 Change-Id: I99577a24dda77c4c96813f8ca14c2a27bdf7f2de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84746 Reviewed-by:
-
Stefan Bürk authored
This change requires PHPStan on the current newest version. Note: In v12 the phpstan baseline is regenerated to adopt for changed reporting behaviour. Used command(s): composer req --dev "phpstan/phpstan":"^1.11.5" Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #104136 Releases: main, 12.4 Change-Id: I7f88c4c3942e22e1536e12a883411f66a3eee3ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84744 Tested-by:
-
Christian Kuhn authored
Inline the 'random seed' option for -s unitRandom, replay a specific seed using: > runTests.sh -s unitRandom -- --random-order-seed=<number> Resolves: #104131 Releases: main, 12.4, 11.5 Change-Id: I84e1cc0a0c57a5132a592a140d1b58ceb6d3b059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84736 Reviewed-by:
-
- Jun 14, 2024
-
-
Willi Wehmeier authored
The aspect ratio buttons in the image cropping tool have a visible focus state now to make them usable when navigating with the keyboard tab key. Additionally the button can now be pressed with the space and return key. Resolves: #103760 Releases: main, 12.4 Change-Id: Id221daddeee9d5b61497cb74604dbf151d25e3ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84554 Tested-by:
-
