Skip to content
Snippets Groups Projects
  1. Feb 03, 2024
  2. Feb 02, 2024
  3. Jan 31, 2024
  4. Jan 30, 2024
  5. Jan 29, 2024
  6. Jan 25, 2024
  7. Jan 22, 2024
  8. Jan 16, 2024
  9. Jan 09, 2024
  10. Jan 06, 2024
  11. Jan 05, 2024
  12. Jan 03, 2024
  13. Dec 30, 2023
  14. Dec 21, 2023
  15. Dec 20, 2023
  16. Dec 19, 2023
    • Stefan Bürk's avatar
      [TASK] Ensure removing dangling images works with podman · 907a61ce
      Stefan Bürk authored
      The TYPO3 core `runTests.sh` contains the `-u` option to
      update the images and remove dangling images. Providing
      an image name and a `--filter` option is not supported
      by podman:
       > Error: cannot specify an image and a filter(s)
       and has not been discovered yet in the TYPO3
      core implementation yet.
      
      Both container runtimes `docker` and `podman` support filtering images
      using the `reference` filter option. Therefore, this change modifies
      the dangling image removal to use multiple filters
      
      To verify that filtering with two `--filter` options can be used with
      podman and docker, the following commands can be executed to list the
      set of local non-dangling images.
      
      Note: This example uses `dangling=false` instead of
      	  `dangling=true` (as in `runTests.sh`), since we expect
            most developers don't have dangling images yet.
      
      > podman images \
          --filter "reference=ghcr.io/typo3/core-testing-*" \
          --filter "dangling=false" --format "{{.ID}}"
      
      > docker images \
          --filter "reference=ghcr.io/typo3/core-testing-*" \
          --filter "dangling=false" --format "{{.ID}}"
      
      Resolves: #102697
      Releases: main, 12.4, 11.5
      Change-Id: I717d1aa229bdfb73c63aa5b2d46e1aff665544cb
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82236
      
      
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      907a61ce
    • Benjamin Franzke's avatar
      [TASK] Sanitize embedded HTML in Installation-Wide Configuration GUI · ee5898d2
      Benjamin Franzke authored
      Input data is statically provided by EXT:core only, so there is no
      security issue known right now. This change is a preparation to avoid
      possible future security issues.
      
      Resolves: #102676
      Releases: main, 12.4, 11.5
      Change-Id: I49a7fdd250e8ce74fdde07ad305cbae7e4af8ec3
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82252
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarOliver Bartsch <bo@cedev.de>
      Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
      ee5898d2
    • Stefan Bürk's avatar
      [BUGFIX] Avoid type errors in `ResourceFactory` methods · d9ab1d20
      Stefan Bürk authored
      With #92289 logic has been decoupled from `ResourceFactory`
      into the `StorageRepository`. As a side change, native php
      types have been added to a couple of methods.
      
      `StorageRepository->findByUid()` parameter type has been set
      to integer, which breaks the `null` fallback and retrieving
      the default storage `uid: 0` in `ResourceFactory` method
      `getStorageObjectFromCombinedIdentifier()`. Even worse is
      the fact that `getObjectFromCombinedIdentifier()` does not
      even try to cope with a invalid identifier provided.
      
      This change modifies `getObjectFromCombinedIdentifier()` and
      `getStorageObjectFromCombinedIdentifier` of `ResourceFactory`
      to cope with missing storage identifier by falling back to
      the default storage (`0`) with a shuffle of the exploded values.
      
      As a side-effect two PHPStan ignore patterns can be removed
      from the PHPStan baseline file.
      
      Used command(s):
      
        Build/Scripts/runTests.sh -s phpstanGenerateBaseline
      
      Resolves: #102692
      Related: #92289
      Releases: main, 12.4, 11.5
      Change-Id: I8ee9736839f59db7917cb49dd0d62af17ee28cda
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82233
      
      
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      d9ab1d20
  17. Dec 17, 2023
  18. Dec 09, 2023
  19. Dec 01, 2023
  20. Nov 27, 2023
  21. Nov 24, 2023
  22. Nov 23, 2023
  23. Nov 21, 2023
  24. Nov 20, 2023
  25. Nov 17, 2023
  26. Nov 16, 2023
  27. Nov 14, 2023
  28. Nov 13, 2023