- Feb 06, 2021
-
-
Oliver Bartsch authored
BackendController::generateJavascript() creates the top.fsMod object to provide frameset modules an easy way of storing their state. The FileList module e.g. stores the current folder identifier. Therefore, after switching back to the FileList module, the previously selected folder is used. This behaviour is now restored by replacing the "instanceof" check, which always evaluated to FALSE, with a typeof check. It's furthermore now ensured that the id will always be set, even if recentIds is not yet an object. Resolves: #92811 Releases: master, 10.4 Change-Id: I36227775bfadfca4d43a719b1508f78976b6e342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67628 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Richard Haeser authored
Updated styling and javascript to restore styling of the localization wizard after the update to bootstrap 5. Resolves: #93408 Releases: master Change-Id: I6f3dc03af943e3eae240c84a218e8b72dcb8d276 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67627 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Andreas Fernandez authored
This patch adds the TypeScript declaration for the sortablejs library. Since the imported module has a different naming, the PageRenderer needs both the new module name ("sortablejs") and the old name ("Sortable") as this would be a breaking change, otherwise. In the master patch, the old module name has been declared deprecated. Resolves: #93454 Releases: master, 10.4 Change-Id: Ia8cc7bb4fb57bc7d55aa3601d6ccd1bfe6e0b54d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67658 Tested-by:core-ci <typo3@b13.com> Tested-by:
-
Ralf Zimmermann authored
While updating bootstrap to 5.0.0-beta1 (https://review.typo3.org/c/Packages/TYPO3.CMS/+/67215) The 'a) Carousel "item" to "carousel-item" class migration' was done for the ext:backend 'Wizard' component but not for the 'MultiStepWizard' component. Therefore the 'new form' wizard will not work properly. This patch migrates the usage of 'item' classes to 'carousel-item' within the 'MultiStepWizard' component. Resolves: #93168 Releases: master Change-Id: I4c2a47147b668694c84ccda1dd01b7fe3e3d7808 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67579 Tested-by:
-
- Feb 05, 2021
-
-
Christian Kuhn authored
Change-Id: Ic60be2582afee8c8fe45e25cafb853285343265f Resolves: #93447 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67653 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Kuhn authored
When a patch is pushed to gerrit, the gerrit-adapter middleware also synchronizes the master branch. This triggers two pipelines if patches have been merged meanwhile. Suppress the master pipeline run: All patches should have been tested already and a run for current master is done with the nightly tasks anyway. Change-Id: I78e9070588027d5fa10f11e63ab3e2677a225094 Resolves: #93438 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67646 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Feb 04, 2021
-
-
Simon Gilli authored
This patch removes usages of mbstring functions which are missing in the fallback package symfony/polyfill-mbstring. Resolves: #93324 Releases: master, 10.4 Change-Id: I08c02e79caca4e9a253c1ac89b2ac0aa199e51a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67471 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Jonas Eberle authored
Earlier, documentation erroneously stated that CSS could be moved to the bottom of <body>. This is not the case (and also not advisable). Instead, the documentation now reflects that CSS is always output in the <head>, with "priority"-assets in front of non-"priority". This also rephrases HTTP/2 information and adds cross-references to the ViewHelper documentation. Rendered output: https://docs.typo3.org/other/typo3/view-helper-reference/master/ en-us/typo3/fluid/latest/Asset/Css.html#priority Resolves: #91769 Releases: master, 10.4 Change-Id: I899e39eb1a85c23cc756d413ff8962c98564cee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67512 Reviewed-by:
Julian Mair <julian.mair94@gmail.com> Reviewed-by:
André Kraus <info@andrekraus.com> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Christian Kuhn authored
Resolves: #93434 Releases: master Change-Id: I9d6918f5bbfc6f12d09b1459405e6749f04b2c0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67641 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
-
Benni Mack authored
This change aims to reduce the overhead by using jQuery in favor of Vanilla JS in various Tree-related JS files in preparation for a TypeScript migration. * SvgTree.js * SelectTree.js * PageTree.js * PageTreeToolbar.ts * PageTreeElement.ts * TreeToolbar.ts Resolves: #93427 Releases: master Change-Id: I57fc8e66415ea4ab6eaf690d925fbf7670d74284 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67583 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
This change migrate the TreeToolbar (used in FormEngine Category Tree for example) to TypeScript, removing effectively one RequireJS call and replacing it with a native TypeScript component. Removing the rest of the jQuery will be part of a separate effort. Resolves: #93432 Releases: master Change-Id: I3df66cd1c28d096c0f32982347dbd37c58834e4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67640 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
When changing the stage of workspace records, e.g. "Publish to live", it's possible to send notification emails to inform further participants about the changes made. In case the mailer configuration is invalid, the whole process previously failed due to uncaught exceptions. These exceptions are now properly caught and logged as it's already done at other places in core. See #93297. Resolves: #93420 Releases: master, 10.4 Change-Id: I606b0459a34c0287b65d23a5a9f376866688cf95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67636 Tested-by:
-
Benjamin Franzke authored
With the Symfony PR https://github.com/symfony/symfony/pull/39851 new depndency injection console.command tag properties are supported, which allow to inject the description and the hidden state into console commands. In order to maintain a consistent console.command DI tag syntax between Symfony and TYPO3 core, we now add forward compatibility for this change. Releases: master, 10.4 Resolves: #93425 Related: #93174 Change-Id: Ie5dac65deaede2099f2d337466295bd2815ce918 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67639 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Feb 03, 2021
-
-
Georg Ringer authored
The help button belongs to the toolbar and not within the content area. Resolves: #93416 Releases: master Change-Id: Ie28f3f3fcedc53d4addbfcff8bd83576be8a4200 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67634 Tested-by:
-
Christian Kuhn authored
A first Build/gitlab-ci.yml for master. Core v10 and v9 will have dedicated patches. This specifies jobs executed via gitlab CI for master pre-merge "a patch has been pushed" and nightly builds. This uses a new testing infrastructure defined by https://gitlab.typo3.org/core-testing/testing-infrastructure to execute test suites. Resolves: #93406 Releases: master Change-Id: I377ac59478925b789f63871c8fa6c3b2d5b2a839 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67626 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Oliver Bartsch authored
PageRenderer now omits empty type attributes also for scripts added through includeJSLibs or includeJSFooterlibs. Resolves: #93391 Releases: master, 10.4 Change-Id: Ic0b06b5ba6f7001c29dd3b1904e7bc0ed48b07d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67630 Tested-by:
-
Benni Mack authored
In previous TYPO3 versions (until the Workspace module was refactored in TYPO3 v8) it was possible to manipulate the collapse / expand toggle via Signals (now PSR-14 event), for third-party records with a lot of IRRE records. This change re-introduces the toggle for PSR-14 event listeners to respond to the JavaScript toggle / flag. Resolves: #93404 Releases: master, 10.4 Change-Id: I56408ac52b6491fe7ac79175ff0ab5017905d45d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67585 Tested-by:
-
- Feb 02, 2021
-
-
Benni Mack authored
With #89496 the ContextMenu got keyboard support added. However, the underlying code does still use only a click event to trigger the ContextMenu, which is now also manually triggered for keypress events. It was therefore not possible to differ between the three possible ways, the ContextMenu can be used: 1. Mouse click only 2. Mixed 2.1 Click on ContextMenu and navigate via keyboard 2.2 Access ContextMenu via keyboard and navigate via click 3. Keyboard only Therefore, we now check the mouse position. If it's NULL, the ContextMenu was openend via keyboard. Furthermore, we use a boolean flag, which helps the getPosition method to determine the correct position in mixed mode. Using mouse click will now behave like before. Using the keyboard will now always use the boundingRect for positioning. Resolves: #93362 Releases: master Change-Id: I1e2be756b85d0a2286524f0bdc9cca76208935d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67510 Tested-by:
-
Benjamin Franzke authored
In order to avoid loading an unnecessarily large complete d3 bundle, we now only pull in the small amount of modules we actually need. d3.transition() is replaced by the native web animation api, as d3-transition would pull in 4 more libraries (d3-color, d3-ease, d3-interpolate and d3-timer). d3-dispatch could easily be replaced by native CustomEvents, but it is a dependency of d3-drag and therefore shipped right now. This change reduces load size from 262K to 19K. yarn remove d3 yarn add d3-dispatch d3-drag d3-selection grunt build Releases: master Resolves: #93396 Change-Id: I1f4b58b967e2dcc57484863faafab3c2ec5d469a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67622 Tested-by:
-
- Feb 01, 2021
-
-
Christian Kuhn authored
Allow mysql & postgres for acceptance tests in addition to default mariadb: * Build/Script/runTests.sh -s acceptance -d mysql * Build/Script/runTests.sh -s acceptance -d postgres Change-Id: If65f1d8d8b4443107d655948ce87af4390d9681f Resolves: #93405 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67623 Tested-by:
-
Chris Müller authored
As the output of the widgets in the Dashboard is processed by htmlspecialchars(), the tags need to be stripped before to prevent showing the full tags as text. Resolves: #91289 Releases: master, 10.4 Change-Id: I0fc24ac6f3ceb298dd6acb8151c04e333bc1ec41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64399 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Christian Kuhn authored
New images are to be found on official TYPO3 https://hub.docker.com/u/typo3 account. Most images are based on alpine instead of ubuntu and are thus significantly smaller than the old ones. For example, the php 7.4 image is now ~170MB instead of ~500MB. Image definitions are found and maintained at https://gitlab.typo3.org/core-testing/testing-infrastructure/ * typo3/core-testing-phpXY: Images based on the official PHP alpine builds, extended with commands and modules we need. * typo3/core-testing-js: Image based on official node image, with current yarn. * typo3/core-testing-js-chrome: As above, but with chrome for javascript unit testing. * typo3/core-testing-mssql2019: Image for microsoft sql server that includes a brutal hack to force sql server is fine if databases are located on a tmpfs (CI does that). * postgres/XY-alpine: Drop-in replacement using the -alpine version that is ~1/3 in size. Change-Id: I3dc57056052d3364ee925ba3a3216d95afe55f57 Resolves: #93403 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67619 Tested-by:
-
Benjamin Franzke authored
During the migration to d3 v6 in #93394 one event listener was forgotten to be updated for the changes callback signature in d3 v6. The caused the event coordinates, instead of the node coordinates to be used for drag-end calculation. Resolves: #93402 Related: #93394 Releases: master Change-Id: If39ac05d93ef34911a3ae6202e9cfdc8c9ab5ba3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67618 Tested-by:
-
Benni Mack authored
When a TYPO3 installation has `warning_email_addr` set, but the mailer configuration is wrong (e.g. cannot connect to mail server), then no login to backend or install tool is possible anymore. This change gracefully catches any exceptions, and logs the information that an email could not be sent anymore. Resolves: #93297 Releases: master, 10.4 Change-Id: I1b658740a64cf1d29b7842f0e2b49d69ce4d5e25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67453 Tested-by:
-
Christian Kuhn authored
* The file permission related LocalDriverTest basically test getPermissions() that is a set of native PHP methods that are hard to mock properly and don't need to be tested in our application. * The DateViewHelperTest relies on a working locale which fails on some environments and gives no error output if it fails. Resolves: #93400 Releases: master, 10.4, 9.5 Change-Id: I9521e8275d6a6461a902f07caee0444a73da8927 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67614 Tested-by:
-
Christian Kuhn authored
Some documentation related files contain a UTF-8 BOM while they shouldn't. Usually, script Build/Scripts/checkUtf8Bom.sh tests for this in CI. The script however fails in CI currently, since the PHP test container doesn't have gnu file shell command installed. Seems nobody saw the according error message and due to the xargs construct the test does not fail. Change-Id: I557c7ec84b61badfcd74a20063baf29eaf9f0959 Resolves: #93397 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67586 Tested-by:
-
Christian Kuhn authored
* Run postgres with hard coded user to avoid connection isssues * Add some missing reports.xml for acceptance tests * The tmpfs for mssql is useless since the db's are stored in var/opt/mssql, not var/lib/mssql * A misleading todo Change-Id: I3806ea6640abfd7fb55bec9e0408b8d23f034960 Resolves: #93399 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67591 Tested-by:
-
Benni Mack authored
The buttons in the info dialog of a record in the workspaces module shows the buttons "Publish to live" (or send to next stage) now only shows the buttons if the editor has access to it, same with sending an element back to the previous stage. Resolves: #93384 Releases: master, 10.4 Change-Id: I47b394307379f3456cc8ea47b75715937e6a93a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67552 Tested-by:
-
Benjamin Franzke authored
D3.js v6 contains quite some changes, but most are irrelevant for TYPO3, as we already migrated from d3-request to core AjaxRequest in #93186. That means we only need to adapt for the global d3-event removal. Commands used: yarn add d3@^6.3.1 grunt build Resolves: #93394 Related: #93186 Releases: master Change-Id: Ie84f8cb5ef3fa8a8217375f26f6969677704baa5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67469 Tested-by:
-
Tobias Wojtylak authored
Resolves: #93393 Releases: master, 10.4 Change-Id: I827e421eef1696edfdc47d7544d8ebc2dd40c052 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67582 Tested-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
Benni Mack authored
The PageTree component (added in TYPO3 v9) is based on SVG Tree, which was added in a previous version (TYPO3 v8). However, changes like https://review.typo3.org/c/Packages/TYPO3.CMS/+/55878/ unnecessarily coupled the SVG Tree to the PageTree. In addition, some minor details to NOT use pagetree IDs everywhere allows to use other SVG-tree based components in the navigation container in the future. id=typo3-pagetree-treeContainer is kept for typo3/testing-framework compatibility, for now. Resolves: #93389 Releases: master Change-Id: Ieb51e46937cfb2f11efeb976da09bc600af8b5cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67575 Tested-by:
-
- Jan 31, 2021
-
-
Torben Hansen authored
TYPO3 now returns a HTTP 403 status code, when BE.adminOnly is configured or when the clients IP address does not match the configured BE.IPmaskList. Additionally, TYPO3 will now present a proper system message instead of showing the default "Oops, an error occurred!". Resolves: #93379 Releases: master, 10.4 Change-Id: I409a514852b25c2891eade71bd61f50e25ffc174 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67546 Tested-by:
-
Richard Haeser authored
It is possible to have multiple og:image meta tags by the specs. By adding the condition to your TypoScript setup, the fallback images for social media will only be rendered when no image is set in the page properties. This will prevent that the fallback image is always rendered even when an image is set in the backend. Resolves: #93272 Releases: master, 10.4 Change-Id: I6efa046059f64d8dfc3d22bac9d451c9b402b81a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67576 Tested-by:
-
Oliver Hader authored
Labels in linkvalidator's additional field settings for the schedule are actually invoking `BackendUtility::wrapInHelp` twice - first time in `ValidatorTaskAdditionalFieldProvider` and second time when actually rendering with `f:be.labels.csh` view-helper. Resolves: #92964 Releases: master, 10.4, 9.5 Change-Id: I8dc5baca7289604a150e2d80258fb21ebab9f59e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67549 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
- Jan 29, 2021
-
-
Oliver Hader authored
+ removed NavigationComponentInterface - actually no class-like component did implement it + introduced TreeInterface, having some aspects of previous NavigationComponentInterface + aim to use native DOM operations (instead jQuery) where possible + switched templating in PageTreeElement and PageTreeToolbar to lit-html Resolves: #93380 Releases: master Change-Id: Ia2a05ff3d05193e52d440e409ecca4c1e1feb518 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67544 Tested-by:
-
Georg Ringer authored
If an external url is provided in a link field, the full url should be shown instead of only the domain. Hiding all other parts makes it harder for the editors to know the linked url as it requires an additional click. Resolves: #93373 Releases: master, 10.4 Change-Id: I4c2a7422e87a1c98b7702815b2081f585388f57d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67547 Tested-by:
-
Georg Ringer authored
Log entries in the log module show some internal log numbers like `(msg#255.3.2)` which is neither understandable nor helpful. Therefore this can be safely removed. An extra exclamation mark is remove as well as one is enough. Resolves: #93378 Releases: master Change-Id: Iffd92766deb0e733da67105811d43ef2851489d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67545 Tested-by:
-
- Jan 28, 2021
-
-
Oliver Bartsch authored
The ImageViewHelper uses strict types for checking if the `title` property of the image is not an empty string. Since this value can also be NULL, a typecast is necessary for the check to work. Resolves: #91759 Releases: master, 10.4 Change-Id: Ide73a6d2aacf0fcd9bb4c6128a66b0685d4fc68c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67504 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Jan 27, 2021
-
-
Oliver Bartsch authored
Performing a core update in the install tool requires a couple of checks, regarding directory structure and permissions. On failure, the corresponding error messages do now contain the information where to check the directory status within the install tool. Resolves: #91630 Releases: master, 10.4 Change-Id: I750203c61a0f697838f55b3fd114e5e2326e6df0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67506 Tested-by:
-
Benni Mack authored
The link browser now uses the full height again by fully utilizing the flexbox functionality and wrapping the content in <div class="element-browser"> This behaviour is now consistent with the File / Record selector which already takes up the full height. Resolves: #93374 Releases: master Change-Id: I7c435b4142b54b0a809c579eac9d1e0095ed691e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67540 Tested-by:
-
