- Jul 02, 2022
-
-
Ralf Zimmermann authored
A new `FormRequestHandler` has been introduced as entry point which takes care of creating and rendering the actual `FormRuntime`. Independent of the current application dispatcher (either the default `FormFrontendController`, any custom Extbase controller or a TypoScript `FLUIDTEMPLATE` cObject) any processing will end up here. To ensure proper caching, it is important to separate the two main actions `render` and `perform`, which unfortunately cannot be resolved easily, especially when using custom Extbase controller actions. The term uncached refers to using cObject `USER_INT` instead of `USER`. More details about the process flow are described in `\TYPO3\CMS\Form\Core\FormRequestHandler`, introduced by this change. Resolves: #93887 Resolves: #92406 Releases: main, 11.5, 10.4 Change-Id: I0b98d39f04b6c70ea370200c53316b381019dd2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70460 Tested-by:
Elias Häußler <e.haeussler@familie-redlich.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
- Jul 01, 2022
-
-
Torben Hansen authored
With #93667 logging of HMAC validation errors caused by potentially manipulated form submissions has been disabled. The change does however not consider exceptions handled in the ProductionExceptionHandler for content objects in ext:frontend. This change prevents logging of two exceptions caused by potential manipulated form submissions in ProductionExceptionHandler for content objects. Resolves: #97830 Related: #90134 Releases: main, 11.5 Change-Id: Ibee8268584e2729766c5528bf8687fd6055a4030 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74998 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Rudy Gnodde <rudy@famouswolf.com> Reviewed-by:
-
Oliver Klee authored
Used commands: > composer req --dev phpstan/phpstan:^1.8.0 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97823 Releases: main, 11.5 Change-Id: Ia124e34cf81c55915c2815cdff71bdde6aabe972 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74792 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Georg Ringer authored
Set the return type to string|false instead of mixed. Resolves: #97832 Releases: main, 11.5 Change-Id: I8648392bb8b8d95aaf8ab5416d9e7d1043f8e9b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75017 Tested-by:
-
Elias Häußler authored
When switching from `master` to `main` as default branch, it was forgotten to change the `defaultbranch` value in `.gitreview` as well. Resolves: #97843 Releases: main Change-Id: I84d011f86d0f165eeb9eccce757bb7fc32f54924 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75014 Tested-by:
-
Benjamin Kott authored
With the update to v3.x of the TYPO3 Icon set, there comes a little change in favor of understanding what sizes of icons to use. There is no defined "default" size anymore. While it is still usable, the new default scales with font size. So it does not matter if you call it "default" or "auto". The default size for icon rendering was adapted to now use the "medium" size. That is the same size as default was before. Fixed sizes are now defined in order: small: 16px medium: 32px large: 64px Aside from some special treatment the CSS from the icon set is now used. It was already reworked in the icon set to make use of CSS variables instead of compiled fixed compiled values. Resolves: #97809 Releases: main Change-Id: I88ff4c4f09a08461674ae5acc6b1cc9b202787b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74981 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Nikita Hovratov authored
Resolves: #97840 Related: #96935 Releases: main Change-Id: If3ea919f5350aa65d2967b22b40a1334eb33fbca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75006 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Elias Häußler authored
The core team agreed on not using yoda-style conditions in PHP. An appropriate PHP-CS-Fixer rule to explicitly disable yoda-style has been added to ensure that this coding style is respected. Additionally, all yoda-style conditions have been transformed to normal conditions. Resolves: #97839 Releases: main, 11.5 Change-Id: Ic3a77fe412c15ec8c8d793f2b4aa6017562a4863 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75005 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Elias Häußler authored
With #96473, the first parameter of `AbstractFormViewHelper::renderHiddenIdentityField()` was hardened to `object|null`. This is actually fine since only objects are suitable to render those fields (falling back to NULL, probably for bc reasons). However, form elements in EXT:form cannot be directly accessed with the FormRuntime. Instead, calling `$formRuntime[$formField]` returns the current value of the form element instead of the elemnt itself. To avoid situations where everything else than an object is passed to said method, the resolved object is now checked and falls back to NULL if it's not an object. This change restores the previous behavior of EXT:form elements prior to the change introcuded with #96473. Resolves: #97834 Related: #96473 Releases: main Change-Id: Ib46fdc7d2ceca56dc5b93787b9f1f7da468128d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75004 Tested-by:
-
Stefan Bürk authored
xdebug does not have an official compatible version which can be used with PHP8.2, and thus xdebug had been missing in the PHP8.2 alpha1 image. To avoid using xdebug with PHP8.2 this had been guarded with a corresponding check in `runTests.sh`. `typo3/core-testing-php82` docker image has since been rebuilt with PHP8.2 alpha2 and using a fork of xdebug, which compiles the extension against PHP8.2. The check in `runTests.sh` is now removed again in order to allow early xdebug-ging using `Build/Scripts/runTests.sh`. Resolves: #97811 Releases: main, 11.5 Change-Id: Ie9b6795873f38e0a8ea98cfabe4acf7de9ef2056 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74983 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Björn Jacob authored
A new chapter for editors regarding form finishers has been added. While being on it a small typo in the form editor has been fixed. Resolves: #97026 Releases: main Change-Id: I94b662d9da45cde6f4c6c4c81161a33294241454 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75002 Tested-by:
-
Björn Jacob authored
With this patch, the validator documentation for integrators also mentions the technical names of the validators and their options. Furthermore, links to the Configuration Reference have been added. In addition, some configuration options have been added to the corresponding YAML configuration files. Resolves: #97083 Releases: main Change-Id: I06d46d6270c9b76684fae04a2b525928d413e23f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74491 Tested-by:
Tobias Jungmann <tobias.jungmann@tritum.de> Reviewed-by:
-
- Jun 30, 2022
-
-
Björn Jacob authored
This patch optimizes the wording of the documentation and adds links to other documents. While being on it, images and their corresponding captions have been fixed throughout the documentation. Resolves: #97825 Releases: main Change-Id: I6d783477e9dcf0ba31c34b7f3d9dae79049d173b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74994 Tested-by:
-
Sybille Peters authored
Clarify in the docblock that it is also possible to pass an icon identifier to addPlugin, not just an icon path. The first argument of the method ExtensionManagementUtility::addPlugin() expects an array. The possible values are explained in the docblock. For the third value, the icon, it is possible to pass a path or an icon identifier. Resolves: #97827 Releases: main, 11.5 Change-Id: If37661344dd4112a076b1b26d3a7fe54b2a6a0cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74995 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Jun 29, 2022
-
-
Oliver Hader authored
All sys_file_reference items had the same foreign_sorting value. Resolves: #97828 Releases: main, 11.5 Change-Id: Ie3bbeb75405cc561c27f5ce12d1c70954d79c3b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74996 Tested-by:
-
Ralf Zimmermann authored
Removes the vendor namespace (TYPO3.CMS.Form) within form documentation. This is a follow-up to #97517 and applies these changes to the form documentation. Resolves: #97520 Related: #97517 Releases: main Change-Id: Id3a98df586a5ee5660fa1d113645421ef37bef90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74493 Tested-by:
-
Ralf Zimmermann authored
Removes the vendor namespace (TYPO3.CMS.Form) within form configuration. The compatibility to the notation with the vendor namespace is maintained, both notations are still possible. Resolves: #97517 Related: #97520 Releases: main Change-Id: I406e968c89002f32854729c96349f44bba3263ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74490 Tested-by:
-
Elias Häußler authored
With #86196, usage of the Symfony expression language was streamlined in core. This also affected EXT:form, since it uses the expression language for form variants. The form prototype configuration `conditionContextDefinition` was replaced by an appropriate configuration using a `Configuration/ExpressionLanguage.php` file. However, some usages of mentioned form prototype configuration were not removed. This patch removes all remaining occurrences of `conditionContextDefinition` and updates the documentation accordingly - since this seems to be forgotten with #86196. Resolves: #97023 Related: #86196 Releases: main, 11.5 Change-Id: If6a7a2b5f5f38326eb1fe9fe339ca7ffeb4bc8e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74514 Tested-by:
-
- Jun 28, 2022
-
-
Christian Kuhn authored
That hook isn't used in this test case since the tests do not manipulate FE TypoScript. Tests stay green without. Resolves: #97819 Releases: main Change-Id: Id3f7a62da6f694ab7c24f6da276e660c9930c220 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74990 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Robert Kärner authored
A PHP 8.0 undefined array key warning was preventing the flash message in the backend from appearing. This is fixed by adding a fallback to null. Resolves: #96132 Releases: main, 11.5 Change-Id: Id2f14a48e79ce1544ca325d025d5c428838ceb35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72350 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
agendartobias authored
config.typolinkLinkAccessRestrictedPages_addParams works only with redirectMode getpost. Releases: main, 11.5, 10.4 Resolves: #97370 Change-Id: I43fc29558eb1d282b4f5939fa115f5350cbede38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74282 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
- Jun 27, 2022
-
-
Larry Garfield authored
The search results page currently may show the "pages" indicator in the title when there are no page numbers to show. This patch changes it to only show pagination information if there is information to show. Resolves: #96796 Releases: main, 11.5, 10.4 Change-Id: I8c1600a7eb732ed018c22bc02b0e689eb39a081c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74370 Tested-by:
Kevin Meier <kmi@network-media.de> Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
- Jun 24, 2022
-
-
Benjamin Kott authored
The following variables are not used or do not differ from their equivalents in bootstrap 5.x: $font-size-h1 $font-size-h2 $font-size-h3 $font-size-h4 $border-radius-base $border-radius-large $border-radius-small Resolves: #97808 Releases: main Change-Id: Id783dfe9bc40b7ec1dd88835931409a7dfca9cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74979 Tested-by:
-
Andreas Fernandez authored
The input field used within the backend search form at the top had an initial padding of 0px which mispositions the search field until all JavaScript is loaded because the field will be wrapped in a div container and thus the responsible CSS rule becomes unused. To solve this wrong positioning, the affected CSS definition is removed. Resolves: #97810 Releases: main, 11.5 Change-Id: I01477cd098adcb95fe18467c524a55f8df70da5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74980 Tested-by:
-
- Jun 23, 2022
-
-
David Bruchmann authored
The new option is explained here: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/10.0/Featur e-80420-AllowMultipleRecipientsInEmailFinisher.html Releases: main, 11.5 Resolves: #96086 Change-Id: I740e360735e09d07f5a6f16513317e4b226fd0b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72291 Tested-by:
-
linawolf authored
Add changelog entry to https://review.typo3.org/c/Packages/TYPO3.CMS/+/74902 - Restrict export functionality to allowed users Resolves: #97771 Releases: main, 11.5, 10.4 Change-Id: I98252b73aa5b14a8cfe5d26559711123e17ced15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74920 Reviewed-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
- Jun 22, 2022
-
-
Andreas Fernandez authored
The maintainers of the package guzzlehttp/guzzle released a new version 7.4.5 that fixes two security issues: * CURLOPT_HTTPAUTH option not cleared on change of origin [1] * Change in port should be considered a change in origin [2] Executed commands: composer require \ guzzlehttp/guzzle:^7.4.5 \ -W composer require \ -d typo3/sysext/core \ guzzlehttp/guzzle:^7.4.5 \ --no-update [1] https://github.com/guzzle/guzzle/security/advisories/GHSA-25mq-v84q-4j7r [2] https://github.com/guzzle/guzzle/security/advisories/GHSA-q559-8m2m-g699 Resolves: #97802 Releases: main, 11.5, 10.4 Change-Id: Ia49f75f8ed078beb43ba42f89efdd8e68ee146c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74971 Tested-by: -
Anja Leichsenring authored
With #74882 usage of vfs was reduced in unit tests, revealing side effects when tests relied on each other to create files or folders. Now they need to take care on their own and clean up behind. This is one of the missed cases where a test still relied on a test directory being created. The test now creates and removes the required assets themself. Resolves: #97801 Related: #97742 Releases: main Change-Id: I55611415b89e6b43431cbc8eec2264608c6dfc75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74970 Tested-by:
-
- Jun 21, 2022
-
-
Benni Mack authored
LZW enabled compression for GIF and TIF is now removed in favor of just using convert which is available most of the time. This was needed back in 200x when TIFF was super-big, but is usually now properly bundled in IM/GM. Resolves: #97797 Releases: main Change-Id: Iba4d19f27cde90ee910048f12ec27ede13282c16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74918 Tested-by:
-
Christian Kuhn authored
Field 'clear' in sys_template is a checkbox field: 1 = clear constants 2 = clear setup 3 = clear both constants & setup The patch updates a functional test setup to properly clear both constants and setup. Change-Id: I45175bbeb571328715928d133ce83245608e208c Resolves: #97800 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74969 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Fernandez authored
To allow dispatching notifications to the user the easy way, a new global flash message queue, identified by `TYPO3\CMS\Core\Messaging\FlashMessageQueue::NOTIFICATION_QUEUE`, is introduced that takes the flash message and renders it as a notification on the top-right edge of the backend. Backend modules based on `TYPO3\CMS\Backend\Template\ModuleTemplate` automatically gain advantage of this feature. Resolves: #97595 Releases: main Change-Id: I0e04f0412117649391c0f50fa4249b7832dded69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74582 Tested-by:
-
Torben Hansen authored
Argument types for 2 functions can safely be set to `string`, since current implementations already ensure, that only a string is passed as argument. Resolves: #97799 Releases: main Change-Id: Ia1f81b63f53c3087b4d03979a8fc17e0f7c8f6dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74968 Tested-by:
-
- Jun 20, 2022
-
-
Oliver Klee authored
This helps avoid breakage when GeneralUtility will switch to strict mode. This change also prevents a whole bunch of possible invalid array access warnings. Resolves: #97583 Relates: #97578 Releases: main Change-Id: Id500872d91a7b47c647bb9a4d860477ee9ca7595 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74961 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
Add some more comments to TemplateService related properties and fix typos. Resolves: #97796 Releases: main Change-Id: I131e141e0d1acce57ded287348c7ed0e2ab8a983 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74964 Tested-by:
-
- Jun 19, 2022
-
-
Oliver Hader authored
The backend related global-event-handler is a helper to especially submit POST forms on various DOM elements. It supersedes "onClick" events by having a watcher defined by data attributes. The patch extends given solution to also act on other elements, especially the "<a .." tag. This will be used by the upcoming backend TypoScript Object browser and in general allows to send POST requests instead of GET requests on many elements. The JavaScript implementation has been prepared a while ago already, but missed a use-case up until now. Change-Id: I6604fd866543f94addbb9909fd41fb2ba3355bf5 Resolves: #97795 Related: #91052 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74963 Tested-by:
-
Christian Kuhn authored
Enrich existing test data providers of ArrayUtility::flatten() with another scenario to see how it behaves on details. Change-Id: I3e97689efc2f72e1a9532b12652c98ecaef67556 Resolves: #97794 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74962 Tested-by:
-
Oliver Klee authored
This helps avoid breakage when GeneralUtility will switch to strict mode. This change also prevents a whole bunch of possible invalid array access warnings. Resolves: #97582 Relates: #97580 Releases: main Change-Id: I950d64fcb2f16b5044eeff465c85b4022525ceb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74863 Tested-by:
-
linawolf authored
Document the status quo and the recent changes. resolves https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/84 resolves https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/77 Resolves: #97758 Releases: main Change-Id: I35596dad6f9f840f21fac42ca7f2d58009ba5463 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74873 Tested-by:
-
Josef Glatz authored
$GLOBALS['TYPO3_CONF_VARS']['MAIL']['dsn'] may contain credentials and is therefore blinded in the configuration module. Resolves: #96993 Releases: main, 11.5 Change-Id: I9a6ff7cc8f6c58fa3281125d5198bebb452a4ebc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74856 Tested-by:
-
Larry Garfield authored
Resolves: #97744 Releases: main Change-Id: I60f3424696f2b6b655922b6c377ce65ec139c877 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74829 Tested-by:
-
