[BUGFIX] Avoid yoda-style conditions in PHP
The core team agreed on not using yoda-style conditions in PHP. An appropriate PHP-CS-Fixer rule to explicitly disable yoda-style has been added to ensure that this coding style is respected. Additionally, all yoda-style conditions have been transformed to normal conditions. Resolves: #97839 Releases: main, 11.5 Change-Id: Ic3a77fe412c15ec8c8d793f2b4aa6017562a4863 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75005 Reviewed-by:Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de>
Showing
- Build/php-cs-fixer.php 1 addition, 0 deletionsBuild/php-cs-fixer.php
- typo3/sysext/core/Classes/Charset/CharsetConverter.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Charset/CharsetConverter.php
- typo3/sysext/core/Classes/Command/Descriptor/TextDescriptor.php 1 addition, 1 deletion...sysext/core/Classes/Command/Descriptor/TextDescriptor.php
- typo3/sysext/core/Classes/Error/DebugExceptionHandler.php 7 additions, 7 deletionstypo3/sysext/core/Classes/Error/DebugExceptionHandler.php
- typo3/sysext/core/Classes/Http/JsonResponse.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Http/JsonResponse.php
- typo3/sysext/core/Classes/Http/UploadedFile.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Http/UploadedFile.php
- typo3/sysext/core/Classes/Log/Writer/FileWriter.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Log/Writer/FileWriter.php
- typo3/sysext/core/Classes/Log/Writer/PhpErrorLogWriter.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Log/Writer/PhpErrorLogWriter.php
- typo3/sysext/core/Classes/Log/Writer/SyslogWriter.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Log/Writer/SyslogWriter.php
- typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php 1 addition, 1 deletion...sysext/core/Classes/Routing/PageSlugCandidateProvider.php
- typo3/sysext/core/Classes/Routing/PageUriMatcher.php 2 additions, 2 deletionstypo3/sysext/core/Classes/Routing/PageUriMatcher.php
- typo3/sysext/core/Resources/PHP/ClassMapGenerator.php 2 additions, 2 deletionstypo3/sysext/core/Resources/PHP/ClassMapGenerator.php
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php 1 addition, 1 deletion.../Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php
- typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableVariant.php 1 addition, 1 deletion...orm/Classes/Domain/Model/Renderable/RenderableVariant.php
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php 1 addition, 1 deletion.../Classes/ContentObject/Menu/AbstractMenuContentObject.php
- typo3/sysext/frontend/Classes/Utility/CompressionUtility.php 1 addition, 1 deletiontypo3/sysext/frontend/Classes/Utility/CompressionUtility.php
- typo3/sysext/indexed_search/Classes/Indexer.php 2 additions, 2 deletionstypo3/sysext/indexed_search/Classes/Indexer.php
- typo3/sysext/recycler/Tests/Functional/Recycle/Pages/AdminRecycleTest.php 4 additions, 4 deletions...ycler/Tests/Functional/Recycle/Pages/AdminRecycleTest.php
- typo3/sysext/recycler/Tests/Functional/Recycle/Pages/UserRecycleTest.php 4 additions, 4 deletions...cycler/Tests/Functional/Recycle/Pages/UserRecycleTest.php
Please register or sign in to comment