- Jan 17, 2018
-
-
Georg Ringer authored
Avoid spamming the log in PHP 7.2 due to get_class(null) if fetching the image in ImageService->getImage() fails. Resolves: #83570 Releases: master, 8.7, 7.6 Change-Id: Icc3c78f5b747842cee89d184134ff298b8e04a3a Reviewed-on: https://review.typo3.org/55376 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Jan 15, 2018
-
-
Christian Kuhn authored
Fix a case during ext:impexp FAL uid mapping where sys_file_reference end up pointing to wrong sys_file records in case new sys_file uids also already exist in import file, due to multiple mappings. Power the patch with a functional test - it fails without the change in Import.php and is ok with the change. See the test method comments for more details on what exactly is checked here. Change-Id: I472cad2652e8d6f5d30e4ebc68ff1ae93de71ea1 Resolves: #67188 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/55368 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jan 08, 2018
-
-
Richard Haeser authored
Prevent warnings and notices if $GLOBALS['TBE_MODULES_EXT'] is not set, which can be the case if no extensions are installed. Change-Id: I72f513329790ee3b71fd30054574b79f41a6dcf8 Resolves: #83479 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/55297 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Markus Günther authored
Adding a condition to check if a backend user has permissions on the search to prevent a JS error while initializing the autocomplete module. Also check if a module is available to start with. Fixes: #82969 Releases: master, 8.7, 7.6 Change-Id: If2827902443ff7411d9b2c1050213be3e0d78fb6 Reviewed-on: https://review.typo3.org/54714 Reviewed-by:
Markus Günther <mail@markus-guenther.de> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
- Jan 06, 2018
-
-
Georg Ringer authored
To avoid exceptions with complex structures, the strict flag must be used in the in_array check. Resolves: #82736 Releases: master, 8.7, 7.6 Change-Id: I3ecf859e3e3cc70ab40b10ef9052d46e8b486957 Reviewed-on: https://review.typo3.org/55189 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Jan 04, 2018
-
-
Andreas Fernandez authored
Resolves: #83453 Releases: master, 8.7, 7.6 Change-Id: I40654f5c230e0e91b3b479dd1c07eb087e639051 Reviewed-on: https://review.typo3.org/55249 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Jan 03, 2018
-
-
Stephan Großberndt authored
Use the correct maximal permission "31" for the root page when setting up an empty site during the installation process instead of "32" which leads to non-editable permissions for that page even by an admin. Resolves: #83369 Releases: master, 8.7, 7.6 Change-Id: I092f32b48c2a6deb79727fd6a1f8730829161287 Reviewed-on: https://review.typo3.org/55246 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Jan 01, 2018
-
-
Georg Ringer authored
Resolves: #83409 Releases: master, 8.7, 7.6 Change-Id: I94a3a3ad31de6e4969d5456f12b728c98adf0815 Reviewed-on: https://review.typo3.org/55237 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Dec 21, 2017
-
-
Andreas Fernandez authored
Fix an issue in unit tests. Resolves: #81222 Releases: 7.6 Change-Id: I439c81e6d3f0c142367b2ea0241a997d0c78cd8e Reviewed-on: https://review.typo3.org/55191 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
-
Andreas Fernandez authored
The HTML5 attribute `controlsList` is used in at least Google Chrome to limit the control buttons. The AudioTagRenderer and VideoTagRenderer classes are now aware of that attribute. Resolves: #81222 Releases: master, 8.7, 7.6 Change-Id: I9a577ae077e7e7b55b9fed7852a5a61a5fd4061a Reviewed-on: https://review.typo3.org/55187 Reviewed-by:
-
- Dec 20, 2017
-
-
Christian Kuhn authored
* Add tags of all v7 Changelog files * Minor .rst reformattings and fixes Change-Id: I4761a1d8028feca5de30a3f860fd5f01bbdd42d1 Resolves: #83402 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/55184 Tested-by:
-
- Dec 19, 2017
-
-
Stephan Großberndt authored
Only select the current file connected to the metadata when editing the metadata of a file. Resolves: #78845 Releases: master, 8.7, 7.6 Change-Id: Ib65b1e1aaae1fa2c93b03e4865582841a28990a6 Reviewed-on: https://review.typo3.org/55168 Reviewed-by:
-
Stephan Großberndt authored
Releases: master, 8.7, 7.6 Resolves: #83375 Change-Id: Id998c9fb688b8dcd41f09a0b863f87e8290adb2a Reviewed-on: https://review.typo3.org/55166 Tested-by:
-
- Dec 18, 2017
-
-
Oliver Hader authored
Resolves: #83345 Releases: master, 8.7, 7.6 Change-Id: I49e0de26154430c8a93c6a25a7fa54d5e49be39d Reviewed-on: https://review.typo3.org/55102 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Dec 17, 2017
-
-
Christian Kuhn authored
Align Howto.rst with version from master. Change-Id: Ie68e5eb59f080537050717106bf549dc6d4a0ef3 Resolves: #83371 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/55141 Tested-by:
-
- Dec 16, 2017
-
-
Christian Kuhn authored
One .rst Changelog file misses the mandatory index to the forge issue number. Change-Id: I3d4275f777bf164cf51b4df61a8a3606c7058bbf Resolves: #83364 Releases: 7.6 Reviewed-on: https://review.typo3.org/55128 Tested-by:
-
Christian Kuhn authored
Two fixes in specific .rst files and syncing main Index.rst and other files on this level with master. Change-Id: Ibe3221e455bd05fe4417aafab4afeb4c2ba409e4 Resolves: #83362 Releases: 7.6 Reviewed-on: https://review.typo3.org/55126 Tested-by:
-
Christian Kuhn authored
Fixes a broken link and restructures the 7.6.x/Index.rst to be free from patch level releases. This is ok with the low number of files in this folder. Since v8, the install tool documentation module will further help with keeping track of new files during patch level releases, too. Not having named patch level versions is easier to maintain from core point of view and simplifies the underlying workflow. The patch also adds indirectly adds a file which has been forgotton to reference in Index.rst, this can't happen anymore from now on due to the glob reference. Change-Id: I2163f0823becbf5b719dc4cf9c1520ed224abb15 Resolves: #83361 Releases: 7.6 Reviewed-on: https://review.typo3.org/55124 Tested-by:
-
Michael Oehlhof authored
Resolves: #83351 Releases: 7.6 Change-Id: I62793199cbbd0c2745fd357563c69f1196911c8c Reviewed-on: https://review.typo3.org/55110 Tested-by:
-
- Dec 14, 2017
-
-
Patrick Schriner authored
each() is deprecated in PHP 7.2 and has to be replaced. Resolves: #83321 Releases: master, 8.7, 7.6 Change-Id: Ic318b50a9921cd6a55435cc9b2e0b254e61b9dbc Reviewed-on: https://review.typo3.org/55084 Tested-by:
-
- Dec 12, 2017
-
-
Alexander Opitz authored
Improve reading the TER XML file while using the php xml extension. The character data handler could be called multiple times, so we shouldn't cut previous data away. Resolves: #83227 Releases: master, 8.7, 7.6 Change-Id: I9e96ade88da6a4709d1f72cd49fe766758d265fe Reviewed-on: https://review.typo3.org/55058 Reviewed-by:
-
Stefan Neufeind authored
Change-Id: I36167b0a8b61532adbafea93c88c93097ea52d73 Resolves: #83297 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/55042 Reviewed-on: https://review.typo3.org/55047 Tested-by:
-
Tymoteusz Motylewski authored
Fixes regression introduced in https://review.typo3.org/53399 Where thumbnail was regenerated every time process was called with empty configuration like: $fileObject->process(ProcessedFile::CONTEXT_IMAGEPREVIEW, []) Resolves: #83242 Relates: #81776 Releases: master, 8.7, 7.6 Change-Id: I6a4c331bad4d80225d3914f1a48f6071b0d87380 Reviewed-on: https://review.typo3.org/55040 Reviewed-by:
-
- Dec 11, 2017
-
-
Nicole Cordes authored
There is a difference between Apache and CLI exposing global path configuration on Windows Systems. The CommandUtility uses the global path to initialize an internal path storage for possible command resources. The patch ensures both possible keys on Windows systems are taken into account to resolve possible application locations. Resolves: #83234 Releases: master, 8.7, 7.6 Change-Id: Id7166042e39c4f468c10c1c489c7fe5beae7a5fc Reviewed-on: https://review.typo3.org/55025 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Dec 09, 2017
-
-
Christoph Lehmann authored
Check if TCEFORM.pages.categories.config.treeConfig.rootUid itself is in the users category mounts (no need for a pseudo parent category) Resolves: #83257 Releases: master,8.7,7.6 Change-Id: I8a60860ee3a22d68964f4e44018f0962f7f0f278 Reviewed-on: https://review.typo3.org/54978 Tested-by:
-
- Dec 06, 2017
-
-
Alexander Opitz authored
We should show what the max upload file size is and not the max size of a HTTP post body. Resolves: #83230 Releases: master, 8.7, 7.6 Change-Id: Ib6fa244b19c434417808bb19126f862cf9418fb0 Reviewed-on: https://review.typo3.org/54939 Tested-by:
-
- Dec 05, 2017
-
-
Helmut Hummel authored
To ensure PHP 5.5.0 compatibility as stated in our version constraints, we limit updating package dependencies within our shipped code to this PHP version. Additionally we update these packages to their latest version Composer commands used: composer up symfony/console symfony/finder composer req symfony/debug:^2.7 composer req --dev symfony/stopwatch:^2.8 symfony/process:^2.8 \ symfony/options-resolver:^2.8 symfony/filesystem:^2.8 \ symfony/event-dispatcher:^2.8 symfony/yaml:^2.8 composer config platform.php 5.5 composer up --lock Releases: 7.6 Resolves: #83223 Change-Id: Idb271d632bf472705a3e887c1405fcffb282cb05 Reviewed-on: https://review.typo3.org/54932 Reviewed-by:
-
Markus Klein authored
This cleanup should ease backporting future patches in that area. Releases: master, 8.7, 7.6 Resolves: #83189 Change-Id: I42b700d2fd17beadc4a9b8e64e500f3d3b93fd1f Reviewed-on: https://review.typo3.org/54901 Tested-by:
-
- Dec 04, 2017
-
-
Christian Kuhn authored
Run core v7 acceptance, unit and lint tests on php 7.2, too. Change-Id: I2db7c3fb6cde92c6d2d0320ba39343679e57e126 Resolves: #83215 Releases: 7.6 Reviewed-on: https://review.typo3.org/54928 Tested-by:
-
Christian Kuhn authored
The update brings patches for PHP 7.2 compatibility. Change-Id: Ibdfc231cd336511e0327eae485003d818fd1cc1e Resolves: #83222 Releases: 7.6 Reviewed-on: https://review.typo3.org/54930 Tested-by:
-
Auer, Fabian authored
Latest 2.2 branch of the require-dev dependency of php-cs-fixer brings PHP 7.2 compatibility. The core has this dependency to run the cglFixMyCommit.sh script which needs a slight adaption with the version raise. Change-Id: I5c80b80716fdfa076ca77d281587cbb9c8d1068d Resolves: #83220 Releases: 7.6 Reviewed-on: https://review.typo3.org/54818 Tested-by:
-
- Dec 03, 2017
-
-
Christian Kuhn authored
The CountViewHelper calls count() on non-arrays or non-Countable objects. This throws warnings on PHP 7.2 - sanitize this call. Change-Id: Ie1932c31a099577cb0d344824a6441509aefbc03 Resolves: #83214 Releases: 7.6 Reviewed-on: https://review.typo3.org/54927 Tested-by:
-
Christian Kuhn authored
Sanitize some view helper unit tests to not trigger PHP 7.2 warnings count()'ing non-arrays by proper mocking. Change-Id: I9929a02a03c9218ab73838f4a214165333d414aa Resolves: #83213 Releases: 7.6 Reviewed-on: https://review.typo3.org/54926 Tested-by:
-
Christian Kuhn authored
Unit test boostrap does not initialize constants TYPO3_REQUESTTYPE and TYPO3_REQUESTTYPE_*, but various tests rely on this basic constants being properly defined in core v7. With PHP 7.2, accessing undefined connstants throws warnings. Patch makes according bootstrap method public and calls it during unit test bootstrap. Change-Id: I450e440694385244c554adef00a9c74135d457f5 Resolves: #83211 Releases: 7.6 Reviewed-on: https://review.typo3.org/54925 Reviewed-by:
-
Christian Kuhn authored
adodb (v7 only) expects constant ADODB_ASSOC_CASE to be set. PHP 7.2 now throws warnings if constants are not defined. Patch defines ADODB_ASSOC_CASE in unit test setUp() if it not has been defined before. Change-Id: Ie338c3e871ae0eb2f8536515c65b556381bf65c3 Resolves: #83210 Releases: 7.6 Reviewed-on: https://review.typo3.org/54924 Tested-by:
-
Christian Kuhn authored
Test suite on core v7 with PHP 7.2 complains a lot about "Undefined constant OCI_COMMIT_ON_SUCCESS". This is found in the adodb oracle oci8 driver, used as property default value and thus evaluated as soon as the driver class is instantiated in tests. The test suite does not include oci8 in php. The php module sets constant OCI_COMMIT_ON_SUCCESS to hex '0x20' which is 32 in decimal. The patch uses decimal 32 to suppress the warning if oci8 module is not loaded for tests. Change-Id: I218e9758fe8b1bf8a92a8398f6782faa4ed4c9c9 Resolves: #83209 Releases: 7.6 Reviewed-on: https://review.typo3.org/54923 Tested-by:
-
Christian Kuhn authored
Raising this indirect require-dev dependency fixes ~330 unit tests on PHP 7.2 that otherwise throw a count() on non-array or countable warning. Change-Id: I3dce8ffe6d2180bf41740b0bc5fd8397425cc985 Resolves: #83207 Releases: 7.6 Reviewed-on: https://review.typo3.org/54921 Tested-by:
-
Christian Kuhn authored
Global function debug() initializes its 6th argument to constant E_DEBUG which does not exist and then defaults to string 'E_DEBUG'. This raises a PHP 7.2 warning. Relevant for v8 & v7 only, this argument has been removed in master already. Fix by defaulting to string 'E_DEBUG' in method signature. Change-Id: If04c9e55bb810980b19b924496680ea1758e4b24 Resolves: #83200 Related: #82640 Releases: 8.7, 7.6 Reviewed-on: https://review.typo3.org/54915 Tested-by:
-
Christian Kuhn authored
Sanitize a count() call in PreparedStatement (8.7, 7.6 only) for PHP 7.2 compatibility. Change-Id: I8d3cac3814093c7223c6be8f8ab8dc8c610d28e1 Resolves: #83196 Releases: 8.7, 7.6 Reviewed-on: https://review.typo3.org/54912 Tested-by:
-
Christian Kuhn authored
Raising this indirect require-dev dependency fixes a PHP 7.2 compatibility issue on core 7.6 branch: "Declaration of DOMNodeComparator::assertEquals() must be compatible with ..." Change-Id: I1c422edab82250b51ae9a0cc268110c62977ee08 Resolves: #83195 Resolves: #83120 Releases: 7.6 Reviewed-on: https://review.typo3.org/54910 Reviewed-by:
-
