- Apr 05, 2023
-
-
Benni Mack authored
This method is just a wrapper for a title="" attribute and is very inflexible. Thus, it is marked as deprecated. Resolves: #100459 Releases: main Change-Id: Ic8e7f5fca9176fdf76a9723a702705dd4fce56b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78321 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Weiske authored
Resolves: #100457 Releases: main Change-Id: Ifa947d33af06b92486220b20afb57354870f0393 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78471 Tested-by:
-
Christian Kuhn authored
Solves simple cases: Make some helper methods static, call them statically, and declace consuming data providers static. There are more hairy cases in this section, those will be sorted out with further patches. Resolves: #100451 Related: #100249 Releases: main Change-Id: I927da99a598f74819247c83f395419b6021a730e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78465 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
Clean up and simplify a bit along the way. Resolves: #100450 Related: #100249 Releases: main Change-Id: I0f808487226689a701e9224c1e93daf2f2fbd7ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78464 Tested-by:
-
Benjamin Kott authored
npm i --save \ @codemirror/autocomplete@^6.4.2 \ @codemirror/commands@^6.2.2 \ @codemirror/lang-css@^6.1.1 \ @codemirror/lang-html@^6.4.3 \ @codemirror/lang-javascript@^6.1.4 \ @codemirror/lang-json@^6.0.1 \ @codemirror/lang-php@^6.0.1 \ @codemirror/lang-sql@^6.4.0 \ @codemirror/lang-xml@^6.0.2 \ @codemirror/language@^6.6.0 \ @codemirror/lint@^6.2.0 \ @codemirror/search@^6.3.0 \ @codemirror/state@^6.2.0 \ @codemirror/theme-one-dark@^6.1.1 \ @codemirror/view@^6.9.3 Resolves: #100429 Releases: main Change-Id: I8f6aafca025ddcc7f5f24968804a3b7cd69b4fa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78437 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Torben Hansen authored
The `PasswordChangeEvent` used in `notifyPasswordChange´ should not be used to validate user passwords, since it is not possible to visualize to the user why a password has been rejected. With TYPO3 v12, a custom password policy validator should be used to validate user passwords. Furthermore it is not usefull to modify the hashed password. The following methods of the `PasswordChangeEvent` PSR-14 event in ext:felogin have therefore been marked as deprecated: * `setAsInvalid()` * `getErrorMessage()` * `isPropagationStopped()` * `setHashedPassword()` Resolves: #100355 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I28841ff5d819b13eea238f2dfacdbff336e089ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78446 Tested-by:
-
Stefan Bürk authored
PHPStan recenently released a new patchlevel version, fixing the one or other bug and changing the reported issue message texts. This change raises the phpstan dependency along with one extending package. The baseline file was regenerated to update to new message texts of some reported messages to mitigate issue flipping between composer locked and composer max testing. Used command(s): > composer require --dev \ "phpstan/phpstan":"^1.10.11" \ "phpstan/phpstan-phpunit":"^1.3.11" > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100452 Releases: main, 11.5 Change-Id: I307089d4b655e92eff2561c4e6d92cf79c20ea82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78466 Tested-by:Chris Müller <typo3@krue.ml> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Kuhn authored
Make a helper method static to allow a static data provider. Resolves: #100449 Related: #100249 Releases: main Change-Id: I2fe4c4bf8125d40c8988ccce1927bc08d759b653 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78463 Tested-by:
-
Christian Kuhn authored
Avoid a useless helper method by having object creation within data provider directly. Resolves: #100448 Related: #100249 Releases: main Change-Id: I630a7f24fe0b5e295d924a83553c85d648d15390 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78462 Reviewed-by:
-
Christian Kuhn authored
Use reflection instead of a mock in this functional test data provider to create data sets. Resolves: #100447 Related: #100249 Releases: main Change-Id: Ib73eb7153dd23f813c7e57b8928cfb006fb26efb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78461 Tested-by:
-
- Apr 04, 2023
-
-
Christian Kuhn authored
Unit tests with phpunit 10 are green for now. We temporarily add them to the CI test suite to ensure they don't break again. This will be kept until other suites are green as well, and further details have been sorted out. We'll later ditch phpunit 9 entirely, but need further patches, first. > Build/Scripts/runTests.sh -s unit10 Note this changes composer.json and composer.lock locally and needs to be used with care. Resolves: #100445 Related: #100249 Releases: main Change-Id: I7ec0a0752b01ddb3564bb13d79d4ad9f1450d21d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78458 Tested-by:
-
Oliver Hader authored
With this update, whenever the `<f:sanitize.html>` view helper is invoked, the initiator reference will be included in the log. This will help to quickly identify which class or component triggered the sanitization process and take necessary actions if needed. Resolves: #100377 Releases: main, 11.5 Change-Id: Ic7b06a7e96d98492c69e917a575b9e6f2a3d7296 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78350 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Christian Kuhn authored
setAccessible() in reflection is a no-op since PHP 8.1. It can be removed. Resolves: #100444 Releases: main Change-Id: I750ef13f93360aaeaba244415275092f0f604818 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78457 Tested-by:
-
Christian Kuhn authored
Resolves: #100442 Related: #100249 Releases: main Change-Id: I5b9c5f90d2a7688f5808513df618219b4eb14bf4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78454 Reviewed-by:
-
Christian Kuhn authored
Resolves: #100443 Related: #100249 Releases: main Change-Id: Iedc841419942629dc9261f190f221b6575285254 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78455 Reviewed-by:
-
Christian Kuhn authored
Pretty straight substitution as done with similar phpunit 10 compatibility patches. Resolves: #100441 Related: #100249 Releases: main Change-Id: I00932cbcc10b57698aaa2882af3d0f3628a13934 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78453 Tested-by:
-
Oliver Klee authored
This also allows automated testing with a minimal data. Resolves: #100430 Related: #100249 Releases: main, 11.5 Change-Id: I2cee7ff96dee58ef76ce8f91161ed21e1a52553a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78438 Tested-by:
-
Oliver Klee authored
Even for a broken/imcomplete configuration, we want to have the exception that complains about the incomplete configuration instead of a `TypeError`. Also add some type casts to have predictable types in more cases. Resolves: #100431 Related: #100249 Releases: main, 11.5 Change-Id: If92af8f66bab7d311cbddc3178bc515b63381741 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78439 Tested-by:
-
Torben Hansen authored
This change removes an unused property in `DeleteRecords` domain model in ext:recycler Resolves: #100440 Releases: main Signed-off-by:
-
Christian Kuhn authored
Resolves: #100436 Related: #100249 Releases: main Change-Id: Id3c6d93080cffd2652013b1a4f2d5bbcf0f34346 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78445 Tested-by:
-
Benni Mack authored
When using the `<f:translate>` ViewHelper out of Extbase context (e.g., in `FLUIDTEMPLATE` or `StandaloneView`), TYPO3 v12 checked for `$GLOBALS[LANG]`, which is wrong, as this is the language of a backend editor - all labels (outside of Extbase) were then rendered with the editors view. This is of course an ugly bug, which happened due to https://review.typo3.org/c/Packages/TYPO3.CMS/+/75941 For this reason, `<f:translate>` does not check for `$GLOBALS[LANG]` anymore, but instead checks for the `SiteLanguage` first, and then checks for the `$GLOBALS[BE_USER]`. In addition, as long as we have a static list of dependencies, the locale object needs to be instantiated from the `Locales` class in order to resolve the defined dependencies. This could probably vanish once all information is put into the right places. Resolves: #100255 Resolves: #100176 Releases: main Change-Id: I50c24008f0a16432e9122e0e186cd4a9b8e8f476 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78325 Tested-by:
Marc Willmann <mw@f7.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Oliver Bartsch authored
To centralize workflows, reaction and webhook records should only be managed in their dedicated backend module. Resolves: #100434 Releases: main Change-Id: Iae76c6d559b30127677af601af303e85bc0e5bf8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78442 Tested-by:
-
Andreas Fernandez authored
The classes `T3editorElement` and `JsonElement` boot a CodeMirror instance and provides a hard-coded label to be rendered in a panel below the editor. That label became useless over time as it provides redundant information and is therefore now removed from those elements. Resolves: #100433 Releases: main Change-Id: If387a5141ab5c03c5e367f32d990e34ff59f456b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78441 Tested-by:
-
Oliver Klee authored
Resolves: #100432 Releases: main Change-Id: I1c037a5b177dbd1f0124e493b26e4ad6f3dc04d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78440 Tested-by:
-
Christian Kuhn authored
The two mocked methods are not called by the test subject - probably due to an earlier refactoring regarding package load state. The two withConsecutive() calls can be removed. Resolves: #100426 Related: #100249 Releases: main Change-Id: I0b32fd1210bbc03f1f002cc58eed727de23da2f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78435 Tested-by:
-
Christian Kuhn authored
The two mocked methods are not called by the test subject - probably due to an earlier refactoring regarding package load state. The two withConsecutive() calls can be removed. Resolves: #100427 Related: #100249 Releases: main Change-Id: I8d1cdedb7599d9de0ae91f0f700a04b596ffae6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78436 Reviewed-by:
-
Andreas Nedbal authored
The options passed to the Paste module through PageLayoutController are all present in the first argument, not three separate arguments. Resolves: #99825 Releases: main Change-Id: Ie77b83fef9337241bdfcaffc3642c1d1b233ec7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78383 Reviewed-by:
-
Nikita Hovratov authored
Until now, the TCA for Site Configuration was never migrated by the TcaMigrator. With the massive amount of TCA deprecations, an error popped up eventually. The gathered TCA overrides are now migrated and will log deprecation level log entries, just like the standard TCA migration. Resolves: #100359 Releases: main Change-Id: I94da983b93e79b1f15c38b5d41763c7ed822e47a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78333 Reviewed-by:
-
Benjamin Kott authored
The handling was introduced in [1] to have a resizable navigation area. With the introduction of a generalized Lit component, the handling was incompletely removed in [2]. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/67511 [2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/68692 Resolves: #100424 Releases: main Change-Id: I20bb526e2c3e82e407d905209fddf9a36feeae0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78433 Reviewed-by:
-
Benjamin Kott authored
Used command: cd Build/ npm i --save-dev \ @types/ckeditor__ckeditor5-utils@^28.0.15 npm i --save \ @ckeditor/ckeditor5-alignment@^36.0.1 \ @ckeditor/ckeditor5-autoformat@^36.0.1 \ @ckeditor/ckeditor5-basic-styles@^36.0.1 \ @ckeditor/ckeditor5-block-quote@^36.0.1 \ @ckeditor/ckeditor5-clipboard@^36.0.1 \ @ckeditor/ckeditor5-code-block@^36.0.1 \ @ckeditor/ckeditor5-core@^36.0.1 \ @ckeditor/ckeditor5-dev-utils@^36.0.1 \ @ckeditor/ckeditor5-editor-classic@^36.0.1 \ @ckeditor/ckeditor5-engine@^36.0.1 \ @ckeditor/ckeditor5-essentials@^36.0.1 \ @ckeditor/ckeditor5-find-and-replace@^36.0.1 \ @ckeditor/ckeditor5-heading@^36.0.1 \ @ckeditor/ckeditor5-horizontal-line@^36.0.1 \ @ckeditor/ckeditor5-html-support@^36.0.1 \ @ckeditor/ckeditor5-indent@^36.0.1 \ @ckeditor/ckeditor5-link@^36.0.1 \ @ckeditor/ckeditor5-list@^36.0.1 \ @ckeditor/ckeditor5-paragraph@^36.0.1 \ @ckeditor/ckeditor5-paste-from-office@^36.0.1 \ @ckeditor/ckeditor5-remove-format@^36.0.1 \ @ckeditor/ckeditor5-source-editing@^36.0.1 \ @ckeditor/ckeditor5-special-characters@^36.0.1 \ @ckeditor/ckeditor5-style@^36.0.1 \ @ckeditor/ckeditor5-table@^36.0.1 \ @ckeditor/ckeditor5-theme-lark@^36.0.1 \ @ckeditor/ckeditor5-ui@^36.0.1 \ @ckeditor/ckeditor5-undo@^36.0.1 \ @ckeditor/ckeditor5-utils@^36.0.1 \ @ckeditor/ckeditor5-word-count@^36.0.1 Resolves: #100425 Releases: main Change-Id: I1534040577af6cc7d946269fe3f247ca72960dd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78434 Reviewed-by: -
Andreas Fernandez authored
With the upgrade to CodeMirror 6, the dark theme is enforced, which may have a negative impact on UX as this stresses the user's eyesight. The implementation is adapted to 1) respect and 2) react on changing `prefers-color-scheme` settings. Resolves: #99730 Releases: main Change-Id: Ia4dc0baf927aef13d3ea545fa2314c281ce8f373 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78335 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
Straight refactoring avoiding withConsecutive(). Resolves: #100421 Related: #100249 Releases: main Change-Id: Iabd2dfbf32bc8066308a9eeb5126084bcf0363a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78392 Tested-by:
-
Christian Kuhn authored
Method getLowestAndHighestIntegerVersions() does not exist and should not be mocked. Resolves: #100418 Related: #100249 Releases: main Change-Id: I12226e350077d10149a491270e651b61f5d820e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78389 Tested-by:
-
Christian Kuhn authored
Resolves: #100419 Related: #100249 Releases: main Change-Id: Ic969120244be3b4ee53c873d788ce9c07d3a8f72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78390 Tested-by:
-
Christian Kuhn authored
Resolves: #100423 Related: #100249 Releases: main Change-Id: Iffffb0d01e96c01e40ac8c4955a4ffa09f1199d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78394 Tested-by:
-
Christian Kuhn authored
Use onlyMethods() instead. Also, setAccessible() is obsolete since PHP 8.1. Resolves: #100422 Related: #100249 Releases: main Change-Id: I62894d3bf19376389e14e8e2df81e0cd4324b5de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78393 Tested-by:
-
Christian Kuhn authored
Avoid mocking not existing methods in one test. Remove two other tests that mock so much that it's very hard to understand what they try to achieve in the first place. Resolves: #100417 Related: #100249 Releases: main Change-Id: I213f82989cbf5d170b8ca68320c8ab2c10a9efef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78388 Tested-by:
-
Christian Kuhn authored
Resolves: #100420 Related: #100249 Releases: main Change-Id: Ib5b3fc4bbf9f8e9f13fddfabdce3cba7a2df7591 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78391 Tested-by:
-
Christian Kuhn authored
Rewriting the tests to mock less makes them better readable and far easier to grasp. Resolves: #100414 Related: #100249 Releases: main Change-Id: If369a4f4d6f7af9836ff3e016996b729697f82f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78385 Tested-by:
-
Christian Kuhn authored
Testing for the input keys is rather useless, it's enough to verify the sub method is called twice. Resolves: #100415 Related: #100249 Releases: main Change-Id: I1c8e0513b5fa556b512dffe0a192c499d57d605e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78386 Reviewed-by:
-
