Skip to content
Snippets Groups Projects
Select Git revision
0 result
Search by author
  • Any Author
  • Daniel Hürtgen Daniel Hürtgen higidi
  • Jenkins Jenkins jenkins
  • **** **** project_53_bot
3 authors
  1. Jan 11, 2024
  3. Jan 10, 2024
    • Stefan Bürk's avatar
      [TASK] Avoid invalid datetime database default in a test · 036c2e36
      Stefan Bürk authored 
      With #102479 support for persisting datetime_immutable
object has been ensured and covered with a functional
test. However, using a empty string as default for a
not nullable datetime field is invalid for MariaDB and
MySQL which seemed to work until now in test executions.

Something has changed, but had no luck to find any traces
in the mariadb, mysql or corresponding docker hub changelogs
and commits explaining this.

The TYPO3 default TCA schema creates nullable fields with a
null default for `date, datetime and timestamp` anyway, and
therefore we now use that for the test case table structure.

It make sense to test a valid structure if working state is
expected.

Note:   It seems that core ci is not blocked by this yet,
        however local execution are broken. To verify with
        and without the change use following command(s):

    > Build/Scripts/runTests.sh -u
    > Build/Scripts/runTests.sh -s functional -d mysql \
        typo3/sysext/core/Tests/Functional/Database/

Resolves: #102807
Releated: #102479
Releases: main, 12.4
Change-Id: Ide32b3f9dc4b049ff5c3982997c85a0bb01e2fce
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82388


Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      036c2e36
    • Oliver Bartsch's avatar
      [BUGFIX] Properly handle unknown link type · 931fc9a7
      Oliver Bartsch authored 
      In case an invalid link type is used in
a link field, the link browser does no
longer throw an exception but instead
displays a flash message with the
corresponding information.

Additionally, an undefined array key access
is resolved, which might happen e.g. in
case such invalid link is being analyzed
by link validator.

Resolves: #102804
Releases: main, 12.4
Change-Id: I5ad35ff46360cc4b27556b8e2c75da69ecbe76d9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82387


Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarNikita Hovratov <nikita.h@live.de>
Tested-by: default avatarNikita Hovratov <nikita.h@live.de>
      931fc9a7
  5. Jan 09, 2024
  7. Jan 08, 2024
  9. Jan 07, 2024
  11. Jan 06, 2024
  13. Jan 05, 2024
  15. Jan 04, 2024
    • Benni Mack's avatar
      [TASK] Streamline indentation of arrays and comments · 8cdf6380
      Benni Mack authored 
      PHP-CS-Fixer rule `array_indentation` is activated to have
consistent indentation of arrays.

In addition, a full run of php-cs-fixer without
caches shows also affected areas where comments
did not apply properly.

Resolves: #102753
Releases: main, 12.4, 11.5
Change-Id: I759149606c4b042f1ac4329d4f5b7166d591456b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82334


Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarBenni Mack <benni@typo3.org>
      8cdf6380
    • Benni Mack's avatar
      [TASK] Allow usage of symfony 7 · b03970d9
      Benni Mack authored 
      This change enables Symfony 7 in
addition to symfony 6 in TYPO3.

Symfony7 requires PHP 8.2, thus
is not installed by default for the
time being, as this change is also
allowed for TYPO3 v12 support when
running with PHP 8.2 and composer.

Used commands:

composer req -W \
 "symfony/config:^6.4 || ^7.0" \
 "symfony/console:^6.4 || ^7.0" \
 "symfony/dependency-injection:^6.4 || ^7.0" \
 "symfony/doctrine-messenger:^6.4 || ^7.0" \
 "symfony/expression-language:^6.4 || ^7.0" \
 "symfony/filesystem:^6.4 || ^7.0" \
 "symfony/finder:^6.4 || ^7.0" \
 "symfony/http-foundation:^6.4 || ^7.0" \
 "symfony/mailer:^6.4 || ^7.0" \
 "symfony/messenger:^6.4 || ^7.0" \
 "symfony/mime:^6.4 || ^7.0" \
 "symfony/options-resolver:^6.4 || ^7.0" \
 "symfony/property-access:^6.4 || ^7.0" \
 "symfony/property-info:^6.4 || ^7.0" \
 "symfony/rate-limiter:^6.4 || ^7.0" \
 "symfony/routing:^6.4 || ^7.0" \
 "symfony/uid:^6.4 || ^7.0" \
 "symfony/var-dumper:^6.4 || ^7.0" \
 "symfony/yaml:^6.4 || ^7.0"

 composer req --dev -W \
 "codeception/codeception:^5.0.13" \
 "codeception/module-filesystem:^3.0.1" \
 "friendsofphp/php-cs-fixer:^3.46" \
 "symfony/translation:^6.4 || ^7.0"

Resolves: #102746
Releases: main, 12.4
Change-Id: I6bbbfb0bc6e26c00fba0010234b5c8b698cf0a81
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82314


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
      b03970d9
    • Anja Leichsenring's avatar
      [TASK] Update locales translation files · 5a4a17fa
      Anja Leichsenring authored 
      TYPO3 uses a composer package [1] to import
locales along with translations and a custom
script has been added to create and update
included translation files.

This change updates the language files with
the last updates and requires the package
with the current highest version as minimum.

Used command(s):

> composer req --dev \
    "sokil/php-isocodes-db-i18n":"^4.0.18"

> Build/Scripts/runTests.sh \
    -s checkIsoDatabase \
    -p 8.1

[1] sokil/php-isocodes-db-i18n

Resolves: #102747
Releases: main, 12.4
Change-Id: I4d6603484c4fca213c66f0df0feff13bc1011b29
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82307


Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      5a4a17fa
  17. Jan 03, 2024
  19. Jan 01, 2024
  21. Dec 30, 2023
  23. Dec 28, 2023
  25. Dec 26, 2023
    • Oliver Bartsch's avatar
      [BUGFIX] Omit calling `getRecordWSOL` in `BU::getProcessedValue()` · b61dfba9
      Oliver Bartsch authored 
      Since #102616, itemsProcFunc config is resolved in
`BU::getLabelFromItemlist()`. This method therefore
was adjusted to take the record in question as argument,
passing it to the underlying `ItemProcessingService`,
which actually just requires the uid and pid.

Since the database row is not passed to
BU::getProcessedValue()`, the record was
fetched for each item manually via
`getRecordWSOL()`. This is not sufficient
and has a serious performance impact.

The functionality of resolving itemsProcFunc is
now still in place but `BU::getProcessedValue()`
does no longer fetch and pass the record, but
only the uid and pid. This will therefore still
enable most use cases, but does no longer slow
down the backend.

Resolves: #102698
Related: #102616
Related: #100855
Releases: main, 12.4
Change-Id: Ic52564fada13b47f5364df642acbf683538b0c21
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82248


Reviewed-by: default avatarOliver Bartsch <bo@cedev.de>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarOliver Bartsch <bo@cedev.de>
      b61dfba9
  27. Dec 22, 2023
  29. Dec 21, 2023