- Jun 18, 2024
-
-
Christian Kuhn authored
Inline the 'random seed' option for -s unitRandom, replay a specific seed using: > runTests.sh -s unitRandom -- --random-order-seed=<number> Resolves: #104131 Releases: main, 12.4, 11.5 Change-Id: I84e1cc0a0c57a5132a592a140d1b58ceb6d3b059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84736 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
- Jun 17, 2024
-
-
Garvin Hicking authored
Once the ExtensionScanner hits a '@extensionScannerIgnoreLine' annotated code line, it internally sets a flag that is never reset. That causes all following lines to be ignored, not just one. This patch will reset the property `$isCurrentLineIgnored` to `false` again, once the annotated line has passed. Tests are adapted to verify this behaviour. Due to the behavioral change it is possible that the scanner now finds more hits in third-party scanned extensions that previously may have been ignored. Resolves: #100702 Releases: main, 12.4 Change-Id: Ib1cbb5e7758e7e302e4395d759e8585eeff15d8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84733 Tested-by:
-
Christian Kuhn authored
The release comes with a nifty memory usage improvement and probably allows us to avoid a couple of hacks we've used, which we'll clean up later. Raise for now. Core v12 will raise phpunit 10 instead. > composer req --dev phpunit/phpunit:^10.5.21 Resolves: #104127 Releases: main, 12.4 Change-Id: I4faf1af0378e2996324b3db101709764a31419b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84731 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Helmut Hummel authored
This reverts commit 4b89b371. Reason for revert: The typo3conf folder is still used by the backend:lock and backend:unlock cli commands and the corresponding backend locking functionality Releases: 12.4 Resolves: #104119 Related: #104074 Change-Id: I37a658b7123aaf3b015a8982efbb4af72b9ec1f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84649 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christoph Lehmann authored
BackendAccessDeniedException is thrown due to inproper client ip. BackendLockedException is thrown when the backend is locked. Both cases are desired behaviour, so they should not get logged. Resolves: #104120 Releases: main, 12.4 Change-Id: If29f4bb58d78a3a3dfcd6d1815ae1b0404311662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84650 Tested-by:
-
- Jun 14, 2024
-
-
Willi Wehmeier authored
The aspect ratio buttons in the image cropping tool have a visible focus state now to make them usable when navigating with the keyboard tab key. Additionally the button can now be pressed with the space and return key. Resolves: #103760 Releases: main, 12.4 Change-Id: Id221daddeee9d5b61497cb74604dbf151d25e3ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84554 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Georg Ringer authored
The bookmark title within the following modules is enriched by the page id: - Info module Resolves: #103909 Releases: main, 12.4 Change-Id: I715a55dea86ac08f1a3dbeeff01e8d1b03712464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84644 Reviewed-by:
-
Oliver Bartsch authored
Defining columnsOnly, which is used by the EditDocumentController to instruct the FormEngine to only render a subset of available fields for records is now table aware. This allows to render records from different tables in the same request, while respecting the fields to be rendered on a per-table basis. The "columnsOnly" parameter therefore now requires the fields as array under the corresponding table name: &columnsOnly[pages][0]=title A backwards-compatibility layer is in place, migrating the previous syntax to the new one by adding the configured fields for the tables from the edit configuration. Resolves: #104108 Releases: main, 12.4 Change-Id: I46500100eb369ad117a2cf5c61a9811c6fd5c7a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84712 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benni Mack authored
In order to enable more possibilities in the events, the PSR-14 events in EXT:felogin are extended with the PSR-7 request object, otherwise the events are useless as $GLOBALS['TYPO3_REQUEST'] must be used. Currently, it is f.e. not possible to modify the view ModifyLoginFormViewEvent based e.g. on a site configuration. Resolves: #104100 Releases: main, 12.4 Change-Id: I9daa6481d71fd1cae98d0a7ab01fe1adc7602748 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84696 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104065 Releases: main, 12.4 Change-Id: I48c121620bf84a9444ff3c9d79d1adfd1fa631f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84648 Reviewed-by:
-
Bingquan Bao authored
The documentation contained a wrong registration code example, which now uses the proper array depth level notation. Releases: main, 12.4, 11.5 Resolves: #104105 Change-Id: Idb3c9b0e723af2f1bb579bc304637497e1272e36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84645 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
- Jun 13, 2024
-
-
Andreas Kienast authored
With the upgrade to Bootstrap 5, the panels have no explicit position anymore, breaking the progress bars in the Extension Scanner found in the Install Tool. This commit adds a relative positioning to the panels. Resolves: #104073 Releases: main, 12.4 Change-Id: Ie67989dbcfa859ebc3020dabaa27913de7ae4b64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84706 Tested-by:
-
Nikita Hovratov authored
The goal here is to have a generic PreviewRenderer, which is not tt_content specific. The StandardContentPreviewRenderer could then extend this generic renderer. This is a pre-patch to make the refactoring easier in the next patch. For this to work, GridColumnItem now exposes methods to retrieve the table from the context, the type column and the record type. Additionally, some drive-by refactorings have been done like early return statements and stricter checks. The unused variable $infoArr has been removed as well. Resolves: #102825 Releases: main, 12.4 Change-Id: I38eab3c095e06b789915600e79b7831556a25ca5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84705 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104071 Releases: main, 12.4 Change-Id: I9e0958168cf9812e20fbd3d3be2ce8dab80a8bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84641 Tested-by:
-
Andreas Nedbal authored
With the rework of moving the "Show clipboard" toggle into the view mode dropdown for the list and filelist module, the functionality of the user TSconfig "options.file_list.enableClipBoard" and the page TSconfig "mod.web_list.enableClipBoard" has been broken. This commit fixes the functionality, aligning it with the documented behaviours. Resolves: #102145 Releases: main, 12.4 Change-Id: I17e3677638ea9d2f950a9f8d6c33ad089fc813c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84642 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Georg Ringer authored
SuggestWizard should also find records in workspace. Resolves: #81732 Releases: main, 12.4 Change-Id: Ic552cd3329174632eb5be92ff9f7876959a454f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84640 Reviewed-by:
-
Andreas Kienast authored
The settings for the `typo3-t3editor-codemirror` element were passed in an `options` attribute, which is unknown. This leads to the issue that e.g. the `readOnly` flag set in TCA is ignored. The composed settings are now properly merged. Resolves: #104084 Releases: main, 12.4 Change-Id: I7e34a8230764c33b7924128176088ab32cb35a58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84699 Tested-by:
-
Stefan Bürk authored
Doctrine DBAL uses lowercased array index names for table or index names, which has been used to make RENAME DDL statements. Due to the lack of having the old information correctly in place, this leads to invalid RENAME DDL statements for tables or indexes having upper case characters in the name. That is a edgecase for PostgreSQL and SQLite due to custom index name handling based on that array key. This change modifies the ConnectionMigrator to use correct casing for column and index naming in case table or column needs to be renamed. That allows, that following correct DDL statements are now created: ALTER INDEX "freeIndexUid_65098221" RENAME TO "customFreeIndexUid_6dedc8fa" ALTER TABLE "index_phash" RENAME COLUMN "freeIndexSetId" TO "zzz_deleted_freeIndexSetId" in case the `EXT:indexed_search/ext_tables.sql` is changed for table `index_phash` to drop the `freeIndexSetId` column by commenting it out or remove it and renaming `freeIndexUid` index to `customFreeIndexUid`. [1] [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/84576/3/typo3/sysext/indexed_search/ext_tables.sql Resolves: #93223 Releases: main, 12.4 Change-Id: I195ad021b8826be59a3ae78a926a396528ca0c66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84698 Reviewed-by: -
Georg Ringer authored
The key `record` might not always contain the full record. When using the `FormSlugAjaxController`, the record might just contain a sub-set of fields. Resolves: #94388 Releases: main, 12.4, 11.5 Change-Id: Ie72d6701ebef4da8af8b039e0da056e28b8d0ecb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84691 Tested-by:
-
Oliver Bartsch authored
The toggle button to open the selection options of the multi record selection component does now provide an aria-label to make it accessible for screen readers. Resolves: #104089 Releases: main, 12.4 Change-Id: I89af5e4f5a0f8dd87be5d532bdd894bd2636502e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84689 Reviewed-by:
-
Jasmina Ließmann authored
In the submodules of the admin tools, information and configuration options are placed in modals. Some of the panel headings used there did not match the style of other panel headings used in the system. The patch now aligns the styling. Resolves: #104087 Releases: main, 12.4 Change-Id: I15b8e447772c67b3627ba42cab1356cd59ab4274 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84639 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Andreas Nedbal authored
Before it was not really clear if/where a select check box header was collapsible. This patch unifies the layout with the one of the recordlist tables, adding a button specifically responsible to collapse/expand the group. Resolves: #98683 Releases: main, 12.4 Change-Id: I6b47cdc9cd2673a85aaa0bfb85dd70534e4ffc33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84638 Tested-by:
-
Christian Weiske authored
The link validator "missing links" report shows the title of the field which contains the missing link. This title is loaded from `TCA.$table.columns.$field.label`, but it is possible to use content-element specific labels in `TCA.$table.types.$contenttype.columnsOverrides.*.label`, and this is not supported by the validator. The patch first tries to load the overridden label and then falls back to the normal TCA column label. This fixes titles of elements generated by the "mask" extension, which only sets labels via overrides. Resolves: #104035 Releases: main, 12.4 Change-Id: I1fa43a4cf0dbc910a8d2eea9b868aaf1cdbead0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84687 Reviewed-by:
-
Garvin Hicking authored
Currently both the Install Tool and Environment > Directory Status sets the directory "typo3conf" as being mandatory and tries to create it. This is no longer needed in Composer mode. Resolves: #104074 Releases: main, 12.4 Change-Id: I880ec2b7ff0be642c2673bb7110ef95f3dc125d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84637 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104025 Releases: main, 12.4 Change-Id: I32b509644018eaa4de452f499d525c6822addad1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84636 Reviewed-by:
-
Jasmina Ließmann authored
The TYPO3 backend has a bookmark function with which records can be saved as bookmarks. Since any other record type can be saved in addition to pages, the corresponding link titles are now adjusted. Resolves: #104053 Releases: main, 12.4 Change-Id: If8c894bdcd6e2aa0cbe3c29276a32ac18355a370 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84678 Tested-by:
-
Garvin Hicking authored
Extbase reserves a couple of keywords for internal use: * action * controller * format (resolving fluid templates for HTML, json, ...) * __trustedProperties * __referrer The notiation "__" (and "@" for sub-arrays) is indiciative of being reserved keywords, however action/controller/format are not. These are now mentioned specifically in the Fluid ViewHelper "arguments" parameter, so that they can show up in the auto-generated documentation. This should help to prevent integrators and developers from advertly using an argument like "format" as a custom variable/property name. Efforts have been made to document this also here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/4525 https://github.com/TYPO3-Documentation/TYPO3CMS-Exceptions/pull/155 Resolves: #102246 Releases: main, 12.4, 11.5 Change-Id: I55a306aaa0ba783f9202350d198c9fdf08f5a997 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84673 Reviewed-by:
-
- Jun 12, 2024
-
-
Michael Telgkamp authored
The rootpages in the site configuration do not have intendation any longer. The computation of the margin value and the unused inline style are removed. Resolves: #104066 Releases: main, 12.4 Change-Id: Ic75d7e10638b2ee3fb06f42add1a36c180f754e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84635 Tested-by:
-
Christian Kuhn authored
> Build/Scripts/runTests.sh Before: Memory: 469.06 MB After: Memory: 373.02 MB Reason: phpunit executes data providers early and keeps data sets in memory. The "xml parser big content" tests create megabytes of data kept in memory. Moving the data generation from data providers to the test execution reduces overall memory usage significantly. Resolves: #104076 Releases: main, 12.4, 11.5 Change-Id: I0ad49824fc1d4c309158b74474853d36af22ffb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84669 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104060 Related: #104046 Releases: main, 12.4 Change-Id: I2b7b8c8911cd3f5552a287a73942c11806f4b8bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84634 Tested-by:
-
Christian Rath-Ulrich authored
To improve accessibility, an aria-label is added to all context menu buttons to allow assistive technologies to announce them correctly. Resolves: #102490 Releases: main, 12.4 Change-Id: Ia397ab17a8fcbfe3a1ea75e86733a6a5a778653e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84667 Tested-by:
-
Oliver Bartsch authored
The "revert selection" action of the SelectCheckBoxElement does now properly handle the current element's "checked" state. This way, the action button gets visible once the initial state is changed (by checking / unchecking checkboxes) and is disabled again, in case the initial state gets restored. Resolves: #104062 Releases: 12.4 Change-Id: Iad14f36c1b8c0de23f4c152a5fd4ba1a4fbee6da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84628 Tested-by:
-
- Jun 11, 2024
-
-
Georg Ringer authored
The string "false" is cast to true and therefore 0/1 must be used in examples. Resolves: #99211 Releases: main, 12.4, 11.5 Change-Id: I5519cd1917b81c1dbb90fbb6746541735e4940ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84528 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Jasmina Ließmann authored
The "About" module lists, among other things, all backend modules available in the system. If an admin or editor does not have access to a module, it will not be displayed in the "About" module list. Some of the modules listed contained a note that the module was only accessible to administrators. With the introduction of the system maintainer role, this note is no longer applicable. In addition, this note was missing for some modules that cannot be made accessible to the editor at all (e.g. "Access" module). If an admin/system maintainer wants to check which backend modules an editor can access, he usually switches to the backend user (via the "Backend Users" backend module). Calling the "About" module is not sufficient at this point, as settings in backend user groups and the backend user accounts themselves also influence whether a backend user can access a backend module or not. For this reason, this note in the "About" module is now being removed. Resolves: #104040 Releases: main, 12.4 Change-Id: Ib27581a9f1fc48985d42550622caffcf0615a0d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84632 Tested-by:
-
Oliver Hader authored
Change-Id: I86360df1a2a39b3fb1ebca927fe2a714bc887691 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84600 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: If61da3b4e4166c368989faab63ae87c26330e588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84599 Tested-by:
-
Andreas Kienast authored
The drag&drop issue reported in #103877 also affects the icons in the page tree, which was not fixed back then. This commit now takes care of the page tree icons as well. Resolves: #104033 Related: #103877 Releases: 12.4, 11.5 Change-Id: I92381a07bfba2d90d7fc1a85097c54f0d4a7b282 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84593 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benjamin Franzke authored
Avoid redirecting to /typo3/empty, which is not helpful to the context. As long as there is not module context in shared record-edit links, it's best to show the first backend module on close of such a view. Resolves: #104028 Releases: main, 12.4 Change-Id: Ia7d50f4e906e92b7f93b6e444f7b18fafcc1ea1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84577 Tested-by:
-
- Jun 10, 2024
-
-
Garvin Hicking authored
When the configuration for `mod.web_layout.BackendLayouts` contains column definitions with an empty content, this will make both the list view and the normal page view in the backend fail. This makes using the GUI editing of the 'backend_layout' records impossible to be fixed/addressed. This patch now does a more lax check on the 'columns.' array to prevent PHP error notices on invalid array key access. Resolves: #103425 Releases: main, 12.4, 11.5 Change-Id: I68c9b5a1ee8f0a70e3808338aa9dd2ed6f12c882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84572 Tested-by:
-
Oliver Bartsch authored
When inserting a record via the element browser, the value argument needs either to be formatted manually or left empty, allowing the element browser to format the identifier automatically. By omitting the value in the `PageBrowser` module, the value is now correctly formatted by the element browser to "pages_<uid>". This makes the "node-action" usable for TCA group fields, which allow more than one record type. The same logic is also used by the `BrowseDatabase` module, which also omits the value argument. Resolves: #103700 Releases: main, 12.4 Change-Id: I80e2cc696d85b5ec83432c35a263b19f9752b0ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84553 Reviewed-by:
-
