[BUGFIX] Fix ExtensionScanner ignoring all lines instead of single one
Once the ExtensionScanner hits a '@extensionScannerIgnoreLine' annotated code line, it internally sets a flag that is never reset. That causes all following lines to be ignored, not just one. This patch will reset the property `$isCurrentLineIgnored` to `false` again, once the annotated line has passed. Tests are adapted to verify this behaviour. Due to the behavioral change it is possible that the scanner now finds more hits in third-party scanned extensions that previously may have been ignored. Resolves: #100702 Releases: main, 12.4 Change-Id: Ib1cbb5e7758e7e302e4395d759e8585eeff15d8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84733 Tested-by:core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/AbstractCoreMatcher.php 5 additions, 0 deletions...sses/ExtensionScanner/Php/Matcher/AbstractCoreMatcher.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/CodeStatisticsTest.php 1 addition, 1 deletion...ll/Tests/Unit/ExtensionScanner/Php/CodeStatisticsTest.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Fixtures/CodeStatisticsFixture.php 1 addition, 0 deletions...t/ExtensionScanner/Php/Fixtures/CodeStatisticsFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayDimensionMatcherTest.php 1 addition, 0 deletions...xtensionScanner/Php/Matcher/ArrayDimensionMatcherTest.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayGlobalMatcherTest.php 1 addition, 0 deletions...t/ExtensionScanner/Php/Matcher/ArrayGlobalMatcherTest.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ClassConstantMatcherTest.php 1 addition, 0 deletions...ExtensionScanner/Php/Matcher/ClassConstantMatcherTest.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ClassNameMatcherTest.php 1 addition, 0 deletions...nit/ExtensionScanner/Php/Matcher/ClassNameMatcherTest.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstantMatcherTest.php 1 addition, 0 deletions...Unit/ExtensionScanner/Php/Matcher/ConstantMatcherTest.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ArrayDimensionMatcherFixture.php 6 additions, 0 deletions...ner/Php/Matcher/Fixtures/ArrayDimensionMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ArrayGlobalMatcherFixture.php 6 additions, 0 deletions...canner/Php/Matcher/Fixtures/ArrayGlobalMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ClassConstantMatcherFixture.php 3 additions, 0 deletions...nner/Php/Matcher/Fixtures/ClassConstantMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ClassNameMatcherFixture.php 3 additions, 0 deletions...nScanner/Php/Matcher/Fixtures/ClassNameMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ConstantMatcherFixture.php 3 additions, 0 deletions...onScanner/Php/Matcher/Fixtures/ConstantMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/FunctionCallMatcherFixture.php 3 additions, 0 deletions...anner/Php/Matcher/Fixtures/FunctionCallMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/InterfaceMethodChangedMatcherFixture.php 1 addition, 1 deletion...Matcher/Fixtures/InterfaceMethodChangedMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentDroppedMatcherFixture.php 2 additions, 0 deletions.../Matcher/Fixtures/MethodArgumentDroppedMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentDroppedStaticMatcherFixture.php 2 additions, 0 deletions...er/Fixtures/MethodArgumentDroppedStaticMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentRequiredMatcherFixture.php 2 additions, 0 deletions...Matcher/Fixtures/MethodArgumentRequiredMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentRequiredStaticMatcherFixture.php 1 addition, 0 deletions...r/Fixtures/MethodArgumentRequiredStaticMatcherFixture.php
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentUnusedMatcherFixture.php 2 additions, 0 deletions...p/Matcher/Fixtures/MethodArgumentUnusedMatcherFixture.php
Please register or sign in to comment