- Apr 04, 2023
-
-
Oliver Bartsch authored
To centralize workflows, reaction and webhook records should only be managed in their dedicated backend module. Resolves: #100434 Releases: main Change-Id: Iae76c6d559b30127677af601af303e85bc0e5bf8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78442 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Fernandez authored
The classes `T3editorElement` and `JsonElement` boot a CodeMirror instance and provides a hard-coded label to be rendered in a panel below the editor. That label became useless over time as it provides redundant information and is therefore now removed from those elements. Resolves: #100433 Releases: main Change-Id: If387a5141ab5c03c5e367f32d990e34ff59f456b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78441 Tested-by:
-
Oliver Klee authored
Resolves: #100432 Releases: main Change-Id: I1c037a5b177dbd1f0124e493b26e4ad6f3dc04d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78440 Tested-by:
-
Christian Kuhn authored
The two mocked methods are not called by the test subject - probably due to an earlier refactoring regarding package load state. The two withConsecutive() calls can be removed. Resolves: #100426 Related: #100249 Releases: main Change-Id: I0b32fd1210bbc03f1f002cc58eed727de23da2f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78435 Tested-by:
-
Christian Kuhn authored
The two mocked methods are not called by the test subject - probably due to an earlier refactoring regarding package load state. The two withConsecutive() calls can be removed. Resolves: #100427 Related: #100249 Releases: main Change-Id: I8d1cdedb7599d9de0ae91f0f700a04b596ffae6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78436 Reviewed-by:
-
Andreas Nedbal authored
The options passed to the Paste module through PageLayoutController are all present in the first argument, not three separate arguments. Resolves: #99825 Releases: main Change-Id: Ie77b83fef9337241bdfcaffc3642c1d1b233ec7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78383 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Nikita Hovratov authored
Until now, the TCA for Site Configuration was never migrated by the TcaMigrator. With the massive amount of TCA deprecations, an error popped up eventually. The gathered TCA overrides are now migrated and will log deprecation level log entries, just like the standard TCA migration. Resolves: #100359 Releases: main Change-Id: I94da983b93e79b1f15c38b5d41763c7ed822e47a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78333 Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Benjamin Kott authored
The handling was introduced in [1] to have a resizable navigation area. With the introduction of a generalized Lit component, the handling was incompletely removed in [2]. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/67511 [2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/68692 Resolves: #100424 Releases: main Change-Id: I20bb526e2c3e82e407d905209fddf9a36feeae0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78433 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benjamin Kott authored
Used command: cd Build/ npm i --save-dev \ @types/ckeditor__ckeditor5-utils@^28.0.15 npm i --save \ @ckeditor/ckeditor5-alignment@^36.0.1 \ @ckeditor/ckeditor5-autoformat@^36.0.1 \ @ckeditor/ckeditor5-basic-styles@^36.0.1 \ @ckeditor/ckeditor5-block-quote@^36.0.1 \ @ckeditor/ckeditor5-clipboard@^36.0.1 \ @ckeditor/ckeditor5-code-block@^36.0.1 \ @ckeditor/ckeditor5-core@^36.0.1 \ @ckeditor/ckeditor5-dev-utils@^36.0.1 \ @ckeditor/ckeditor5-editor-classic@^36.0.1 \ @ckeditor/ckeditor5-engine@^36.0.1 \ @ckeditor/ckeditor5-essentials@^36.0.1 \ @ckeditor/ckeditor5-find-and-replace@^36.0.1 \ @ckeditor/ckeditor5-heading@^36.0.1 \ @ckeditor/ckeditor5-horizontal-line@^36.0.1 \ @ckeditor/ckeditor5-html-support@^36.0.1 \ @ckeditor/ckeditor5-indent@^36.0.1 \ @ckeditor/ckeditor5-link@^36.0.1 \ @ckeditor/ckeditor5-list@^36.0.1 \ @ckeditor/ckeditor5-paragraph@^36.0.1 \ @ckeditor/ckeditor5-paste-from-office@^36.0.1 \ @ckeditor/ckeditor5-remove-format@^36.0.1 \ @ckeditor/ckeditor5-source-editing@^36.0.1 \ @ckeditor/ckeditor5-special-characters@^36.0.1 \ @ckeditor/ckeditor5-style@^36.0.1 \ @ckeditor/ckeditor5-table@^36.0.1 \ @ckeditor/ckeditor5-theme-lark@^36.0.1 \ @ckeditor/ckeditor5-ui@^36.0.1 \ @ckeditor/ckeditor5-undo@^36.0.1 \ @ckeditor/ckeditor5-utils@^36.0.1 \ @ckeditor/ckeditor5-word-count@^36.0.1 Resolves: #100425 Releases: main Change-Id: I1534040577af6cc7d946269fe3f247ca72960dd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78434 Reviewed-by: -
Andreas Fernandez authored
With the upgrade to CodeMirror 6, the dark theme is enforced, which may have a negative impact on UX as this stresses the user's eyesight. The implementation is adapted to 1) respect and 2) react on changing `prefers-color-scheme` settings. Resolves: #99730 Releases: main Change-Id: Ia4dc0baf927aef13d3ea545fa2314c281ce8f373 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78335 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
Straight refactoring avoiding withConsecutive(). Resolves: #100421 Related: #100249 Releases: main Change-Id: Iabd2dfbf32bc8066308a9eeb5126084bcf0363a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78392 Tested-by:
-
Christian Kuhn authored
Method getLowestAndHighestIntegerVersions() does not exist and should not be mocked. Resolves: #100418 Related: #100249 Releases: main Change-Id: I12226e350077d10149a491270e651b61f5d820e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78389 Tested-by:
-
Christian Kuhn authored
Resolves: #100419 Related: #100249 Releases: main Change-Id: Ic969120244be3b4ee53c873d788ce9c07d3a8f72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78390 Tested-by:
-
Christian Kuhn authored
Resolves: #100423 Related: #100249 Releases: main Change-Id: Iffffb0d01e96c01e40ac8c4955a4ffa09f1199d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78394 Tested-by:
-
Christian Kuhn authored
Use onlyMethods() instead. Also, setAccessible() is obsolete since PHP 8.1. Resolves: #100422 Related: #100249 Releases: main Change-Id: I62894d3bf19376389e14e8e2df81e0cd4324b5de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78393 Tested-by:
-
Christian Kuhn authored
Avoid mocking not existing methods in one test. Remove two other tests that mock so much that it's very hard to understand what they try to achieve in the first place. Resolves: #100417 Related: #100249 Releases: main Change-Id: I213f82989cbf5d170b8ca68320c8ab2c10a9efef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78388 Tested-by:
-
Christian Kuhn authored
Resolves: #100420 Related: #100249 Releases: main Change-Id: Ib5b3fc4bbf9f8e9f13fddfabdce3cba7a2df7591 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78391 Tested-by:
-
Christian Kuhn authored
Rewriting the tests to mock less makes them better readable and far easier to grasp. Resolves: #100414 Related: #100249 Releases: main Change-Id: If369a4f4d6f7af9836ff3e016996b729697f82f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78385 Tested-by:
-
Christian Kuhn authored
Testing for the input keys is rather useless, it's enough to verify the sub method is called twice. Resolves: #100415 Related: #100249 Releases: main Change-Id: I1c8e0513b5fa556b512dffe0a192c499d57d605e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78386 Reviewed-by:
-
Christian Kuhn authored
The tests try to configure method mocks that don't exist. The patch adapts the tests accordingly. They should receive a bigger overhaul, though. Resolves: #100416 Related: #100249 Releases: main Change-Id: Ia1a15a4c9520f2fc4630ea62f50f486ead1131ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78387 Tested-by:
-
Andreas Nedbal authored
This caused page titles in copy/cut functionality to not be resolved and instead display the site title as a fallback. Resolves: #99826 Releases: main, 11.5 Change-Id: I925981a1040dab92518af3fc6f0bc5c2342ec262 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78355 Tested-by:
-
- Apr 03, 2023
-
-
Christian Eßl authored
Remove some superfluous checks for is_object(), null and similar in conditions, where subsequent conditions already check the type more thoroughly. Resolves: #100369 Releases: main Change-Id: I2e5617e065ef2346fd0e9a831abe5aba7f284ff4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78342 Tested-by:
-
Christian Kuhn authored
Even though the RequestHandlerTest unit tests are an aweful mocking party, we can't simply throw them away since the class is so important. They should still be turned into functional tests later, to be more useful, maybe together with a refactoring of that class. The patch just changes the tests to avoid withConsecutive(), which does not improve the situation, but a bigger refactoring is currently a bit too much with our current goal of "just" adding phpunit 10 compatibility. Resolves: #100410 Related: #100249 Releases: main Change-Id: I8b09013b826ed56e0c6e96eade4c9f4a61346273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78379 Tested-by:
-
Christian Kuhn authored
AbstractPlugin ("Pi1" FE plugins) has been marked as "not maintained anymore" a while ago. The unit tests are a heavily mocking aweful mess, most of them look at details that are obvious reading the implementation. The central topics like the ContentObjectRenderer have unit tests on their own to sort out details. AbstractPlugin may see a final deprecation and there are little code changes in general. The patch removes the "unit" tests to reduce maintenance nightmares in this area, the tests don't add much value. Resolves: #100408 Related: #100249 Releases: main Change-Id: If906aae54f1fdcf55b7aa88486e28f276322df6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78378 Reviewed-by: -
Oliver Hader authored
Replace `GeneralUtility::makeInstance` with `new` statement. Resolves: #100411 Releases: main Change-Id: I340212fb7baf68072d7b924aff8a13f43b543068 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78380 Tested-by:
-
Christian Eßl authored
Internally, the clipboard class only knows of the identifier "_FILE", which is used for copying both files and folders. Resolves: #100367 Releases: main Change-Id: Ibef87567cd71f73d2e4b3c8a360b1bff1f420fd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78340 Tested-by:
-
Christian Kuhn authored
Turns existing unit tests into functionals, making them more concise, avoids mocking parties, and makes them better maintainable. SilentConfigurationUpgradeService is slightly cleaned up along the way, together with a minor fix regarding a missing BE/lang/debug removal, which was now found by the functional tests. Resolves: #100407 Related: #100249 Releases: main Change-Id: I9188af068243b3beacc56ab7c9a24f6536c46ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78377 Tested-by:
-
Christoph Lehmann authored
Don't check accessibility to current page and if its content should be rendered twice. This is already done in the TypoScriptFrontendController. Resolves: #100372 Releases: main Change-Id: I550401bb34828283bc39fd1e865d9a36ca5f8536 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78345 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Andreas Nedbal authored
Hidden content elements are still present in the document flow but just have a height of 0 causing the uniform spacing with collapsed margins to fail. We remove the hidden element from the document flow to prevent this. Resolves: #100370 Releases: main Change-Id: Ia7616b1d95206fb67441e36f15a866c01ba28b1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78352 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Christian Kuhn authored
Avoids phpunit 10 deprecation and failures and allows minor modifications of ActionController. Resolves: #100400 Related: #100249 Releases: main Change-Id: I4b39af2c326bb1c5c9b0df74c7c8e85c48f32ad4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78373 Tested-by:
-
Christian Kuhn authored
Resolves: #100403 Related: #100249 Releases: main Change-Id: Iaec3d23b6fdfb70698f3715f7724915d8e7152d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78376 Reviewed-by:
-
Christian Kuhn authored
Using the test class as fixture is problematic since the constructor changes in phpunit 10. Resolves: #100402 Related: #100249 Releases: main Change-Id: I8315346c5f9dbb9d38283d9fdf9a51b2c98450de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78375 Tested-by:
-
Christian Kuhn authored
Using the test class as fixture is problematic since the constructor changes in phpunit 10. Refactor this and clean up a bit. Resolves: #100401 Related: #100249 Releases: main Change-Id: Id15be97acb967e1badd17163389583c56859b0bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78374 Reviewed-by:
-
Christian Eßl authored
When a page containing a typoscript template has been deleted, there won't be a valid rootline for the template. Add a simple check to avoid an "undefined array key" error. Resolves: #100365 Releases: main Change-Id: Ic082c9b1d895241b87a372e490031626b91b1604 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78338 Reviewed-by:
-
Christian Kuhn authored
Resolves: #100397 Related: #100249 Releases: main Change-Id: I5578b8fbd76e198d91c2aad5421e715957981f94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78371 Tested-by:
-
- Apr 02, 2023
-
-
Chris Müller authored
Resolves: #100333 Releases: main Change-Id: I6b9a36758b66748d4c2e092e5390d5bcc3ead8b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78298 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Christian Kuhn authored
Clean up and simplify a bit along the way. Resolves: #100396 Related: #100249 Releases: main Change-Id: I821c2c8e19aed4f4c1636eadf328d46a3dbc8c5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78370 Tested-by:
-
Christian Kuhn authored
Resolves: #100395 Related: #100249 Releases: main Change-Id: Ida96df615efdeab4f735057a1ff597f7d7a280fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78369 Tested-by:
-
Christian Kuhn authored
Clean up a bit along the way. Resolves: #100394 Related: #100249 Releases: main Change-Id: I4a9395f5f96f129b3673dfbf870ee88bb531763b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78368 Tested-by:
-
Christian Kuhn authored
Resolves: #100393 Related: #100249 Releases: main Change-Id: I039a5cc5e8473c7c9a4e6f2bced053a76358eb05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78367 Reviewed-by:
-
