- Jul 20, 2018
-
-
Benni Mack authored
The field "uid" is never fetched, so no count() is possible in the DB count query. Resolves: #85252 Releases: master, 9.3 Change-Id: I9a3f1cb13bf20dcbe4bfb5451afd465e5981ecb4 Reviewed-on: https://review.typo3.org/57634 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
The method is just a wrapper for PageRepository->enableFields() which should be used instead. Resolves: #85558 Releases: master Change-Id: I5fd18ef3e101325bc95f4d0147899d961f5898f6 Reviewed-on: https://review.typo3.org/57598 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Jul 19, 2018
-
-
Christian Kuhn authored
Bring back backend acceptance test execution as pre-merge and nightly tests. They are hopefully more stable now and we'll test if they survive the hard pre-merge load without being too flaky.. The patch changes the bamboo plan specs accordingly but disables a couple for FormEngine related detail tests that need further investigation. The patch also fetches a new patch level of testing-framework to have proper ac path definition of the ac splitter script: composer update typo3/testing-framework Change-Id: Iffcfd60391ba60d5ab2196a00a5bd0a4a93fff7f Resolves: #85599 Releases: master Reviewed-on: https://review.typo3.org/57635 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Markus Klein authored
Resolves: #85238 Releases: master Change-Id: Ie47e1ba0a4f0ba3e5e1a8d62bc137cabd3ae4d1e Reviewed-on: https://review.typo3.org/57125 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
The TYPO3_OS constant is deprecated with the introduction of Environment API. Resolves: #85597 Releases: master Change-Id: Ie0f844d2d024f2a3f6acdf5af24debead6ba836b Reviewed-on: https://review.typo3.org/57632 Tested-by:
-
Benni Mack authored
Resolves: #85598 Related: #85553 Releases: master Change-Id: Ib5c0a6850c79880eac0eb47dab957083ca328e2b Reviewed-on: https://review.typo3.org/57633 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Ramon Zöllner authored
Fixed Link to Extension-Scanner Docs Releases: master Resolves: #85595 Change-Id: I181b34497db5d0f2807c035d6228f6fb9f2f31a4 Reviewed-on: https://review.typo3.org/57631 Reviewed-by:
-
Benni Mack authored
The default value for - PageRepository->getPageOverlay() - PageRepository->getPagesOverlay() should be "null" and not some magic "-1" usage. Resolves: #85553 Releases: master Change-Id: Ic665c4a563e6496678ab944c80901db26f2b72ba Reviewed-on: https://review.typo3.org/57591 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Oliver Hader authored
When determining the SaltedHashingMethod of a salted hash check only SaltedHashingMethods which are marked as available. Resolves: #85526 Releases: master, 8.7 Change-Id: I72ca88ce35c891dc149d0628543d30b6c4122407 Reviewed-on: https://review.typo3.org/57520 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Jul 18, 2018
-
-
Markus Klein authored
Resolves: #85236 Releases: master Change-Id: Iad1047b7a91adee4d0dcad766d5116bea27e34ce Reviewed-on: https://review.typo3.org/57198 Tested-by:
Jürgen Venne <venne@schaffrath-digital.de> Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Michael Giek authored
The source page redirects now also with get-parameters to the target page. Resolves: #85538 Related: #85488 Releases: master Change-Id: Ibc1ae6afdbe11065156201e8118838203e427cf3 Reviewed-on: https://review.typo3.org/57569 Tested-by:
-
Christian Kuhn authored
When the site configuration module has been introduced, it came with a custom functionality to show an additional help text when editing site records between the field label and the field input. This useful feature is now changed into a general TCA feature available everywhere: A new field information node expansion / "wizard" is added to all form elements, the inline and flex containers: If the property "description" is set for a TCA column type (same array level as "label", it will show the value as localized string between the field label and the input section. There are three available render types for "wizard a-like" output: * Field information - text between label+field * Field control - buttons next to input sections like the link popup button * Field wizards - clickable stuff below the input section, for example the localization state selector If a field has been set to readOnly=true in TCA, field control and field wizards do not make sense to render since they are meant to act with the field value. The field information node however has only informational character which is useful for readOnly fields, too. Thus, this node expansion type is now the only one that is always rendered, even if a field has been set to readOnly. Note this patch is fully covered by ext:styleguide (master) to have examples for all changed elements now using the description property. Resolves: #85410 Releases: master Change-Id: Idcfacafa19b8208614b653b8fac22ce47bca3b8f Reviewed-on: https://review.typo3.org/57397 Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Andreas Fernandez authored
Since our code does not work with doctrine/dbal 2.8.0 we for now pin to the previous minor release. A hidden dependency to doctrine/collections is also removed by using the ExpressionBuilder constant instead. Used command: composer require doctrine/dbal ~2.7.0 Resolves: #85575 Related: #85552 Releases: master Change-Id: Icc8d41c566cf39d15a4eae500b8b216a44689dce Reviewed-on: https://review.typo3.org/57613 Reviewed-by:
-
sascha307050 authored
Releases: master,8.7 Resolves: #85589 Change-Id: I965f559b0307bd477e8f64340a12513a9827842d Reviewed-on: https://review.typo3.org/57624 Reviewed-by:
-
Stefan Neufeind authored
In composer-mode the autoload-information can't be dumped. A FlashMessage is shown as a notice. But the message itself was left empty and instead a message-title was given which is not shown in the backend. Resolves: #85515 Releases: master Change-Id: Ie8e59fb5272f1a1682b19652ac991e5dbee6a4e3 Reviewed-on: https://review.typo3.org/57511 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
-
Tymoteusz Motylewski authored
When PID of the parent record has not changed, child records should not be moved/sorted. Little background helping reviewing the patch: The 2 important changes are made in DataHandler.php line 4603 and DataHandlerHook.php around line 346. In both cases the condition is added checking if the destination PID of the record is the same as current one. In that case, processing of the IRRE children is skipped. All the changes made in the .csv files are reflecting that. To validate them one can compare the content of the csv files with LiveDefaultElements.csv datasets. For example, check that sorting values in file: core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/changeParentContentSorting.csv are the same as in the: core/Tests/Functional/DataHandling/IRRE/CSV/DataSet/LiveDefaultElements.csv In the Workspaces related datasets, you will see that there are no move placeholders for IRRE children any more (and versioned records have 0 instead ...
-
Felix Althaus authored
Use :=getEnv() in TypoScript to read values from environment variables. Resolves: #85146 Releases: master Change-Id: I6c480627e4b07f76f4d8887df0db9d95fd75e6d9 Reviewed-on: https://review.typo3.org/57115 Tested-by:
Hannes Lau <office@hanneslau.de> Tested-by:
-
Oliver Hader authored
ModuleMenu and Viewport initialization need to be defered to ensure that DOM is available in order to apply further behavior in mentioned client implementation. Resolves: #80312 Releases: master, 8.7 Change-Id: I9581a7f2164050f73683928b8f2ebe1d69a6d5e7 Reviewed-on: https://review.typo3.org/57526 Tested-by:
-
Peter Kraume authored
This patch improves the usability of the new Settings module by moving the extension configuration card in the first place since this will probably be the most used card in the Settings module. Resolves: #85546 Releases: master Change-Id: I21aa5bcccacd49b0ab6a67c5bf87812f295b0c49 Reviewed-on: https://review.typo3.org/57584 Reviewed-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
Marco Huber <mail@marco-huber.de> Tested-by:
-
Wouter Wolters authored
Resolves: #85293 Releases: master Change-Id: Ifabbb20c1ef4ad482df676fe9999dcbdf18eb704 Reviewed-on: https://review.typo3.org/57249 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Rudy Gnodde <rgn@windinternet.nl> Reviewed-by:
-
Stefan Neufeind authored
The description so far says fieldnames are prepended. Resolves: #85507 Releases: master Change-Id: I06fccdc2aee70a95e64cb14adccba0e24a22c1cb Reviewed-on: https://review.typo3.org/57499 Tested-by:
-
Benni Mack authored
The unused method TypoScriptFrontendController->getUniqueId() is marked as deprecated, as this method conceptually should go into a custom service with a singleton pattern or a runtime cache, but not within TypoScriptFrontendController. Resolves: #85555 Releases: master Change-Id: Ib3af4b32e3c03d90b832ee725dcf9846af92f9ba Reviewed-on: https://review.typo3.org/57597 Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Mathias Brodala authored
Change-Id: I9f396da2084880b3dd813c8d7f0777c36ac989d9 Resolves: #84414 Releases: master Reviewed-on: https://review.typo3.org/56331 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Robert van Kammen <rvkammen@hotmail.com> Tested-by:
-
- Jul 17, 2018
-
-
Christian Kuhn authored
bamboo php 7.2 has apc & apcu support again. Two unit tests fail. These two however don't make much sense in the first place since they md5(internal-knowledge). Remove them. Resolves: #85584 Releases: master Change-Id: I5f1e1589189866508e684a7ca1bb6cae87d22fad Reviewed-on: https://review.typo3.org/57621 Reviewed-by:
-
Christian Kuhn authored
The bamboo containers need a better passwd mapping per agent to set a proper home directory, otherwise ssh tasks may fail. Resolves: #85582 Releases: master, 8.7, 7.6 Change-Id: I42b59df7512dd5bd6e00c2c07eee9441cf1aa28c Reviewed-on: https://review.typo3.org/57618 Tested-by:
-
- Jul 16, 2018
-
-
Tymoteusz Motylewski authored
It's based on tt_content and categories. Releases: master, 8.7 Resolves: #85493 Change-Id: Ie7222f38ea89536ab463ff46aabb94b8f834d599 Reviewed-on: https://review.typo3.org/57474 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Markus Klein authored
Resolves: #85552 Releases: master, 8.7 Change-Id: I1056a5825fd79df4c495894970721713b10728cd Reviewed-on: https://review.typo3.org/57603 Reviewed-by:
-
Christian Kuhn authored
Our unit tests should not rely on running daemons, there is a functional test environment to take care of this. The patch turns redis cache backend unit tests into funcitional tests and adapts the unit test setup to no longer start dependencies. Resolves: #85565 Releases: master Change-Id: I8d81209ed339d35af11bb06fb7cb191845b6b587 Reviewed-on: https://review.typo3.org/57607 Tested-by:
-
- Jul 15, 2018
-
-
Christian Kuhn authored
A new bamboo agent infrastructure has been deployed that significantly changes how tests are executed: The agent docker containers are now "stupid" and no longer bundle specific php versions or daemons. Instead, they can run own containers to start needed daemons for specific jobs and execute needed php commands in ad-hoc containers that provide the required php version. Daemons needed for single jobs are defined in a docker-compose.yml file provided by core itself. This docker-compose.yml file can not be used directly for local test execution since it has to fiddle quite a bit with docker volume mounts, networks and executing users that is specific to the bamboo environment. However, another yml file can be added later to ease local test execution in a similar way. The patch rewrites the bamboo plan pre-merge and nightly specs of core master to use the new infrastructure and brings a couple of minor changes to tests that rely on a running memcached or redis to retrieve the daemon host from an environment variable. There will be separated patche for older core versions. Change-Id: I65777eeee6e28fca5b3d3d979498293cc91a77af Resolves: #85563 Resolves: #36934 Releases: master Reviewed-on: https://review.typo3.org/57522 Tested-by:
-
Jigal van Hemert authored
In CommandTest::testGetDescription() now also LF is used as line ending, just as in the tested function. Resolves: #85509 Releases: master, 8.7 Change-Id: I907e24b19d87d94a3fb1b3cbee9947d68358e5cc Reviewed-on: https://review.typo3.org/57501 Tested-by:
-
Benni Mack authored
Minor fix to use the static constant directly, like in all other usages. Resolves: #85559 Releases: master Change-Id: I163bea97ddd78b6f37945daaf7aecaab6c47bdff Reviewed-on: https://review.typo3.org/57599 Tested-by:
-
- Jul 14, 2018
-
-
Andreas Fernandez authored
With the release of doctrine/dbal in version 2.8, the class `Doctrine\Common\Lexer` got removed. To circumvent this issue, the package `doctrine/lexer` will be used. Used composer command: composer require doctrine/lexer:^1.0 Resolves: #85552 Releases: master, 8.7 Change-Id: I5dd007c3b95be42dfd3305f750606ae4fcabedf2 Reviewed-on: https://review.typo3.org/57589 Reviewed-by:
-
- Jul 13, 2018
-
-
Oliver Hader authored
Including files from Phar archives (e.g. "phar://file.phar/autoload.php") does not work properly with having PHP setting open_basedir defined. The reason for that is, that TYPO3's custom PharStreamWrapper tries to find the appropriate base Phar file using file_exists() calls internally. In case those files are not part of the open_basedir restriction - which is the case for everything prefixed with the "phar://" scheme - a PHP warning is shown. Resolves: #85547 Releases: master, 8.7, 7.6 Change-Id: I72fdd7f0c016c0a8b1ed56a82b6b4042cac4d930 Reviewed-on: https://review.typo3.org/57587 Reviewed-by:
-
Benni Mack authored
This change adds a new Aspect called "Language" which bundles most existing TypoScript options on frontend language fetching. A factory allows to migrate the logic from TSFE. Major / Important Changes: - RootlineUtility is decoupled from PageRepository - TSFE->sys_language_mode is not necessary anymore - TSFE->sys_language_contentOL can be substituted by "overlayType" of Aspect - A new PageRepository->getLanguageOverlay() bundles all other methods - A lot of common public properties in TSFE are now deprecated Next steps: - Isolate calls from RootlineUtility/PageRepository more from each other and from TSFE - Migrate PageRepository "-1" parameters to "null" - Migrate usages PageRepository->getRootline() to RootlineUtility::__construct() - Then deprecate PageRepository->getRootLine() - Migrate Extbase QuerySettings to Contexts Resolves: #85543 Releases: master Change-Id: I8d177222a244a8d1fd66a884e9fc50b107f27e20 Reviewed-on: https://review.typo3.org/57424 Tested-by:
-
Benni Mack authored
The constructor of TemplateService now has a context, which knows everything to define public settings to define if tt_track and verbose should be set. Resolves: #85542 Releases: master Change-Id: I11306a57c64e8c5cb0d0a069b73e06f066b72d8e Reviewed-on: https://review.typo3.org/57581 Tested-by:
-
Benni Mack authored
The new Context API is added so TypoScript can check this in cObject like this: 10 = TEXT 10.data = context:workspace:id where as the key is context:[aspectName]:[propertyName] Arrays are automatically converted to comma-separated lists, which is useful for reading info on user groups. Resolves: #85550 Releases: master Change-Id: I86673055e088ec4e65288df6145399f8e45055c8 Reviewed-on: https://review.typo3.org/57588 Tested-by:
-
Mathias Brodala authored
Resolves: #85536 Releases: master, 8.7 Change-Id: Ie1f5c97af1a315eb5b8d7bf4bc7a31872362750d Reviewed-on: https://review.typo3.org/57536 Tested-by:
-
Josef Glatz authored
Show progress bar only if verbosity level is set. The default output of this command is disabled by default to limit the amount of e-mails sent by the TYPO3 scheduler (which normally makes only sense, if any error occurs). You can activate the output if you set the verbosity while calling the command ("-v" option). Resolves: #85533 Releases: master Change-Id: I6f95559cc1228afd66192f7382e81f9ae91c0ed8 Reviewed-on: https://review.typo3.org/57530 Tested-by:Alexander Grein <alexander.grein@gmail.com> Reviewed-by:
-
- Jul 12, 2018
-
-
Anja authored
The included task in not subject to be executed upon each `composer install`. Resolves: #85537 Related: #83249 Releases: master, 8.7 Change-Id: I12240cbd7ea571b1872effd6942a3bd65bf37a89 Reviewed-on: https://review.typo3.org/57537 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Susanne Moog authored
FormDefinitionValidationServiceTest modified the encryption key in test data-provider functions. Those functions are executed prior to actually executing the tests and causes side-effects during running the test suite. Resolves: #85539 Releases: master, 9.3, 8.7 Change-Id: I9fbd60905eb37470fa3661225b681476ff9df3c3 Reviewed-on: https://review.typo3.org/57570 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
