- Dec 03, 2016
-
-
Manuel Selbach authored
According to task #78437 queries should follow the prepared statement principle. Thus method BackendUtiltiy::getRecordsByField() has to be refactored to retrieve a queryBuilder which holds the parameter assigned to e.g. additional where clause, etc. otherwise the parameter and the dynamically generated placeholders in the queryQuilder will be reset. Change-Id: Id66d7b2fcfc5bcdca4d920b645c2285ded0c160a Resolves: #78704 Releases: master Reviewed-on: https://review.typo3.org/50664 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Michael Oehlhof authored
A "remove" button is added to the list of the installed languages. Resolves: #58637 Releases: master Change-Id: Ibd8911d2c58e449a026f52f4bd8b0b2d04bc2bbf Reviewed-on: https://review.typo3.org/50860 Reviewed-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
Alexander Stehlik authored
The condition that checks for CLI mode in the ext_tables.php of the install tool is fixed. The EnvironmentStatusReport is now active in the Backend and not on CLI. The additional checks added in #78786 are not required any more and are reverted. Change-Id: I4d364fc08c68c7c25d9210c08b813247bee7d47f Resolves: #78854 Relates: #78786 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50825 Tested-by:
-
Sascha Egerer authored
Selecting a file an the RTE linkhandler works but reopening the linkhandler ends with a fatal error as a file object is passed instead of string. Change-Id: I56972ef8d25e9add0c51e1b72fd7034c1140bc01 Resolves: #78782 Releases: master Reviewed-on: https://review.typo3.org/50767 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Alexander Stehlik authored
The ext-lang-am.js now has unique linux linebreaks. Before it had a mixture of windows and linux linebreaks. Change-Id: I4f74677c66611e2ca2143cf249934cb69b5e5ea5 Resolves: #78871 Relates: #77808 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50867 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Johannes Goslar authored
The temppath for gdlib and combineImages is different then all other image tests The assets/images path is set in imageMagickConvert for other image tests Releases: master Resolves: #77851 Change-Id: I4fec0422595045cfb5ca67a48f8e6dae79fc08d7 Reviewed-on: https://review.typo3.org/49864 Reviewed-by:
Gleb Levitin <gleb.levitin@dkd.de> Reviewed-by:
Manuel Glauser <mail@manuelglauser.ch> Tested-by:
-
Jan Helke authored
Moves most of the HTML from the PHP to an own Template. In fact in line 408 and in the function linkItemText are some remaining html tags, but removing those would require some major refactoring. Resolves: #73016 Releases: master Change-Id: Ie9859758885be0516ff8aeb58c473c5634848c81 Reviewed-on: https://review.typo3.org/46367 Tested-by:
Florian Mast <flo.mast@web.de> Reviewed-by:
-
Claus Due authored
This patch adds a check when processing the update reference index stack, in order to avoid calling the update function more than once with the same input arguments (which are $table and $uid). Saves around 100 SQL queries when doing a standard copy of 25 (nested) pages with 25 content elements. Change-Id: If162218d4eabb749a92270e18c7c39108fd15f34 Resolves: #78761 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50724 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
Anja Leichsenring authored
Respect the max length of 64 chars in sql if removing (renaming) an SQL table. Add unit test. Resolves: #78636 Releases: master Change-Id: I94f38c40f6539d5e53e2ac9bad5ed1c059836333 Reviewed-on: https://review.typo3.org/50865 Tested-by:
-
- Dec 02, 2016
-
-
Andreas Wolf authored
This changes the internal date processing for FormEngine and DataHandler to use ISO-8601 dates including a proper timezone. Dates are converted to ISO-8601 as early as possible and converted back to UNIX timestamps as late as possible. As before, the database values are always values in the server’s timezone, interpreted as UTC. Also, the client side inputs are interpreted as UTC. The main advantage is that once and for all we get rid of the timezone issues that may potentially arise if the server and client use different timezones. Additionally, the values are human readable (which is of course not so much of an issue for hidden fields) and we can directly use Moment.js for all heavy lifting. Another big advantage is that we can make the date formats configurable and decouple displayed dates and internally stored dates (by putting the Moment objects to the input fields). Change-Id: I3461915c2beaa96cd29c52c60e65a2e5005065b7 Resolves: #77702 Releases: master Reviewed-on: https://review.typo3.org/47124 Reviewed-by:
-
Claus Due authored
This patch fixes a problem where setting showAccessRestrictedPages setting in HMENU etc. did not result in the correct behavior according to documentation at https://docs.typo3.org/typo3cms/TyposcriptReference/MenuObjects/CommonProperties/Index.html. The patch changes the behavior caused by using `NONE` as keyword in the setting. Before: using the option renders `<a>Page title</a>` when page is inaccessible. After: using the option renders `<a href="index.php?id=123">Page title</a>` when page is not accessible. Change-Id: I4364f7ec9f44e1e0b70654830efc236f20e6bf30 Resolves: #17904 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50696 Reviewed-by:
-
Andreas Allacher authored
IRRE records have to point to their specific localized parent record. This works in general for tables containing records of the default language as well as localizations. For the "pages" table this look-up has to be extended to query from "pages_language_overlay". Change-Id: I84b6ee9304f85222430a5bdf62bd2271aae68fd5 Resolves: #76174 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/48495 Tested-by:
-
Daniel Windloff authored
- Change "Show" button to btn-default - Use infobox for missing files - Streamline button order and groups - preview / edit - history - opens list module Resolves: #78864 Releases: master Change-Id: I1e74b5e5d75a0678ab385b40f53802a30028980a Reviewed-on: https://review.typo3.org/50851 Tested-by: -
Markus Hoelzle authored
Respect the max length of 64 chars in sql if removing (renaming) an SQL table. Add unit test. Resolves: #78636 Releases: master Change-Id: I5f5d4b239f467a205edfdceeac97da5625631a83 Reviewed-on: https://review.typo3.org/50583 Tested-by:
Alexander Rothmund <alexander@rothmund.ch> Tested-by:
-
Claus Due authored
This patch reduces the number of SQL queries and PHP calls which get performed when rendering menus. The patch has two parts: * Runtime cache is used to remember a generated link and is given a cache identifier which includes a hash of all parameters which may affect the link. * Runtime cache is used to remember the decision if a page is a submenu. The item rendering function is called every time the same page is rendered in any menu in the same request, and the decision function to check if page is a sub-menu is called at least three times with the same UID when generating a menu. Both of these implements together reduce the necessary re-calling of methods which generate the same output given the same arguments. Change-Id: Idd6225081e8fb3f8160270af3d865b48208b756e Releases: master, 7.6 Resolves: #78693 Reviewed-on: https://review.typo3.org/50652 Tested-by:
Daniel Alder <dalder@snowflake.ch> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
-
Nicole Cordes authored
If a checkbox or a multiple selectbox is rendered, a hidden field is automatically inserted before to send an empty default value. Field information are stored within an own viewHelperVariableContainer variable. After a form is rendered, this information has to be reset to be able to render another form with same field names. This patch adds the missing reset of the hidden field information. Resolves: #78551 Releases: master, 7.6, 6.2 Change-Id: I3cde5618d07cae39b7841875504471cb2341dc17 Reviewed-on: https://review.typo3.org/50486 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
Michael Oehlhof authored
Resolves: #76408 Releases: master, 7.6 Change-Id: I20cfc02b588776f4e76980aa68dfe5c032103563 Reviewed-on: https://review.typo3.org/50786 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Kevin Ditscheid <kevinditscheid@gmail.com> Reviewed-by:
-
Wouter Wolters authored
Small other code cleanups are done as well. Resolves: #78861 Releases: master Change-Id: I983e1f76d8ad46dd4d6c231b99b41ab8f05fe454 Reviewed-on: https://review.typo3.org/50844 Tested-by:
-
Claus Due authored
Allows manually defining all options and optgroups for the f:form.select parent field as tag contents of the select field. The added ViewHelpers are TagBasedViewHelpers which means they support all standard HTML attributes. Note that while tag content rendering is now supported, it is *STILL* not possible to create ``<option>`` tags manually - you *HAVE* to use the form fields! Change-Id: I5f122f746a5309671ad0faf2feccda2d29fef4c7 Releases: master Resolves: #29399 Reviewed-on: https://review.typo3.org/48281 Reviewed-by:
-
Christian Kuhn authored
The suggest wizard does not work in FormEngine flex form section containers for existing containers. The patch splits the ajax controller action and the FormEngine wizard display into two classes to have a dedicated entry point for the ajax action and refactors the flex form field configuration search logic to find the correct configuration for existing containers, too. Change-Id: Ia870618629943b1f3c665cb3a10a7f3769a02540 Resolves: #78558 Releases: master Reviewed-on: https://review.typo3.org/50839 Tested-by:
Valentin Funk <valentin.funk@computerfabrik.de> Reviewed-by:
-
Helmut Hummel authored
TypoScriptFrontendController::reqCHash() is now called for Extbase frontend plugin actions just like they were usually called for the legacy AbstractPlugin. This throws a 404, if plugin arguments are present, but cHash is not, which would also happen, if the plugin arguments were added to "cHashRequiredParameters" configuration. This provides a more reliable page caching behavior by default and with zero configuration for extension authors. With the feature switch "requireCHashArgumentForActionArguments" this behavior can be disabled, which could be useful, if all actions in a plugin are uncached or one wants to manually control the cHash behavior. Resolves: #78002 Releases: master Change-Id: Ic6f71c3e5c8a94a0d422372a08c944aef5663f06 Reviewed-on: https://review.typo3.org/49976 Tested-by:
-
Kay Strobach authored
This settings enforces LF consistently on all plattforms and fits it to the .editorconfig Resolves: #77808 Releases: master, 7.6, 6.2 Change-Id: Ibc6efbf9a2a2360d84aa0ed4c3b74ff731ef1398 Reviewed-on: https://review.typo3.org/49791 Tested-by:
-
Michael Oehlhof authored
Moved all HTML from PHP code to an own Fluid template. Resolves: #78644 Releases: master Change-Id: I5351ce114618c4f9a56070e51df7ebe9de983a21 Reviewed-on: https://review.typo3.org/50642 Reviewed-by:
Daniel Windloff <daniel.jc.windloff@googlemail.com> Tested-by:
-
Markus Sommer authored
* Resolves the problem with many languages * Set width to min-width to enlarge the viewport Resolves: #78594 Releases: master, 7.6 Change-Id: I7360f620021d2614800f03da7960bb9acd2360e1 Reviewed-on: https://review.typo3.org/50525 Reviewed-by:
Gianluigi Martino <gmartino27@gmail.com> Tested-by:
-
Alexander Opitz authored
If there are many previewable languages on one page the modal dialog now will have a scroll bar for more than 4 entries, so it doesn't break the UI any more. Add 'modal-inner-scroll' class to modal 'show' call to let the JS framework handle the maximum height / scroll behavior. Resolves: #69637 Releases: master, 7.6 Change-Id: I59f91c4364d0d611c5822492b9ace513b1a45a33 Reviewed-on: https://review.typo3.org/49511 Tested-by:
-
Christian Kuhn authored
The new flex form data structure handling in more picky and throws exception if a given data structure identifier can not be resolved. The FormEngine logic that displays exclude fields of flex forms has to do some guess work to find possible data structures. This may fail, resulting in an exception. The patch changes the according general exception to a specific one, catches it in the find flex form access rights logic, and adds more docu on what exactly is happening in this code. Change-Id: I2b808cbe804ba4ab967c8d95b17c0a12ec65ffd4 Resolves: #78852 Related: #78581 Releases: master Reviewed-on: https://review.typo3.org/50820 Tested-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
-
Helmut Hummel authored
This commit ensures that the FormViewHelper is in a clean state and can render the required hidden fields (again). Resolves: #77097 Releases: master, 7.6, 6.2 Change-Id: I82f90ee7c0aaf44cd48a9abde6dbb012f536543e Reviewed-on: https://review.typo3.org/49104 Tested-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
-
Oliver Hader authored
Resolves: #78191 Releases: master Change-Id: I944601b8ccd2c2aa5c15bd7473eae5f4246d52a3 Reviewed-on: https://review.typo3.org/50845 Tested-by:
-
Michael Oehlhof authored
Resolves: #78764 Releases: master Change-Id: I0cdedd33540a917ba7744f3dad96c7b728967fad Reviewed-on: https://review.typo3.org/50726 Reviewed-by:
-
Wouter Wolters authored
This reverts commit 1d65ffe0. Resolves: #78856 Related: #78803 Change-Id: I5ef82b6b5c32de798b6d2677bc9a6dd6089d386a Reviewed-on: https://review.typo3.org/50843 Tested-by:
-
Wouter Wolters authored
Move missed parts during rebase in MoveElement.html Resolves: #78647 Releases: master Change-Id: I1e907235766fc83e735f3a452f375cf15bf61996 Reviewed-on: https://review.typo3.org/50842 Tested-by:
-
- Dec 01, 2016
-
-
Johannes Goslar authored
Remove support for transForeignTable and transOrigPointerTable in TCA. More details in Breaking-78191-RemoveSupportForTransForeignTableInTCA.rst Resolves: #78191 Releases: master Change-Id: Ibd7e1a963fdbf84ca7f4b5926b4a8cd02ba24631 Reviewed-on: https://review.typo3.org/50819 Reviewed-by:
-
Oliver Hader authored
Resolves: #78859 Releases: master Change-Id: I4b6ca84c119430d87d5d603ad07ccb8ea76f2f91 Reviewed-on: https://review.typo3.org/50840 Tested-by:
-
Andreas Fernandez authored
The method `BackendUtility::explodeSoftRefParserList()` checks whether `$parserList` is an empty string. This check may fail, as the variable may be null instead. `$parserList` is now casted to a string, which converts null to an empty string. Resolves: #78858 Releases: master, 7.6 Change-Id: Ia833fd64f3349c5856a879e917bb3cd6f581caa0 Reviewed-on: https://review.typo3.org/50838 Reviewed-by:
-
Claus Due authored
Solves an issue in Chrome where calculating the height of the editor window returns zero. Solved by hardcoding a minimum context menu height of 150 pixels; applied via Math.max()'ing the resolved height and 150. Change-Id: Ie79507d661128f6aff31c12573b9c020b913ec8a Resolves: #78795 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50779 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Michael Oehlhof authored
Resolves: #78756 Releases: master Change-Id: Ia2bb170811c310d16154529bb2d4af27a1c6412b Reviewed-on: https://review.typo3.org/50719 Reviewed-by:
-
Wouter Wolters authored
No need to call has on the caching framework in the function explodeSoftRefParserList. Furthermore we do not need to store false to the runtime cache if parseList is an empty string. Resolves: #78773 Releases: master Change-Id: Iaa3fae35d4d07a78eb0fde8efc892a9ddb46b974 Reviewed-on: https://review.typo3.org/50752 Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Robert van Kammen <rvkammen@hotmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Wouter Wolters authored
Resolves: #78814 Releases: master Change-Id: I18475fa8daa006e8887cf4b1c3855bf0e870fdc6 Reviewed-on: https://review.typo3.org/50769 Tested-by:
-
Benni Mack authored
The method GeneralUtility::callUserFunction() method allows to call "&" to put this logic into a "persistent" pool. We already have the SingletonInterface which should be used for objects that should be persistent. Currently there are two "persistent object pools", one for makeInstance and one for callUserFunc, which makes it very hard to understand which object is used when. Reducing complexity and using the SingletonInterface everywhere should be the best practice. Resolves: #78733 Releases: master Change-Id: I6d3c57056c2b5ab411a9b9f488dc48c757b4a148 Reviewed-on: https://review.typo3.org/50693 Reviewed-by:
-
Oliver Hader authored
Resolves: #75184 Releases: master, 7.6 Change-Id: Iff4ea23dfc1e8d96c45ba675aab6484830468718 Reviewed-on: https://review.typo3.org/50836 Tested-by:
-
