- Aug 27, 2021
-
-
Helmut Hummel authored
The idea of this change is, that when using Composer, all TYPO3 extensions, that are part of the Composer installation, should be considered as active and there is no need whatsoever to install code of an extension with Composer (and making all its classes available), but not wanting the extension to interact with TYPO3 API. Therefore with this change, all TYPO3 extensions installed with Composer are considered to be active (and therefore can and will interact with TYPO3 API). Additionally, since the list of active extension is known during Composer installation, a persistent artefact is created at this point, which represents the final state of TYPO3 extension packages for the PackageManager, making both, the PackageStates.php file and the PackageManager cache obsolete for Composer managed TYPO3 installations. Note any extension present in the typo3conf/ext folder, but not installed by Composer, will still be considered and marked as part of TYPO3 packages when doing a "composer install". The only requirement here is, that such extensions need a composer.json file nonetheless. Note this behaviour is deprecated and will be removed with TYPO3 12. Additionally the extension manager UI is adapted to not allow changing the active state of extensions anymore. Respectively the commands "extension:activate" and "extension:deactivate" are disabled in Composer managed systems as well. A new cli command "extension:setup" is introduced, which supersedes both, the extension manager UI as well as the activate/deactivate commands. It performs all steps that were done before, except changing the active state of an extension. With cli command "extension:setup" ALL extensions are set up in terms of database schema changes, static data import, distribution files imports, etc. Last but not least, any installed Composer package, that defines an extra.typo3/cms section in their composer.json file, but is not of type "typo3-cms-extension" at the same time, will be considered for TYPO3 and will have full access to TYPO3 API. It has to be noted though that such packages can not deliver public resources. This remains exclusive for TYPO3 extensions for now. Releases: master Resolves: #94996 Change-Id: I919873dd4ddd087c943f1289a12253c6acec7fa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69174 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
- Aug 10, 2021
-
-
Larry Garfield authored
The channel field is more flexible than types, and will be populated by PSR-3 loggers as well. Switch belog to use that instead of the old type ints. Resolves: #94439 Relates to: 94356 Releases: master Change-Id: Ia834a63be88e17aaca62d806940d0404273050ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69663 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Jul 19, 2021
-
-
Benni Mack authored
Resolves: #94571 Releases: master Change-Id: Ic84bf7ba69ef5b020f91661ff5387ef4b62f34f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69905 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- Jun 30, 2021
-
-
Christian Kuhn authored
The patch changes the extbase Mvc/Request to implement PSR-7 ServerRequestInterface: The former extbase request details like 'controllerAction' are changed to an PSR-7 attribute and the Request class is now a decorator - it receives the original PSR-7 request as constructor argument, then implements both the extbase RequestInterface plus PSR-7 ServerRequestInterface. This way, the Request object itself does not hold state (except the original request), but channels all get* and with* calls to the PSR-7 request object. This avoids creating a new standalone object and moving all data from the PSR-7 object into the new object. The patch is relatively conservative. The extbase related set* methods are kept even though they're all @internal and violate immutability, and various method signatures are not adapted towards strict typing, yet. The reason for that are various chain- and loop dependencies especially in fluid view that should be solved with single patches before extbase Request can be streamlined further. Current usages also rely on fallback layers within __construct(), which can be solved when consuming places are adapted - The patch would have become much bigger if that would be mixed in. Change-Id: I218de0ee30d16245e7d562d0aba2795ccc439901 Resolves: #94428 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69545 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jun 28, 2021
-
-
Benni Mack authored
In order to make TYPO3 Core compatible with doctrine/dbal 3.0, Core now requires doctrine/dbal 2.13 to allow to track all deprecations and use the forward-facing APIs. Used composer commands: * composer req doctrine/dbal:^2.13 * composer req doctrine/dbal:^2.13 -d typo3/sysext/core --no-update * composer req doctrine/dbal:^2.13 -d typo3/sysext/install --no-update * composer req doctrine/dbal:^2.13 -d typo3/sysext/redirects --no-update Resolves: #94423 Releases: master Change-Id: Ifede8ebdac0b47a0db0ba5d304878c91c3579f58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69632 Tested-by:
-
- Jun 21, 2021
-
-
Jochen Roth authored
Will fix creation/edit content as well as publishing workflow for workspaces and add a basic ac test for page change, switch workspace and publish Also EXT:workspaces is now enabled in test environment Resolves: #94361 Releases: master Change-Id: I9f85a4edaa90e77cbdfc5f988007917263ed51ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69508 Tested-by:
-
- Jun 09, 2021
-
-
Oliver Hader authored
`GeneratorClassesResolver` used for the extension scanner preprocesses `GeneralUtility::makeInstance` calls, transforms class-string values to their corresponding class-constants and provides a low-level class instantiation using `new`. When modifying PHP parser nodes, only expected types shall be used, which is `ClassConstFetch` instead of `FullyQualified`. Resolves: #94283 Releases: master Change-Id: I3a802212dc067c5ced0e03aa2cce6519d5ed1dbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69403 Tested-by:
-
- Jun 01, 2021
-
-
Daniel Goerz authored
composer req friendsoftypo3/phpstan-typo3 ^0.8.1 --dev This patch is the next step towards full level 3 compatibility of the TYPO3 core. Releases: master Resolves: #94127 Change-Id: I5092ce3a9248a7e5ecba3f42183765c1b1d5b1cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69327 Tested-by:
-
Daniel Goerz authored
* EXT:core Resolves: #94122 Releases: master Change-Id: I843e50719c5e5a2c3de425f49eae2f112e0df32f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69321 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- May 31, 2021
-
-
Christian Kuhn authored
A minor raise from 2.6 to 2.7 brings an aria related feature and a cleanup we adapt in core. composer req typo3fluid/fluid:^2.7.0 Resolves: #94242 Releases: master Change-Id: I9b479c33aa5183ea2bad845452dfa8cba52245e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69334 Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
- May 04, 2021
-
-
Daniel Goerz authored
Resolves: #94059 Releases: master Change-Id: I9687dddef9889d79359e64987e8886a305d3149f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69016 Tested-by:
-
- Apr 27, 2021
-
-
Daniel Goerz authored
Resolves: #93997 Releases: master Change-Id: Idf0591125371cc25f53b8c9cc178a5c595c7be2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68887 Tested-by:
-
Alexander Schnitzler authored
Update phpstan to version 0.12.84 and fix new issues detected by the new version. Releases: master Resolves: #93979 Change-Id: I7546fedf79656561369008765b303cfb9af246d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68850 Tested-by:
-
- Apr 21, 2021
-
-
Daniel Goerz authored
Releases: master Resolves: #93955 Change-Id: Idb5e338c7a1e34f1197d38d01bec5f8735509e8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68834 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Apr 20, 2021
-
-
Daniel Goerz authored
Resolves: #93704 Releases: master Change-Id: I24067c4b705c671b87a9bbdfed30535a39528879 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68359 Tested-by:
-
- Mar 12, 2021
-
-
Daniel Goerz authored
Remove entries from phpstan.neon for ignored errors that have been fixed meanwhile. Parameter reportUnmatchedIgnoredErrors finds those, but it is false by default. We may drop that parameter with a dedicated patch, but are currently not sure why it is commented as 'needed for bamboo' at the moment. Resolves: #93711 Releases: master Change-Id: I9439b2144f60f0a4021b307ef5bacaa23801880e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68358 Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
- Mar 11, 2021
-
-
Daniel Goerz authored
From now on, phpstan will validate arguments passed to methods for type integrity. This patch also resolves all remaining issues in the core up to PHP 7.4. Running phpstan on PHP 8 is therefore disabled temporarily and will be enabled again with another patch that resolves all remaining PHP 8 issues regarding argument types. Resolves: #93652 Releases: master Change-Id: I2cbd15c5e83ae188a4d453c71b5841d424b2eef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68191 Tested-by:
-
- Jan 26, 2021
-
-
Christian Kuhn authored
Allows: * Build/Scripts/runTests.sh -s docBlockCheck * Build/Scripts/runTests.sh -s phpstan These two have been added to bamboo with #89023, but not to runTests.sh. phpstan is tuned a bit to create it's cache in .cache rather than ephermal /tmp to survive between host reboots. Additionally the number of max CPU's is restricted in phpstan to be a better neighbor on local dev machines and on CI. Resolves: #93367 Related: #89023 Releases: master, 10.4 Change-Id: I5672370b51205266ee46888837f151de8e809edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67534 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
-
- Jan 04, 2021
-
-
Jörn Wagner authored
Make all the necessary changes to classes used during the first installation to run on PHP 8 Resolves: #93205 Releases: master, 10.4 Change-Id: I93f64b2848e4cea76a4f36d11d394cb09fd8301c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67227 Tested-by:
-
- Oct 29, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92273 Change-Id: Ifb45f980a08efd79f5e3f288e0f20e1ac283e1f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65664 Tested-by:
-
- Sep 26, 2020
-
-
Alexander Schnitzler authored
Since all level 2 rules are active and only level 2 parameters are set to different values compared to their originally declared value, the whole file can be removed, the overall phpstan level can be raised to 2 and the parameters can be defined in the main phpstan file. Releases: master, 10.4 Resolves: #92424 Change-Id: I8404f5f2f4ff318bb3419ed307b1ffe7edcc6822 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65902 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
- Aug 13, 2020
-
-
Alexander Schnitzler authored
Updating phpstan to version 0.12.37 lets phpstan benefit from static reflection which does no longer come with the need to load analyzed classes and use the native reflection api of php. Instead, roave/better-reflection is used, which does a better job and reduces false positives. Since phpstan has been updated, the rules which have been copied over from the vendor package had to be updated as well. And since phpstan does find more errors now, a few rules had to be disabled again. Used commands: - composer require phpstan/phpstan:^0.12.37 --dev - composer require friendsoftypo3/phpstan-typo3:^0.4.0 --dev Releases: master Resolves: #91635 Change-Id: Ia6b68e7ed1428fbc40ae4d1b9eb3a13d212a3a5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64851 Tested-by:
-
- Apr 16, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90910 Change-Id: If03889ee330e96c5ca82b31ae0604fb1d1d0afc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64031 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Apr 08, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90913 Change-Id: If38a526547518e93b3002ffa01accebf4a12e5b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64032 Tested-by:
-
- Apr 07, 2020
-
-
Daniel Siepmann authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018 several @var annotations have been adjusted to reflect the actual used type of properties. This however led to the issue that several properties of Extbase models had one type as annotation but used more than one specific type internally. Adding the additional type made phpstan happy but broke the property mapper of Extbase, which expects just one type to be annotated via @var. Therefore, the @var annotations in the affected models have been reverted to their original state and the reoccurring errors have been put onto phpstans list of ignored errors. Resolves: #90969 Releases: master Change-Id: I91944a631b9e1ff300ada25953577d852a998270 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094 Tested-by:
-
- Apr 02, 2020
-
-
Alexander Schnitzler authored
Several issues have been ignored because of checks on runtime constants which vary from context to context. Since we can only simulate one context, phpstan is unable to properly detect several paths. Releases: master Resolves: #90909 Change-Id: Ie3213112a299559687f27317821453137cd5322a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64030 Reviewed-by:
-
- Mar 27, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90802 Change-Id: I84da713c7b8c68ae67b6b9c33ad66dcbac8d72bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63810 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
- Mar 23, 2020
-
-
Alexander Schnitzler authored
Used command: composer require friendsoftypo3/phpstan-typo3:"~0.2" --dev Releases: master Resolves: #90811 Change-Id: Ibd9ae856e8046edc67cb7610956ede92c474bf12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63846 Tested-by:
-
- Mar 20, 2020
-
-
Alexander Schnitzler authored
As there are a lot of rules that do not raise any errors with our code base, those rules up to level 8 are enabled with this patch resulting in more pre merge tests being executed as of now. Releases: master Resolves: #90795 Change-Id: I3628569c90e1e7bbf2ffde81abbef37065bd45e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63812 Tested-by:
-
Alexander Schnitzler authored
This patch simply pulls out the level 2 rules into a separate configuration file which is a copy of the original level 2 configuration file of phpstan with some rules, services and parameters disabled. Also, additional configuration files are put into the Build folder and phpstan.neon has been added to the .gitattributes file. Releases: master Resolves: #90789 Change-Id: Ia3b3c30cfa57227c0607904df38add31f36be0e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63802 Tested-by:
-
- Mar 08, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90668 Change-Id: I92cc4942f9f06d587a7957a94f006d157143e55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63569 Tested-by:
-
- Mar 06, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90665 Change-Id: I55c08b826d6e4560cbfbcde99e795f55036b049c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63565 Reviewed-by:
-
- Mar 02, 2020
-
-
Alexander Schnitzler authored
phpstan reported superfluous usages of isset checks for variables that are defined and whose type is more specifically checked in the same condition. Some reported errors of phpstan have been ignored for now as they are considered false positives and which will be tackled once there is more type safety in the context of those reported errors to be able to properly replace the isset checks. Releases: master Resolves: #90576 Change-Id: I028a928bcbc18185f69f7bda4358aaf08cc016b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63481 Tested-by:
-
- Feb 28, 2020
-
-
Alexander Schnitzler authored
This patch introduces a bootstrap file for phpstan to define missing constants phpstan would report otherwise. A dedicated config file phpstan.typo3.neon has been introduced because there are plans to release a seperate configuration package that not only the core uses but which is also useful for TYPO3 users that test their codebase with phpstan. Releases: master Resolves: #90575 Change-Id: I1c5bce558c882f9dd002e480d78405770bdf8cc0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63480 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Feb 27, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90558 Change-Id: I9a02974eb3c4efc242d83f0610f7fc15764b30b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63042 Tested-by:
-
- Feb 23, 2020
-
-
Daniel Goerz authored
Resolves: #90500 Releases: master Change-Id: Ieaecff065dcc60c4e8e7c7a19d87fe5a8d18cd40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63384 Reviewed-by:
-
- Feb 21, 2020
-
-
Alexander Schnitzler authored
This patch ignores several errors found by phpstan which are not easy to solve as of now or which are not solvable at all. - Unsafe usage of new static Those errors can be solved in different ways. Making classes final, making constructors final or using new self. Which solution is used has to be decided by people who are familiar which the affected files. - Call to an undefined method in AbstractWidgetViewHelper and AbstractViewHelper Those issues aren't solvable as those methods exist if users choose fluid ^3. - Access to undefined constant TYPO3\CMS\Core\Type\Enumeration ::__default This issue can't be solved as the Enumeration class does a lot of magic stuff which isn't compatible with static code analysis. Releases: master Resolves: #90402 Change-Id: Ie4a1623d42cb37d30082275ca1a09a733301d06e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63276 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de>...>
-
- Feb 19, 2020
-
-
Alexander Schnitzler authored
Bleeding edge configuration may be useful to use but shouldn't be enabled by default. To make the inclusion convenient, the include has only be commented and not be removed at all. Releases: master Resolves: #90403 Change-Id: I9a8dfdef29947df890db92d331f1b4b27d13b736 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63277 Tested-by:
-
- Feb 15, 2020
-
-
Alexander Schnitzler authored
Upgrade phpstan/phpstan to at least 0.12.10 and enable bleeding edge configuration to be able to run the phpstan analysis with all available cpu cores. Releases: master Resolves: #90378 Change-Id: I4c76a8f44c570b126844d1bde96998cf9d3790fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63253 Tested-by:
-
- Jan 17, 2020
-
-
Alexander Schnitzler authored
This commit introduces a development requirement to phpstan/phpstan to enable static code analysis. A basic configuration file has been added as well to identify most basic errors in the TYPO3 code base. Releases: master Resolves: #90097 Change-Id: I87e11eca6296864fdd7ba8cd109a23b82c27f641 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62851 Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Felix P. <f.pachowsky@neusta.de> Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
