Change-Id: I68f99111a53217f6b05ac6656b84763051516402
Reviewed-on: http://review.typo3.org/11510
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

Change-Id: I5018a3800a8a3553251ae0a79dfec7e7e5e9cb15
Reviewed-on: http://review.typo3.org/11438
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team

If PHP warnings are not catched, file_get_contents issues a warning
message whenever a file cannot be retrieved.

Change-Id: Ibecfebf5ff4c89ca6c7c43370d87fc4e546a02c1
Fixes: #36976
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/11093
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader

These require_once calls are needed to make the exception classes
available even if the autoloaded is not loaded at this point yet.

The comment point this out and (hopefully) keeps people from deleting
the require_once calls as part of some clean up.

Resolves: #37335
Relates: #23444, #36061

Change-Id: Ie226b67f44ea0c3cbd17fa9e52018dbf8d8b58d4
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11340
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I063ff48e2f1d6f9dceaf910405d2f510818120c0
Fixes: #37324
Releases: 6.0
Reviewed-on: http://review.typo3.org/11337
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Copying large branches (500+ pages, depending on the server) has a big
problem: The AJAX request is answered too late (after Ext.Direct
timeout), so Ext.Direct will resend the request. This will copy the
branch once again. So the copied branch appears twice after copying.

The whole process fails with a connection timeout error message and the
user has to reload the page tree.

Change-Id: If0307586ec3196c3c3dedde92cfb6aee07bc9064
Resolves: #26993
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8981
Reviewed-by: Stefan Neufeind
Reviewed-by: Stefan Galinski
Reviewed-by: Philipp Gampe
Tested-by: Stefan Galinski
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Fix some CGL violations in class.browse_links.php against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Change-Id: Ie0d3e471cb7ff443269c0d391b3a40752ce29ad3
Resolves: #37327
Releases: 6.0
Reviewed-on: http://review.typo3.org/11328
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix some CGL violations in alt_clickmenu.php against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Change-Id: Ie7b6da34e1ce1a0ecd23aaac29476dde13a7afd8
Resolves: #37323
Releases: 6.0
Reviewed-on: http://review.typo3.org/11323
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up the phpDoc of t3lib_fullsearch

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I0889c1272feda994e564d28704a6c31b6494c230
Resolves: #37326
Releases: 6.0
Reviewed-on: http://review.typo3.org/11325
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix some CGL violations in /tests/ against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Change-Id: I5a35bf48de79d9f1a7945b2191b5be9bd94146c8
Resolves: #37319
Releases: 6.0
Reviewed-on: http://review.typo3.org/11317
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Characters with a special meaning must be properly quoted
if they appear in a regular expression.

Change-Id: I2587acb9d0f61a441be6e13dcaba7b7ca0fc82bc
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #35410
Reviewed-on: http://review.typo3.org/10103
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

versionOL in t3lib_tstemplate can cause a fatal error for
scripts like eID that run in frontend mode, but without a full
blown frontend environment.

The patch replaces the frontend check with a more specific test
for the required methods.

Change-Id: Ib3f9ebf355ee820e5144dd484d9a3a5e7708ebd4
Related: #31139, #25144
Resolves: #36981
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11096
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

The patch introduces a shutdown method to the bootstrap that
can be used to perform clean up and shutdown things at the
end of a script run. It is used in the most important entry
scripts like FE, mod.php, cli and backend.

First usage of shutdown() is the autoloader: If new classes are found
during script run, for example because they stick to the extbase naming
scheme and do not have a ext_autoload entry, the autoloader wrote a new
cache file for each class it found. Now, the autoloader remembers that
the cache file should be updated and delays of writing the cache file
until it is unregistered.
This way the full cache entry is only written once during shutdown.

Change-Id: Ibb84a7db65eb28e792c0b5ee9bedec00b29dbbb9
Resolves: #37268
Releases: 6.0
Reviewed-on: http://review.typo3.org/11279
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Releates to #36784 which would have brought some basic tests.
This patchset now has full coverage for the entire functionality
of callUserFunction and #36784 can be reduced to its actual purpose.

Change-Id: I02cfe3e963f90aa3c3986e57bdba4a08c6e4c0d5
Resolves: #37317
Releases: 6.0
Reviewed-on: http://review.typo3.org/11316
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

MySQL allows a maximum of 64 characters for column and table names.
When prefixing them with 'zzz_deleted' this limit might be reached
by accident. (e.g. with
'zzz_deleted_tx_powermail_tellAFriendForm_receiverEmailContentField')

The patch avoids the overstepping 64 characters.

At the same time the prefixed and shortened field names are more
likely to have the same name, therefore the names are cut
from the beginning.

Change-Id: Id423a5bc0bee8509c6da89793812b1399d6a14c0
Fixes: #33580
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/8791
Reviewed-by: Oliver Klee
Reviewed-by: Xavier Perseguers
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Adds tests for htmlspecialchars_decode, deHSCentities, slashJS,
rawUrlEncodeJS, rawUrlEncodeFP, strtoupper and strtolower.

Change-Id: I1c68da9ac6bb187c1db559da03a2de6b20c4ab46
Resolves: #37315
Releases: 6.0
Reviewed-on: http://review.typo3.org/11315
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

There were a lot spacing CGL violations in /typo3/sysext/.
These will be reduced by this commit.

Change-Id: Iae4dc7bfbca79f5e71446d850eebfceeb20e4a18
Resolves: #37310
Releases: 6.0
Reviewed-on: http://review.typo3.org/11311
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

There were a lot spacing CGL violations in /t3lib/.
These will be reduced by this commit.

Change-Id: I66981be01ecb4f289de2ccbc0363d2f02bd98f6a
Resolves: #37309
Releases: 6.0
Reviewed-on: http://review.typo3.org/11310
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

There were a lot spacing CGL violations in /typo3/.
These will be reduced by this commit.

As there are really a lot of violations this fixes
these, which are NOT in /typo3/sysext/.

Change-Id: I71184548d54880905407ab6a80ac3feeee1123ee
Resolves: #37308
Releases: 6.0
Reviewed-on: http://review.typo3.org/11309
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

There were a lot spacing CGL violations in
class.tslib_menu.php. These will be reduced by
this commit.

Change-Id: I0c925ad2706d597906e830464f22a7ee939c6e98
Resolves: #37307
Releases: 6.0
Reviewed-on: http://review.typo3.org/11308
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

There were a lot spacing CGL violations in
tslib_fe.php. These will be reduced by this commit.

Change-Id: Id105b331df8a7970b52113228a6ab3bfda974e4e
Resolves: #37304
Releases: 6.0
Reviewed-on: http://review.typo3.org/11305
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up the phpDoc of t3lib_div

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I682d552d7cbf7ee3882f93d608390a50d57b1c41
Resolves: #37305
Releases: 6.0
Reviewed-on: http://review.typo3.org/11304
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

There were a lot spacing CGL violations in
class.tx_impexp.php. These will be reduced
by this commit.

Change-Id: I075a5ef7df9f2f33d89f90db409bc788a4786410
Resolves: #37306
Releases: 6.0
Reviewed-on: http://review.typo3.org/11306
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Some of the most basic functions should be covered with unit tests.

The change creates tests for inArray, array_merge, remapArrayKeys
and keepItemsInArray.

Change-Id: Id57148bc0d0418ed7308b9647c63af2d82ec94f2
Resolves: #37299
Releases: 6.0
Reviewed-on: http://review.typo3.org/11298
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

Some of the most basic functions should be covered with unit tests.

Change-Id: If9466ebdf9d7177de298db14c5460cddfcc5cbe1
Resolves: #37297
Releases: 6.0
Reviewed-on: http://review.typo3.org/11296
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

There were a lot spacing CGL violations in
/typo3/alt_clickmenu.php. These will be reduced
by this commit.

Change-Id: I5c209b0f05843412820d81f317ef7fafe19cadfc
Resolves: #37303
Releases: 6.0
Reviewed-on: http://review.typo3.org/11303
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_tsfebeuserauth.php
* t3lib/class.t3lib_tsparser.php
* t3lib/class.t3lib_tsparser_ext.php
* t3lib/class.t3lib_tsparser_tsconfig.php
* t3lib/class.t3lib_tsstyleconfig.php
* t3lib/class.t3lib_tstemplate.php
* t3lib/class.t3lib_xml.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I312660e9da1964cff90b3998155d77bb3f4f0edd
Resolves: #37291
Releases: 6.0
Reviewed-on: http://review.typo3.org/11289
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_svbase.php
* t3lib/class.t3lib_syntaxhl.php
* t3lib/class.t3lib_tceforms_fe.php
* t3lib/class.t3lib_timetrack.php
* t3lib/class.t3lib_timetracknull.php
* t3lib/class.t3lib_transferdata.php
* t3lib/class.t3lib_transl8tools.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I30f3f6819505751ff9339e0584ee58bff2944cc8
Resolves: #37290
Releases: 6.0
Reviewed-on: http://review.typo3.org/11288
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up the phpDoc of t3lib_stdgraphic

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ic5797a1a33e75d1f8f474e855ba78198f4350c36
Resolves: #37289
Releases: 6.0
Reviewed-on: http://review.typo3.org/11287
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_refindex.php
* t3lib/class.t3lib_scbase.php
* t3lib/class.t3lib_softrefproc.php
* t3lib/class.t3lib_sqlparser.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I1297ce2e244c7d19c590537d93b090f75a6043ce
Resolves: #37288
Releases: 6.0
Reviewed-on: http://review.typo3.org/11286
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Corrects several whitespace related issues.

Special focus lies on files
* typo3/class.db_list_extra.inc (127 violations)
* typo3/template.php (148 violations)
* EXT: rtehtmlarea/class.tx_rtehtmlarea_base.php (129 violations)

Sonar / metrics terms to be improved:

* OpeningFunctionBraceKernighanRitchieSpaceBeforeBrace
* FunctionCallArgumentSpacingSpaceBeforeComma
* FunctionCallArgumentSpacingTooMuchSpaceAfterComma
* SemicolonSpacingIncorrect

Change-Id: I18a971c64e62ad976d9da5daf6d9a4d5aa463425
Fixes: #37295
Releases: 6.0
Reviewed-on: http://review.typo3.org/11295
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

The fix for issue #35260 introduced a new bug in method
t3lib_TCEmain::getPreviousLocalizedRecordUid() by adding a
field in a query in the wrong place. In particular, this breaks
the localization of tt_content elements used with IRRE.

This patch fixes the problem by separating the list of fields
used for selecting and for sorting.

Change-Id: I66101071a0320b7c2b1826c3422e7bf99671a122
Fixes: #37221
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11250
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch

Change-Id: Id5bf3756e215b50eb9d789648b2bca57bb8bb712
Resolves: #37264
Releases: 6.0
Reviewed-on: http://review.typo3.org/11277
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

If no cli key is given, cli_dispatch.phpsh exits with a generic
error message that a key must supplied to run the script. If a
key is given, but it is no registered cli script, the script
exits with a list of valid keys.

The patch removes the first test to also show the list of valid
keys if there is no key at all and adapts the error message a bit.

Change-Id: I4d356a1837218aaeb92ef85d9c5b8833b2737e08
Resolves: #37238
Releases: 6.0
Reviewed-on: http://review.typo3.org/11263
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Klee
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in typo3/sysext/install/mod/class.tx_install.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Iad13d9b4f2bad80cb7921ae44f46c3723f82cc20
Resolves: #37254
Releases: 6.0
Reviewed-on: http://review.typo3.org/11274
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in class.tslib_fe.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Ib4a8d95b99e06e1342a4f5c5a53df5582a9b7d86
Resolves: #37253
Releases: 6.0
Reviewed-on: http://review.typo3.org/11272
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_parsehtml_proc.php
* t3lib/class.t3lib_positionmap.php
* t3lib/class.t3lib_querygenerator.php
* t3lib/class.t3lib_readmail.php
* t3lib/class.t3lib_recordlist.php
* t3lib/class.t3lib_registry.php
* t3lib/class.t3lib_rteapi.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I42a5b48a8eda5d77605a963ba8168d1d4342fa5f
Resolves: #37252
Releases: 6.0
Reviewed-on: http://review.typo3.org/11271
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Change-Id: I255e5067c3d2608870e4b35d35faf305af0f6b22
Releases: 6.0
Resolves: #37250
Reviewed-on: http://review.typo3.org/11269
Reviewed-by: Ingmar Schlecht
Tested-by: Ingmar Schlecht

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_pagerenderer.php
* t3lib/class.t3lib_pagetree.php
* t3lib/class.t3lib_parsehtml.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I56ffee774456d7712cf68cbd74652aad1b0f07bb
Resolves: #37242
Releases: 6.0
Reviewed-on: http://review.typo3.org/11265
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

Fix some cgl flaws that slipped through during the bootstrap refactoring.

Change-Id: Id2d122d0afdb3e0e1091a13eeecf62c1c67236f4
Resolves: #37236
Releases: 6.0
Reviewed-on: http://review.typo3.org/11261
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn