- Jul 05, 2024
-
-
Andreas Nedbal authored
Resolves: #104313 Releases: main Change-Id: I17bb0ab444ef180434847a03561aac0414c7af27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85111 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benni Mack authored
This change reduces BackendUtility calls in DataHandlerHook of EXT:workspaces towards complete TcaSchema usage. Resolves: #104307 Related: #104002 Releases: main Change-Id: I161325bc62d91e91fef6d75618628cb85fabf983 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85099 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
The debug information of each element in FormEngine now displays the correct field names for FlexForm fields in a container. Additionally, do the container elements itself display the correct (field) name now. Resolves: #104303 Releases: main, 12.4 Change-Id: Ic2a92bc0deea4b3165f4aa77103c56050cb3dc63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85096 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
- Jul 04, 2024
-
-
Benjamin Franzke authored
The cache.assets container entry was pregenerated in Bootstrap for historic reasons: it used to be statically injected into the IconRegistry and PageRenderer from Bootstrap::init(). This has been refactored with #93475 and #97030, therefore assets cache generation can now be delayed until it is actually needed. Note: It is needed in uncached installtool context, therefore it is provided in ServiceProvider.php instead of Services.yaml Resolves: #104305 Related: #93475 Related: #97030 Releases: main Change-Id: I3a0f1a5b6f01ed19da79d2547b418029d68bf0f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85102 Tested-by:
-
Guido Schmechel authored
An example for the addition of multiple CSS classes to editor.config.style will be added to the existing RST files. Resolves: #104310 Releases: main, 12.4 Change-Id: I8a77aae8c402608857b3b7ea690da23f4f8134c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85107 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Benni Mack authored
The method getTcaFieldConfiguration is the first to fall in BackendUtility as we now have a new API for accessing information from TCA. The last pieces have been migrated. Historical fun fact: This method was introduced with TYPO3 4.x to add support for IRRE in Workspaces in 2010 by ohader: "Add feature #16374: Implement Inline Relational Record Editing (IRRE) in Workspaces" Kudos for this tremendous effort. Resolves: #104304 Related: #104002 Related: #16374 Releases: main Change-Id: I5c38592777ca4ee64e5a9155e338e17322ae452c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85100 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Georg Ringer authored
Use a local variable to remember the path of a file before it is moved and use that in the flash message and log. Resolves: #104194 Releases: main, 12.4 Change-Id: Ib13eb28e5d8674ce1fe3df0ab29a9cd5c3b72c78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84923 Reviewed-by:
-
- Jul 03, 2024
-
-
Oliver Bartsch authored
This adds new fields to EXT:styleguide for testing TCA type `file` in FlexForm. Additionally, this also properly tests that TcaPreparation is working for `file` in FlexForm context. This includes the `columnsOverrides` and `overrideChildTca` functionality as well as the special allowed / disallowed evaluation and corresponding placeholder replacement. Resolves: #104301 Releases: main Change-Id: I96b41c95898d6782d362e6a4f9140f5ab5419d62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85094 Tested-by:
-
Garvin Hicking authored
It is possible in Flexform containers to set a XML configuration that uses the same input field names, but within different sheets. The `FlexFormSectionContainer::render()` method used a HTML DOM id attribute that did not consider the Flexform sheet name, which has lead to the same id attribute being re-used. The JavaScript events (add and delete items from a container) would then fire only on the first instance, but as many times as there were wrongly regarded "duplicate" containers using the same id. This fix introduces another identifier section to the id attribute, containing the Flexform sheet name. This XML attribute is compatible with allowed CSS class names, so no further escaping is done with it, similar to the use of `$flexFormFieldName`. Resolves: #97042 Related: #99947 Releases: main, 12.4 Change-Id: Ic1c81c658b090cb7b9c1a4230c0b4e75c12560dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85083 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Central single flex datastructure field TCA migration and preparation has been established with #104293. This patch refactors the code another time to avoid a recursion, merges the two traverse operations into one construct, and checks for not supported data structure setups like section containers defining TCA types with DB relations. Those checks for invalid data structures were previously located within FormEngine related TcaFlexProcess, and are now relocated to the more central FlexFormTools. Resolves: #104300 Related: #104293 Related: #102970 Releases: main Change-Id: Iba0bef3bee09d350e258d69c987e754a56297297 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85092 Tested-by:
-
- Jul 02, 2024
-
-
Stefan Bürk authored
Activating a package (extension) involves a change in the TCA structure and the `PackageActivationService` ensured to create all tables and fields based on the added package. With replacing more and more TCA related functionality throughout the core with the recently added TCA Schema, it's now vital to rebuild the schema based on changed global TCA structure. This change uses the TcaSchemaFactory in the mentioned service to ensure this. Resolves: #104298 Related: #104002 Releases: main Change-Id: I847dff8fbec0f30a261ca8bda77bd404b9c2b2c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85091 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Stefan Bürk authored
This change modifies the `php-cs-fixer` ruleset and activate two rules related to nullable types. Following options are added: 'nullable_type_declaration' => [ 'syntax' => 'question_mark', ], 'nullable_type_declaration_for_default_null_value' => true, `nullable_type_declaration` ensures to use `?<type>` declaration instead of union type `<type>|null` as a convention for properties, method and return types. For already union types the nullable is added as additional null union type `ObjectOne|ObjectInterface|null`. `nullable_type_declaration_for_default_null_value` ensures to use nullable type declarations to mitigate implicitly nullable method arguments [1] which has been already fixed with a series of dedicated changes. Used command(s): Build/Scripts/runTests.sh -s cgl [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #103751 Releases: main, 12.4, 11.5 Change-Id: Ia790a6757c5fbe92da45298333037c5b5d36575d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84073 Tested-by: -
Georg Ringer authored
Instead of showing outdated versions above the listing of wizards, use the actual version. Resolves: #104289 Releases: main, 12.4 Change-Id: Ife6486978010a7e4b85238722125734abd9c6082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85075 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104284 Releases: main, 12.4, 11.5 Change-Id: Iadea4cde1d3b80962a47ffa4c183a885504bef6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85052 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Stefan Bürk authored
Since Doctrine DBAL 4 field types are no longer communicated based upon column comments [1]. Database vendors not supporting certain types, for example JSON in case of SQLite, the type retrieved from reading the database schema does not match when compared with the virtual database column type. Doctrine internally mitigates this by using a new way of comparing the compatible create statements for the database vendor. Sadly, this comparison has been disabled and circumvented during the Doctrine DBAL 4 upgrade and still cannot be removed until open issues have been properly integrated. This change modifies the virtual structure normalization for SQLite to change JSON column types to TEXT column types, restoring correct comparability again. Note that this a needed normalization based on the blocked Doctrine DBAL 4 way of comparison. The exclusion for two system extensions in the full database clear-schema-migration test is removed along the way. [1] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-removed-platform-commented-type-api Resolves: #104297 Related: #102875 Releases: main Change-Id: I940f29732a69d77ecdd126eb4f8eca379314d757 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85086 Reviewed-by:
-
Oliver Bartsch authored
The functionality to ensure that system internal columns that are required for data integrity are available in case they have been defined in the TCA control section, was previously done in TcaMigration. However, since TcaMigration should only contain migration functionality, which on the one hand logs deprecation warnings and on the other hand get's removed again after some versions, the corresponding functionality is now moved to TcaPreparation. Resolves: #104294 Releases: main Change-Id: I5e072cef866b36440f9409b1c68e114892ebcd51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85084 Tested-by:
-
Christian Kuhn authored
With introduction of new types "category", "file", "email" and "link", class TcaPreparation has been established to auto-add TCA details that should be shadowed-away for devs, and are added internally. This created quite a mess within FlexFormTools since TcaPrepration needs to be applied there as well, but with slightly different "category" and "file" details. Also, "email" and "link" received some hacks in runtime code to dynamically add "softref" - a thing TcaPreparation should handle as well, but didn't, also due to the hacks in FlexFormTools. This is an issue in combination with new TcaSchema: TcaSchemaFactory relies on TCA being "final" and not changed at runtime. The patch clean this up: * Free FlexFormTools from own implementations of "category" and "file" fields, call TcaPreparation. * Align TcaPreparation with the changes for flex fields by having a toggle for this and act upon. * Move "email" and "link" "softref" runtime hacks into TcaPreparation. * Protect a helper method in TcaPreparation previously used by FlexFormTools. * Refactor a double nested closure in TcaPreparation towards methods. * Refactor some tests and add some easy ones for "sofref" handling in TcaPreparation. Resolves: #104293 Related: #104002 Related: #103316 Related: #97013 Related: #97159 Related: #94622 Related: #104287 Releases: main Change-Id: If0cf7f99aad2acdedd785186c199252fb6388faf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85037 Tested-by:
-
Garvin Hicking authored
Resolves: #104291 Releases: main Change-Id: Ic79826e076077e281a699709d7ee6d38363e85d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85080 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Benni Mack authored
Resolves: #104292 Releases: main Change-Id: Ia09ef532f01fe5c14c809bcfbedb01b79fdcd485 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85081 Tested-by:
-
Benjamin Kott authored
This patch advances elevation streamlining by adding leveled surface colors to the backend. It serves as a preliminary update, laying the groundwork for future enhancements. While it initiates the introduction of surface colors, additional work in other areas is required for a full rollout. Resolves: #104285 Releases: main Change-Id: Icbafaf616cbe28102476dcc0bd0c2f3c4e89cca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84032 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benni Mack authored
Change-Id: Ia8a718c96803f84f558dc5bfab35b9559491a8c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85078 Reviewed-by:
-
Benni Mack authored
Change-Id: Ieb4da6a77ab6da4ad0149d6b3f7f91bafc9ae13c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85077 Tested-by:
-
Benni Mack authored
Change-Id: Idd321771d9772715595e7bbbf648fb16ead1de61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85076 Reviewed-by:
-
Benni Mack authored
Due to a bug in TYPO3's packaging tool, composer.json files were malformed and are now repaired. Releases: main Change-Id: Ib489171cc0c1dc80b4cf8d3454d3d84c3f44622f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85074 Tested-by:
-
Benni Mack authored
Change-Id: I8727969ce901dcedca5aa86f8c830ca38bccf541 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85072 Tested-by:
-
- Jul 01, 2024
-
-
Garvin Hicking authored
When multiple crop variants are defined (for example in EXT:styleguide "Form engine elements - imageManipulation" for "crop_5" with "mobile" and "desktop), the currently selected aspect ratio and the size of the cropping box was only computed based on the first crop variant. This patch uses a wrapping container for each variant and adjusts the JavaScript to operate on that context. The information for the current cropping box size is now also based on this context. Resolves: #103879 Releases: main, 12.4 Change-Id: I38e235ddb5ed5f7463a5f0931608944326097f9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84781 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
TcaMigration for flex form fields lived in FormEngine related TcaFlexPrepare, and has been moved to FlexFormTools with #99756. The related tests were located within UnitDeprecated since they trigger_error(, E_USER_DEPRECATED). Those have been later removed with #101115 during v13 deprecation removals. This is bad, we do need to know if this recursive implemention works. * Move remaining FormEngine TcaFlexPrepareTest from unit to functional tests for simplified maintenance. * Use DI for TcaItemsProcessorFunctions - a class used as TCA 'itemsProcFunc' for special BE cases. * Add tests of flex form TcaMigration to functional FlexFormToolsTests. This is done using a dummy error handler to have them within casual (non deprecated) tests, which should prevent accidential removal in the future. * Move TcaItemsProcessorFunctionsTest unit tests to a functional test case for simplified maintenance. Resolves: #104287 Related: #99756 Related: #101115 Releases: main Change-Id: I8cfcdb8a42f9029d909cdde31f382541e2285096 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85050 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104278 Releases: main, 12.4, 11.5 Change-Id: Ia3a4bc344b369b8697c88ed14ac06354dd988dce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85040 Tested-by:
-
Christian Reifenscheid authored
This commits adds the following hints: * module classes needs to be set to public * module classes needs to implement the ShortInfoProviderInterface * description on how to add custom page settings * description on how to add custom module settings Resolves: #104242 Releases: main, 12.4 Change-Id: Id495359e007bf09e38a80bc1097c95946f964217 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84984 Tested-by:
-
Benjamin Kott authored
We are adapting the CodeMirror implementation to also respect the current `color-scheme`, instead of purly rely on `prefers-color-scheme`. Resolves: #104279 Releases: main Change-Id: Iafcde4ee2581c68378874c32050855b1b54a8dee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85039 Tested-by:
-
Andreas Kienast authored
The code example regarding `f:constant()` is wrong, as it uses `value` as argument, but it is actually `name`, which is now fixed. Resolves: #104282 Related: #103560 Releases: main Change-Id: I848b6d1773e96c2578de70f67e75eb387ea2f72e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85043 Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Benjamin Kott authored
The styleguide examples were forced into adaptive light dark mode instead of respecting the current inheritance. We are now only forcing dedicated modes when the `colorschemes` option of the CodeViewHelper is set. Resolves: #104276 Releases: main Change-Id: Iea2ceb3ad429af97a10902a3e9b4a1be9df7f653 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85038 Tested-by:
-
Stefan Bürk authored
Apply the latest rules of php-cs-fixer for both fixer (code and header-comment) also in the `Build/Scripts` folder. The Build folder is now added to the usual php-cs-fixer execution for code and header fixer scripts to avoid code style drifitng in this folder for the future. Used command(s): Build/Scripts/runTests.sh -s cgl ; \ Build/Scripts/runTests.sh -s cglHeader Resolves: #104274 Releases: main, 12.4, 11.5 Change-Id: I7977e2254b9e271c45b840c6696cd7600ab0b1aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85034 Tested-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Jun 30, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104263 Releases: main, 12.4, 11.5 Change-Id: I7f132b2d3f7df9ba620b26656bbfca7fd038f32a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85013 Tested-by:
Mogens Fiebrandt <mogens.fiebrandt@googlemail.com> Tested-by:
-
Christian Kuhn authored
The MockEventDispatcher unit test fixture became useless with introduction of NoopEventDispatcher. The patch removes last remains: Most simply inject NoopEventDispatcher, some others create a mock of EventDispatcherInterface and use it for event manipulation when testing $subjects that act on event results. Resolves: #104273 Related: #97449 Related: #98016 Releases: main Change-Id: I0babc60cdd3c87bf9f25a931edfd3f47f642bfae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85032 Tested-by:
-
Christian Kuhn authored
FlexFormTools is a stateless service since #102229. The - also stateless - TcaMigration dependency is now injected. Get the service injected more often and adapt a few tests to deal with this. Resolves: #104268 Related: #102229 Releases: main Change-Id: I4cca73dc90ec652a4963b56c9a6ce5e2fccccf17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85026 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Kevin Appelt authored
Use #[AutowireLocator] instead. Resolves: #104262 Related: #103437 Releases: main Change-Id: Iee77653ec3a1cf8ba1513439239834561043e240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85011 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104265 Releases: main, 12.4, 11.5 Change-Id: Ifb6887a9fc77bc74c2d287b34a6876cc5da477da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85019 Tested-by:
-
Garvin Hicking authored
In the Admin Tools > Settings > Extension Configuration module, extensions can provide a ext_config_template.txt file. Comments inside that file dictate where and in which order a configuration option is listed. The syntax is: ``` # cat=SomeCategory//0; type=boolean; label=some config bar = 0 # cat=SomeCategory//1; type=boolean; label=other config baz = 0 ``` The parsing routine however could not properly deal with "0" entries for the input element order because checking this was using an "falsy" statement instead of allowing also "0" as a string. In this case, such a zero-based config element was not displayed. This is fixed, and an example is added to the EXT:styleguide extension configuration. Note that the error would not cause problems when either: * Another category assignment of another input element took place before, thus properly initializing the sort ordering. * The key did not use "0" as a sorting index, but anything non-falsy. * The string "cat=SomeCategory//0" was replaced with "cat=SomeCategory/0" (thus having an unset sorting key). Resolves: #102760 Related: #97816 Releases: main, 12.4 Change-Id: I6954bcf8f840d9e45372fc8fa8099381ce2b8b76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84912 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104266 Releases: main, 12.4, 11.5 Change-Id: I731d63dbbb13df6b3e0b6f40641ac0a98e92519f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85022 Tested-by:
-
