Skip to content
Snippets Groups Projects
Commit 0596cb3c authored by Stefan Bürk's avatar Stefan Bürk
Browse files

[TASK] Avoid implicitly nullable class method parameter in `EXT:adminpanel`

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator or adding a null
type to an union type definition. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Resolves: #104266
Releases: main, 12.4, 11.5
Change-Id: I731d63dbbb13df6b3e0b6f40641ac0a98e92519f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85022


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarMogens Fiebrandt <mogens.fiebrandt@googlemail.com>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 3c41e99f
Branches
Tags
No related merge requests found
......@@ -42,7 +42,7 @@ class DoctrineSqlLogger implements LoggerAwareInterface
$this->enabled = true;
}
public function startQuery($sql, array $params = null, array $types = null): void
public function startQuery($sql, ?array $params = null, ?array $types = null): void
{
if ($this->enabled && MemoryUtility::isMemoryConsumptionTooHigh()) {
$this->enabled = false;
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment