- Sep 06, 2023
-
-
Stefan Bürk authored
With #101739 a bug has been reported, which is not correct. This change adds functional tests to `ext:redirects` to show and cover that: * regexp redirects with a pattern not covering params but query arguments are given in the request uri and "Respect GET Parameters" has been set do not redirect. * RegExp Redirects with a pattern not covering params and no GET arguments are given in the request uri but "Respect GET Parameters" has been set redirects to the target url. Resolves: #101739 Releases: main, 12.4, 11.5 Change-Id: I023889ba6fefe5a4b06b392e02dece4b6ac517c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80848 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Stefan Bürk authored
During the migration to the specific TCA type `link` with #97159 the allowed link types for the field in the siteConfiguration->static-routes have been added incorrectly. This change re-adds the file link-type as allowed link type to that field. Resolves: #101837 Related: #97159 Releases: main, 12.4 Change-Id: Iee40a86fe115749482c2aa0faa2c887adb4d025b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80847 Reviewed-by:
-
Andreas Fernandez authored
The TypeScript part of the FormEngine got the form element in a weird way all over again. To make the code a little bit cleaner, the form element is now accessed using a `FormEngine` getter property in order to ensure types are properly infered. Resolves: #101836 Releases: main, 12.4 Change-Id: I737287fc9a0b8fd94cc3bf915e7f1d2511c720ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80880 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Benjamin Kott authored
We are removing the obsolete .collapseIcon wrapper and replace the icons directly. Resolves: #101854 Releases: main, 12.4 Change-Id: I7c640eba173edc167910312087c46d6614d7f5c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80846 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Benjamin Kott authored
The GenericButton requires a label to be set instead of a title. The title rendering falls back to the label if no dedicated title is provided. Resolves: #101853 Releases: main, 12.4 Change-Id: I41e835b44ee2bf1b33927811b8353f49ad725b42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80878 Reviewed-by:
-
Stefan Bürk authored
Avoid native PHP warnings in FrontendBackendUserAuthentication because of invalid array key access. The places are now guarded using null coalescing operator with a suitable fallback value. Resolves: #101848 Resolves: #101847 Releases: main, 12.4, 11.5 Change-Id: Iaf747172b6ac04b9d2bdbf60519346ef7e3b3f2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80844 Tested-by:
-
- Sep 05, 2023
-
-
Elias Häußler authored
This patch re-adds support for the `fieldExplanationText` property of form finisher checkboxes. It was removed with #95086, but is actually still used in some finishers, e.g. email finisher. Said patch also introduced wrong HTML for the checkbox label, which is fixed as well. Resolves: #101831 Related: #95086 Releases: main, 12.4 Change-Id: Ia1fe626ee5375f6d13adad8274b04be28345ed65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80843 Tested-by:
-
Benjamin Kott authored
We also ensure that TYPO3.lang checks are correct when the modal is used in a context where TYPO3.lang is not defined. Resolves: #101844 Releases: main, 12.4, 11.5 Change-Id: I1e6e90ed86e72f483929429b8e2c833179b60f87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80867 Tested-by:
-
Benjamin Franzke authored
The parser originates from the original codemirror javascript-mode and therefore contains a lot of legacy and unneeded code. Code that is obviously unneded for TypoScript (like backticks (called "quasi") or function expressions are removed to reduce the amount of code that needs to be type-declared. Resolves: #101803 Related: #101783 Releases: main, 12.4 Change-Id: If048e8c914cad3953463e9af712908f0e84c5f8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80852 Tested-by:
-
Andreas Fernandez authored
The image cropper component uses buttons to let a backend user toggle the currently active aspect ratio setting, indicated via an `active` class and a checkmark icon. With the removal of Font Awesome in #97877, some CSS was removed that was responsible for toggling the visibility of the checkmark icons. This patch adds the missing CSS again, including necessary adaptions to Core's Icon API. Resolves: #101788 Related: #97877 Releases: main, 12.4 Change-Id: I1daf428cafba3bc5f1e707c2763bf3f5dd6ba293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80842 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benjamin Kott authored
Resolves: #101845 Releases: main, 12.4 Change-Id: I1ba482f9f482a9579a6d0295cde161de83d5bebf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80864 Reviewed-by:
-
Benjamin Franzke authored
With #101782 eslint project configuration was overwritten to use a custom path. eslint read the relative project configuration based on the current execution folder instead of relative to the eslintrc file. This worked as long as eslint was executed from the Build/ folder (execution folder == eslintrc folder). As some tools execute eslint from the git root directory, the configuration is now adapted to always resolve the tsconfig file name as an absolute path based on the configurations directory name. Also overrideConfigFile is removed from Gruntfile.js as .eslintrc.[json|js] is read by default and no override is needed. Resolves: #101846 Related: #101782 Releases: main, 12.4 Change-Id: I58a6322a74d388efb0da28d1d8e7375f491c7aea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80841 Reviewed-by:
-
Anja Leichsenring authored
New ISO data has been published, so we update our set. Resolves: #101842 Releases: main, 12.4 Change-Id: If0a4663b91862615a8ddcfd5e0887efb03009ada Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80840 Tested-by:
-
Chris Müller authored
Twitter made the CSS framework Open Source in 2011, since then it is called only "Bootstrap". Resolves: #101840 Releases: main, 12.4, 11.5 Change-Id: I05c7d9ce3a197cb61058a5582918935d6720e371 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80838 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Sep 04, 2023
-
-
Benjamin Franzke authored
Now that our build chain targets ESM modules, we can use our TypeScript toolchain to also build utility entry point scripts, allowing to make use of TypeScript checking and centralize asset management. Resolves: #101790 Related: #101783 Releases: main, 12.4 Change-Id: I2b4e89114022a611a0e061d16d012e4b389dc750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80830 Tested-by:
-
Anja Leichsenring authored
New ISO data has been published, so we update our set. Resolves: #101832 Releases: main, 12.4 Change-Id: I029135f8e13f3337596b62d1ff954230c7b9536d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80837 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Sep 03, 2023
-
-
Markus Klein authored
This supplements the other viewhelpers already equipped with this attribute. Resolves: #101775 Releases: main, 12.4, 11.5 Change-Id: Iadcdb1de591d9d9e56722623cacd1a5cf8fbe0af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80836 Reviewed-by:
-
- Sep 01, 2023
-
-
Benjamin Franzke authored
Resolves: #101795 Related: #101783 Releases: main, 12.4 Change-Id: Id881225a77fcbb0fa6dbd9a7e75caba4fbe05ab1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80821 Reviewed-by:
-
Friedemann Altrock authored
Only add implicit default paths (Resources/Private/X) when they are not explicitly configured via TypoScript, as they may have been configured as an overwrite for another base path. Resolves: #81099 Releases: main, 12.4, 11.5 Change-Id: I0fe4cb690aa253d5d9941fcfbe0a9c9063298547 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80834 Tested-by:
-
Christian Kuhn authored
We finally removed remaining usages with #101647 and can thus drop the info in about module. The domain is offline meanwhile, so we backport to v12 to avoid dead links in the backend. Resolves: #101823 Related: #101647 Releases: main, 12.4 Change-Id: Id925da8a2dc87ca840d65b750f5025ae00fee7f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80818 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Friedemann Altrock authored
Before this fix, only the first RTE processing configuration would be taken into account when deciding which tags to keep in an HTML snippet. RteHtmlParser is a DI service and as such is treated as a singleton. Using multiple RTE processing configurations with potentially different sets of allowed tags should work as expected. Resolves: #101190 Releases: main, 12.4, 11.5 Change-Id: Ib0227872b542f53b30a16494aa2f979b8f601e07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80832 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
- Aug 31, 2023
-
-
Stefan Bürk authored
FormEngine sends some information as payload with the suggest wizard ajax request to the `SuggestWizardController` as context. The controller loads the record based on the tableName and the uid to determine the recordType to read the correct TCA field configuration, respecting special overrides like `columnsOverrides`. If a new record is created, there is no record uid available and passed to the controller. Therefore, the recordType is not properly determined. That leads to wrong record suggestions, if for example the `allowed` record table is overriden for specific recordTypes. This change adds the recordTypeValue as additional html data attribute to the suggest search field, reads and sends it along with the context payload in the ajax request to the suggest wizard controller, which now uses the passed value while keeping the record retrievement as fallback for now. Suggest records are now directly searched correctly respecting the full TCA configuration for the type, even for new records. Additionally, uid is send as null instead of the string "NaN". Used command(s): > Build/Scripts/runTests.sh -s buildJavascript Resolves: #101796 Releases: main, 12.4, 11.5 Change-Id: I3b814d37b7d4d3e9674ad6f2af882520c4f91413 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80773 Tested-by:
-
Christian Kuhn authored
To be an example of best practice, this patch changes all usages of "<INCLUDE_TYPOSCRIPT ..." to "@import". Tests are adapted as well, as long as they are not tailored to actually test INCLUDE_TYPOSCRIPT syntax. Resolves: #101813 Related: #97816 Releases: main, 12.4 Change-Id: I01c4eb19dfd0106c5577457cd0e1836865112d6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80797 Tested-by:
-
Achim Fritz authored
BackendUtility has a couple of strtotime() calls that may end up as strtotime(null). This emits a PHP E_DEPRECATED error since PHP 8.1. Add a cast. Resolves: #101811 Resolves: #101805 Releases: main, 12.4, 11.5 Change-Id: I5cca1b2fd3bc0d6792f6d61a59bdbc5b4850d15d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80771 Reviewed-by:
-
Oliver Hader authored
Resolves: #101808 Releases: main, 12.4 Change-Id: Iab938e0608a5547838d8b0cbc40c795e7653f929 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80795 Tested-by:
-
Andreas Fernandez authored
When TYPO3 is installed via CLI, the setup command now asks for the webserver being used to be able to copy necessary webserver files, e.g. `.htaccess` for Apache or `web.config` for IIS. Resolves: #100719 Releases: main, 12.4 Change-Id: Ibb97c4cf92b29ceeda85ae848ceeae16afb73359 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80772 Tested-by:
-
- Aug 30, 2023
-
-
Christian Kuhn authored
We can reduce class state by explicitely handing over runtime state to consuming methods in favor of parking them on $this. Resolves: #101804 Releases: main, 12.4 Change-Id: Ic33d619a189625fa9407a3ee36cddf76d0f14d32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80691 Tested-by:
-
Christian Kuhn authored
Changing stages using the various buttons in workspace preview module fatals server side since the request is incomplete. This is mainly due to the weird ajax dispatching from class AjaxDispatcher to ActionHandler: This area needs a major overhaul. However, patch for issue #100577 already introduced a hack to hand the current request down. The patch re-uses this to fix the issue. Resolves: #101802 Related: #101781 Related: #96904 Related: #100577 Releases: main, 12.4 Change-Id: Ifacf653ed0409891469a168c7bc0c38eaacf183f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80690 Tested-by:
-
Benjamin Serfhos authored
See: https://github.com/ckeditor/ckeditor5/issues/14200#issuecomment-1625171318 This allows similar behaviour as CKEditor 4 with applying styles to block components as DocumentList is preferred over List. Resolves: #100348 Releases: main, 12.4 Change-Id: I155889e37ca1e63b27aed0d01dad2154da5bd37e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80689 Tested-by:
-
Oliver Hader authored
DataMapProcessor tries to access `$possibleChainedIds[0]` which might not be defined, since that array is the result of a previous `array_intersect` invokation, which keeps the array keys of the original input array. DataHandler tries to access `$this->copyMappingArray[$table][$uid]`, which might not be defined in case the previous copy command could not be executed (e.g. since the record was deleted already). Resolves: #101748 Releases: main, 12.4, 11.5 Change-Id: Ibcbc412c7df62ce17dfa2c0f6fc120ccebb953d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80670 Tested-by:
-
Robert Kärner authored
This patch fixes two issues when generating symlinks to the public extension resources (Public/Resources) into the _assets folder during Composer installation. First, directory symlinks can't be created the same way on Windows as on Unix platforms. The creation requires elevated rights, and the required command is named differently as well. Junctions should be used on Windows instead, because they do not need elevated privileges to be created. When installing a TYPO3 extension via Composer, its Resources/Public folder is getting symlinked to the publicly accessible _assets folder. Until now, this process only used the Unix specific functions provided by Composer. It did not create any symlinks on Windows based installations, without generating any error message. This patch adds the same checks and platform-specific functions used by Composer when symlinking packages from a local path repository. The second issue that has been addressed is the naming of the symlinks themselves. When a Resources/Public directory is symlinked into the _assets folder, the symlink will be named using an md5 hash based on parts of the extension's installation path on the filesystem. During Composer installation, this relative path is derived from the absolute path provided by Composer. As Windows uses a different default path separator (backslash) compared to Unix (forward slash), the relative path will be different between both platforms, resulting in a different md5 hash being generated. Absolute path on Unix: /path/to/typo3/vendor/mycompany/myext Absolute path on Windows: C:\path\to\typo3\vendor/mycompany/myext Relative path to be used for the hash on Unix: /vendor/mycompany/myext Relative path to be used for the hash on Windows: \vendor/mycompany/myext If an uri into the _assets folder is to be generated in either frontend or backend, the md5 hash will be always be generated by using forward slashes, resulting in incorrect links on Windows installations. This difference has been solved by replacing all backslashes in the absolute extension installation path into forward slashes on Windows installations, so the symlink will be named correctly from the beginning. Resolves: #98434 Resolves: #98447 Releases: main, 12.4, 11.5 Change-Id: I221eb538312302a7af4f7c3010c9982922f1c6ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80688 Tested-by:
-
- Aug 29, 2023
-
-
Benjamin Franzke authored
@lezer/common – in contrast to other @lezer modules, is placed in dist/index.js instead of dist/index.es.js. Therefore we add a distinct copy rule. The sortablejs npm package recently changed to provide both, a UMD bundle and a native ESM module. As we actually failed to update the UMD bundle (due to a rename of the build output filename in sortablejs), we switch to the new ESM variant right away. muuri failed to update because dashboardToEs6 was missing in the npmcopy concurrent target. Resolves: #101784 Resolves: #101785 Resolves: #101787 Related: #101783 Releases: main, 12.4 Change-Id: I2ccf69847876edb55f089a4a5142ac388699fb54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80687 Tested-by:
-
Benjamin Franzke authored
IDEs like PhpSstorm complain about the same thing, so better we have that defined and checked via CI. Commands executed: node_modules/.bin/eslint --fix Sources/TypeScript/ Resolves: #101780 Releases: main, 12.4 Change-Id: I01e0289b671dfd4348319bca90dddaec085fbfe4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80747 Reviewed-by:
-
Benjamin Franzke authored
This helps to prevent hard-to-discover build failures, that only happen on clean installs (e.g. CI). This is because TypeScript will by default scan the entire source dictionary (Build/ in our case) for possible includes. We previously excluded /Build/composer in #95046, but it is actually much better to explicitly include the actually used source paths to also exclude build output (Build/JavaScript/) from being reinterpreted by subsequential eslint or tsc compile runs. Note that we also refactor the types/ directory in order to be a folder that conforms to the @types/* packages conventions, by being actually usable in the compilerOptions.types property. Note that our custom global type definitions (types/) were previously implicitly loaded as globally available sourcepaths. With the new `include` option we could add them back, but then we wouldn't notice if we do not add proper index.d.ts files (like we did until now). Therefore index.d.ts files are added in here. Now, with TypeScript being "clean", we need a another small adjustment in order for eslint to still being able to lint our types/ folder. Therefore tsconfig.json is extended to include the types directory. See [1] for more information on why eslint needs that. [1] https://typescript-eslint.io/linting/troubleshooting/#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file Resolves: #101782 Related: #95046 Releases: main, 12.4 Change-Id: I3ab8b874192d25470bbd5e71cc5d99e853259f89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80746 Reviewed-by:
-
Benjamin Franzke authored
This allows to drop a npm patch that had been applied to the TypeScript @types/jquery before, in order to achieve the same effect. With eslint we can additionally provide a good hint for the developer, what to use instead. For the v12 backport @types/jqueryui is removed additionally, as it conflicts with the bootstrap jquery definitions and was unused. This showed a small adaption that needed to be changed in upgrade-docs, which has already been fixed in main and is reapplied in here. Commands executed: npm remove patch-package npm install npm remove @types/jqueryui Resolves: #101697 Releases: main, 12.4 Change-Id: I77e15a4b4c2a18f8b72ec2a5f41c7e54a7966c30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80686 Tested-by:
-
Benjamin Franzke authored
Remove unused files that have been forgotten to be removed when there respective TypeScript source files where removed. Resolves: #101786 Related: #101783 Releases: main, 12.4 Change-Id: I75a74996e9dc1f9f30fd3b2f08914e25452df06f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80685 Reviewed-by:
-
Andreas Fernandez authored
The Install Tool router attempts to build URLs manually by wild string replacements and manipulation, which is rather error-prone. This patch changes the approach to use the URL API instead. Resolves: #101789 Releases: main, 12.4 Change-Id: I07ee73764b4fc5167f732d67faf2843fef0db199 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80745 Tested-by:
-
Benjamin Franzke authored
…of a new form element, that has not yet been persisted. Tabbing through an elemenet is considered an "input" by the browser, which is why the "input" even is triggered. The result is an empty input element (as before), but an intent is made to delete the underlying property from the form element object model. When the object model is empty (remeber, it is a new element), and an input field refers to a nested property (e.g. properties.fluidAdditionalAttributes.placeholder) removing an element (e.g. 'placeholder') will fail when the parent has not yet been set (e.g. properties.fluidAdditionalAttributes) Resolves: #101750 Releases: main, 12.4, 11.5 Change-Id: I49a9ead343e671c3d0289bd6d969316b888d05eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80729 Reviewed-by:
-
- Aug 28, 2023
-
-
Christian Kuhn authored
The extbase ConfigurationManager is (unfortunately) a stateful singleton that we can not get rid of without a bigger rewrite. While stateful singletons are bad enough, the extbase LocalizationUtility makes this worse by parking an instance of ConfigurationManager in a static property, re-using it as a "cached" singleton. LocalizationUtility does this since it in itself is static, which makes this service just so convenient to use. When it comes to sub requests and similar, static state is doomed and we need to get rid of it, we've had a couple of patches in v12 dealing with similar things. Mid-term, extbase LocalizationUtility needs to vanish anyways, but in the meantime, we have to get rid of static state that kills sub request scope. The patch removes the static $configurationManager property and adapts functional tests that already showed the current solution was a hack. There are various upper and lower cache layers that ensure removing this "cache layer" won't make things more expensive in practice, which allows us to remove this static state without further fallback. In main, this needs a TF update: > composer u typo3/testing-framework In 12.4, this need a TF raise: > composer req --dev typo3/testing-framework:^8.0.3 Resolves: #101779 Releases: main, 12.4 Change-Id: Ie5db07b0475f612a996d369ab3417672b33fbb2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80737 Reviewed-by:
-
Andreas Fernandez authored
Previously, the `keyup` event was intercepted in "Extension Configuration", which doesn't work with `clearable()`. This patch changes the code to listen to `input` and `change` events instead. Resolves: #101772 Releases: 12.4 Change-Id: I1e90ede6ab1693fd76dcb6aafb1dab0a616b5784 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80714 Reviewed-by:
-
