- Oct 19, 2023
-
-
Simon Praetorius authored
It is already possible to use the "value" argument together with "property" in form ViewHelpers. This should be reflected in the ViewHelper documentation. One possible use case is a form to edit a user. For the password field you would want to define property="password", but also value="" to not expose the current password hash to the form. Resolves: #102206 Releases: main, 12.4, 11.5 Change-Id: I3c7b1a201e38ccef84efcc863075043cf461dd20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81478 Tested-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Simon Praetorius <simon@praetorius.me>
-
Andreas Kienast authored
Executed commands: npm install --save-dev terser@^5.22.0 npm run build Resolves: #102201 Releases: main, 12.4 Change-Id: I16e9c884f7314b8b38d7587341a57f2777e89986 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81475 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Andreas Kienast authored
Some dev dependencies have known security issues again, that are now updated. Executed command: npm audit fix Resolves: #102208 Releases: main, 12.4 Change-Id: Ib83c955dbd06d6ba54dc264c4c82315888fe9622 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81479 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Oliver Hader authored
The new MutationRepository is a central place for providing static mutations (from configuration) and resolved mutations (static mutations + dynamic resolutions from database). The corresponding logic has been extracted and moved from the PolicyProvider to the new repository. Resolves: #102011 Releases: main, 12.4 Change-Id: Iaa627236fd55fb2c7c910ea7c13b54a1ad7cc663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81174 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Kienast authored
This commit updates ckeditor5 to v40. See changelog at https://github.com/ckeditor/ckeditor5/releases/tag/v40.0.0. Executed commands: npm i --save \ @ckeditor/ckeditor5-alignment@^40.0.0 \ @ckeditor/ckeditor5-autoformat@^40.0.0 \ @ckeditor/ckeditor5-basic-styles@^40.0.0 \ @ckeditor/ckeditor5-block-quote@^40.0.0 \ @ckeditor/ckeditor5-clipboard@^40.0.0 \ @ckeditor/ckeditor5-code-block@^40.0.0 \ @ckeditor/ckeditor5-core@^40.0.0 \ @ckeditor/ckeditor5-dev-utils@^39.1.0 \ @ckeditor/ckeditor5-editor-classic@^40.0.0 \ @ckeditor/ckeditor5-engine@^40.0.0 \ @ckeditor/ckeditor5-essentials@^40.0.0 \ @ckeditor/ckeditor5-find-and-replace@^40.0.0 \ @ckeditor/ckeditor5-heading@^40.0.0 \ @ckeditor/ckeditor5-horizontal-line@^40.0.0 \ @ckeditor/ckeditor5-html-support@^40.0.0 \ @ckeditor/ckeditor5-indent@^40.0.0 \ @ckeditor/ckeditor5-link@^40.0.0 \ @ckeditor/ckeditor5-list@^40.0.0 \ @ckeditor/ckeditor5-paragraph@^40.0.0 \ @ckeditor/ckeditor5-paste-from-office@^40.0.0 \ @ckeditor/ckeditor5-remove-format@^40.0.0 \ @ckeditor/ckeditor5-show-blocks@^40.0.0 \ @ckeditor/ckeditor5-source-editing@^40.0.0 \ @ckeditor/ckeditor5-special-characters@^40.0.0 \ @ckeditor/ckeditor5-style@^40.0.0 \ @ckeditor/ckeditor5-table@^40.0.0 \ @ckeditor/ckeditor5-theme-lark@^40.0.0 \ @ckeditor/ckeditor5-ui@^40.0.0 \ @ckeditor/ckeditor5-undo@^40.0.0 \ @ckeditor/ckeditor5-utils@^40.0.0 \ @ckeditor/ckeditor5-word-count@^40.0.0 npm run build Resolves: #102198 Releases: main, 12.4 Change-Id: Ie8535118f53f80509985277766b1ed2fb95bf778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81450 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Oct 18, 2023
-
-
Benni Mack authored
One of the main methods for processing logic when working the ImageMagick in TYPO3 is "imageMagickConvert". This method is rather cryptic when detecting the file extension, the final command and additional parameters / instructions and default commands for certain file types, so this code is brought in line with better naming and more readability. The quality setting for example is now properly used for jpg/jpeg files, which wasn't always the case. In addition, all non-public properties are now typed. Resolves: #102187 Releases: main Change-Id: I68467cd560f7ea539d42247d7a70aba98acd24de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81439 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Markus Klein authored
`$TCA['ctrl']['title']` is optional and may not be set. Resolves: #102195 Releases: main, 12.4, 11.5 Change-Id: I38a5aa921515f48b2e35a0ebdb8bcdce646b5bd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81448 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Garvin Hicking <gh@faktor-e.de>
-
Jan Greth authored
The file `settings.php`, which stores the value of $GLOBALS['TYPO3_CONF_VARS']['BE']['installToolPassword'] is located under `config/system/` in Composer-mode. If a project is not set up with composer it is `typo3conf/system/`. The hint next to the Install Tool's login mask spells the wrong path, which is corrected with this patch. Also the difference between legacy and composer setups is taken into account, without exposing information about the projects file structure. Resolves: #102166 Releases: main, 12.4 Change-Id: I5b2313516c1af9623a9c8de8f1dca7bb46fb8ce0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81425 Reviewed-by:
Jan Greth <jan@greth.me> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Jan Greth <jan@greth.me> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de>
-
Christoph Lehmann authored
They are executed to build a descriptive cache identifier and the database name is now received from configuration instead firing an SQL query. SQLite for example does not have a database name, here 'generic' is used as fallback. Resolves: #102174 Releases: main, 12.4 Change-Id: Ic8f46675a850a7fca9508acb7dc1432493437ff3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81433 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
Georg Ringer authored
More TCA types must be allowed for field mapping of reactions. Resolves: #102180 Releases: main, 12.4 Change-Id: I33327e7d083f9b31ab8e1764255eb5e7aa111d70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81438 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Oliver Klee authored
Resolves: #102116 Releases: main Change-Id: If78eabc7e7a729d04e6501bb3d9ce1fae0c373c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80183 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Benjamin Franzke authored
An `instanceof Type` on `Type|null` is unneeded and is to be replaced by a null-check (or modern alternatives like optional chaning or the null coalescing operator) in order to avoid narrowing code branches unnecessarily. We call them "pseudo" uncertain checks there is no need to express uncertainty regarding the type in a condition where native type declarations define a specific type *or* null: It is `null` or `!null`. Definition of a pseudo uncertain instanceof check: `$foo instanceof Bar` is fully equivalent to `$foo !== null`, when `$foo` is defined (via native PHP types) to be `Bar|null`. ⇒ `instanceof` expresses pseudo uncertainty regarding the type. From what we have seen in previous gerrit discussions, there were two reasons why instanceof was preferred over null checks although being unneeded: 1) Cognitive load for an instanceof check is perceived to be lower in contrast to negated null (not null) condit...
-
- Oct 17, 2023
-
-
Thomas Hohn authored
Deprecate the following constants in: * `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_UNKNOWN` * `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_TEXT` * `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_IMAGE` * `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_AUDIO` * `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_VIDEO` * `\TYPO3\CMS\Core\Resource\AbstractFile::FILETYPE_APPLICATION` Instead a new native backed enum `\TYPO3\CMS\Core\Resource\FileType` is added as a drop-in replacement. Resolves: #102032 Releases: main Change-Id: Ia79a0bd4c6741c0772964cd01d1bc7dd4cf5b1a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81261 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Markus Klein authored
'transOrigPointerField' may not be set for a table Resolves: #102190 Releases: main, 12.4, 11.5 Change-Id: I79febf5d99774b5e22d03f42f9088c00fa98dfc4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81444 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Christian Kuhn authored
With ReferenceIndex->updateIndex() being pretty much cleaned up and optimized, we start looking at the main worker method updateRefIndexTable(). The patch refactors some details to make the method more easy to follow. updateIndex() now hands over the current record to suppress another DB call per row which improves 'bin/typo3 referenceindex:update' performance. Resolves: #102189 Releases: main Change-Id: I2bbd571162deb6bff676f46f6dc7d836b823eccf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81443 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
One piece of code within ContentObjectRenderer was kept when File Abstraction Layer was not able to process an image. In my test cases, I was unable to trigger this place with the given setup. The case (dating to pre 6.0) could stem from chaining multiple processes of ImageMagick, which should then occur within the processing chain of TYPO3 itself. As it is not possible to trigger this code, it is removed without an RST as the implications or migrations cannot be explained. Resolves: #102182 Releases: main Change-Id: I421966ff645574e5746af7efbe96579ed4281221 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81437 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
It is now possible - if PHP was compiled with gdlib that supports webp (available since PHP 7.1), to generate webp files via GifBuilder. Example: page.10 = IMAGE page.10 { file = GIFBUILDER file { backColor = yellow XY = 1024,199 format = webp quality = 44 10 = IMAGE 10.offset = 10,10 10.file = 1:/backimage.jpg } } Resolves: #102177 Releases: main Change-Id: I48dac569da5904b4871ee2ad3b3759c54004e8c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81417 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org>
-
Garvin Hicking authored
Resolves: #102113 Releases: main Change-Id: I7304567faee9d0883d3c24d93b4b133fba7852d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81442 Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Chris Müller <typo3@krue.ml>
-
Christian Kuhn authored
CLI command `bin/typo3 cleanup:flexforms` of ext:lowlevel is extremely slow due to its page-tree-based strategy. It can run many hours on seasoned instances. Rewriting the command towards a TCA table based approach speeds it up dramatically. Example data point with my tiny test DB: Before ~450 seconds, with patch ~0.5 seconds. Resolves: #102181 Releases: main Change-Id: I9451b40953c3a6fa02c690591751e1170d486beb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81436 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
- Oct 16, 2023
-
-
Stefan Bürk authored
With #102171 a sub-query is used to fetch the records to delete. We missed two things: * Placeholders in the sub-query need to use the 'parent' QueryBuilder instance. * MySQL is picky and disallows using the same table from the delete query in a sub-query, at least not directly. This change adds an additional, chunked query to the mix, to mitigate picky MySQL and takes care of correct placeholder handling. Resolves: #102175 Related: #102171 Releases: main Change-Id: I52684537952b6e0a331541ca88b212ce19bf2455 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81434 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com>
-
Oliver Hader authored
Some database systems like PostgresSQL and MySQL are really picky if selected columns are not contained in all group and order selections or no aggregation method is used (aka 'ONLY_FULL_GROUP_BY'). That may be influenced by server configuration, which makes it really hard to come up with a minmal grouping query if: * not all used `ORDER BY` fields are included in the `GROUP BY` selection * not all `GROUP BY` fields are contained in the `SELECT` field list * Fields in the `SELECT` list are not included in the `GROUP BY` list OR using a aggregation function like `MAX()`, `MIN()`, `AVG(), `SUM()` and similar. Aggregation function cannot be used for non numeric values like `uuid like` strings and prevent to group on a field but retrieve the uinique id (UUID, uid, ) of the `first` or `last` record per group in on query. To get a similar effect through all database vendor and without requiring specific, mostly not default database settings provided by many hosting provider or in default configuration for databases, this change introduces a nested inner join construct with to ensure the same result across multiple systems. Resolves: #101913 Releases: main, 12.4 Change-Id: I28fa36db46d8219fc67a5503509e2a92a71ea6a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81015 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
Anja Leichsenring authored
Tables with TCA columns set to type="link" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=link. Resolves: #102168 Related: #101553 Releases: main Change-Id: I332ae15484a4aca0eebe0115fd00e46f356a6e12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81427 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com>
-
Nikita Hovratov authored
Tables with TCA columns set to type="radio" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=radio. Note that values of type=radio can be both, integers or strings. Items are checked for their values to determine the best suited field type. These can be varchar(255), smallint(6) or int(11). Resolves: #102163 Related: #101553 Releases: main Change-Id: Icd4e6b0f5554882617bec96c3446ff6d2f778c95 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81426 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Oct 15, 2023
-
-
Patrick Schriner authored
The option untrusted is now properly passed to the addQueryString configuration for the menu object. Resolves: #102162 Releases: main, 12.4 Change-Id: Ibdda3dd256d1984f5589c39077f8defc4a4b818a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81424 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Kevin Appelt authored
Make sure the clipboard action gets changed to move if the user chooses cut in the dot menu. Only the dot-menu in the list view was affected. Also removes an unused variable. Resolves: #102144 Releases: main, 12.4 Change-Id: Ic5bee9415292d75c531a82a052c0032fb148024d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81412 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
By deleting sys_refindex rows pointing to deleted=1 records early, and ignoring soft-deleted ones in the main loop, we can speed up the call significantly for instances with many soft-deleted records. Example data point with my test DB: Before ~24 seconds, with patch ~6 seconds. The more soft-deleted records exist in a table, the higher the improvement. Resolves: #102171 Releases: main Change-Id: I0f567fd2197e06d8da1adc5857c2877a36028c63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81421 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-
Torben Hansen authored
With #98370, all occurrences of `setOriginalRequestMappingResults()` have been replaced with the reassignment of the global Extbase request object attached with a modified `Result` object. This is however not required and has no effect, since in all cases, an Extbase `ForwardResponse` is returned, which includes the modified `Result` object. The `Result` object is then used in Extbase Dispatcher to build the new Extbase request object, which then is redispatched. This change therefore removes the superfluous Extbase request object assignments in `PasswordRecoveryController`. Additionally, the variable name for the original result has been streamlined to `$originalResult`. Resolves: #102112 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I28cdc69d2772dc87543a39d13305be610ee94a54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81372 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. This change also cleans up the affected test to better match the setup/execute/verify structure. Resolves: #102117 Related: #101601 Releases: main, 12.4 Change-Id: Iaa6cee9893d41cb95e20cda80e03f044d52d82cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81374 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Philipp Kitzberger authored
Resolves: #102134 Releases: main, 12.4, 11.5 Change-Id: I3aaf6f2c8161579394a0dbe1c9f470edeb0a8bca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81398 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-
Christian Kuhn authored
GeneralUtility::trimExplode() needs a string since #101453 as second argument. TCA type=folder DB values can be null, which can be triggered for instance by bootstrap_package in BackendUtility::getProcessedValue(). Cast the value before feeding it to GU::trimExplode(). Resolves: #102172 Related: #101453 Releases: main, 12.4 Change-Id: I3a742d592efe28324d07b0c941185601cfc14891 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81429 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Christian Kuhn authored
There is no point calling addDefaultPermittedLanguageIfNotSet() with $incomingFieldArray as reference. It is more easy to see the method can change $incomingFieldArray when it simply returns the updated array instead. Resolves: #102173 Releases: main Change-Id: If048cc438e53afca7a207200190689074963d2e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81431 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Oct 14, 2023
-
-
Benni Mack authored
Within the FileProcessingService class, various cleanups regarding the configuration array were made in order to avoid duplicate processed files. However, as noted in the existing code, this actually are special cases for specific tasks (ensuring that width and height are actually integers and have max boundaries in ImagePreviewTask for example). There is a culprit though, when moving this to the actual Task Objects (and that might be the reason why it was implemented the way it was): First, there is the ProcessedFile object, which then has a ->getTask() call, which then builds the Task object. The Task object thus needs a ProcessedFile object. But the ProcessedFile object is created AFTER it was checked in the DB based on the given configuration (which needs to be sanitized first to avoid duplicates), so a classic Chicken Egg problem. In the ideal world, the Task object should not hold state anymore, but write everything back to the ProcessedFile (e.g. configuration) as this is still duplicated in the current state. So, to reduce the interwoven situation, the AbstractTask object now has a new option called sanitizeConfiguration() which at a later point should be part of the interface (= breaking), but then also work with the ProcessedFile->getProcessingConfiguration() directly to reduce the duplication of memory everywhere. For the time being, an intermediate (empty) ProcessedFile is created, a Task object is instantiated and the configuration is sanitized (in the ProcessedFileRepository), when checking in the DB if a DB entry is available. The final ProcessedFile object is re-created after the DB query, which contains the sanitized configuration array. This change adds a new method to the Tasks, and adds some checks regarding the method, however this should go in the interface. As the interface will be cleaned up anyways in v13, this will be added separately in the next steps and the breaking change will follow as next patch. Resolves: #102164 Releases: main Change-Id: I01d5bef97a2fa319c1bffacacf28db6ca3f9b7a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81153 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Oct 12, 2023
-
-
Christian Kuhn authored
Skip some queries when there are no rows in a table. Resolves: #102152 Releases: main Change-Id: Ia156c654fb4e5d769ea6d99af6225359ac9d7f5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81420 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Christian Kuhn authored
There is no point in not adding the XML prologue when using FlexFormTools->flexArray2Xml(). We can remove the second argument to always add it. Resolves: #102151 Releases: main Change-Id: I9baa2e36def97ff8271faebea6ded7ec5e2e9353 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81418 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-
Nikita Hovratov authored
It is best practice to use permanently visible information to help to fill out forms of any kind. In case of sys_file_storage the placeholder is even partially cut off, so one can't read the whole text. Resolves: #102150 Releases: main, 12.4 Change-Id: I8ad357470b4ff7a42454aba77c14cc8b6a532e8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81416 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Oliver Klee authored
Resolves: #101989 Releases: main Change-Id: Ifb2a68271f8e9dcd0bf37834fc673587a3cbcfcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81129 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
TYPO3_CONF_VARS BE/flexformForceCDATA is an ancient setting introduced 2009 with #19338 in TYPO3 4.3 to work around a weird behavior in libxml at that time. It is the last usage of 'useCDATA' in GU::array2xml() and some others. We can remove both. Resolves: #102146 Related: #19338 Releases: main Change-Id: I11c98c857a0fd85f1b3c9f66ae3b0896d7eec9ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81413 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Nikita Hovratov authored
This is a pre-patch for introducing a native enum for DuplicationBehavior. In order to prevent changes to the signature of `$conflictMode` two times, we omit the typehint `string` in v13 and will change it in v14 immediately to native enum `DuplicationBehavior`. Resolves: #102149 Related: #101294 Releases: main Change-Id: I536151486b21f72bd2bc3959fc74e1124552af50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81415 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Benni Mack authored
This change avoids using the `$this->im` property which is the resource pointer to the `\GdImage` object. In addition, the method `gifBuild()` is the only place to deal with absolute path and the actual path prefix, making `fileName()` easier to understand. This change will then allow to advance with Gdlib, adding support for webp at the next stage. Resolves: #102148 Releases: main Change-Id: I875ad7d8e2ae3a086c457642a363cef671057c06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81414 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- Oct 11, 2023
-
-
Mehdi Chaouch authored
Releases: main, 12.4 Resolves: #102142 Change-Id: I57661704305c47842e7042f499bb247c9eefef58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81410 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
core-ci <typo3@b13.com>
-