- Jun 13, 2024
-
-
Andreas Nedbal authored
Before it was not really clear if/where a select check box header was collapsible. This patch unifies the layout with the one of the recordlist tables, adding a button specifically responsible to collapse/expand the group. Resolves: #98683 Releases: main, 12.4 Change-Id: I6b47cdc9cd2673a85aaa0bfb85dd70534e4ffc33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79703 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Garvin Hicking authored
Currently both the Install Tool and Environment > Directory Status sets the directory "typo3conf" as being mandatory and tries to create it. This is no longer needed in Composer mode. Resolves: #104074 Releases: main, 12.4 Change-Id: I880ec2b7ff0be642c2673bb7110ef95f3dc125d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84672 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Christian Rath-Ulrich authored
Resolves: #104025 Releases: main, 12.4 Change-Id: I32b509644018eaa4de452f499d525c6822addad1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84549 Tested-by:
-
Jasmina Ließmann authored
The TYPO3 backend has a bookmark function with which records can be saved as bookmarks. Since any other record type can be saved in addition to pages, the corresponding link titles are now adjusted. Resolves: #104053 Releases: main, 12.4 Change-Id: If8c894bdcd6e2aa0cbe3c29276a32ac18355a370 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84616 Tested-by:
-
Philipp Kuhlmay authored
Resolves: #104078 Releases: main Change-Id: I094f735e60ce0a78970099f95e76578e34cc1105 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84675 Tested-by:
-
Garvin Hicking authored
Extbase reserves a couple of keywords for internal use: * action * controller * format (resolving fluid templates for HTML, json, ...) * __trustedProperties * __referrer The notiation "__" (and "@" for sub-arrays) is indiciative of being reserved keywords, however action/controller/format are not. These are now mentioned specifically in the Fluid ViewHelper "arguments" parameter, so that they can show up in the auto-generated documentation. This should help to prevent integrators and developers from advertly using an argument like "format" as a custom variable/property name. Efforts have been made to document this also here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/4525 https://github.com/TYPO3-Documentation/TYPO3CMS-Exceptions/pull/155 Resolves: #102246 Releases: main, 12.4, 11.5 Change-Id: I55a306aaa0ba783f9202350d198c9fdf08f5a997 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84657 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Jasmina Ließmann authored
When a site configuration has one or more dependencies on site sets, an infobox is displayed in the TypoScript submodules. This patch updates the integration to align the infobox display with the general infobox styling. The wording has also been slightly updated. Resolves: #104051 Releases: main Change-Id: I966467b255221367f04490bde0ced9b9b535e25f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84613 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Garvin Hicking authored
The issue reported in #93743 seems to not be reproducible in main, the datepicker works even when "collapseAll=true" (and "collapseAll=true") is set in the TCA. To easily reproduce the scenario, a new styleguide TCA element "Form engine - inline expand single - inline_2" is introduced and added as inline relation to "Form engine - inline expand single". The inline elements are dateTime inputs. Resolves: #93743 Releases: main Change-Id: I74da9da60a7b79213cae7d4b6b8c327972c2652a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84490 Tested-by:
-
- Jun 12, 2024
-
-
Michael Telgkamp authored
The rootpages in the site configuration do not have intendation any longer. The computation of the margin value and the unused inline style are removed. Resolves: #104066 Releases: main, 12.4 Change-Id: Ic75d7e10638b2ee3fb06f42add1a36c180f754e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84671 Tested-by:
-
Jasmina Ließmann authored
In the module menu, in addition to the visible module title, the short description is inserted as a link/button title tag. The title attribute is useful when the module menu is minimized. The short descriptions previously used as titles are sometimes too long or not very helpful in identifying the module. With this patch, the module titles are used as link/button title tag. Resolves: #104059 Releases: main Change-Id: I19e8d9cebdbea4c6837373994c14954183069824 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84621 Tested-by:
-
Christian Kuhn authored
> Build/Scripts/runTests.sh Before: Memory: 469.06 MB After: Memory: 373.02 MB Reason: phpunit executes data providers early and keeps data sets in memory. The "xml parser big content" tests create megabytes of data kept in memory. Moving the data generation from data providers to the test execution reduces overall memory usage significantly. Resolves: #104076 Releases: main, 12.4, 11.5 Change-Id: I0ad49824fc1d4c309158b74474853d36af22ffb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84668 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Christian Rath-Ulrich authored
Resolves: #104060 Related: #104046 Releases: main, 12.4 Change-Id: I2b7b8c8911cd3f5552a287a73942c11806f4b8bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84623 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Christian Rath-Ulrich authored
To improve accessibility, an aria-label is added to all context menu buttons to allow assistive technologies to announce them correctly. Resolves: #102490 Releases: main, 12.4 Change-Id: Ia397ab17a8fcbfe3a1ea75e86733a6a5a778653e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81943 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Garvin Hicking authored
Related: #104067 Releases: main Change-Id: Ie640f046ca4795df2a7d3845ee44f59052997a47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84664 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Christian Kuhn authored
Similar to type=slug with #104063, type=link fields are now set to TEXT by default. This especially saves precious row size in tt_content due to header_link. type=link fields can be nullable and can have default values. Doing this with TEXT fields is possible since issue #103578. Resolves: #104068 Related: #104063 Related: #101553 Related: #103578 Releases: main Change-Id: Ib1aa1f3df0e84afc9a99a25972ddc85fb3b462f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84658 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104029 Releases: main, 12.4 Change-Id: I89571726e5cfa4b9c2296fdb0994910d24f3b3b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84550 Tested-by:
-
Oliver Bartsch authored
The form listing in the form backend module is now sortable. Resolves: #104067 Releases: main Change-Id: Ib950e17b6b8a350b07e3340ce948969da7fed69d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84656 Tested-by:
-
morgane garcia authored
Currently module is nammed Access we change to Permissions to be consistent to all the the backend Resolves: #104037 Releases: main Change-Id: I43587b496070c52a79fc6023ad06c731c4132dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84604 Tested-by:
-
Oliver Bartsch authored
To unify and streamline record selection in the backend, the SelectCheckBoxElement now also utilizes the MultiRecordSelection component. This allows to get rid of the custom JS implementation. Resolves: #104012 Releases: main Change-Id: I2ed675e9c04530d822036c7573ab62301486b2d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84602 Reviewed-by:
-
Michael Telgkamp authored
The Treeview widget is only allowed to have one tabstop. Focus handling within the widget is done using arrow keys. When scrolling away from the focused node, and then focusing the widget again, the focus is restored. Resolves: #104061 Releases: main Change-Id: If99bd5c5de506cbc649430fb8678736bdb7efdf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84626 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Christian Kuhn authored
Big VARCHAR fields can be problematic with mysql/mariadb [1], as outlined in [2]: A utf8mb4 varchar(2048) eats 8096 table size space. We can mitigate by making type="slug" fields a TEXT field instead, which saves quite a bit of precious row size especially in the pages table. [1] https://mariadb.com/kb/en/innodb-row-formats-overview/#maximum-row-size [2] https://github.com/contao/contao/issues/4159 Resolves: #104063 Related: #101553 Related: #97173 Change-Id: I57f8526124db8be0c58a10f934fb9ba165fd1358 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84630 Tested-by:
-
- Jun 11, 2024
-
-
Georg Ringer authored
The string "false" is cast to true and therefore 0/1 must be used in examples. Resolves: #99211 Releases: main, 12.4, 11.5 Change-Id: I5519cd1917b81c1dbb90fbb6746541735e4940ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84528 Reviewed-by:
-
Marcin Sągol authored
This patch reorganizes sections within the tabs of the backend user group form: - The sections 'groupMods', 'availableWidgets', 'mfa_providers', and 'custom_options' were moved to a newly created tab named 'Module Permissions'. - The 'pagetypes_select' section was moved to the top to avoid splitting the closely related 'tables_select', 'tables_modify', and 'non_exclude_fields' sections. - The 'Access Rights' tab was renamed to 'Record Permissions'. - The 'Access Rights' tab in the backend user form was renamed to 'Permissions'. - The purpose of renaming these tabs is to distinguish them and their content from the more general 'Access' tab, which handles access and visibility for given records. Resolves: #103759 Releases: main Change-Id: I4a889ee5094a2ba0c5e0f888c159b124912fc597 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84080 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Jochen Roth authored
Currently, Services.yaml files are used to register a services as public. This has been changed throughout the core (where possible) to use the PHP attribute "Autoconfigure" to have all options in one place. Resolves: #104023 Releases: main Change-Id: I3165806fb635c17d10b42f268cc2f0cd194dde56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84548 Reviewed-by:
-
Andreas Kienast authored
Resolves: #104050 Releases: main Change-Id: Ie5e3ce1af90d6d28de19dc9d5fdb76c5b49b73c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84612 Tested-by:
-
Jasmina Ließmann authored
The "About" module lists, among other things, all backend modules available in the system. If an admin or editor does not have access to a module, it will not be displayed in the "About" module list. Some of the modules listed contained a note that the module was only accessible to administrators. With the introduction of the system maintainer role, this note is no longer applicable. In addition, this note was missing for some modules that cannot be made accessible to the editor at all (e.g. "Access" module). If an admin/system maintainer wants to check which backend modules an editor can access, he usually switches to the backend user (via the "Backend Users" backend module). Calling the "About" module is not sufficient at this point, as settings in backend user groups and the backend user accounts themselves also influence whether a backend user can access a backend module or not. For this reason, this note in the "About" module is now being removed. Resolves: #104040 Releases: main, 12.4 Change-Id: Ib27581a9f1fc48985d42550622caffcf0615a0d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84610 Reviewed-by:
-
Lina Wolf authored
No backport is needed as only the main version of the changelog is rendered. Resolves: #104026 Releases: main Change-Id: I47e30da3b0ad0c372313419c84c1df4820a37fef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84615 Tested-by:
-
Stefan Bürk authored
The nightly CI run recently revealed a regression within phpunit [1] which has been fixed meanwhile upstream [2] by Sebastian Bergmann. This change raises phpunit to the bugfix version and the conflict is removed. Used command(s): composer require --dev "phpunit/phpunit":"^11.2.1" [1] https://github.com/sebastianbergmann/phpunit/issues/5857 [2] https://github.com/sebastianbergmann/phpunit/releases/tag/11.2.1 Resolves: #104036 Releases: main Change-Id: I8f83ca4b574d174dc0f13bb4a59ad5f35a905204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84595 Tested-by:
-
Andreas Kienast authored
This commit introduces a new component to render progress bars in a streamlined fashion, addressing common accessibility issues by providing proper aria attributes. The component supports a `max` value and a relative `value` attribute. If `value` is omitted, the progress bar is rendered in an indeterminate state. If `value` is present, an optional `severity` attribute can get passed to visually describe the state of the progress bar. Please note that only successful, warning and error states are supported. Additionally, an optional `label` can get passed, describing the progress bar and its current state. Important note: this component is rather experimental by now and may change in a few details. Until further notice, this component is strictly for internal use only. Resolves: #103767 Releases: main Change-Id: I2a99c10e589482a2972935f49af87119ea899f34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84038 Tested-by:
-
Benjamin Franzke authored
Avoid redirecting to /typo3/empty, which is not helpful to the context. As long as there is not module context in shared record-edit links, it's best to show the first backend module on close of such a view. Resolves: #104028 Releases: main, 12.4 Change-Id: Ia7d50f4e906e92b7f93b6e444f7b18fafcc1ea1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84573 Tested-by:
-
- Jun 10, 2024
-
-
Garvin Hicking authored
When the configuration for `mod.web_layout.BackendLayouts` contains column definitions with an empty content, this will make both the list view and the normal page view in the backend fail. This makes using the GUI editing of the 'backend_layout' records impossible to be fixed/addressed. This patch now does a more lax check on the 'columns.' array to prevent PHP error notices on invalid array key access. Resolves: #103425 Releases: main, 12.4, 11.5 Change-Id: I68c9b5a1ee8f0a70e3808338aa9dd2ed6f12c882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84538 Reviewed-by:
-
Jasmina Ließmann authored
The "About" backend module provides overviews of the modules available in the system, installed external libraries, authors of installed extensions, as well as general information about TYPO3 and its community. This patch standardizes the appearance of the cards in this module with those from the "Admin Tools" area. In addition, the heading structure has been updated and some headings have been added. In addition, links are now colored blue, similar to those in the "System Information" toolbar element, and email links in the extension authors list were removed because they violated the Content Security Policy. Resolves: #104009 Releases: main Change-Id: Ia3a0811e973edea579e8d66d2f0d7f01e9ded0c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84400 Reviewed-by:
-
Willi Wehmeier authored
The aspect ratio buttons in the image cropping tool have a visible focus state now to make them usable when navigating with the keyboard tab key. Additionally the button can now be pressed with the space and return key. Resolves: #103760 Releases: main, 12.4 Change-Id: Id221daddeee9d5b61497cb74604dbf151d25e3ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84079 Tested-by:
-
Oliver Bartsch authored
When inserting a record via the element browser, the value argument needs either to be formatted manually or left empty, allowing the element browser to format the identifier automatically. By omitting the value in the `PageBrowser` module, the value is now correctly formatted by the element browser to "pages_<uid>". This makes the "node-action" usable for TCA group fields, which allow more than one record type. The same logic is also used by the `BrowseDatabase` module, which also omits the value argument. Resolves: #103700 Releases: main, 12.4 Change-Id: I80e2cc696d85b5ec83432c35a263b19f9752b0ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84018 Reviewed-by:
-
Sandra Erbel authored
Releases: main, 12.4 Resolves: #104024 Change-Id: Ie2ffbbaa4867c1d8f0724a0f2352551599caef59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84547 Tested-by:
-
Sandra Erbel authored
Releases: main, 12.4 Resolves: #104022 Change-Id: I31703188cd154cd8fec433b4ce47f8acbb93bab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84546 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104016 Releases: main, 12.4 Change-Id: I509554667d6aa5a97a51419ecef79fd60ccb377a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84542 Reviewed-by:
morgane garcia <morgane.garcia@ideative.ch> Reviewed-by:
-
Stefan Bürk authored
PHPUnit changed the way how double creation is handled internally and now emits an exception if a manually defined `mock class name` should be registered. In some places within the unit tests, manual mock class names have been used, because the names are needed for cross referencing at a later point. For this, different approaches have been used, for example hardcoded MD5 hashes as strings or creating hashes of static values like `md5('1')`, and also reused hashes in different places or in tests using data providers. This now leads to an exception: PHPUnit\Framework\MockObject\Generator\NameAlreadyInUseException The name "b70551b2b2db62b6b15a9bbfcbd50614" is already in use This change mitigates the issue by using `StringUtility::getUniqueId('somePrefix')` as is already done in other places. As a sideeffect, four phpstan baseline entries can be removed. Used command(s): Build/Scripts/runTests.sh -s phpstanGenerateBaseline [1] https://github.com/sebastianbergmann/phpunit/pull/5804 Resolves: #104005 Releases: main, 12.4 Change-Id: Icc558844275c9ae9f67a0e7c20daa318f5ad6b41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84530 Reviewed-by:Andreas Wolf <andreas.wolf@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
A new TSconfig option `mod.web_list.searchLevel.default` is added, which allows to define the default search level for record search. The option expects one of the available level items as value. Those items can already be customized using `mod.web_list.searchLevel.items`. Resolves: #103706 Releases: main Change-Id: I6dc558ec5976d0abc9276bce53255952ed97e843 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84009 Tested-by:
-
- Jun 09, 2024
-
-
Stefan Bürk authored
PHPUnit refactored the double creation to support doubling readonly classes [1], thus breaking classes where the class constructor is called with constructor arguments, but calling itself a class method which is mocked using the `onlyMethods()` setup option. This leads now to some internal state setup issue and is reported as `regression` [2] providing steps to reproduce it. This change adds `phpunit 11.2.0` as conflict to the monorepo version to avoid using it in nightly tests for now, until a proper regression fix has been implemented in phpunit. Used command(s): \ cat \ <<< $(jq --indent 1 --tab \ '."conflict" += {"phpunit/phpunit": "11.2.0"}' \ composer.json) > composer.json \ && Build/Scripts/runTests.sh -s composer -- update --lock [1] https://github.com/sebastianbergmann/phpunit/pull/5804 [2] https://github.com/sebastianbergmann/phpunit/issues/5857 Resolves: #104007 Releases: main Change-Id: Ia384ff98a9ea4e318738a48bd9ff8afcc4faff15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84533 Reviewed-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
