- Jan 18, 2024
-
-
linawolf authored
If you happen to have inconsistent data in the config.yaml like: ``` routes: - route: robots.txt type: staticText source: 'EXT:my_sitepackage_mysite/Resources/Public/robots.txt' ``` Currently a PHP type error is thrown instead of a proper exception. Resolves: #102773 Releases: main, 12.4 Change-Id: If16a93b851237c9d39893cd3e56fa9693986721d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82367 Reviewed-by:Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Stefan Bürk authored
This change updates the "typo3/testing-framework" to fetch required changes as preparation for the upcoming Doctrine DBAL 4 upgrade. Used command(s): > composer req --dev \ "typo3/testing-framework":"dev-main" [1] https://github.com/TYPO3/testing-framework/pull/529 [2] https://github.com/TYPO3/testing-framework/pull/530 Resolves: #102813 Releases: main Change-Id: I38df3e939f8b381c8c5813b91f838bf60023e44a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82428 Reviewed-by:Oliver Bartsch <bo@cedev.de> Tested-by:
-
Chris Müller authored
Resolves: #102850 Related: #99323 Releases: main Change-Id: I15f188d221f7dbc899f819103283cf3f8ff4f5c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82500 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Bartsch authored
Resolves: #102852 Related: #102755 Releases: main Change-Id: I2640742252b34d0b8f3c61a9e62c765f63dfbe9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82501 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Jan 17, 2024
-
-
Torben Hansen authored
This change introduces constructor property promotion where possible in EXT:core/Classes/Localization/* Resolves: #102843 Releases: main Change-Id: Ib8d9f8ec77b23a7142f5e2a0a5211747800494d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82493 Tested-by:
-
Torben Hansen authored
Some type casts in ext:form are superfluous, since it is already ensured, that the variable type is as expected. This change removes all redundant type casts. Resolves: #102840 Releases: main Change-Id: I0daa178ab69c88e61bc92f31caefd9f8b45766df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82461 Tested-by:
-
- Jan 16, 2024
-
-
Oliver Bartsch authored
This replaces the previously available hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['stdWrap'] which is therefore now removed. Instead of one hook class, containing different methods, required by the deprecated `ContentObjectStdWrapHookInterface` does this patch add four dedicated PSR-14 Events, which can be used individually. Additionally, using the parent `EnhanceStdWrapEvent` it's still possible to register listeners, which are called on each occurrence. Resolves: #102745 Releases: main Change-Id: I3f85dca7673b8af23a3ed0c896d1cb48af4bfb4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82305 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Oliver Bartsch authored
In case a plugin, using the `list` CType has an item group configured, which is not defined in `list_type>config>itemGroups`, EMU::addPlugin() tries to get the label from the `CType>config>itemGroups` definition. This does now properly work by using the correct array access in the if clause as well as the correct fallback value in case the defined item group does not exists in `CType>config>itemGroups`. Resolves: #102841 Related: #102826 Releases: main, 12.4 Change-Id: If50fc533b6b3c107e21d73b7b0b6380c45807093 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82462 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Benjamin Franzke authored
The example value '-t -i' for `transport_sendmail_command` is incorrect, as an executable is expected to be provided, not just command flags. Since this option is not needed for SMTP at all, it is dropped from this example. Releases: main, 12.4, 11.5 Resolves: #102837 Change-Id: I99569f23339ae68077edf16aaa59873aa84ba24d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82456 Tested-by:
-
- Jan 15, 2024
-
-
Simon Schaufelberger authored
It has been deprecated with TYPO3 v12.4.8 and is now removed. Resolves: #102754 Related: #101751 Related: #100963 Releases: main Change-Id: I71580e01dc74f0fdf085141104b981ac6d215c2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82311 Reviewed-by:
-
- Jan 14, 2024
-
-
Anja Leichsenring authored
The label has been added, so the output of the help section for the command will now provide basic information about the option. Resolves: #102833 Releases: main, 12.4 Change-Id: I72e82f1516eaf960ce572b8e920be6bcaa747663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82454 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Nikita Hovratov authored
In case of a type `select` and renderType `selectSingle` TCA field, which doesn't define `items` nor `itemsProcFunc`, TcaSchema would always generate a type integer db field. This should rather fall back to varchar as the type can not be assumed properly. Exception: If foreign_table is defined then we know the values are uids. Resolves: #102828 Related: #102279 Releases: main Change-Id: Ie8444eb2859d2a4d1580aca3f0296786f5e10cb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82446 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Daniel Siepmann authored
The current application context was already available within conditions. It now is also added to data. That way it can be inserted via insertData, dataWrap and data. Resolves: #102815 Releases: main Change-Id: I4cd25d89a0c020ccade5497570f1b4338b65b41a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82431 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Thore authored
Exception message is wrong. The file did not move, the path is empty in itself or due to error in getFileAbsFileName. Releases: main, 12.4 Resolves: #102829 Change-Id: Ia10cc4a3511d042eecba9d06b34a501ab1998182 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82447 Reviewed-by:
-
Nikita Hovratov authored
Fix comment about obsolete type user with dbType json. Resolves: #102832 Releases: main, 12.4 Change-Id: I390a1a7d3a7fe4d511f361efae4c2735f9b34c4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82453 Tested-by:
-
- Jan 12, 2024
-
-
Stefan Bürk authored
Doctrine DBAL 3.7.0 introduced a performance issue [1] which has been already fixed by the Doctrine Team [2]. This change updates the `doctrine/dbal` composer constraint to ensure that this performance issue is gone. Note: The monorepo composer.lock already containted the 3.7.2 bugfis release, therefore this has not been detected in casual core development. This update is to mitigate the performance issue at all costs for TYPO3 users. As a sideeffect, this should put `composerInstallMin` nightly function tests on speed again. Used command(s): > composer require --no-update --no-install \ -d typo3/sysext/redirects \ "doctrine/dbal":"^3.7.2" ; \ composer require --no-update --no-install \ -d typo3/sysext/core \ "doctrine/dbal":"^3.7.2" ; \ composer require --no-update --no-install \ -d typo3/sysext/install \ "doctrine/dbal":"^3.7.2" ; \ composer require --no-update \ "doctrine/dbal":"^3.7.2" ; \ composer update --lock [1] https://github.com/contao/contao/issues/6409 [2] https://github.com/doctrine/dbal/pull/6202 Resolves: #102830 Releases: main, 12.4 Change-Id: If8b09f9556f11cc0fda4690f81343fc6c5d5e476 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82448 Tested-by:Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
When using DataHandler->log, the format changed to using an associative array as $data, whereas the message then contains PSR-3 compatible log strings. This was handled in TYPO3 v12 but a few places around Workspaces were missed. This patch adapts these places. Resolves: #102827 Related: #97556 Releases: main, 12.4 Change-Id: Id871d65a52243489d7434025850438e0f7aeb670 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82445 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
This removes usages of those properties from TSFE that have been modeled as PageInformation object attached to the Request as attribute 'frontend.page.information' with #102715. The patch is relatively intrusive since especially TSFE->page and TSFE->id were frequently consumed properties. It however allows us to reduce dependencies to TSFE quite significantly, the number of calls to $GLOBALS['TSFE'] shrinks. It also shows that we still have a couple of constructs that need to get the Request hand over, in particular the data processors and more importantly the LinkFactory and link builders: Those tend to either get the Request using "parent" ContentObjectRenderer->getRequest() (that method should be declared protected later) or from $GLOBALS['TYPO3_REQUEST']. We accept this for now since using $GLOBALS['TYPO3_REQUEST'] is at least less worse than using $GLOBALS['TSFE']. A dedicated patch will resolve that situation later, though. Note most remaining use TSFE->config, especially TSFE->config['config']. To model this in a good way, we need a preparation within the TypoScript calculation in getFromCache(), which will be a target of one of the next patches. Resolves: #102824 Related: #102715 Releases: main Change-Id: I9336b4215155eb53422016254f8ef2edb0ee86cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82416 Reviewed-by:
-
Benni Mack authored
With TYPO3 v12, the SelectItem API was introduced to allow an associative array for registering items in TCA select. However, it was forgotten to be added in registerPlugin and addPlugin, which is now supported as well to be consistent around TYPO3 Core, and the new API. As an addition, Extbase plugins can now also add a description in order to have feature parity with Core API. Core plugins such as indexed search now utilize description and group, moving "EXT:indexed_search" plugin into the forms group for consistency reasons. Resolves: #102826 Related: #99739 Releases: main, 12.4 Change-Id: Ifcfc5f8ce482fab3203fe6a9591cc152d0a4261a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82441 Tested-by:
-
- Jan 11, 2024
-
-
Nikita Hovratov authored
Resolves: #102812 Releases: main, 12.4 Change-Id: I43ea655938b8e4e691359bd22113c4f02ea71036 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82427 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Christian Kuhn authored
With removal of ext:feedit from core in v10 and removal of FE editing related code in v12 from ContentObjectRenderer, a couple of methods in @internal FrontendBackendUserAuthentication are unused. Remove them now. Resolves: #102822 Releases: main Change-Id: I8aa1d1b32ad3d6897bcc9a1b55c58d8aa3e389f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82439 Reviewed-by:
-
Benni Mack authored
Resolves: #102819 Releases: main Change-Id: Ib5a0b3f69685aed0529900d27e147dbfe567589a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82437 Tested-by:
-
Andreas Kienast authored
This commit updates all `lit` packages to their respective latest version. Executed commands: npm install --save \ @lit/reactive-element@^2.0.3 \ lit@^3.1.1 \ lit-html@^3.1.1 \ lit-element@^4.0.3 npm install --save-dev \ eslint-plugin-lit@^1.11.0 npm run build Resolves: #102816 Releases: main, 12.4 Change-Id: Ic0a3908b128174953ea10aadf5da1bff1d477868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82434 Reviewed-by: -
Joey Bouten authored
This introduces a new PSR-14 event, enabling extension authors to modify the fetched records as well as related options and configuration of the `CONTENT` CcontentObject. This replaces the previously available hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content_content.php']['modifyDBRow'] which is therefore now removed. Resolves: #99323 Releases: main Change-Id: I4378df877b9f727b06bdd99acebc7e808ff4d44a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77274 Reviewed-by:
-
Christian Kuhn authored
Extbase CacheService has been extracted from the storage backend in v11 with #94703, is still @internal and still only used by the storage backend (fired in extbase bootstrap). It has a weird construct that checks if a given table/uid combination has a pid column. With this service being fired from storage backends, which hard codes various pid calls already, and with extbase repositories working on TCA tables that have a pid column anyway, this is useless. Additionally, there is code that checks if TSFE exists to eventually clear page cache of current page uid. This is bogus as well: Extbase is fired either as USER or USER_INT plugin. In case of USER, a page cache entry can't exist, or the plugin would not be rendered anyways. In case of USER_INT, the plugin content is not cached, so it does not make sense to kill any page cache entry. Resolves: #102818 Related: #94703 Releases: main Change-Id: Ifb90c2c6be7168e861983a204cc750dfed7ac5bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82436 Reviewed-by:
-
Benni Mack authored
Types are added to all class properties in export and import classes. Some code only related to import has been moved from the parent "god-class" to the relevant subclass. In addition, some code related to inline images (without FAL) in RTE images as well as sys_template resources (html, css) export handling is removed, which did not work since TYPO3 v8 anymore. Resolves: #102810 Releases: main Change-Id: I7fa6db179d490de8378205aa8825a230ca69c52c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82421 Tested-by:
-
Christian Kuhn authored
The FE page title handling is a rather awful construct: First, providers need to be registered with TypoScript, which is kinda funny in the first place. Then, single providers are singletons since extensions may need to park title data when they are rendered, to be considered later. It also has a rather ugly 'cache' construct for _INT handling. It is also questionable that the main class construct resides in ext:core. And last, getTitle() does not get *any* information like the current request and thus needs to fetch stuff from globals. The patch does not solve all these things, but at least single providers now retrieve the current request to work on it instead of fetching stuff from globals. To be not breaking, the patch does this by adding a setRequest() method, which is for now not added to the interface. Resolves: #102817 Releases: main Change-Id: I78b732ce9d27e7b8a41b4595f1233c41c52e9bef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82435 Reviewed-by:
-
Nikita Hovratov authored
Less if statements by using early return on error. Resolves: #102811 Releases: main Change-Id: I65e28f2ebab3571001729f8cc6a25af2b67ce8fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82426 Reviewed-by:
-
Andreas Kienast authored
This commit updates `typescript` and its `eslint` and `terser` friend packages to their respective latest version. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^6.18.0 \ @typescript-eslint/parser@^6.18.0 \ @typescript-eslint/typescript-estree@^6.18.0 \ eslint@^8.56.0 \ grunt-eslint@^24.3.0 \ terser@^5.26.0 \ typescript@^5.3.3 npm run build Resolves: #102788 Releases: main, 12.4 Change-Id: I18132539bbe088f7c6025e0a461649244b0641e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82407 Tested-by: -
Benni Mack authored
The two leftover hooks $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][\TYPO3\CMS\Core\Domain\PageRepository::class]['init'] and $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_page.php']['getPage'] have been removed. The former hook is removed without substitution, as the hook has no benefit anymore in TYPO3 v13: * There are no public properties to modify after initialization * `PageRepository` is instantiated multiple times nowadays, instead of being a kind-of singleton via TSFE->sys_page The latter hook is replaced by the more powerful PSR-14 `BeforePageIsRetrievedEvent`, which can not only modify the UID of the incoming page, but also actually resolve the whole Page directly and bypassing the actual logic from PageRepository. Resolves: #102806 Releases: main Change-Id: Id816769a9ed01c8c9f8eeeef3c5fb8710729343a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82418 Tested-by:
-
- Jan 10, 2024
-
-
Stefan Bürk authored
With #102479 support for persisting datetime_immutable object has been ensured and covered with a functional test. However, using a empty string as default for a not nullable datetime field is invalid for MariaDB and MySQL which seemed to work until now in test executions. Something has changed, but had no luck to find any traces in the mariadb, mysql or corresponding docker hub changelogs and commits explaining this. The TYPO3 default TCA schema creates nullable fields with a null default for `date, datetime and timestamp` anyway, and therefore we now use that for the test case table structure. It make sense to test a valid structure if working state is expected. Note: It seems that core ci is not blocked by this yet, however local execution are broken. To verify with and without the change use following command(s): > Build/Scripts/runTests.sh -u > Build/Scripts/runTests.sh -s functional -d mysql \ typo3/sysext/core/Tests/Functional/Database/ Resolves: #102807 Releated: #102479 Releases: main, 12.4 Change-Id: Ide32b3f9dc4b049ff5c3982997c85a0bb01e2fce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82423 Reviewed-by:Markus Hofmann <typo3@calien.de> Tested-by:
-
Oliver Bartsch authored
In case an invalid link type is used in a link field, the link browser does no longer throw an exception but instead displays a flash message with the corresponding information. Additionally, an undefined array key access is resolved, which might happen e.g. in case such invalid link is being analyzed by link validator. Resolves: #102804 Releases: main, 12.4 Change-Id: I5ad35ff46360cc4b27556b8e2c75da69ecbe76d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82422 Tested-by:
-
Stefan Bürk authored
With #102518 the minimal suported version for MariaDB has been raised, and the version selection `-i` for functional tests adjusted. Adjusting the default for MariaDB if no manual version is selected has been missed, which is now corrected. Resolves: #102808 Related: #102518 Releases: main Change-Id: I12e3f64abad313c7d11ea0dbf7553bfbfc1a5f58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82424 Tested-by:
-
Oliver Bartsch authored
Using `__METHOD__` already contains the FQDN. Therefore, the duplicated static class string is removed from corresponding deprecation messages. Resolves: #102805 Releases: main Change-Id: I38d2a673041fd4c3119a2d4c416b4df938b4c489 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82417 Tested-by:
-
- Jan 09, 2024
-
-
Benni Mack authored
This change replaces the hook to manipulate enableFields DB query constraints in PageRepository with a PSR-14 Event called "ModifyDefaultConstraintsForDatabaseQueryEvent" which allows to manipulate existing constraints as well. At the same time, the method "PageRepository->enableFields" is deprecated in favor of a new method called "getDefaultConstraints()" consisting of of two arguments now, removing the superfluous "show_hidden" which can be also set via the next method argument "$ignoreArray" as well. "getDefaultConstraints()" returns an array of constraints, which is quite handy to use in your own Doctrine DB QueryBuilders. This method also supports tableAlias definitions, useful for JOINs in e.g. Extbase. Resolves: #102793 Releases: main Change-Id: I5816e97ebda3a0ba8945b0ec2001eafe515b7076 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82405 Tested-by:
-
Torben Hansen authored
The title of a file reference container is currently wrapped to multiple lines, depending on the length of the title and the current screen resolution. This change removes the fixed column width of the dt element. Additionally, the debug information is now on the same line as the title, which is the same behavior as for other inline elements in TYPO3. Resolves: #102066 Related: #99873 Releases: main, 12.4 Change-Id: Ic2b7d8b008a3dd4a95dce0f55228fd89e9b243af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82363 Reviewed-by:
-
Oliver Bartsch authored
Code cleanup of internal page layout grid classes. Resolves: #102801 Releases: main Change-Id: I3294d0d3db64ad9df91ce42f40e0a8e7535013dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82413 Tested-by:
-
Oliver Bartsch authored
Due to the major update of the `chart.js` package to v4, corresponding `legend` configuration of the BarChartWidget and the DoughnutChartWidget needs to be migrated. Resolves: #102759 Releases: main, 12.4 Change-Id: Iced423d184a86b334390cad21319bf088a8369a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82402 Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
Declare Event classes, only having readonly properties, as readonly. Resolves: #102795 Releases: main Change-Id: I1d2de9a0f95dba7eece5ccafb858a697c1eb4420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82412 Reviewed-by:
-
Benni Mack authored
TYPO3 v13 requires Symfony 7, which will be subsequently updated until Symfony 7.4 (LTS) Symfony 7 requires PHP 8.2, and will have support until November 2028 whereas Symfony 6 will "only" have support until November 2026. Used commands: composer req --dev -W \ "symfony/translation:^7.0" \ "composer/composer:^2.6.5" composer req -W \ "symfony/config:^7.0" \ "symfony/console:^7.0" \ "symfony/dependency-injection:^7.0" \ "symfony/doctrine-messenger:^7.0" \ "symfony/expression-language:^7.0" \ "symfony/filesystem:^7.0" \ "symfony/finder:^7.0" \ "symfony/http-foundation:^7.0" \ "symfony/mailer:^7.0" \ "symfony/messenger:^7.0" \ "symfony/mime:^7.0" \ "symfony/options-resolver:^7.0" \ "symfony/property-access:^7.0" \ "symfony/property-info:^7.0" \ "symfony/rate-limiter:^7.0" \ "symfony/routing:^7.0" \ "symfony/uid:^7.0" \ "symfony/var-dumper:^7.0" \ "symfony/yaml:^7.0" Resolves: #102786 Releases: main Change-Id: I93adeadd9a711352c7a916fe83e42f2bb9c69f5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82273 Reviewed-by:
-
