- Jun 01, 2021
-
-
Daniel Goerz authored
composer req friendsoftypo3/phpstan-typo3 ^0.8.1 --dev This patch is the next step towards full level 3 compatibility of the TYPO3 core. Releases: master Resolves: #94127 Change-Id: I5092ce3a9248a7e5ecba3f42183765c1b1d5b1cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69327 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Benni Mack authored
This change enables the usage of pages containing a trailing slash in their "slug" like "/my-page/subpage/" to be working, and modifies tests to cover this use-case. The main routing first fetches all records including the trailing slash (= also fetches pages with a trailing slash in their slug). The symfony routing then checks for e.g. "/my-page/" at the very end, but will fail if the page was named "/my-page", and then re-runs the symfony routing to find the "/my-page" request (same behavior as before). This change therefore solves two issues: 1. Pages with a slug with a trailing slash are properly resolved 2. Pages with a slug with trailing slash can be also called via "/my-page" and (new) pages without a trailing slash can be called WITH the trailing slash (as before) keeping maximum backwards-compatibility with RealURL logic. Resolves: #89091 Releases: master, 10.4 Change-Id: I5b82389f9769284d09d98b9335e11ed60c701896 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64655 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Kuhn authored
We recently added a Services.yaml to ext:install. This isn't an incredible great idea since the install tool is designed to work with uncached DI via ServiceProviders in general. The config made Symfony scan all classes, but we need Symfony DI for the backend adapter class only. The patch reduces Symfony DI registration down to this class. Resolves: #94250 Related: #94209 Releases: master Change-Id: I5345e369a1080ddcab5da27ec1ef1c75e48f72d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69361 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
crell <larry@garfieldtech.com> Tested-by:
-
Jochen Roth authored
* Removes duplicated dropdown caret and use bootstraps css caret (gridelement inside/after and finisher) * Fix preview mode dropdown in workspaces Resolves: #94198 Releases: master Change-Id: I7785f3ce21a6ee9773ebcd192b7a6abaded57273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69266 Tested-by:
-
André Buchmann authored
Set inlineTopMostParentUid fallback to "null" as "0" is a valid sys_language. "0" gives false positives in the check which languages are already defined. Resolves: #94248 Related: #94057 Releases: master Change-Id: I7975c0fa91940c502faec25cdbe0b30426300ee5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69355 Tested-by:
-
Christian Kuhn authored
The removed unit test mocks the system under test and checks for specific method calls. The test relies on AbstractTagBasedViewHelper from TYPO3Fluid\Fluid which added a feature in 2.7.0. This fails in core v9 and v10 which allow 2.6 and 2.7. This whitebox test is kinda useless anyway, so we drop it. Resolves: #94249 Releases: master, 10.4, 9.5 Change-Id: I70804f2881a84352ca793e7d523531a583a44b34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69358 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Daniel Goerz authored
* EXT:core Resolves: #94122 Releases: master Change-Id: I843e50719c5e5a2c3de425f49eae2f112e0df32f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69321 Tested-by:
-
André Buchmann authored
$GLOBALS['TYPO3_CONF_VARS']['MAIL']['format'] allows to configure the format for the mails, sent by TYPO3. The format "txt" does not exist and is therefore replaced by the correct value: "plain". Resolves: #94247 Releases: master, 10.4 Change-Id: I55535355f0f708a9e76cdbe1e0cae1583af93bda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69354 Tested-by:
-
Oliver Hader authored
In order to determine whether HTTP referrer headers would be submitted to server-side backend API, a corresponding "reload" was triggered for the backend's main login form. Since the behavior resulted in reduced user experience, the refreshing mechanism was replaced by an equivalent AJAX endpoint and request. Resolves: #92293 Releases: master, 10.4, 9.5 Change-Id: I745d266a97135496276437b8eaf9dd206bc5806e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69336 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Benni Mack authored
In prior TYPO3 versions, it was possible to customize the list of fields to be shown in the list view. This was only possible if the clipboard was active OR the user was in "single table view", and displayed in a box at the bottom of the module without any context. The new field selector is now right at the top of the database table - and per table - thus, always active and in context with the table. Via UserTSconfig it is possible to explicitly disable the functionality for users/groups for all tables or just a specific table. Example: Disable it for all tables except for sys_category: mod.web_list.displayColumnSelector = 0 mod.web_list.table.sys_category.displayColumnSelector = 1 Resolves: #94218 Releases: master Change-Id: Ia6db3a18fea5d0cf96fa32611535048f6e5c6199 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69262 Tested-by:
-
Jochen Roth authored
Currently the preview of the generated code for a backend layout uses only <code> tag. To streamline the ui this will use the t3editor if installed to display the generated code Resolves: #94222 Releases: master Change-Id: I1df1d03af120c50662ec5806c067b9af49c85dc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69308 Tested-by:
-
- May 31, 2021
-
-
Andreas Fernandez authored
This patch implements the "Refresh required" dialog for group fields configured to request a reload once their value changes. In the same run the validation is now applied to the field holding the actual value, which requires a minor change in the validation process. Resolves: #93855 Releases: master Change-Id: I1a1cd1ff65230da23c820b94b82644d860e06f39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68671 Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Oliver Bartsch authored
In case administrators don't want their users to initiate the reset password process, they have to set the global configuration option "passwordReset" to false. This however also prevents administrators from using the cli command or the action in the backend user module. Therefore, some things changed in the password reset implementation: - `passwordReset` now only affects the login screen - The CLI command is always enabled (requires shell access since the command is not schedulable) - Initiating password reset in the backend can be managed separately with a new user TSconfig option Also the descriptions of the global configuration options are adjusted. Actually `passwordResetForAdmins` previously mentioned that setting this to FALSE will only affect the login screen, which was not the case. It always affected all places. In the end, this enables administrators to be more precise when configuring the password reset functionality in their installations. Resolves: #91496 Releases: master Change-Id: Ic74080adffbaf55f82189dffddb93fdd601034e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69268 Tested-by:
-
Christoph Lehmann authored
With this option pages can be excluded recursive in the XML sitemap: plugin.tx_seo.config.xmlSitemap.sitemaps.pages.config { # comma-separated list of page uids which should be excluded recursive excludePagesRecursive = 10,24 } Resolves: #94206 Releases: master Change-Id: Ibcf543050c7892df9f768d27e4cb425ee7005a14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69328 Tested-by: -
Christian Kuhn authored
A minor raise from 2.6 to 2.7 brings an aria related feature and a cleanup we adapt in core. composer req typo3fluid/fluid:^2.7.0 Resolves: #94242 Releases: master Change-Id: I9b479c33aa5183ea2bad845452dfa8cba52245e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69334 Tested-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
Oliver Bartsch authored
Classes and positioning of the recipients checkboxes in the EXT:workspaces "Send to stage" dialog are adjusted to be bootstrap 5 compatible, restoring proper space between checkbox and label. Resolves: #94241 Related: #93119 Releases: master Change-Id: If38f03f8c39c830ee5a1292667e8d942b446daff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69335 Tested-by:
-
Nikita Hovratov authored
Allow overriding the scheme with forceAbsoluteUrl even if the page is not protected. Also the case is now covered where a scheme of a full URL with a path should be changed. The path in now correctly prepended by a slash. Resolves: #90228 Releases: master, 10.4 Change-Id: I37592838a2026ad0bed0386e44caa7ffac1fb65e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63252 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Bartsch authored
This adds the EXT:seo XML sitemap related constants to the constant editor. Resolves: #94239 Releases: master, 10.4 Change-Id: I8e8ca1d4272b7894e0539dc86953531f6b7fd1c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69332 Tested-by:
-
Thomas Löffler authored
Previously the image of a distribution extension was only shown in the extensionmanager, in case the distribution was already installed. In the list view, all distributions therefore displayed the same fallback image. This is now fixed by adding a new field to the extension record, which is filled via the XML parser. As it contains the URL to the image, it can be directly used in the corresponding templates and therefore allows to remove the DistributionImageViewHelper. Instead, a new web component handles the image and ensures a preview image is displayed, even if the distribution image is not available. Resolves: #83465 Releases: master Change-Id: Id249b99833571024e39ed3f5991751e24e2e8d1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69099 Tested-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-by:
-
- May 30, 2021
-
-
Christian Kuhn authored
ext:form is full of ObjectManager usages. This first patch tackles a series of simple cases: Mostly things we know can be created via makeInstance() easily or can be injected and that are easy to test since errors would lead to immediate BE module or FE plugin fatals. Some places benefit by switching to DI, and the patch does this in some cases. Some other parts are harder to switch, for instance because they'd require a bigger test rewrite, or raise b/w compat issues. Those places simply switch from ObjectManager->get() to makeInstance() for now. Change-Id: I400cf5c2e9b384d214ca0921c38c1c135df47cf7 Resolves: #94236 Related: #90803 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69326 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Daniel Goerz authored
* EXT:dashboard * EXT:extbase * EXT:extensionmanager * EXT:filelist Resolves: #94124 Releases: master Change-Id: I57e3f0b390639d2160420e4dc26468c08c6341c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69320 Tested-by:
-
Christian Kuhn authored
The BaseViewHelper which renders a base tag is kinda useless in our scope: Fluid based rendering typically takes care of markup within body tag, but base must be in head. In frontend, a base tag is thus almost always set using TypoScript config.baseURL, ending up in PageRenderer. The backend does stuff like this on a different level, usually ending up in the PageRenderer as well. Even with HTML mails, a base tag is uncommon and would usually - at least in the frontend - again render via PageRenderer. The patch deprecates BaseViewHelper. Resolves: #94227 Releases: master Change-Id: I7029dd609ca1f0aa1057b67380c7bd3a46b7ed09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69315 Tested-by:
-
Andreas Fernandez authored
The modal stack handling is slightly changed to update the instance stack when a modal was requested to get closed already and not once a modal has been destroyed anymore. This fixes an issue in case a closing modal triggers a new modal which resulted in the new modal being broken. Resolves: #94219 Releases: master, 10.4 Change-Id: Idbc16ac08e95d8b3fed896783672b58ff062cafe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69305 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Did you know there's supposed to be a context menu entry on pages in 'more' section that jumps to the edit access view of the permission module? No? Well, it's broken since the v8 context menu rewrite and never rendered due to insufficient initialization. forge doesn't have a single bug report about this, it seems nobody ever missed that entry. This is probably due to its limited use - the access module is used by admins rather seldom, as soon as the basic access rights system has been done for an instance and some pageTS settings take care of setting proper access for new pages, there is little need to fiddle with it often. And if it's used, it's accessed via the main module. Let's drop the implementation of the context menu entry instead of fixing it, to not bloat the 'more' section with an entry nobody missed. Resolves: #94237 Related: #78192 Releases: master Change-Id: I6c87ad8b9f4f2945b29b540e800811ab607bdadd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69329 Tested-by:
-
Christian Kuhn authored
The next step towards a PSR-7 compatible request object in extbase is to get rid of getRequestUri() and setRequestUri(). The strategy is similar to getBaseUri() from issue #94223: The Internal method setRequestUri() is dropped and the unused getRequestUri() is deprecated. Resolves: #94228 Related: #94223 Releases: master Change-Id: I99f74ac989fd697404b63c90c3ee8843abb80626 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69316 Tested-by:
-
Torben Hansen authored
Change method name for doc header button registration to `registerDocHeaderButtons`, since it strictly follows the PSR-1 camelCase naming. Resolves: #94235 Releases: master Change-Id: Ib6bc5af33c11ec96db4aeb77364a2683f52bccf8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69325 Tested-by:
-
- May 29, 2021
-
-
Christian Kuhn authored
makeInstance() can be used as straight substitution for now. Do this and clean up the test case a bit along the way. Resolves: #94233 Releases: master Change-Id: I1e802d405fd161501e10beea35848eebba397d83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69323 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Christian Kuhn authored
ext:beuser BackendUserRepository extends ext:extbase BackendUserGroupRepository, which is of course bogus. It triggers an unneeded call of extbase BackendUserGroupRepository->initializeObject(), which explicitely sets respectStoragePage(false) on query settings. This is redundant since [ctrl][rootLevel] = 1 of the be_user table TCA triggers the same call via the DataMapper. Change-Id: Id809f83fae549e859a426a615c0865d84a5c7250 Resolves: #94229 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69317 Tested-by:
-
Oliver Bartsch authored
To further prepare towards a PSR-7 Request in extbase we have to get rid of the setMethod() method. Therefore, the internal method setMethod() is dropped, while the public getMethod() is adjusted to use the PSR-7 Request. Additionally, the now unused InvalidRequestMethodException is deprecated. Resolves: #94231 Related: #94231 Related: #94223 Releases: master Change-Id: I1298cd049cf6fc1d44cf46ec3cbb3bd588b3bb7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69319 Tested-by:
-
Christian Kuhn authored
Both settings are useless: * The storagePid = 0 setting is ignored for be_users and be_groups queries since the extbase DataMapper sets setRespectStoragePage(false) automatically because both tables have TCA ctrl rootLevel = 1. * The check for this funny 'dummy = foo' has been removed from the controller years ago. Change-Id: Ic5ee3207ae1a7bbe17de640e5dbe61a39492a844 Resolves: #94232 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69322 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
Extbase tends to become a victim of its own magic. In this case, whenever a repository method like initializeObject() uses setDefaultQuerySettings(), it fully overrides potentially useful settings created by the factory. Developers struggle here since all of a sudden things like storagePid restrictions from configuration are no longer applied. We can't change this behavior easily - it would require some awful dirty handling in QuerySettingsInterface, leading to even more opaque complexity in this area. The change adds comments to the property and the setter hinting about the behavior. Resolves: #89295 Releases: master, 10.4 Change-Id: I3b99dfa6d5a7881caaa952672386c00ebfa0166c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69324 Tested-by:
Christian Wolff <chris@wolffc.de> Reviewed-by:
-
- May 28, 2021
-
-
Christian Kuhn authored
The fluid backend ContainerViewHelper is very similar to the PageRenderViewHelper, with the exception that container VH adds a default and empty ModuleTemplate leading to a default and thus pretty useless docheader. The main ModuleTemplate logic of backend modules should be done within controllers and resource registration like CSS can be done with PageRenderer VH. The patch deprecates the ContainerViewHelper. Resolves: #94225 Releases: master Change-Id: I69f06313f7ba1d647b702572e58eed1394dd1f2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69312 Tested-by:
-
Christian Kuhn authored
typo3/sysext/backend/Resources/Private/Templates/helper_javascript_css.html is an unused left over since FormEngine rewrite in v7 and can be dropped. Resolves: #94226 Releases: master Change-Id: Ic8eccade663e380c37f9abb045f14c3a5992adb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69313 Tested-by:
-
Christian Kuhn authored
To further prepare extbase towards a extbase Request object compatible with PSR-7 ServerRequestInterface, we need some solution for those methods within existing extbase Request that prevent immutability. One relatively straight case are setBaseUri() and getBaseUri(): The setter has been marked @internal in v10 already and can be dropped, and the getter is used just in a couple of cases. The patch adapts usages of getBaseUri() to implement the uri retrieval on their own based on the PSR-7 request (global access as temporary solution) and deprecates the method. The setter is dropped. Change-Id: Ifc224ecb8ab1a9d2b6f789fe8b92b692187614b7 Resolves: #94223 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69310 Tested-by:
-
Christian Kuhn authored
typo3/sysext/backend/Resources/Private/Templates/blank.html is unused since the removal of DocumentTemplate and can be dropped. Resolves: #94224 Related: #91514 Releases: master Change-Id: I3fd2e8f1eec25981f69fdcf26e7f8ac1932002d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69311 Tested-by:
-
Oliver Bartsch authored
Both, the recordlist as well as the backend user module already check the currently logged in user when evaluating the available record actions, e.g. disable or delete. Since disabling / deleting the currently logged in user will result in a completely broken state, which can only be fixed with direct database access, those checks are now also implemented in FormEngine and the ContextMenu. Furthermore, a new DisplayCond is added to hide the "disable" field in the current user record. Resolves: #94216 Releases: master, 10.4 Change-Id: Iebb7c5c685dc4c4aad489b73ee59fd9ac62cab4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69304 Tested-by:
-
Benni Mack authored
The Extbase action controller does not worry about clearing cache or changing plugins from USER to USER_INT as this is now handled within Extbase Bootstrap, reducing logic within Extbase controllers. Future iterations in this area then allow to a) have Extbase in BE not depend on an active cObject anymore b) have Extbase Bootstrap be sending headers to its parent object. Resolves: #94217 Releases: master Change-Id: Iff1608ecbc37ce7e6461f9e67c73d183354ebc4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69110 Tested-by:
-
Christian Kuhn authored
When dealing with TER extensions in the extension manager, the TER provides an XML file with extension details that are parsed and loaded into a database table. When this has been added a long time ago, two XML parsers have been added together with a factory to select one. Since PHP extension 'xml' is a required TYPO3 extension since a lot of core versions, always the first parser did the job. The patch removes the legacy parser and the factory, injects the parser via DI to the consuming class, merges the abstract parser class into the now single parser, moves the namespace, and refactors the class towards PHP strict typing. This leads to a significantly simplified codebase, much easier to maintain and adapt. Change-Id: I5f64370f943964686717dccb4e39cda1ae9511c9 Resolves: #94220 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69307 Tested-by:
-
- May 27, 2021
-
-
Volker Diels-Grabsch authored
For complex validators, it often makes sense that a custom validator can attribute an error to a specific property or sub property, even though it is validating a whole class. This is already possible by accessing a validator's $this->result directly, but that is cumbersome and in no way obvious, as this requires deep knowledge of the Result and Error classes. So this commit adds a convenience method addErrorForProperty() similar to addError() that takes a property path in addition to the error details. Resolves: #93835 Related: #93836 Releases: master Change-Id: I52f2b4cebaa8b4b4a91e47e983ce47533b63c6d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68658 Tested-by:
-
Albrecht Koehnlein authored
If a canonical URL is set in the page properties, this will always be used before checking the other options for defining the canonical URL. Resolves: #94201 Releases: master Change-Id: I200a086952cd70d0659692f144b2fae93173a8f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69271 Tested-by:
-
