- Apr 24, 2024
-
-
Stefan Bürk authored
TYPO3 provides the ability to configure different error handlers for specific (or all) error codes, as well as the error handler type to use (core handler or custom). The `\TYPO3\CMS\Core\Error\PageErrorHandler\PageContentErrorHandler` allows to specify a target using the link handler. The default config allows to define `LinkService::TYPE_PAGE` and `LinkService::TYPE_URL`. After implementing and stabilizing the TYPO3 sub-request feature, this particular error handler has been refactored to use an internal sub-request to resolve the error page content: An external URL not matching the same instance or having a page unavailable within the TYPO3 instance will not return any content. This change modifies the `PageContentErrorHandler` to send a Guzzle request for an external URL instead of using internal sub-requests, even if it would access the originating instance again. A limitation is that the requested URL **must** return a HTTP status-code 200. A custom request header is attached to this request. It is then checked to avoid recurring errors or loops in the page-resolving workflow. Resolves: #103399 Related: #98396 Related: #94402 Releases: main, 12.4 Change-Id: If09158abd2aa9246bcb7a4fa41a0ad6e4a0f942c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83947 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Apr 23, 2024
-
-
Oliver Bartsch authored
To be consistent with the other listings in the backend is the root page title of a site in the site configuration module now linked, allowing to edit the corresponding site configuration. Additionally does the link as well as the edit button now use a dedicated label instead of a generic one. Resolves: #103695 Releases: main, 12.4 Change-Id: Ice46e82587cdc36daa6275f6eec2c46909e8a071 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83950 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
Since the button to create a new site configuration is already descriptive the non-translated title attribute is removed. Resolves: #103696 Releases: main, 12.4 Change-Id: I28c8945f9b2b8fba29461dbd8033c52eacc1f035 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83951 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Jasmina Ließmann authored
If no record was found in "Workspaces" backend module, an information is displayed. This text is now displayed in the typical infobox style instead of with specific Bootstrap styling classes. Resolves: #103714 Releases: main, 12.4 Change-Id: I78637defba53cebdfc659b2414c59b4f4dbb7bbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84010 Reviewed-by:
-
Daniel Siepmann authored
The existing solution using `array_diff` did not work, as it only respects values, not a combination with keys. Given an existing record with some empty values would prevent unsetting another value with an empty. The same would apply for setting another value to an existing value. That's why we change to `array_diff_assoc`, which handles proper diff of value in combination with key. Resolves: #103708 Releases: main, 12.4 Change-Id: I36adbc8279e5160c33e8feffcd8741c30c667adc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84000 Tested-by:
-
Andreas Nedbal authored
In the current frontend tooling, we invoke Rollup twice: * via grunt-rollup to build library modules * via the command line to build everything related to CKEditor This commit gets rid of the first way and moves the library compilation to a JS-backed configuration as well, so we can get rid of a grunt package and also unify the tooling a bit. We also make use of @rollup/plugin-terser instead of the deprecated rollup-plugin-terser module that was used in ckeditor build before. To match the new behaviour, the "exec:ckeditor" task also was renamed to "exec:rollup". Executed commands: npm remove grunt-rollup npm remove rollup-plugin-terser npm install @rollup/plugin-terser --save-dev npm run build Resolves: #103686 Releases: main, 12.4 Change-Id: I8057dcceae2d039c637c6db68cf51b3ef1f12406 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83942 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Jasmina Ließmann authored
To improve the UX and accessibility of the "Workspaces" backend module the following changes are made: * Grouping and rearranging action buttons * Showing system language title in addition to the flag icon * Addition of a new "Action" column to represent the type of change and resolve the previous workspace state legend and colored record titles * Output notification messages with the icon if integrity issues exists * Removal of the live record column (This only contained the name of the live record and no other function. Additionally, records created in workspace were also displayed incorrectly in the live column even though they did not yet exist in live environment.) Resolves: #103670 Releases: main Change-Id: Ic7cd00fc46b638adaca9bd4cf4c6a97f2a53d787 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83924 Reviewed-by:
-
Ayke Halder authored
There is a checkbox in page module to show hidden content elements. If this checkbox is not selected the hidden content elements must be hidden. Additionally hidden elements must not be accessible/focusable by keyboard. Resolves: #103626 Releases: main, 12.4 Change-Id: Id8f4b98938ae27e3bd3d3e7903c3f50588d554b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781 Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Christian Kuhn authored
ReferenceIndex does not write rows with 'ref_table' set to '_FILE' anymore since #87428. The patch removes some left over handling at a couple of places. Resolves: #103710 Related: #87428 Related: #102222 Releases: main Change-Id: Iccb94a57b7fb551da48ba516b668fe970b9fb5f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84001 Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Lina Wolf authored
Resolves: #103713 Releases: main Change-Id: I8735da3d64bb1697775dac561a9407c414dc631c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84007 Reviewed-by:
-
Oliver Hader authored
Given a static route argument mapper is used - for instance one that allows values in the range of 1 to 100 - then generating an URL from a route with an out of scope `&value=5000` was still generating an URL. However, HTTP request to that URL would result in an 404 error. This change skips routes using out of scope values during the URL generation process to avoid pointing to invalid resources. Resolves: #103400 Releases: main, 12.4, 11.5 Change-Id: I11e12f29e294ec86bec948d3a922d4a56b231771 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83470 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
There are two labels 'folderNotDeletedHasFilesWithReferences'. Those are in use, the two 'folderNotDeletedHasFiles' are not. Resolves: #103709 Releases: main Change-Id: I804f67b4dbcee127cf951588b43cbfd55093a45c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83999 Tested-by:
-
Benjamin Kott authored
With new web standards arising and getting shipped to the web platform, we are migrating the currently limited light and dark mode components to the web native color-scheme. See: https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme Instead of relying on preferred color scheme queries, we're adopting the light-dark color function, streamlining our CSS and ensuring compatibility with all major browsers, except Safari (for now). While Safari is slightly behind, we anticipate full support for light-dark mode by May 2024, with the feature already available in Safari 17.5 Beta. See: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark See: https://developer.apple.com/documentation/safari-release-notes/safari-17_5-release-notes Note: Safari users will experience missing backgrounds and colors due to our decision not address this behavior. We're forward-facing and planning for the LTS release. If you intend to use Safari during development, please ensure you're using at least Safari 17.5 Beta. We're monitoring the situation closely and will implement a fallback if Safari hasn't released a compatible version before 13.2. Resolves: #103705 Releases: main Change-Id: I9f53e992f4d55efd86420a72a84da9d90b16e490 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83995 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Benni Mack authored
Change-Id: I06f3088f1b06adc56000391ea0af8bc199586cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83993 Tested-by:
-
Benni Mack authored
Change-Id: I0de3c394a9e37ca840c3d0aa6f6df745bca8ac3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83992 Tested-by:
-
Oliver Bartsch authored
To allow the use of "empty" attributes, such as `download` in the CKeditor, the RTEHtmlParser does now keep such attributes while processing. Resolves: #103698 Releases: main, 12.4 Change-Id: I331066c0abaa604ba68c19f0013b5a077fe8f5f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83953 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
The rootline calculation has been moved around with various patches in v12 & v13. Refactor some related tests and move them to a more appropriate place. This also avoids another TSFE access in tests. Resolves: #103701 Related: #102856 Related: #102715 Related: #103410 Releases: main Change-Id: I0da5f0484ce90eab3909d1c202a13ce79250b0bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83956 Tested-by:
-
Nikita Hovratov authored
It is possible that TCA items array is not set in DataHandler if 1. items is defined through types/*/columnsOverrides 2. DataHandler is triggered with context of another record type (e.g. by a translation request) This patch ensures we are always dealing with an array for items. Also, when passing it as parameter to `ItemProcessingService->getProcessingItems`. Resolves: #103472 Releases: main, 12.4 Change-Id: I364841982b7c2913e339bf5a504d811b3e050049 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83575 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Andreas Kienast authored
Executed commands: npm install --save chart.js@^4.4.2 npm run build Resolves: #103652 Releases: main, 12.4 Change-Id: Iddbfb5be5f998c7b9d693dac94fee88a1f242edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83851 Tested-by: -
Andreas Kienast authored
Executed commands: npm install --save alwan@^2.0.4 npm run build Resolves: #103651 Releases: main, 12.4 Change-Id: I56b52fdff9031eec2cabfaeb968469a20fa72bb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83850 Reviewed-by: -
Andreas Kienast authored
Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.7.0 \ @typescript-eslint/parser@^7.7.0 \ @typescript-eslint/typescript-estree@^7.7.0 \ eslint-plugin-wc@^2.1.0 \ sass@^1.75.0 \ sharp@^0.33.3 \ terser@^5.30.3 \ typescript@^5.4.5 npm run build Resolves: #103653 Releases: main, 12.4 Change-Id: I96bb9e96d12182adc33b5fafb52d53a4fecf6806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83872 Tested-by: -
Andreas Kienast authored
The "No results found" alert is rendered in a flex-row container, which caused a rendering bug where the alert box was stretched to a height of 100%, but its width is limited to its content. Use flex children modifiers to ensure correct positioning. Resolves: #103662 Releases: main, 12.4 Change-Id: I5b17950ca381fda841cd3a901d9f5e1a70e5562d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83919 Reviewed-by:
-
Chris Müller authored
Resolves: #103675 Releases: main Change-Id: Id576952b1390d5727643eb6c535ce56c50a20831 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83935 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Apr 22, 2024
-
-
Sybille Peters authored
The TSconfig configuration option mod.linkvalidator.searchFields is documented in the documentation. Previously, it was only possible to check within fields, if at least one softref was configured. This was changed to include fields with the type "link" (see LinkAnalyzer class). This change updates the documentation to reflect that. Resolves: #103477 Related: #83835 Releases: main, 12.4 Change-Id: I83ceafca206b2b1821e622bc36867eb13a9a5984 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83584 Tested-by:
-
Andreas Kienast authored
In order to streamline the backend UI and to re-use introduced web components, the "Add widget" wizard in the dashboard module now utilizes the `@typo3/backend/new-record-wizard` module that is already known from the Content Element creation wizard. As a small quality-of-life change, the modal title now includes the name of the dashboard as well. Resolves: #103697 Releases: main Change-Id: I58f069e5d3f57484cba8e020f51ab82cf923d25a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83937 Reviewed-by:
-
Andreas Kienast authored
With patches #102679 and arguably #103351, the image processing got refactored at multiple locations with good intentions. However, this triggers a bug in case `fileadmin/` is symlinked as it removes original files from `fileadmin/` due to incomplete checks. The class `LocalCropScaleMaskHelper` compares two paths to check whether further processing needs to be done. One part of the condition is the path "as-is", the other one is the real path with symlinks being resolved, leading to a negative result albeit both paths point to the exact same file. Another condition to trigger this bug is to render images in the frontend that don't need processing at all, e.g. because their dimensions are small enough. This patch converts the original file name in `LocalCropScaleMaskHelper` to a real path as well to have a successful comparison in symlink scenarios. Resolves: #103648 Releases: main Change-Id: I81e7f9d3e8951a0a0f18fe2838925f272659028e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83846 Reviewed-by:
-
Benjamin Franzke authored
A first set of extensions is converted to the new set infrastructure provided by #103437, #103439 and #103522. Resolves: #103556 Related: #103437 Related: #103439 Related: #103522 Releases: main Change-Id: I826cc661d726dbf54ca2b46e115b17b8dedd05f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83526 Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save \ lit@^3.1.3 \ lit-element@^4.0.5 \ lit-html@^3.1.3 npm run build Resolves: #103654 Releases: main, 12.4 Change-Id: Id250be2076f29d095cffed34bffe3f882feb223d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83874 Reviewed-by:Fabien Udriot <fudriot@omic.ch> Tested-by:
-
Willi Wehmeier authored
Add accessible aria-labels to the record icon located in the docheader component on the upper right. Additionally the record icon on the bottom right below the edit record form has got an aria-label now. Resolves: #103636 Releases: main, 12.4 Change-Id: I02a473e954f74c1b9fe8da765ca562a8a4ded290 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83834 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Benjamin Franzke authored
The description has been forgotten to be added in #103437. Releases: main Resolves: #103630 Related: #103437 Change-Id: Ie254e6bd8b0fc35ba2a2ea2ca03b3f0383317c47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83949 Reviewed-by:
-
Andreas Kienast authored
The component `@typo3/backend/new-content-element-wizard` is primarily used to render a wizard-like UI for selecting a content element for creation. To make the component usable in other places as well, it get's renamed to `@typo3/backend/new-record-wizard`. Resolves: #103683 Releases: main Change-Id: I9ad19d95fd0c8aa1efb60c335726dac57eb7c54c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83936 Reviewed-by:
-
Benjamin Franzke authored
TypoScript constants expressions have been extended to support a null coalescing operator (`??`) as a way for providing a migration path from a legacy constant name to a newer name, while providing full backwards compatibility for the legacy constant name, if still defined. Resolves: #103671 Related: #97816 Releases: main Change-Id: I959b07deb40a9a5582599d5c3eee96da831e8149 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83912 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
- Apr 21, 2024
-
-
Chris Müller authored
When providing a custom submodule for the admin panel with JavaScript, the script tag does not have a nonce attribute attached. The $attributes argument of the getAdditionalResourcesForModules() method holds a "useNonce" configuration, which is now also passed to getAdditionalResourcesForModules(), like for other calls in this method. Resolves: #103673 Releases: main, 12.4 Change-Id: I135a263734b7273c2065429185f1dd7287bd19a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83927 Tested-by:
-
Oliver Bartsch authored
This extends the PAGEVIEW content object to provide not only the page record, but the full Page Information object, which among others contains the page record, the rootline and additionally also the Page Layout object. Resolves: #103570 Releases: main Change-Id: I904b91f7427e0bcd27c74f3fb3a92a7e320dff8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83708 Reviewed-by:
Lisa Kreitz <lisamariakreitz@web.de> Tested-by:
-
Stefan Bürk authored
The TYPO3 system extension `redirects` now fully supports the setting of relative links as the `target` URL, which is a documented feature. Previously, an issue arose when attempting to use path links with leading slashes as URLs. This issue has been addressed in #101083, marking the initial step toward resolving the problem of relative target links. Additionally, the fix now allows for linking to arbitrary resources, even those that do not currently exist in the File Abstraction Layer (FAL). The class `TYPO3\CMS\Core\LinkHandling\LegacyLinkNotationConverter` has been changed to limit the handling of arbitrary resources to the smallest scope to reuse existing code and to use them as `LinkService::TYPE_URL` links. The superflous outer catch block has been removed to remove dead code. In addition, a test for coverage has been added that covers DataHandler and the lower LinkHandling layer. Resolves: #103387 Related: #101083 Releases: main, 12.4 Change-Id: I51cad29e5551824a0ad8d4528aa43cff7e0f9da7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83444 Reviewed-by:
-
- Apr 20, 2024
-
-
Simon Schaufelberger authored
Place the search icon on the right side of the input field. Resolves: #103404 Releases: main Change-Id: I7a0ed1ab77273ad300b406b8c356b8e7f7851474 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83571 Reviewed-by:
-
Chris Müller authored
The main key is not "RTE" in YAML, but "editor". Resolves: #103678 Releases: main, 12.4 Change-Id: I3c09ac3f0071be70ba3fb6c130653b8b75dc98b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83931 Tested-by:
-
- Apr 19, 2024
-
-
Chris Müller authored
This patch streamlines some spellings, break long code lines, so so they are visible without horizontal scrolling and adds more context to the RTE configuration examples. Resolves: #103677 Releases: main, 12.4 Change-Id: I2366888a29b90ee59d76f1b8f6876eb600b730d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83930 Tested-by:
-
Andreas Kienast authored
This commit removes the import of `@typo3/backend/tabs.js` in the "New Content Element" wizard for two reasons: 1. the module is not required in this scope 2. the import is apparently defunct, no request is made for that file Resolves: #103684 Releases: main, 12.4 Change-Id: I1f9af422f6c2b14590b96a058bc2ed088d0853d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83938 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Oliver Bartsch authored
When resolving the first and last inline elements in the `FilesControlContainer` and `InlineControlContainer`, it is now properly checked, whether any children exist at all, preventing possible type errors. Additionally a fallback is added to prevent further warnings in the containers while trying to iterate over the children. Resolves: #103646 Releases: main, 12.4 Change-Id: I6f46ee5dc6d5553f3bd43c12447ef2390e1f941f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83844 Reviewed-by:
Marcin Sągol <marcin@soee.pl> Tested-by:
-
