- Mar 15, 2023
-
-
Nikita Hovratov authored
Tests for the "key" argument were duplicated. This patch aligns the comments with the actual input. Resolves: #100178 Releases: main Change-Id: I92d853e9b8d5890d4f54c24803ff4d3ce99f11c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78133 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
- Nov 07, 2022
-
-
Christian Kuhn authored
Switch the Extbase BackendConfigurationManager to use the new TypoScript parser. The implementation is quicker for Extbase Backend modules. Change-Id: Icb821fbe8804f219806abc5094ace3d404b96a73 Resolves: #99017 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76447 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Nov 03, 2022
-
-
Georg Ringer authored
To avoid exceptions if arguments are given but empty, an additional check is added in extbase LocalizationUtility, plus the default in f:translate is changed back to the same 'null' value as in v11. Resolves: #98924 Related: #96473 Releases: main, 11.5 Change-Id: Idd08f7b948eb504999a80a215a7ded64f3c648a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76269 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Sep 21, 2022
-
-
Christian Kuhn authored
The Extbase Request still had a fallback to fetch the base Request from $GLOBALS. The base Request is of course a hard dependency of the Extbase Request, it should be actively hand over as construct argument. Change-Id: If0b66ce0daae8983d2a083808af0b8cbc724e824 Resolves: #98391 Related: #98370 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75782 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
- Jul 13, 2022
-
-
Christian Kuhn authored
The testing-framework method setUpBackendUserFromFixture() is kinda flawed since it does two things at once: It creates db records and creates global state. This is unfortunate in various cases, especially when db snapshoting is used. Additionally, it relies on a class property which defaults to a fixture file delivered by testing-framework in XML format. We want to get rid of the .xml fixtures, and we don't want that the testing-framework delivers default fixtures. The patch adapts all usages of the property and of method setUpBackendUserFromFixture() by splitting it into two calls to first insert a local extension fixture .csv file and to then call the backend user init helper method. This finishes the removal of .xml fixture uses in the core. $ composer req --dev typo3/testing-framework:dev-main Change-Id: I32a5c43a6c8176a9e9182d08e08b42b5ff279634 Resolves: #97928 Related: #96856 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75168 Tested-by:
-
- Feb 27, 2022
-
-
Benjamin Franzke authored
The private container now provides access to non-public services that have been at least once injected (and thus be considered as service during DI compilation phase). This may be used to provide dependencies to functional test setups where some dependencies needs to be mocked while other should receive the vanilla dependency the container would normally inject. A functional test case does implement the ContainerInterface now, allowing tests to access both public and private services. $this->getContainer() may still be used if the default container (delivering public services only) needs to be injected into a service. Related testing-framework pull request: https://github.com/TYPO3/testing-framework/pull/331 Commands executed: composer u typo3/testing-framework git grep -l "this->getContainer()->get(" | xargs sed -i 's/this->getContainer()->get(/this->get(/g' Resolves: #97032 Releases: main, 11.5 Change-Id: I5987d5244270a3e190c8721f6a8971c7fd1309ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73646 Tested-by:
-
- Feb 18, 2022
-
-
Oliver Bartsch authored
Some components in the Core allow to either define locallang references or static labels. To process them in a template, usually the f:translate ViewHelper is used. Since the value will be dynamically and a static label as "key" will lead to an exception in non extbase context, the dynamic value must also be defined as the default, which will be used by the ViewHelper, in case the "key" can not be resolved. There are two possibilities to define the default. Either by setting the "default" attribute or by adding the value as tag content. Latter failed since #96473 because the tag content was resolved too late. The previous behaviour is now restored by evaluating a possible default value before processing the "key". Resolves: #96964 Related: #96473 Releases: main Change-Id: If932d2de14b8b58005051a03ccf7be290b66ddd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73599 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Jan 25, 2022
-
-
Wouter Wolters authored
Adapt to a patch in typo3/testing-framework, thus update of typo3/testing-framework in composer.lock is mantandory in this patch. Used command: composer u typo3/testing-framework Resolves: #96172 Releases: main Change-Id: I9c9a08eca10a836b450cc1717c02cb7afa6be01e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72342 Tested-by:
-
- Jan 19, 2022
-
-
Stefan Bürk authored
StandaloneView() initalizes an ExtbaseRequest in __construct() and adds it to the rendering context. This is unfortunate for ViewHelper tests, since it hides the information if a specific ViewHelper has a dependency to a request. This patch replaces all StandaloneView usages in functional tests with the TemplateView class of typo3fluid, which doesn't do anything with request. When needed, request objects are created and added within the test manually, making this dependency transparent. The patch adds some minor refactorings of some tests along the way and fixes a couple of smaller bugs. Resolves: #96573 Releases: main Change-Id: If1c0fd9c96db0212ad251391b4b12ee967fdf21b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73043 Tested-by:
-
- Jan 06, 2022
-
-
Christian Kuhn authored
This changes StandaloneView and RenderingContext to accept instances of ServerRequestInterface or no Request at all - in contrast to extbase Request only. This is possible with extbase Request implementing ServerRequestInterface since v11. The patch changes a couple of ViewHelpers like the often used TranslateViewHelper: It can run without triggering extbase magic, which especially avoids the performance wise awful ConfigurationManager. Further patches will refactor backend views to leverage this. Internal method RenderingContext->getUriBuilder() is obsoleted and removed along the way. This is a powerful change since it drops the last hard dependency to extbase in fluid and allows views without extbase being involved at all. Change-Id: I3b447b6f70e9ae6f94b981478cd8c4f43a86e9d4 Resolves: #96473 Related: #94428 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72758 Tested-by:
-
- Nov 12, 2021
-
-
Simon Gilli authored
Change #95839 introduced a regression that causes TranslateViewHelper to fail when an invalid extension key is specified. This patch restores the previous behavior and avoids more regressions by a new test. Resolves: #95957 Releases: master Change-Id: I98675f94cf367b43f4123bb981f60c35286ace7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72158 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Jul 19, 2021
-
-
Christian Kuhn authored
We have a decent test coverage of view helpers, especially those within ext:fluid. This is an important asset and we're sure all main functionality works. Most of the tests rely on ViewHelperBaseTestcase from the testing framework. This class prepares the main mocking of view helper dependencies. Reading the code it becomes obvious that this approach is kinda unfortunate: View helpers are part of a bigger system - they have some general dependencies like the rendering context, the request and render children. This leads to a mocking party in many unit tests, making the test goal hard to understand and follow. The mock preparations and assumptions of internal handling actively block further separation of concern patches within ext:fluid since the ViewHelperBaseTestcase breaks all the time. The patch refactors all unit tests that extend ViewHelperBaseTestcase towards functional tests: Most of them simply create a StandaloneView, feed a template string for the specific view helper and string compare the render result. Some FE related VH tests additionally set up a full frontend and retrieve a rendered fluid view as sub request. This makes the tests much easier to read, follow and understand. The functional tests are now good examples to show the various features of single VH's. Change-Id: I6c5d4eeb0c79ba66a18398a5623a591381a6d707 Resolves: #94580 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69857 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
