- Mar 15, 2023
-
-
Nikita Hovratov authored
Tests for the "key" argument were duplicated. This patch aligns the comments with the actual input. Resolves: #100178 Releases: main Change-Id: I92d853e9b8d5890d4f54c24803ff4d3ce99f11c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78133 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
- Mar 14, 2023
-
-
Chris Müller authored
With the introduction of the new country API and the correspodning Fluid form viewhelper in #99618, is the form framework extendend for a new form element "country select". The form element allows several configuration options and renderes a single select element in the frontend, using the corresponding form viewhelper. Following configuration options are available: - First option: Defines the "empty option", i.e. the first element of the select. - Prioritized countries: Defines a list of countries, which should be listed on top. - Only countries: Defines the countries to be shown in the select list. - Exclude countries: Defines the countries not to be shown in the list. Resolves: #99735 Releases: main Change-Id: I27f135bb38ba727d25fb6bdc684555972f1e8f1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77623 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Klee authored
Also add the missing types and correctly use intersection types. Also reorder the type declarations for consistency. Also drop superfluous type annotations. Resolves: #100139 Releases: main Change-Id: I6b5337a0e02f36be84ff28a861c2afa58341093a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78091 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
- Mar 13, 2023
-
-
Sybille Peters authored
The PHPDoc block in the ViewHelper source is used to render the ViewHelper documentation. Remove link to Changelog with incorrect formatting in asset.css ViewHelper, which never worked. As the Changelog is from version 10.4, there is little benefit and more risk of linking to outdated information in the future. Resolves: #100151 Releases: main, 11.5, 10.4 Change-Id: I0b11e7ec90ccfa8864ca4ddaa7ca83004fe266c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78105 Tested-by:
-
- Mar 10, 2023
-
-
Oliver Klee authored
Also fix some types as needed. Resolves: #100134 Releases: main Change-Id: I87cebe0a3a7e3cb97a9a1802640ed856d7939f39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78085 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
- Mar 01, 2023
-
-
Christian Kuhn authored
The TypoScript condition matching and our symfony expression language handling is a heavily convoluted mess: The entire API tends to fetch lots of global state, the classes are complex, hard to understand and handle, over-abstracted and full of anti-patterns. The patch aims to mitigate this. The main strategy is to provide relevant data from within callers directly instead of fetching globals TYPO3_REQUEST, calling GeneralUtility::_GP() and GeneralUtility::getIndpEnv(). * For TypoScript 'condition' expression handler usages, the frontend/backend related ConditionMatcher classes are obsoleted. The IncludeTreeConditionMatcherVisitor class within the new TypoScript parser is now the construct that prepares TypoScript relevant variables to initialize the symfony expression language construct, and gets variables actively hand over. * The default provider now prepares variables from state that can be injected, the entire ProviderInterface no longer relies o...
-
- Feb 24, 2023
-
-
Thomas Hohn authored
Added string cast before trimming $typoLink. Changed annotation to be string|null. With TYPO3 v13 string should be added to the methods signature and cast removed. In addition fixed some potential calls that could have sent null to the method, prophylactically. Resolves: #99975 Releases: main, 11.5 Change-Id: I8cbafa51d96e3ab35d39855831803897b4ff0035 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77887 Tested-by:
Marc Willmann <mw@f7.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
Kay Strobach <typo3@kay-strobach.de> Tested-by:
-
- Feb 10, 2023
-
-
Benni Mack authored
With the introduction of the Locale API in 12.2 and its inclusion in SiteLanguage->getLocale(), the property "hreflang" can be completely removed from the Site Configuration, as the Locale API can convert the hreflang property properly into a format like "de-AT" directly. This format is described as IETF RFC 5646 language tag standard: https://www.rfc-editor.org/rfc/rfc5646.html Resolves: #99908 Releases: main Change-Id: Ie712a89b41e5f00d1c592fc3cc978f58712ef0c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77807 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Feb 07, 2023
-
-
Benni Mack authored
Change-Id: Ie632b791d59866eddbe3e22f654fb261b7e02f6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77747 Tested-by:
-
Benni Mack authored
Change-Id: I716386d2d91ecd2f463e4500b592498cade9dea2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77746 Reviewed-by:
-
Oliver Hader authored
This reverts commit d38764ff. Reason for revert: Release script pushed to wrong branch Change-Id: I17778c7f3e0fd7f56a8e22725b7ff02ee0149064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77754 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: I93476c966ba30ade007c8f5ada514ef3c286fad1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77740 Reviewed-by:
-
- Feb 06, 2023
-
-
Benni Mack authored
When no cHash is given but GET parameters are handed in which _would_ require cHash parameters, these are now properly evaluated during the frontend request. As this has a security impact, a new option called $GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash']['enforceValidation'] is introduced, which then skips the "requireCacheHashPresenceParameters" option. The latter is an include list, but cache Hash calculation should rather be based on the exclude list such as "excludedParameters" and "cachedParametersWhiteList". If the new option is set, but some properties such as tx_solr[q] should be allowed, then this needs to be added to the excludedList ("excludedParameters") by extension authors. A new test "SlugSiteWithoutRequiredCHashRequestTest" is added which works with a disabled feature flag compared to "SlugSiteRequestTest" which has the feature flag enabled. Resolves: #95297 Releases: main, 11.5, 10.4 Change-Id: Ib72c6a34602e77d8c2044ad2e826c0474ebd23...
-
- Feb 04, 2023
-
-
Georg Ringer authored
Provide a filter method to create a list of countries with given included and excluded countries. Resolves: #99732 Related: #99618 Releases: main Change-Id: I904b9243ddcdc6b0e455096481ed4321900f5ff4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77619 Reviewed-by:
-
- Feb 01, 2023
-
-
Chris Müller authored
Related: #99618 Resolves: #99788 Releases: main Change-Id: I826a40e306a77403dd06270eb83f5131920c219d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77661 Tested-by:
-
- Jan 23, 2023
-
-
Oliver Bartsch authored
While the fragment in a LinkResult is named "fragment", is the typolink related config key "section". Related ViewHelpers do now use the correct key again. Resolves: #99658 Releases: main Change-Id: I9f31c651e44887588b29f472348c3dcf694e6ecc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77531 Tested-by:
-
- Jan 20, 2023
-
-
Anja Leichsenring authored
The method will be phased out due to being an antipattern to grab information directly from global variables. This patch replaces all usages of GU::_GP(), where a PSR-7 Server Request Object is available. Resolves: #99635 Releases: main Change-Id: I7a441b7cb4999763d852dd78f09b5d28039497ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77493 Tested-by:
-
Anja Leichsenring authored
The EXT:extbase UriBuilder already has a local instance of the RequestInterface object, but relies in its method `buildBackendUrl()` solely on $GLOBALS['TYPO3_REQUEST']. This is now cleaned up, with a fallback on the global object in case none has been given as a local instance. In this case, a deprecation warning will be raised. Resolves: #99650 Releases: main Change-Id: Ib05a92c999e83e19cfde65a038439e3f571afba7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77507 Tested-by:
-
- Jan 19, 2023
-
-
Henrik Ziegenhain authored
TranslateViewHelper needs to cast $id to string to avoid feeding an int to str_starts_with(). Resolves: #99637 Releases: main Change-Id: Icf432eed5b983daea4a8feafaa2e040d2a7aa7f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77495 Reviewed-by:
-
Benni Mack authored
TYPO3 now supports loading a list of all countries of the world in all supported translations that TYPO3 has to offer - out of the box. For this, a dev-dependency "sokil/php-isocodes-db-i18n" package is used, which contains a list of all countries (ISO 3166-1), their short names, their official names in english, and optional translations. This package fetches the data from debian repositories and is updated automatically on the second day of each month. A new Build script then transfers the information and the translations (originally in PO files) via symfony/translation into a PHP class and XLF translations for country names ("France") and official country names ("French Republic"). The Build script is already prepared to also fetch language script codes in the future, along with languages and/or currencies as well. A new API (CountryProvider) is available which returns the countries, and prepared label strings to be used with TYPO3's language me...
-
- Jan 18, 2023
-
-
Chris Müller authored
The docblock of the class is rendered for documentation, see: https://docs.typo3.org/other/typo3/view-helper-reference/main/en-us/typo3/fluid/latest/Format/Html.html This information should therefore be mentioned. Related: #99031 Resolves: #99536 Resolves: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/250 Releases: main, 11.5 Change-Id: I6f21710975a8916e27cdcd38c0bcb83a129319ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77380 Tested-by:
-
- Jan 17, 2023
-
-
Benni Mack authored
This change cleans up some tests, and also streamlines some usages (not all of them) of $TYPO3_CONF_VARS['EXTCONF']['lang']['availableLanguages']. Resolves: #99578 Releases: main Change-Id: I52b6f43260d08abf59d6078498511084469b2308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77423 Reviewed-by:
-
- Jan 10, 2023
-
-
Georg Ringer authored
Force the return value to be a string if the uri to a page is generated but the provided page is not existing or hidden and no child node is provided. Resolves: #99502 Releases: main, 11.5 Change-Id: Ia2300d107bed03d8cc26efdc13b48cb4fb3dbcc0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77312 Reviewed-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
- Dec 12, 2022
-
-
Benjamin Kott authored
This adds a <f:format.trim> ViewHelper that trims a string with the option to trim characters off a string from the end or from the start of the string. Resolves: #99285 Releases: main Change-Id: I78411d61c0f190df5b0925b0dd5a14df4c6f19e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76937 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
- Dec 06, 2022
-
-
Achim Fritz authored
Cast decimals input arguments to integer before using them in number_format(). Resolves: #99283 Releases: main, 11.5 Change-Id: If0f49d644c99b212ffb7dd3a774e4dcba8baa2c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76936 Tested-by:
-
Benni Mack authored
Change-Id: I206be78ca4e53366c8ded19ebbabdf6ec4047471 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76935 Tested-by:
-
Benni Mack authored
Change-Id: Ica979328b58e9d44ae8703a67ed7d5c9218afe3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76934 Tested-by:
-
- Dec 01, 2022
-
-
Benni Mack authored
Symfony 6.2 provides a longer support lifetime than the currently supported Symfony 6.1. For this reason the dependencies are changed as TYPO3 v12 LTS will upgrade to Symfony 6 LTS at some point (after its release) anyway. Used composer command: composer req -W symfony/config:^6.2 \ symfony/console:^6.2 \ symfony/dependency-injection:^6.2 \ symfony/expression-language:^6.2 \ symfony/filesystem:^6.2 \ symfony/finder:^6.2 \ symfony/http-foundation:^6.2 \ symfony/mailer:^6.2 \ symfony/mime:^6.2 \ symfony/options-resolver:^6.2 \ symfony/property-access:^6.2 \ symfony/property-info:^6.2 \ symfony/rate-limiter:^6.2 \ symfony/routing:^6.2 \ symfony/var-dumper:^6.2 \ symfony/yaml:^6.2 Resolves: #99239 Releases: main Change-Id: Iaff58735379cabb3a8dbb732fe4c254213a8ae6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76873 Tested-by:
-
- Nov 30, 2022
-
-
Benni Mack authored
This change introduces a Backend Route Result, similar to the Frontend Route Result object, using symfony's native URL routing component in TYPO3 Backend now, to allow to use placeholders in the URL. The Backend Route Result now contains the resolved Route object and the arguments defined in the Route, which are then resolved during the PSR-15 middleware when the Router kicks in. Note: In a later stage Router->matchRequest() will be deprecated. Resolves: #99234 Releases: main Change-Id: Id2030f8fe17457ea3791fdf4b88a375cc93ffd39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76865 Reviewed-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- Nov 29, 2022
-
-
Nikita Hovratov authored
Resolves: #99216 Releases: main Change-Id: I1d0e92fb5b5fbf91d873c8b5e8a6d313e1bea517 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76850 Reviewed-by:
-
- Nov 20, 2022
-
-
Christian Kuhn authored
Method return annotations identical to the return signature are useless and can be omitted. Resolves: #99143 Releases: main Change-Id: I5f268dfd166667df9df23e504575fcd904678b16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76740 Tested-by:
-
Christian Kuhn authored
Method parameter annotations identical to the parameter signature are useless and can be omitted. Resolves: #99142 Releases: main Change-Id: I907113b7049d551113c84aadec74c93597252069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76734 Tested-by:
-
- Nov 12, 2022
-
-
linawolf authored
Solves https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-ViewHelper/issues/50 Occurences of `:ts:` are adressed in https://forge.typo3.org/issues/99068 Resolves: #99069 Releases: main, 11.5 Change-Id: I49a42ba29017081d338bec815e3b2c5f14bf7a68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76566 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
linawolf authored
Replace `:ts:` with ``:typoscript:` in ViewHelper class comments. `:ts` does not render properly, see for example https://docs.typo3.org/other/typo3/view-helper-reference/main/en-us/typo3/fluid/latest/CObject.html Resolves: #99068 Releases: main, 11.5 Change-Id: Idfac843859a5e9054e6e48f29b19616b2b956dac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76562 Tested-by:
-
- Nov 10, 2022
-
-
Christian Kuhn authored
This is not about TypoScript constants/settings that are accessed using {$myConstant} in TypoScript setup. This is about the TypoScript setup "constants" top-level-object: It is used in TypoScript "parseFunc" and allows referencing string literals by name in "parseFunc" strings, which are substituted by using ###theName###, when property "constants = 1" is set in "parseFunc". This feature dates back to Kasper's "Initial revision" and is obsolete ever since: The feature exists next to well-known TypoScript constants, existing usages can be easily substituted. The confusion with TypoScript "constants" alone justifies a deprecation of this detail. The patch deprecates both the TypoScript setup "constants" top-level-object, plus the "constants" property in "parseFunc". Resolves: #99040 Releases: main Change-Id: I91546067db8a7eb72661087780e39f320db2cbeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76532 Tested-by:
-
- Nov 09, 2022
-
-
Christian Kuhn authored
The HtmlViewHelper relies of Frontend TypoScript "parseFunc" functionality and has an ugly hack to prepare Frontend rendering in Backend context. The core no longer uses f:format.html in Backend context since the introduction of f:sanitize.html and f:transform.html. Using f:format.html in Backend context should be deprecated. Resolves: #99031 Related: #94825 Releases: main Change-Id: I60c5ea36b664a35abde431d2ac845ee9e2bff4bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76519 Tested-by:
-
- Nov 07, 2022
-
-
Christian Kuhn authored
Switch the Extbase BackendConfigurationManager to use the new TypoScript parser. The implementation is quicker for Extbase Backend modules. Change-Id: Icb821fbe8804f219806abc5094ace3d404b96a73 Resolves: #99017 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76447 Tested-by:
-
- Nov 03, 2022
-
-
Georg Ringer authored
To avoid exceptions if arguments are given but empty, an additional check is added in extbase LocalizationUtility, plus the default in f:translate is changed back to the same 'null' value as in v11. Resolves: #98924 Related: #96473 Releases: main, 11.5 Change-Id: Idd08f7b948eb504999a80a215a7ded64f3c648a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76269 Tested-by:
-
- Oct 31, 2022
-
-
Benni Mack authored
This change modifies all places in TYPO3 Core to avoid using FormProtectionFactory::get() and use proper DI. A new method FormProtectionFactory->createForType(string $type) is added. In addition, FormProtectionFactory::set is removed as all affected tests are moved towards injection. The next step in this series is to deprecate the ::get() method and make a singleton out of the Factory to avoid purgeInstances() calls. Resolves: #98696 Releases: main Change-Id: I77cec532009ea4171f382bb5d9f207c0fcb7221c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76130 Tested-by:
-
- Oct 29, 2022
-
-
Nikita Hovratov authored
These comments don't add any value as the class under test can be easily determined from the filename. Executed commands: > grep -Rn -E "^\s\*\sTest case(\sfor.*|\.)?$" --include="*Test\.php" \ typo3/sysext/ | awk -F':' '{print "sed -i \047" $2-1 "," $2+1 "d\047 " $1}' | sh Some files with more comments needed manual adaption. Resolves: #98956 Releases: main Change-Id: Ia2fe96edda6ac26203bdfe8537a4d6e9d3e768c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76332 Tested-by:
-
