- Nov 29, 2020
-
-
Christian Kuhn authored
Code in ext_localconf.php must not create different framework state depending on the (frontend or backend) application type. The ApplicationType helper class does not work at this point in bootstrap, since the PSR-7 request object has not been created, yet. Solution is to always register the admin panel logger, and to decide within the logger instance if an incoming log record should be handled. Resolves: #92952 Related: #92951 Related: #92947 Releases: master Change-Id: If0834abff33d5ed1fa4f0e18c0f76c252db4013c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66943 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Daniel Haupt <mail@danielhaupt.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
-
Christian Kuhn authored
The cardinal issue with constant 'TYPO3_MODE' is that it's value is NOT constant: It is defined early during bootstrap and derived from information that is hand over from entry point index.php's. Depending on this, value is either 'FE' or 'BE'. Using that constant or the related constant 'TYPO3_REQUESTTYPE' makes it impossible to change scope from backend to frontend in one PHP call. This actively blocks executing sub requests, use cases are for instance executing a frontend request within a running backend call (eg. view module), or executing frontend requests from cli (eg. some indexer). Dropping 'TYPO3_MODE' and its friends is thus a requirement to finally allow such scenarios. We can't get rid of the distinction between 'frontend' and 'backend' altogether since some legit use cases like different paths or security settings depend on it. Looking at TYPO3 bootstrap, the only class that 'knows' if it's frontend or backend are the Application classes of ext:frontend and ext:backend. They are the PSR-15 entry points, they create a first PSR-7 request object if it has not been given, and then call the PSR-15 middleware stack dispatcher to create a PSR-7 response, starting with this first request object. The solution to get rid of 'TYPO3_MODE' is to add the information 'I am a frontend or backend request' as attribute to the request object in the Application classes. To simplify things, the helper class ApplicationType is introduced that answers isFrontend() and isBackend() for a given request object. Documentation changelog files with full details on the impact of this change will be added with an upcoming patch that deprecates the constants in master. This patch targets master and v10: 'TYPO3_MODE' is used in extensions quite often. Having the API in both v10 and v11 helps extension developers to deliver deprecation free extensions that are compatible with both v10 and v11 in one version. Codewise, neither the 'applicationType' attribute nor the helper class harm in v10. Resolves: #92951 Related: #92947 Releases: master, 10.4 Change-Id: Ia4ea637b252b774cf72492402e6be52ee4695242 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66942 Tested-by:
-
Christian Kuhn authored
Avoid usage of constant 'TYPO3_MODE' as security gate in script files that don't run in class or callable context. Use new constant 'TYPO3' instead. Resolves: #92949 Related: #92947 Related: #92948 Releases: master Change-Id: I95618793ed29b4b71e9e97ea8da124924d6753fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66938 Tested-by:
-
- Nov 28, 2020
-
-
Christian Kuhn authored
TYPO3 still has some script files that run in global scope without class or callable encapsulation. Those are especially ext_localconf.php, ext_tables.php and Configuration/TCA/Overrides/* script files. When those files are located within document root, they can be called directly via HTTP and may output something, which can be a security risk. To prevent this, they have a call at the very start: 'defined('TYPO3_MODE') or die();'. Unfortunately, constant 'TYPO3_MODE' is a technical debt, core tries to phase it out in v11. We thus need something equivalent for these calls. Since that test for existance of a constant is so simple and straight forward, the solution is to define a new constant to true, simply named 'TYPO3', to substitute 'TYPO3_MODE'. The call is very similar: 'defined('TYPO3') or die();'. The patch targets core master and v10: Having that constant in v10 simplifies life of extension developers who want to deliver extensions compatible with v10 and v11 in the same version, when 'TYPO3_MODE' constant is deprecated in v11 with upcoming patches. Resolves: #92948 Related: #92947 Releases: master, 10.4 Change-Id: Ib7b438422a41e242cf49cd4f87a6f8c50a9907d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66937 Tested-by:Benni Mack <benni@typo3.org> Tested-by:
-
- Nov 27, 2020
-
-
Andreas Fernandez authored
If may happen that the flatpickr is rendered behind a checkbox of nullable values in FormEngine due to conflicts in z-index. This patch increases the z-index of flatpickr. Resolves: #92912 Releases: master Change-Id: I632b424e6d00c48b5aef48ec1a15fdb7149f509a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66932 Tested-by:
okmiim <okmiim@live.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Daniel Goerz authored
A phpstan related patch revealed a flaw in EXT:form PropertyMappingConfiguration when an "EXT:" path was passed to the FAL ResourceFactory. Instead of relying on the InvalidArgumentException this patch now prevents the invalid argument from being passed in the first place. Resolves: #92908 Related: #92264 Releases: master, 10.4 Change-Id: I09ff5e28c28e8bbc2de954c1b9077969befb3646 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66852 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
Calling `AbstractTreeView::getIcon()` with the records uid as first argument is deprecated. This helps to increase type safety through the core and also properly reflects the expected value for the parameter, as its name is `$row`. Side note: There was no benefit in providing just the records uid since the full record was fetched in that case anyways internally, but without adding any restrictions or respecting any overlays. Because the method returns a string in any case, the return type is furthermore added to the method signature. Resolves: #92922 Releases: master Change-Id: I60ccaf17d8244a2a86fb3b9bc377ce19a6a58e69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66892 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Bartsch authored
Add the missing "delete" button to the RegularExpression validator for form elements "Telephone" and "Url", allowing to remove a previously manually added validator again. Note: The "Email" and "Number" form elements do both also include validators which are missing the "delete" button. But since this validators (email validator respectively number validator) are added automatically on form element creation, it's considered intended behaviour. Only validators which were added manually must provide the option to delete them again. Resolves: #92916 Releases: master, 10.4 Change-Id: I56969395ccb8237af6b48ed1793e1af9afc21423 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66877 Tested-by:
-
- Nov 26, 2020
-
-
Benni Mack authored
The UserTsConfig setting `options.lockToIP` is removed, which was only active the global setting $GLOBALS['TYPO3_CONF_VARS']['BE']['enabledBeUserIPLock'] was active. Happy Eyeballs makes this feature very useless, but if this is still needed, it should be rather implemented as an individual AuthenticationService or PSR-15 middleware than evaluated separately. Resolves: #92941 Releases: master Change-Id: I1e2be7784a3c4b54573b3c3118db1fb3109b0ddc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66640 Tested-by:
-
Benni Mack authored
The global configuration option, which is always active by default, restricts ALL non-administrators to be locked in to their webroots (DB mounts). Disabling this option would allow any editor to see the whole page tree, overriding most of the concepts used in TYPO3 Backend and permission handling. As stated in the description of the option, it is highly recommended for security reasons to leave this option enabled. This option is removed to streamline TYPO3's permission handling. Resolves: #92940 Releases: master Change-Id: I15f6538bdb34077a99cb8d2db7a21e60492bb923 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66908 Tested-by:
-
Remo Schneider authored
The `makeSearchStringConstraints` hook in DatabaseRecordList expects a class name to be given as value. The method to be called on the instantiated hook object is fix and can not be provided in the hook registration. Releases: master, 10.4, 9.5 Resolves: #92938 Change-Id: I43b0b553901019fa299bb4c9632722cf2beb759f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66907 Tested-by:
-
Markus Gerdes authored
This patch removes the concatenation of the queued messages of the spools in the __toString() methods which is needed for newer Symfony releases. Instead a simple identifier for representing the spool is returned. Resolves: #92934 Releases: master, 10.4 Change-Id: I8b8559dcb8235ec14951c7233fa49f736bdc4860 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66902 Tested-by:
-
- Nov 25, 2020
-
-
Oliver Bartsch authored
Add missing descriptions to ViewHelpers, improving the usability within the IDE as also on the ViewHelpers docs, since these values are rendered there automatically. Resolves: #92927 Releases: master, 10.4 Change-Id: I9b5506c39f92a65840da0d187f1c7cc7f4a1810b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66897 Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
-
Markus Klein authored
On updating an existing session we must use the un-hashed sessionId to query the existing session. Resolves: #92869 Releases: master, 10.4, 9.5 Change-Id: I4eecb8eaf84342261ba7d9b5a7a6dab619dad481 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66696 Tested-by:
-
- Nov 24, 2020
-
-
Oliver Bartsch authored
Resolves: #92905 Releases: master Change-Id: Id42f4f97bd43c78a326be0bb6d9248ba8f9a4b03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66827 Tested-by:
-
Benni Mack authored
used composer commands * composer req "doctrine/annotations:^1.11.0" * composer req "doctrine/instantiator:^1.4.0" * composer req "doctrine/lexer:^1.2.1" Doctrine DBAL will be handled separately Resolves: #92924 Releases: master Change-Id: I6c0da8e427724938519c70185004b61fbbe343fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66733 Tested-by:
-
Georg Ringer authored
The feature toggle for `fluidBasedPageModule` is removed to enforce the use of the new fluid based page module. The already deprecated `PageLayoutView` will finally be removed in a separate patch. Resolves: #92870 Releases: master Change-Id: I974a1b010cb14a545e80b7486f5f7c1f0083788e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66698 Tested-by:
-
- Nov 23, 2020
-
-
Dmitry Dulepov authored
Translation wizard will hang if there are new content elements to translate and there is an element with language "All". This change fixes the problem by disallowing to fetch elements with this language. The fix is contributed by the University of Basel. Resolves: #92751 Releases: master, 10.4, 9.5 Change-Id: Ib018e04f6e95a1dc1a1d1f57631a31b986a10cd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66557 Tested-by:
-
- Nov 22, 2020
-
-
Oliver Bartsch authored
Since #92836 backend users have to confirm their password on accessing the install tool in the backend. The corresponding password field now properly gets the focus assigned. This improves the accessibility, especially for keyboard users who otherwise had to tab through the whole module menu first. Resolves: #92895 Releases: master, 10.4, 9.5 Change-Id: I001f851b3730a864923c73a766026ed18d9c5466 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66773 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
- Nov 21, 2020
-
-
Sybille Peters authored
Resolves: #92894 Releases: master Change-Id: I21ab03f80924f27af267c9e4a401b53358ea6327 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66772 Tested-by:
-
Andreas Fernandez authored
Resolves: #92896 Related: #92888 Releases: master Change-Id: Icda106771196a1bcabd10651170f553bb56a7ffa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66793 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Nov 20, 2020
-
-
Oliver Bartsch authored
System notes are being displayed in various modules. Previously one however had to always switch to the list module to add such note. Therefore, a new button is added to the button bar of the page, list and info module which allows to directly create a new sys_note record for the current page. The new button can be disabled via page TSconfig. Resolves: #83814 Releases: master Change-Id: Id7ab3b7a25d14c67a2a1b41753e1eae34eecd69e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66373 Tested-by:
-
Alexander Schnitzler authored
With this patch method canProcessRequest() of class \TYPO3\CMS\Extbase\Mvc\Controller\ActionController has been removed because it could never fulfill its claim, enabling users to simply register custom request types and then have custom controllers be built and dispatched depending on the request type. Besides that, dispatching another controller than the one configured and requested is unwanted behaviour. Furthermore, the corresponding protected property $supportedRequestTypes and the UnsupportedRequestTypeException have also been removed. Releases: master Resolves: #92853 Change-Id: I2d7ae9fea86f5161e67e0f17a11f563b037cc412 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66644 Tested-by:
-
Matthias Weber authored
Add a visible label for the email input field in the forget password form. Releases: master Resolves: #92627 Change-Id: I8114b47e83320fdc730b4a0d4f6bf71761199226 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66273 Tested-by:
-
Olaf Schmidt-Wischhöfer authored
Also add aria-expanded and aria-controls arguments for screen readers Resolves: #92682 Releases: master, 10.4 Change-Id: I48d0edcbea4d185d11216048d7847ad3574d704d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66271 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Sybille Peters authored
The HTTP requests for checking external links did not have a timeout. The timeout from Global Configuration was used which is set to 0 (not timeout) by default. This could cause the link checking to run indefinitely and scheduler tasks to never terminate. Usually, there is a connect timeout, a read timeout and a total timeout. We set the total timeout and make this configurable via page TSconfig. If this is not set via TSconfig, it will default to the value set in $GLOBALS['TYPO3_CONF_VARS']['HTTP']['timeout']. Resolves: #92655 Releases: master, 10.4 Change-Id: Ib4727a665e41be247a7391c9ae814917df39df6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66241 Tested-by:
-
Elias Häußler authored
This patch adds keyboard navigation for the multi-step wizard handling duplication of existing forms in backend and improves accessibility. Resolves: #92819 Related: #90132 Releases: master, 10.4 Change-Id: Iea487044557dba0caf33f83e47b8c87a7d603040 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66605 Tested-by:
-
Martin Kutschker authored
States of checkboxes defined in the TCA with "invertStateDisplay" enabled are announced in the same way as the visual representation. The underlaying checkbox value is inverted instead of just inverting the corresponding visual representation. The CSS class "checkbox-invert" used for styling these checkboxes has been removed. Resolves: #92678 Releases: master Change-Id: Id35d0cc3b3872a8176f30eee6abdf49287a2c44a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66282 Tested-by:
-
Olaf Schmidt-Wischhöfer authored
Instead of <a href="#" ...> or <span ...>, a <button> tag is used for inline relations to enable proper keyboard navigation. * rename variable and protected method names from "link" to "button" * remove unsed $objectPrefix argument from getLevelInteractionLink (now ...Button) Resolves: #91595 Releases: master, 10.4 Change-Id: I167c175fe9e0fa211e637936e9d777459f892e79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66233 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Benni Mack authored
The PHP version that is required now, is PHP 7.4, more specifically PHP 7.4.1, which fixed a hard issue on the JIT compiler. Used composer commands: composer config platform.php 7.4.1 composer req php:^7.4 composer req php:^7.4 -d typo3/sysext/core --no-lock Releases: master Resolves: #92890 Change-Id: Iaf090b34b1f825adcdb5d42e8a4df20673677a6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66717 Tested-by:
-
Devid Messner authored
Replace the uid of the translated page with the uid of the original page in the mountpoint parameter. Resolves: #91328 Releases: master, 10.4 Change-Id: I6eeceff8b191cd76e134fda59e67550b58dfa985 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64952 Tested-by:
-
Sybille Peters authored
Linkvalidator ships with several Linktype classes that are used to check specific links such as ExternalLinktype, Filelinktype etc. The Linktype LinkHandler is not used by default (see Page TSconfig mod.linkvalidator.linktypes). It was used to check links of the extension "linkhandler" which is now outdated. The latest version supports TYPO3 4.1.0. Functionality from the extension linkhandler has been migrated to the core in TYPO3 8, but in any case the LinkHandler link type supports outdated link syntax starting with "record:". Resolves: #92693 Releases: master Change-Id: Ie0736720ce975b8ccf8e8323660e18d0c772b251 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66265 Tested-by:
-
Sybille Peters authored
When a broken link is fixed by using the pencil icon in list of broken links, the broken link should get removed from the list. Resolves: #92710 Releases: master, 10.4 Change-Id: I56e620313491414916f81cb32419348b7dab00d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66287 Tested-by:
-
Eric Chavaillaz authored
The TsConfig CGL are described: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/CodingGuidelines/CglTsConfig.html This patch ensure that those rules are now respected everywhere in the core. Resolves: #92820 Releases: master Change-Id: I7eef518c1aad5758a5d39d469ea16d5bbb97653b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66606 Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Sybille Peters authored
The edit record icon now has a proper button style to unify the appearance between the modules (e.g. redirect module). Resolves: #92823 Releases: master Change-Id: I899007222068fba39ff6672433908e04db31804e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66609 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Joachim Eckerlin authored
Additional wrapper around the sword in the search result template. Allowing CSS Styling to the word, but not the label. Resolves: #92786 Releases: master Change-Id: Iff9cab894883ed1cefe0769d40cad2f50ecf9102 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66695 Reviewed-by:
-
Anja Leichsenring authored
In order to improve quick result accessment, a summary is now outputted at the very end of the local test run. Details about test suite, php version and DBMS version are given, together with a clear message whether the test run was successful or not. Resolves: #92796 Releases: master, 10.4, 9.5 Change-Id: I0470a5e811088a5b56174ff66eaff1fd8387264e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66571 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
-
Markus Klein authored
The l10n_parent fields of sys_file_metadata and sys_file_reference are never shown anywhere. Having them as type 'select' in the TCA causes the FormEngine to try loading all possible parent value, which can be thousands or more. This degrades backend performance towards unusable. Changing the TCA definition to 'group' mitigates the issue easily as no lookup list has to be created/loaded. Resolves: #92863 Releases: master, 10.4 Change-Id: Ibf76ac51f6d79a69fdc19bfe1993bcb6c97de233 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66671 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Matthias Weber authored
Set the color of placeholders to #767676 to meet WCAG AA conformance for background-color #fefefe. Resolves: #92621 Releases: master Change-Id: I573876390cc628793817a5498479b0389afd05cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66262 Tested-by:
-
Christian Kuhn authored
It seems the DynamicReturnTypePlugin for PhpStorm does not deal with 'self::class'. Change a couple of makeInstance() calls to hint for the returned object. Resolves: #92876 Releases: master Change-Id: I2cd2ad28dcd4e3baba641bdbc0dbdbc50d6bde9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66699 Tested-by:
-
