- Mar 28, 2017
-
-
Wouter Wolters authored
Resolves: #80529 Releases: master Change-Id: Ic90bf297baad33576509f9ff13ab67674ba658ac Reviewed-on: https://review.typo3.org/52221 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Helmut Hummel authored
When file relations are added, the crop area of these is calculated, even if they are not images. We avoid that by only doing this processing, when the file has a width property. Resolves: #80071 Releases: master Change-Id: I42924b271e5a6697d35ffb7d5f322f555139ec57 Reviewed-on: https://review.typo3.org/52192 Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Hader authored
The current behavior for file fields using TCA type inline is configured to use localizationMode=select, which is deprecated. Actually files have been copied along during the localization of the parent record - and files can then be defined independently for the default language record and in the translated record. The localizationMode synchronization behavior was disabled in the user-interface. With this change the default core behavior will stay the same. If the localization buttons would have been enabled individually, this now can be done with the more specific allowLanguageSynchronization feature. Change-Id: I88668e3d0ce1dd192d32b93f0312796c59d62358 Resolves: #80504 Releases: master Reviewed-on: https://review.typo3.org/52201 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Cedric Ziel authored
Direct assignments are usually 2x faster and often more readable when pushing one value only. Releases: master Fixes: #80283 Change-Id: I16fc1938f74550d1a3d9f9c0cbafe85dc2ff1c5b Reviewed-on: https://review.typo3.org/52049 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
Now, all functionality for marker-based templates are encapsulated in MarkerBasedTemplateService, instead of polluting cObjectRenderer which is used a lot in the frontend, even though no markers are in use. All methods within ContentObjectRenderer have been marked as deprecated. Resolves: #80527 Releases: master Change-Id: If7a27281470935af893d1a9838f06ca77a3041c1 Reviewed-on: https://review.typo3.org/52220 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Benni Mack authored
The TypoScript properties config.setJS_mouseOver and config.setJS_openPic have been marked as deprecated. Resolves: #80516 Releases: master Change-Id: Ida5de8b3e873adfe7e27decf6e43813e7dc5cc2e Reviewed-on: https://review.typo3.org/52213 Reviewed-by:
-
Benni Mack authored
The public property DocumentTemplate->extJScode can be used to fill in ExtJS-specific code to be loaded on "onExtReady". The functionality is not used in the core anymore, as there are better ways to include JavaScript code in a backend response. Resolves: #80512 Releases: master Change-Id: I4cf24f6b096a79d76e1d30f587f25dcc8ca10fa4 Reviewed-on: https://review.typo3.org/52210 Tested-by:
-
Benni Mack authored
The method in DataHandler->destPathFromUploadFolder is basically useless nowadays and should be avoided, since it just prepends PATH_site to a string. The fourth parameter for extFileFunctions() is also useless as the method only is triggered for "deleteAll" and no other value is allowed. Resolves: #80513 Releases: master Change-Id: I371fd9233bbe63dd2d3775e4ddd8212358164ced Reviewed-on: https://review.typo3.org/52211 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
The two static methods are sole wrappers for the Caching Framework nowadays which can simply be dealt with in a custom way. Use the Caching Framework directly instead! Resolves: #80524 Releases: master Change-Id: I8fced0800a2c72705f1a01e0a3d6e52aeaf5daef Reviewed-on: https://review.typo3.org/52217 Reviewed-by:
-
Benni Mack authored
ContentObject renderer has an unnecessary call to $TSFE->sys_page for calling a static method in a non-static way. It should directly use the caching framework instead. Resolves: #80482 Releases: master Change-Id: Iaa93de3c1e98cf5e639605dcf49cb5715a28b5d7 Reviewed-on: https://review.typo3.org/52181 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Benni Mack authored
The ExtDirectApi simply calls PageRepository to store data in the "cache_hash" cache. This can be simplified by just using the Caching Framework directly without depending on a EXT:frontend class in a EXT:core class. Resolves: #80517 Releases: master Change-Id: I77825bf71264621fb984b39f79009baf71cfdec3 Reviewed-on: https://review.typo3.org/52214 Tested-by:
-
Benjamin Kott authored
Resolves: #80501 Releases: master Change-Id: I5371b546bb7ebffdfc78a5bbfe1b86699a4f4a43 Reviewed-on: https://review.typo3.org/52198 Reviewed-by:
-
Benni Mack authored
Loading a locallang.xlf inside the abstract function module now uses the regular $GLOBALS['LANG']->includeLLFile() of the current file, instead of doing a manual check on .xml and .php extensions, which the LanguageService/LanguageFactory is taking care of anyway. The PHP method incLocalLang() and the now not necessarily needed $thisPath are therefore marked as deprecated. Resolves: #80511 Releases: master Change-Id: I3a9d27bf794a4cd8c1f2d31ed9250d634aa68ee8 Reviewed-on: https://review.typo3.org/52209 Reviewed-by:
-
Benjamin Kott authored
Resolves: #80498 Releases: master Change-Id: I139922f0bb86e1ff1dc4bd9258491bd5eedaedc2 Reviewed-on: https://review.typo3.org/52195 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Christer Vindberg authored
Make sure to check the correct variable classesAnchorDefaultTitle when fetching the title of anchors. This affects CKeditor as well as htmlarea. Resolves: #80209 Releases: master, 7.6 Change-Id: I1cdd760ee1fe2879ac53edff38f25515d656d706 Reviewed-on: https://review.typo3.org/52205 Reviewed-by:
-
Frank Naegler authored
The current mail presets only allow to modify sendmail settings, but it's not possible to configure SMTP settings. Resolves: #80457 Releases: master Change-Id: Ib70351c9048c0ceec2b2a585d43a3ad04c81424e Reviewed-on: https://review.typo3.org/52167 Tested-by:
-
Benni Mack authored
The method cObject->URLqMark() adds a question mark to a string to append it. This method should not be in scope of cObject, but rather be put in e.g. StringUtility or GeneralUtility... however, since the functionality is rather simple, it can be achieved without any helper method as a one-liner. Resolves: #80510 Releases: master Change-Id: I5230c5a4e27f8ef198190defd15598023279c1c2 Reviewed-on: https://review.typo3.org/52182 Reviewed-by:
-
Benjamin Kott authored
Resolves: #80502 Releases: master Change-Id: I01cac3870381c1783e0a1bb1226c0ab537619455 Reviewed-on: https://review.typo3.org/52199 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Wouter Wolters authored
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
Frank Naegler authored
Resolves: #80507 Releases: master Change-Id: I5494a9a61829d6245fa2410c3bafe8c6bc4a9043 Reviewed-on: https://review.typo3.org/52206 Reviewed-by:
-
Georg Ringer authored
As the image field has been changed to FAL, also the model must be adopted. Resolves: #80437 Releases: master Change-Id: I09b6ef8db190467ee5dfea67e5e66ded12b99dcd Reviewed-on: https://review.typo3.org/52146 Tested-by:
Nikolai Townsend <info@nikolaitownsend.de> Reviewed-by:
-
Benjamin Kott authored
For a more streamlined rendering this patch adds nessesary html tags with fluid namespaces to all indexed_search templates, unifies indention and adds an empty space before closing bracket of self-closing tags. Resolves: #80392 Releases: master Change-Id: Ia6bc46c8fb602b4f3592094ad963691bbf412d7d Reviewed-on: https://review.typo3.org/52119 Tested-by:
-
Benjamin Kott authored
Resolves: #80484 Releases: master Change-Id: Ie17a8cc5cb118c9ecd381355b96d9e60cd278712 Reviewed-on: https://review.typo3.org/52183 Reviewed-by:
-
Benni Mack authored
There are some places where PHP comments have been done wrong (using doccomments) or where there is no comment at all. Resolves: #80503 Releases: master Change-Id: Ib12d3b82755d801abcbefe7127f1189239f766af Reviewed-on: https://review.typo3.org/52200 Reviewed-by:
-
Benjamin Kott authored
Resolves: #80505 Releases: master Change-Id: I8188f7c9c63776a41a2f4e5c5077139e55312281 Reviewed-on: https://review.typo3.org/52202 Reviewed-by:
-
Benni Mack authored
The protected property "AbstractXmlParser->charset" is set from the outside but never used anymore in either the abstract class nor in the subclasses. The protected method "getCharset()" is basically useless: a) it's never called or in use b) it has nothing to do with the XmlParser as it does not work with any properties / functionalities of the XmlParser itself. The protected method "initialize()" is called solely in the contructor which can be dealt with directly in the constructor (that's what a constructor is there for). The third parameter $charset within getParsedData() is now not needed anymore within the Parsers, as all expect UTF-8 for files. Resolves: #80486 Releases: master Change-Id: I929c3960fb5b94f5448a2d29f4a73fbb5d81a500 Reviewed-on: https://review.typo3.org/52185 Reviewed-by:
-
- Mar 27, 2017
-
-
Ralf Zimmermann authored
* Create 'grid rows' without 'grid container' wrappers * Disable 'grid containers' within the form editor by default because twitter bootstrap prohibits container nesting Resolves: #80455 Releases: master Change-Id: I3997943858ac3b235094b765697f724cb1e4c95d Reviewed-on: https://review.typo3.org/52166 Tested-by:
-
Benjamin Kott authored
Resolves: #80499 Releases: master Change-Id: I820ac450c5bd32c9d992dcfd39983b20c304799f Reviewed-on: https://review.typo3.org/52196 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Benni Mack authored
The parameter of the $TSFE->whichWorkspace() method decides whether the UID of the current workspace should be returned or the actual "title" of the sys_workspace record. As this parameter is not in use anymore and clearly makes this function harder to understand why and when someone could use this, this property is marked as deprecated. Instead, fetching the workspace title should happen in the place where it is needed. Resolves: #80485 Releases: master Change-Id: I06512e40c48b35826c0d0a89cc8c4cdcdc8773e6 Reviewed-on: https://review.typo3.org/52184 Reviewed-by:
-
Oliver Hader authored
Change-Id: I69beabad3e4b9419778d1ed7d1b181349089b139 Resolves: #80494 Releases: master Reviewed-on: https://review.typo3.org/52190 Tested-by:
-
Thomas Hohn authored
DataHandler does not need to force "live ID" processing to be enabled on RelationHandler when EXT:version is not loaded. Avoiding this saves some semi-expensive operations inside the RelationHandler class. Resolves: #78998 Releases: master Change-Id: If53cdd73db15352d6f4854a5aef4b407836cb6ce Reviewed-on: https://review.typo3.org/50970 Reviewed-by:
Claus Due <claus@phpmind.net> Tested-by:
-
Helmut Hummel authored
Due to usage of Fluid dynamic variable parts in the template, ratio IDs must not contain a "." Resolves: #80214 Releases: master Change-Id: I12dac926169c827c9e3022320dd90a058f72913b Reviewed-on: https://review.typo3.org/52194 Reviewed-by:
-
Benni Mack authored
The Frontend Controller (TSFE) does some initialization which should belong to the FrontendBackendUserAuthentication directly. Additionally, some further code cleanups are made for this area. Resolves: #80479 Releases: master Change-Id: I32d9c98bb511f1eaa1f56203c4678358107aa7bc Reviewed-on: https://review.typo3.org/52177 Tested-by:
-
Benni Mack authored
Resolves: #80492 Releases: master Change-Id: Id835329586bf0fa315dc46377bc195ace005da61 Reviewed-on: https://review.typo3.org/52188 Tested-by:
-
Benni Mack authored
The TypoScript Frontend Controller has a unnecessary dependency to a static call (which is made non-static !) of PageRepository which can be done exactly 1:1 by instantiating the cacheManager and fetching the "cache_hash" cache directly by storing and fetching the contents itself. Resolves: #80480 Releases: master Change-Id: If6f5976a6c07ea754915b9c612264d733a6b1a41 Reviewed-on: https://review.typo3.org/52179 Tested-by:
-
Frank Naegler authored
This patch adds a missing PHP version check to the /install/index.php file which exists only for the redirect to the install tool. Because of this missing version check an installation without PHP 7.0 will fatal with an parsing error. Resolves: #80496 Releases: master Change-Id: Iec97021fb18ac7a4cfa0dcf1961675c3d58305ee Reviewed-on: https://review.typo3.org/52193 Reviewed-by:
-
Markus Klein authored
FormEngineValidation is meant as integral part of FormEngine. The current dependency definition is inverted, such that FormEngine now depends on FormEngineValidation and not the other way around. Note that FormEngineValidation does not need any other feature of FormEngine, so this is safe. This solves a possible race condition with other modules. Releases: master, 7.6 Resolves: #80459 Change-Id: Ie2cb9dd90220b37a98bc8e3ca174fd074488cc8d Reviewed-on: https://review.typo3.org/52178 Tested-by:
Kay Strobach <typo3@kay-strobach.de> Tested-by:
-
Benni Mack authored
When the BackendController was just a plain backend.php file (back in TYPO3 6.2) there were some hooks available to load ExtJS components and JS/CSS files via include statements and relative paths. There are now better hooks within BackendController, so CSS and JS resources can be loaded via PageRenderer and within the BackendController scope. The obsolete methods and hooks are marked as deprecated. Resolves: #80491 Releases: master Change-Id: I9e0e72df7237ab958ec06f7d58a9fa41c75ba890 Reviewed-on: https://review.typo3.org/52187 Reviewed-by:
-
Benni Mack authored
The way of calling CLI scripts from within TYPO3 via the "cliKeys" functionality and the typo3/cli_dispatch.phpsh entrypoint have been superseded by the new Symfony Console integration. All code related to this functionality has been marked as deprecated. Calling the CliRequestHandler (which is the main entry point for the cli_dispatch.phpsh) will trigger a deprecation message warning. Resolves: #80468 Releases: master Change-Id: Ib72ab93bee27421163c9117ebedcc0e97e17d41e Reviewed-on: https://review.typo3.org/52173 Reviewed-by:
-
Benjamin Kott authored
Resolves: #80487 Releases: master Change-Id: I23db288f4592cc09fe183c32ec17931e99b4ea74 Reviewed-on: https://review.typo3.org/52186 Reviewed-by:
-
