- Feb 26, 2017
-
-
Thomas Hohn authored
In DatabaseIntegrityCheck the method selectNonEmptyRecordsWithFkeys also needs to take the BLOB into account or else it will fail with a PHP warning. Furthermore the returned tableColumns list may contain quoted fields names if the field name can be interpreted as a keyword for the used connection platform. This patch ensures the correct column information is received before further processing is started. Additionally the "Record Statics" module is fixed by checking for an empty TCA table field which invokes an exception. Resolves: #79347 Resolves: #79991 Resolves: #79992 Releases: master Change-Id: Ie455abd2da90d7dabc773ec345b5c8a87b0b5836 Reviewed-on: https://review.typo3.org/51813 Reviewed-by:
Christer V <cvi@systime.dk> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Anders Kostending <aha@systime.dk> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Claus Due authored
Prevents issues if key length exceeds maximum key lengt for the SQL server. Keys are now kept below a 255 byte limit. Change-Id: I8e0c2a167f94695dd728c777368fac9e779678d8 Resolves: #79993 Releases: master Reviewed-on: https://review.typo3.org/51828 Tested-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
-
Helmut Hummel authored
The code to transfer the inline parent context to form engine in Ajax requests exists but is currently non functional in some situations. The config is stored as array, which is hashed by serializing the array, and building the hash on that string. However that string is not transferred over the wire, but the json encoded array. If a float value was present at some place in this array, json_encode and json_decode will add a slight offset to these numbers than if the value is serialized. To avoid such errors, the hmac is now calculated and checked against the json encoded value. We also clean up the code in this area to avoid duplication and improve the hash calculation and comparison. By doing so, we can clean up and simplify the flex form handling for IRRE fields as well. Resolves: #79999 Releases: master Change-Id: I049d699f9f30edad0a9c8b06bbc3970e2cdac417 Reviewed-on: https://review.typo3.org/51783 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Joerg Kummer authored
The notification js object gets "duration" as additional default value. This can be increased for acceptance tests to ensure notifications don't vanish before they are tested. Activate two ac tests again that were disabled for that reason. Resolves: #79963 Releases: master Change-Id: Ib7bf046e7de1999fc693e08eeefc7d4c420bddae Reviewed-on: https://review.typo3.org/51832 Tested-by:
Joerg Kummer <service@enobe.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
-
Nicole Cordes authored
Currently it is possible to install incompatible extensions without confirming the overlay popup. This patch prevents submitting the overlay if the button is still disabled. Resolves: #80005 Releases: master, 7.6 Change-Id: Ia68539cb9ce2a82f1e90aef3823f60cfadee2ce1 Reviewed-on: https://review.typo3.org/51834 Tested-by:
Jasmina Ließmann <code@frauliessmann.de> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Thomas Hohn authored
If the user is not allow to modify the avatar it gets lost since there was no distinction between deleted and not allowed to modify causing the avatar to be deleted on save. Resolves: #80002 Releases: master Change-Id: I1cf6fa93c2af1122c481b52860990c2433d86594 Reviewed-on: https://review.typo3.org/51860 Reviewed-by:
-
Morton Jonuschat authored
The test only works on MySQL with disabled SQL MODE ONLY_FULL_GROUP_BY. All standard conformant database setups fail this test as the result of the query is not deterministic due to GROUP BY being evaluated before ORDER BY. Change-Id: Ib6d4599e0f5682e8b72971d0f35ef00cfa8d3e6a Resolves: #80014 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51844 Reviewed-by:
Johannes Goslar <jogo@kronberger-spiele.de> Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Michael Oehlhof authored
If there are no pages containing Page TSconfig settings in the page configuration an info FlashMessage is shown instead of an empty table. Resolves: #78509 Releases: master Change-Id: I4a5cda38746187a1147e5500e77b516cb9a85fd6 Reviewed-on: https://review.typo3.org/51043 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Christian Kuhn authored
Controller class UpgradeWizard of install tool method performUpdate() calls getDatabaseConnection() (old TYPO3_DB) and connects. This was done in the past to receive the list of executed queries during upgrade and is now implemented in the single upgrade classes directly. If running postgres, the connect attempt of old database class tries to connect to a mysql instance and runs into a timeout. Remove this TYPO3_DB left over from the install tool to successfully execute upgrade wizards on non-mysql platforms. Change-Id: Ia87ae4bce1c4f4992527f0fa6fbddebdb6e3733c Resolves: #80026 Releases: master Reviewed-on: https://review.typo3.org/51862 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Thomas Hohn authored
Length changes of TEXT/BLOB type are not analyzed by the Doctrine schema analyzer as only MySQL has different length version of these fields. Add a custom column comparator that compares the different fields length on MySQL to properly detect changes in field type. Resolves: #79722 Releases: master Change-Id: I2e448dcde02c3fa370496b4920dfad536fbafcd6 Reviewed-on: https://review.typo3.org/51807 Reviewed-by:
-
Claus Due authored
Solves an issue where DB may end up containing duplicates if the reference indexer is unable to finish, e.g. if memory or max execution time are exhausted. Such cases would leave duplicate indexed references. The patch avoids those duplicates by ensuring that the patch does not contain a sorting value, which lets the reference indexer retrieve the original reference even if it has a new sorting. Further an update wizard is added that allows to rewrite the hash of existing records. Resolves: #78829 Releases: master Change-Id: I145aa60460c5904a83b6c8373f107c7bfce8b434 Reviewed-on: https://review.typo3.org/50803 Reviewed-by:
-
Georg Ringer authored
The lowlevel CLI tasks have been migrated to symfony commands and therefore the readme has to be updated as well. Resolves: #79996 Releases: master Change-Id: If584569680bfcf769056b39b5472571deeb21807 Reviewed-on: https://review.typo3.org/51839 Tested-by:
-
Georg Ringer authored
The header of the element "shortcut" states "not visible in frontend" and it should not be shown (like it was previously). Resolves: #79825 Releases: master Change-Id: I87db1e47211983f259c0323a6b0b684e23f012e2 Reviewed-on: https://review.typo3.org/51708 Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
-
Anja Leichsenring authored
irre_tuturial test extension uses TCA setting 'localizeReferences', but that setting does not exist and has no meaning in TCA. Remove it. Resolves: #80015 Releases: master Change-Id: I421b392cb7dec2c9530d86f926fd0169efe99b82 Reviewed-on: https://review.typo3.org/51848 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Thomas Hohn authored
Join consecutive lines for INSERT statements in ext_tables_static+adt.sql using a space instead of a linefeed to avoid parser errors. Resolves: #78892 Releases: master Change-Id: Ide550419b7ef41109a660a671b8aba65a33eb6b3 Reviewed-on: https://review.typo3.org/51854 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Helmut Hummel authored
The dynamic variable syntax does currently work in Fluid standalone, but not with the variable provider used for TYPO3 CMS (as promised) To fix this, we copy the necessary code to the CMS variable provider as it is only a few lines. Cover that with tests and apply it in the image cropper UI as one example. Resolves: #79997 Releases: master Change-Id: I3a811b0d496b12191d2ccbaa9c07525f4cf8f340 Reviewed-on: https://review.typo3.org/51841 Tested-by:
-
- Feb 25, 2017
-
-
Susanne Moog authored
The current user permissions were not initialized for the context menu resulting in non-existing permissions for editors (and no possibility to copy a page). Change-Id: I8fe747a1f19b4bea794b7fdbd676e7f366eea695 Resolves: #80019 Releases: master Reviewed-on: https://review.typo3.org/51852 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Sascha Egerer authored
Throw a meaningful InvalidXmlFileException when an invalid locallang.xml file is detected. Resolves: #79908 Releases: master, 7.6 Change-Id: Idc5586166d2475edeaeef407128525ea57fb9a09 Reviewed-on: https://review.typo3.org/51761 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Tested-by:
Faton Haliti <fha@systime.dk> Tested-by:
-
Mads Jensen authored
Fixes a bug where editing a backend user record without updating the password would result in the password being set to the string literal "*********". This reverts #79576 because the fix for showing the password hash in the readable field was wrong and causing this bug. Instead of forcing the database value in the hidden field to be asterisks, we now correctly set the type of the human readable field to be password. This triggers a special handling in the form engine JavaScript, not filling the human readable field with the database value and switching to type text when entering a new password. Resolves: #79714 Reverts: #79576 Releases: master Change-Id: Ia465293272131c32bbb9fd9b0d3916676e130996 Reviewed-on: https://review.typo3.org/51829 Reviewed-by:
Mads Lønne Jensen <mlj@systime.dk> Tested-by:
-
Christer Vindberg authored
Moved the check for if the target is coded as a JS open window link, to a later stage in the function. Since Css Styled Content and Fluid Styled Content was refactored, the target might not be set until later in the typoLink function. This caused pop links to stop working, moving the check for a pop up link target to a later stages fixes the problem. Resolves: #79918 Releases: master Change-Id: Ie27fa3142df83c33ba3ad465ecb35c0f6e571f86 Reviewed-on: https://review.typo3.org/51830 Tested-by:
Timo Hund <timo.hund@yahoo.com> Tested-by:
-
Nicole Cordes authored
The current implementation for getting paginated items from ObjectStorage objects in TYPO3\CMS\Fluid\ViewHelpers\Widget\Controller\PaginateController enforces null items if the count of objects is lower than the itemsPerPage count. This patch calculates the correct count and returns valid items only. Resolves: #79559 Releases: master, 7.6 Change-Id: I5746d83120474d6246da949f67096459ed1076d7 Reviewed-on: https://review.typo3.org/51475 Tested-by:
-
Nicole Cordes authored
Due to some security changes in GeneralUtility::validPathStr some wrongly encoded files are now returned as invalid. This breaks e.g. the file list. This patch adds a try/catch block to ignore invalid files and return the valid ones. Resolves: #79776 Releases: master, 7.6, 6.2 Change-Id: Iaa3697b04c123bba61a426fdf39ee3959f68b705 Reviewed-on: https://review.typo3.org/51655 Tested-by:
Tobias Liebig <tobias.liebig@typo3.org> Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Raphael Okon authored
The fix is to remove previously introduced CSS hacks and provide a cleaner and leaner base Resolves: #79998 Resolves: #79989 Releases: master Change-Id: Ic63b3acaf46f50f92a3c44578c28748dfca74351 Reviewed-on: https://review.typo3.org/51842 Tested-by:
-
- Feb 24, 2017
-
-
jliessmann authored
Use bootstrap grid to arrange image thumbnails Resolves: #79960 Releases: master Change-Id: I99ef6fc159c1497ea5464ef33398cf799c91a534 Reviewed-on: https://review.typo3.org/51810 Reviewed-by:
-
Christer Vindberg authored
When [FE][pageNotFoundOnCHashError] = true, searching with Indexed search in FE causes an 404, because the POST action is missing the cHash. Resolves: #79970 Releases: master Change-Id: If4f205ddfd264b1213ef696265fda0a8a6d9f29c Reviewed-on: https://review.typo3.org/51809 Tested-by:
-
Nicole Cordes authored
This patch adds the modal context to be able to confirm the installation of an incompatible extension. Resolves: #79995 Releases: master Change-Id: I84187076684eb1fb4ee69679f8003ec115a6bf2c Reviewed-on: https://review.typo3.org/51826 Tested-by:
-
Thomas Hohn authored
Some references to the _cli_lowlevel were still present and have been removed. Resolves: #79986 Releases: master Change-Id: I79473cc422a21761b3474facb4f981501ed7f545 Reviewed-on: https://review.typo3.org/51814 Reviewed-by:
-
Mads Jensen authored
Added CSS to ensure images are contained in parent element. Resolves: #79971 Releases: master Change-Id: I38a4038af067166d771d012e2ddc0e2983060513 Reviewed-on: https://review.typo3.org/51802 Reviewed-by:
Morten Pless <mpl@systime.dk> Tested-by:
-
Timo Schmidt authored
Currently you get an error in the backend when you try to set the language to "all" for a new or existing content element (integer was expected but null received triggers PHP strict type error). The reason for this is, that the DataMapProcessor tries to sychronize elements from tt_content with uid 0. This patch adds an integration test that content elements without an existing source do not get synronized. Resolves: #79853 Releases: master Change-Id: I67d4b35efe1564c13e9faf085c4848f2d0313998 Reviewed-on: https://review.typo3.org/51804 Tested-by:
-
Christian Kuhn authored
A recently added test in extbase query building reveals a non-trivial-to-fix issue of the created query with postgres. This is the last issue we have with functionals on postgres, to have them running as pre-merge tests we for now disable the offending tests on that database platform, and handle the real fix in a separate issue. Change-Id: I830af04ecdb41fa968421521e9860c388f74d75b Resolves: #79987 Related: #79988 Related: #79931 Related: #79932 Related: #79330 Releases: master Reviewed-on: https://review.typo3.org/51818 Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Morton Jonuschat authored
Deprecate BackendUtility::getRecordsByField() as it has a flawed design due to passing SQL fragments. This contradicts the goal of using named parameters for all queries in the core and requires passing the original QueryBuilder object in addition to the stringified constraint. Replace all calls to the method with direct usage of the QueryBuilder and deprecate the method. Resolves: #79122 Releases: master Change-Id: I8b040b98e20271aff84ef16fb89b59a406d54003 Reviewed-on: https://review.typo3.org/51078 Tested-by:
-
Benjamin Franzke authored
All redirect status codes (e.g. 201,301,303,307) are incorrectly sent as 302. We need to set the response code before setting the Location header, as a call to header('Location: ...'); sets the response code implicitly to 302 (unless it has already been set to 201 or 3xx) [1]. By settings the status code/header first, header('Location: ..') will not change the status code, if the PSR-7 response object contains a proper redirect status code. [1] http://php.net/manual/en/function.header.php The second special case is the "Location:" header. Not only does it send this header back to the browser, but it also returns a REDIRECT (302) status code to the browser unless the 201 or a 3xx status code has already been set. Change-Id: Ifa076e6393c6ed42d93959fe8c3a5b79cee145a4 Fixes: #79043 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51002 Tested-by:Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
Marco Huber <mail@marco-huber.de> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Josef Glatz authored
Add a description field also for fe_users records which could be used as for already known other record types. Resolves: #79894 Releases: master Change-Id: Ia1d7ad7746a0b7dd3ebb809864e290db97ac228d Reviewed-on: https://review.typo3.org/51745 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Jasmina Liessmann authored
Use Bootstrap grid for arrangement of search form fields. Resolves: #79848 Releases: master Change-Id: Ied1b30a2ba81b339ac93a9a874720b43623e6e66 Reviewed-on: https://review.typo3.org/51812 Reviewed-by:
-
- Feb 23, 2017
-
-
Helmut Hummel authored
Fix the changed path as well Resolves: #79980 Releases: master Change-Id: I5b23e4bb56f47d151b506439c4e46b9c0838bd87 Reviewed-on: https://review.typo3.org/51811 Reviewed-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Morton Jonuschat authored
Introduce dedicated fixures for the export data based on the database platform being tested. Due to mysqlnd and PDO based drivers returning different types of values (mainly int vs string) the resulting XML is dependent on the database. Change-Id: I776cfbc28c7355e72c21fa89097077f94225e223 Resolves: #79798 Releases: master Reviewed-on: https://review.typo3.org/51774 Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
Christian Futterlieb authored
In order to avoid time-based hash-based attacks, the native PHP security functions are used instead of simple string comparisons, when comparing passwords with hashes. Change-Id: I0dbe2c12c5017f9d71ea7628ddd35d919510ac12 Releases: master Resolves: #79888 Related: #79795 Reviewed-on: https://review.typo3.org/51737 Reviewed-by:
-
Thomas Hohn authored
During copying of pagetrees various sql statments are executed. One on sys_file_reference has a bad performance and can benefit from an index. Fixes: #79604 Releases: master Change-Id: I2caa83db6259ad6baad75427b5040a11ece768ba Reviewed-on: https://review.typo3.org/51512 Tested-by:
-
Sascha Nowak authored
In the current implementation it is not possible to create a new translations outside of the default translation. So we can readd the new translation option when the record has a default translation. Change-Id: I89c4200ff847dadfdeec03b5f43a6577f40702e3 Resolves: #72797 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51092 Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Stefan Froemken authored
It is not possible to change or override cropVariants via TSconfig for sys_file_reference (e.g. for a specific user or page tree branch), thus making the cropping functionality a pain for bigger sites. Setting a FormEngine option as expected like TCEFORM.sys_file_reference.crop.config.cropVariants.* does now work. Resolves: #79812 Releases: master Change-Id: I9d36f6661c2a5ca051b803f06485fdb4c8c8a437 Reviewed-on: https://review.typo3.org/51676 Reviewed-by:
-
