- Jun 02, 2017
-
-
Christian Kuhn authored
This reverts commit c2a9726c from review https://review.typo3.org/#/c/50803/ due to regression in #81320 Change-Id: I496e13ce9efe743a5607e12b46a3fdc90e2f17c2 Resolves: #81320 Reverts: #78829 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52921 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jun 01, 2017
-
-
Benjamin Kott authored
Resolves: #81411 Releases: master, 8.7 Change-Id: I2b0f848ee6db870e78d8d102ef48ba2b417f91d7 Reviewed-on: https://review.typo3.org/53007 Tested-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
Jasmina Liessmann authored
Add scroll possibility for modal body. Resolves: #81387 Releases: master Change-Id: I11d54473a6996bee534ea5663cc0de5a4552b66e Reviewed-on: https://review.typo3.org/52998 Reviewed-by:
Jasmina Ließmann <code@frauliessmann.de> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Claus Due authored
JSON encoding ViewHelper from Fluid is fully compatible. Also removes a number of unused arguments in the Fluid template - note that removed ViewHelper declared it was a tag based ViewHelper which supports additionalAttributes, but did not render a tag, which is why all the attributes were simply ignored and unused. Change-Id: I8d59f5a5e8971aac2b63be86c0a51aaf56437306 Resolves: #81301 Releases: master Reviewed-on: https://review.typo3.org/52903 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Claus Due authored
Counterparts exist in Fluid engine. Change-Id: I7fd0bc3b5569196858a8f5aa6967de2bf76385b1 Resolves: #81307 Resolves: #81106 Releases: master Reviewed-on: https://review.typo3.org/52915 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Hader authored
If loading the backend using a slow internet connection an early click on any item in the module menu on the left side causes the link to be opened directly. The reason is, that JavaScript and thus click handlers are not completely loaded yet. Thus, the regular DOM behavior of anchor tags is executed. To circumvent this behavior, href-arguments have to be disabled and the module URL moved to a dedicated new data-attribute. As a result all items that trigger a module change have to be adjusted as well. Resolves: #80565 Releases: master, 8.7 Change-Id: I4687e6594eb539acc0d299dc8fc02e6820019911 Reviewed-on: https://review.typo3.org/52996 Tested-by:
-
Georg Ringer authored
Instead of using a custom viewhelper in the EXT:cshmanual use the ViewHelpers of fluid and chain those. Resolves: #81324 Releases: master Change-Id: I7b936b0d684333909c71f35bfe8156a51688646a Reviewed-on: https://review.typo3.org/52926 Tested-by:
Joerg Kummer <service@enobe.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
In preperation of a scss linter and typescript linter we require bower as root dev dependency and register some happy little scripts. Change-Id: I425fd848a4012065fc7d955be0ae961f0f2ee8c4 Resolves: #81410 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53003 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Jasmina Liessmann authored
Use absolute position for hints of remaining characters to prevent form fields from being moved down. Resolves: #77069 Releases: master, 8.7 Change-Id: Iacba62543b036309e17828ab86f1986eb65f36a0 Reviewed-on: https://review.typo3.org/52997 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Benjamin Kott authored
The file describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates. https://docs.npmjs.com/files/package-lock.json Resolves: #81406 Releases: master Change-Id: I8c2f0d7a8d6a1d0cd7434d8e753a32d387b32f8f Reviewed-on: https://review.typo3.org/52993 Reviewed-by:
-
Johannes Goslar authored
Resolves: #78464 Releases: master, 8.7 Change-Id: I8d861df1e047213a355d145e05a9131386c7439f Reviewed-on: https://review.typo3.org/52991 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- May 31, 2017
-
-
Christian Kuhn authored
Functional tests annotated with "@group mysql" are currently ignored if running tests on postgres via "--exclude-group mysql" argument. With mssql we have some tests that run fine with mysql and postgres, but not with mssql. To improve handling, "@group mysql" annotation is renamed to "@group not-postgres". Tests not available on postgres and mssql will then later have a second annotation "@group not-mssql". This way its easier to keep track which tests go red on which DBMS. Change-Id: I2522b00352f1a7d61479588a22cdd9ea5d454ca3 Resolves: #81394 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52984 Tested-by:
-
Claus Due authored
Multiple calls to get() from cache can be condensed to one. Change-Id: I1d949fcbc0c91afdbfb2d0e2bc3d9c1b4dfd475a Resolves: #81385 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52974 Tested-by:
-
Christian Kuhn authored
The ext:impexp functional tests are rather hard to read and follow. The patch untangles them to make them better maintainable: * Combine the two different import / export abstract classes into 1 class * Don't inherit from AbstractDataHandlerActionTestCase anymore * Give single test cases better file names and do not hide them in sub dirs * Move all fixtures to Fixtures/ dir * Use less helper methods to import and test things * File paths are more straight and with less helper magic Change-Id: Iae36771b94045f99444f394129cbcf183168b584 Resolves: #81393 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52980 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Georg Ringer authored
Use the term "Upgrade wizard" instead of "Update wizard" for the buttons of the single steps as the main menu item is also called "Upgrade wizard". Resolves: #81383 Releases: master, 8.7 Change-Id: I8047ae45101533a67fa4488af7040acc49af563f Reviewed-on: https://review.typo3.org/52973 Tested-by:
Elmar Hinz <t3elmar@gmail.com> Reviewed-by:
-
- May 29, 2017
-
-
Elmar Hinz authored
Support case sensitve file systems again. Releases: master, 8.7 Resolves: #80814 Change-Id: I82274b328e9cfa75fb35360145d7a668d1270dc3 Reviewed-on: https://review.typo3.org/52939 Tested-by:
Claus Due <claus@phpmind.net> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Markus Klein authored
http_build_query() internally uses the PHP setting arg-separator.output to identify the URL parameter separator. This does not seem appropriate for URLs generated by TYPO3. Use the optional parameters of http_build_query() to get the desired functionality. Releases: master, 8.7, 7.6 Resolves: #81366 Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf Reviewed-on: https://review.typo3.org/52934 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
-
Daniel Goerz authored
Resolves: #81272 Releases: master, 8.7 Change-Id: Iac3d486697b8c52fbace185ab1a55c514847db07 Reviewed-on: https://review.typo3.org/52863 Tested-by:
-
- May 28, 2017
-
-
Georg Ringer authored
Remove the last parameter of method makeEditForm_accessCheck in BackendUtilityHook as it is unused. Resolves: #81290 Releases: master Change-Id: I46a8d88273765762c6dbc8793b76e35b5a2b6653 Reviewed-on: https://review.typo3.org/52924 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- May 26, 2017
-
-
Georg Ringer authored
Escape the < > in the check of the Windows Apache ThreadStackSize. Resolves: #81134 Releases: master, 8.7 Change-Id: Iaa73e61438766f413ba7aeeaebac0fcbf41f1a99 Reviewed-on: https://review.typo3.org/52925 Tested-by:
-
- May 24, 2017
-
-
Markus Klein authored
http_build_query() internally uses the PHP setting arg-separator.output to identify the URL parameter separator. Our code relies on having a simple ampersand as this character. If the PHP is set to a different configuration the code will fail. This is fixed by enforcing the ampersand. Moreover we force RFC3986 encoding to ensure that decoding with rawurldecode() does the right thing. Releases: master, 8.7 Resolves: #81293 Change-Id: I321c7bba03ee597adc29a2f8429b8fc9ac3b709d Reviewed-on: https://review.typo3.org/52922 Reviewed-by:
Carsten Falkenberg <office@limebox.de> Tested-by:
-
- May 23, 2017
-
-
Christian Kuhn authored
Some DB drivers are picky on their arguments not being objects. Add an explicit cast to string for a VersionState object just before it's fed to a query as argument. Change-Id: I81c8f9dded7068ad7bf817e034aa67a29f28290c Resolves: #81309 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52916 Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
- May 22, 2017
-
-
Stephan Großberndt authored
Using the correct datatype "string" instead of a \Doctrine\DBAL\Schema\Identifier as TableDiff->name prevents exceptions if another SchemaEventSubscriber is registered. Releases: master, 8.7 Resolves: #81276 Change-Id: If273a165604ff3149d8e5aba2c0b5ccbdef8102d Reviewed-on: https://review.typo3.org/52872 Tested-by:
-
Stephan Großberndt authored
Using $connection->getSchemaManager()->listTableNames() instead of ->listTables() in Install Tool prevents a DBAL\Exception as the table details are not requested - which are not used anyway, so this is faster too. Releases: master, 8.7 Resolves: #81264 Change-Id: I35db1b6fa743ad4869bf2ba24717320f0f009995 Reviewed-on: https://review.typo3.org/52858 Tested-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
-
Stephan Großberndt authored
Re-enable the tests passing tests changeExistingColumn() and installDoesNotAddIndexOnChangedColumn() in SchemaMigratorTest. Resolves: #81302 Releases: master, 8.7 Change-Id: Idaf9d87c16d58864c6de3353ec68be46ae93024f Reviewed-on: https://review.typo3.org/52905 Tested-by:
-
Claus Due authored
This patch reduces the amount of time required to check CGL to less than 3% of what it was before when xdebug is loaded and the script is asked to check ~100 files. Time before: 17m Time after: 23.3s Change-Id: I533ac3bfd03922362ccd6180caf6df2bfecd5bac Releases: master, 8.7 Resolves: #80814 Reviewed-on: https://review.typo3.org/52417 Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
Anja Leichsenring authored
Ext:core comes with a little testing framework for functional tests, that is pretty useful for all kind of DataHandler related tests. Those classes are better located in the testing-framework package to be available. Change-Id: I429e801b7318fda3a96acb4f5f63bb75050fb3e3 Resolves: #81154 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52728 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Anja Leichsenring authored
Resolves: #81284 Releases: master, 8.7 Change-Id: I59730f5807d27bbc7eb232917763daa89f41315a Reviewed-on: https://review.typo3.org/52879 Tested-by:
-
Thomas Hohn authored
Copying big sub-trees can benefit from caching the calls to doesRecordExist_pageLookUp in a run-time cache since there are a lot of identical calls to the database. In addition the signature was adjusted - see also the already merged issue #77391 which altered the signature. Resolves: #79610 Releases: master Change-Id: I2da164193f13759123d57c17985be46e7bd7667b Reviewed-on: https://review.typo3.org/51516 Tested-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Tested-by:
-
Christian Kuhn authored
A basic acceptance tests clicking through installer using a mysql db connection, checking backend login and "blank" site frontend output works. Change-Id: Ie14d9c6fd8280d382b4041f98fa04ed00ef8386c Resolves: #81285 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52880 Tested-by:
-
Christer Vindberg authored
Use quoted/escaped values embedded in the SQL fragment instead of named parameters in QueryGenerator::getSelectQuery. The values of named parameters get lost when the SQL fragment is returned and subsequently used in a query. Resolves: #80872 Releases: master, 8.7 Change-Id: If22bf24b75d2aa0efe36e587e38e7c590f3ec34a Reviewed-on: https://review.typo3.org/52472 Tested-by:
Christer V <cvi@systime.dk> Reviewed-by:
Anders Kostending <aha@systime.dk> Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- May 21, 2017
-
-
Christian Kuhn authored
Change-Id: I4ce5bae6d200bbd7eba6679136375c71cfb6e268 Resolves: #81289 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52889 Reviewed-by:
-
Christian Kuhn authored
A couple of bug fixes and a setup for acceptance tests of the installation procedure. Change-Id: I97c211acb6f65a48ee90a45885887f8d16f800b9 Resolves: #81287 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52885 Tested-by:
-
Elmar Hinz authored
Releases: master, 8.7 Resolves: #81280 Change-Id: I8689827c9e33202e7659a39bb55e7a9bfd792aa2 Reviewed-on: https://review.typo3.org/52877 Tested-by:
-
- May 20, 2017
-
-
Christian Kuhn authored
The components/ directory has been a temporary directory in v8 phase, does not exist anymore and can be removed from .gitignore. Change-Id: I0f690c8fb38733dc8d168a7e43078dffc60450ea Resolves: #81286 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52881 Tested-by:
-
- May 19, 2017
-
-
Anja Leichsenring authored
If the code given for PageNotFound_handling is a relative URL, the host determination gets skipped, resulting in a redirect of the markup of the page instead a proper redirect. Change-Id: Id9c26cba813c212438368cee031673dc59db360b Resolves: #81267 Relates: #81031 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52859 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- May 18, 2017
-
-
Thomas Schur authored
Prevent duplicated special char conversion of page title in TYPO3 backend breadcrumb and fix title cropping Resolves: #81242 Releases: master, 8.7 Change-Id: Id7710d8d8f79e20b20f43569558833d3d3f68f16 Reviewed-on: https://review.typo3.org/52820 Reviewed-by:
-
Josef Glatz authored
Related: #81171 Resolves: #81258 Releases: master Change-Id: I2a07571bb45aefd5927498dee5604edb99ba271b Reviewed-on: https://review.typo3.org/52855 Reviewed-by:
-
Benni Mack authored
The method PageRepository->checkWorkspaceAccess() does a SQL query to fetch the workspace record, then hands it over to BE_USER->checkWorkspace which has the same functionality - to fetch the full workspace record. As this is redundant code, the PageRepository code can be simplified a lot by just leaving the workspaceCache property. Resolves: #81187 Releases: master, 8.7 Change-Id: Ia82febb2269084ea9101acfc36a1c9aa20950290 Reviewed-on: https://review.typo3.org/52754 Tested-by:
-
Oliver Hader authored
Tryign to determine workspace versions for a particular database table results in a very long process execution time and possible timeout due to the following reasons: * in general a bug was introduced during the Doctrine DBAL migration which leads to misbehaviors in resolving versions for pages * the SQL query implicitly creates an INNER JOIN with a huge result set that takes a long query time * invalid types leading to possible flaws when using prepared statements The SQL query has been split into using sub-queries now. Change-Id: I4e4f69815bd73f0562f7ffbd6d411b417be7a18a Resolves: #80898 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52506 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
