- Mar 14, 2023
-
-
Benni Mack authored
Change-Id: I93a8567b97e7e1cd9c4b95fee83012810045de2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78113 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Thomas Hohn authored
Added string cast before trimming $typoLink. Changed annotation to be string|null. With TYPO3 v13 string should be added to the methods signature and cast removed. In addition fixed some potential calls that could have sent null to the method, prophylactically. Resolves: #99975 Releases: main, 11.5 Change-Id: I8cbafa51d96e3ab35d39855831803897b4ff0035 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77956 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
- Mar 13, 2023
-
-
Thomas Hohn authored
If an image has been deleted and marked missing in sys_file, the cImage method tries to access $info[3] which is null. Added a null coalescing operator around the access to $info[3]. The code has been rewritten in TYPO3 v12 and will ensure that value of $info[3] is a string. Resolves: #100132 Releases: 11.5 Change-Id: I152f8cc8fe74afb5513c023b0774c23e9f8134a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78086 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Daniel Hettler authored
When indexing files the FileContentParser collects some metadata e.g. title, description and keywords. For some files these information are not given and the parser breaks in an PHP 8 environment. Resolves: #100122 Releases: main, 11.5 Change-Id: I54b5512c7e30c9719654591d520943733fbfe920 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78053 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Sybille Peters authored
The PHPDoc block in the ViewHelper source is used to render the ViewHelper documentation. Remove link to Changelog with incorrect formatting in asset.css ViewHelper, which never worked. As the Changelog is from version 10.4, there is little benefit and more risk of linking to outdated information in the future. Resolves: #100151 Releases: main, 11.5, 10.4 Change-Id: I0b11e7ec90ccfa8864ca4ddaa7ca83004fe266c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78055 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Mar 09, 2023
-
-
Oliver Klee authored
This version removes some false positives from the baseline. > composer req --dev phpstan/phpstan:^1.10.6 > composer req --dev phpstan/phpstan-phpunit:^1.3.10 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100133 Releases: main, 11.5 Change-Id: I1120a6b808baff1af8993ca700725b09987e76ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78054 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Oliver Klee authored
For variable arguments, the type annotation needs to match the type of the single arguments, not an array of the single arguments. Resolves: #100127 Releases: main, 11.5, 10.4 Change-Id: Ic107cff8e08c00b18ced783d61783ed182039fd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78081 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Mar 08, 2023
-
-
Andreas Fernandez authored
The LiveSearch in the TYPO3 backend is configured to wait 250ms for additional input before sending the request to the server. Previously, every entered character triggered an independent search, unnecessarily hammering the server with requests. Resolves: #100011 Releases: 11.5, 10.4 Change-Id: Ifd2499b03ed6f149432f0224480a188a35ef7c88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77926 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Klee authored
Resolves: #100080 Releases: main, 11.5 Change-Id: If607b7dc6d8f7bdc984751835433dabcc6cad085 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78052 Tested-by:
-
- Mar 07, 2023
-
-
Torben Hansen authored
The redirect mode `referer` has been fixed with #91844. The fix is however incomplete, since it always uses the current HTTP_REFERER for redirect evaluation. This is problematic, if the login fails due to wrong credentials. In such a scenario, the user is redirected to the login page, which also overwrites the original HTTP_REFERER and results in the user being redirected to the login page after successful login. This patch ensures, that the original HTTP_REFERER is evaluated in the loginAction and passed as a variable to the login form, where it is used in the hidden field `referer`. This ensures, that the initial evaluated referer is kept in the failed login scenario. Change-Id: Ie9e81378080c4259044fc7777010e32adc861673 Resolves: #99920 Related: #91844 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77969 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
- Mar 06, 2023
-
-
Andreas Fernandez authored
The "superglobal" `TYPO3.Utility` TypeScript module was removed in v10 with #87339. However, the related definition in our index.d.ts was forgotten, which is now removed. Resolves: #100095 Related: #87339 Releases: main, 11.5 Change-Id: Iece43a40b93f8ebfd1c312c09566600272bdfe10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77970 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Thomas Hohn authored
If the page record could not be resolved by getPage_noCheck, throw a PageAccessFailureReasons exception. Resolves: #99648 Releases: main, 11.5 Change-Id: Iecec94eea65814a695cfce1559f7c96bb0cde1df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77968 Tested-by:
-
- Mar 05, 2023
-
-
Stefan Bürk authored
Due a regression since GitLab runner 15.1,we cannot use the official docker dind image to raise runner version to keep up with the TYPO3 gitlab instance. Because of other issues, using a custom docker dind image with changed expose port for the healthcheck to work around that issue is needed. See: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/29130 After Gitlab has released a proper fix for this, this should be reverted and the official docker dind image used again. Resolves: #100086 Releases: main, 12.1, 11.5, 10.4 Change-Id: I4b433ba7f3a42c718b4d436cf42cdf619b9094ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77965 Tested-by:
-
- Mar 03, 2023
-
-
Joey Bouten authored
Resolves: #100070 Releases: main, 11.5 Change-Id: I1795983f0bf6990868a9f7d2275ddbb97482713d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78015 Tested-by:
-
- Mar 02, 2023
-
-
Torben Hansen authored
This patch adds a missing `col` divider element in the record history element, so the element is correctly positioned in the bootstrap grid system and content does not overflow the viewport. Resolves: #99823 Releases: main, 11.5 Signed-off-by:
-
Jasmina Ließmann authored
In viewports with a resolution of less than 1000px, portrait format images are not fully visible in the image manipulation editor. This adjustment ensures that the complete image is visible. Resolves: #99199 Releases: main, 11.5 Change-Id: I4e2d961b889ceb1b2e7ec8e26f53f0c42adf33b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77994 Tested-by:
-
Thomas Hohn authored
Display PHP_VERSION after TYPO3 version number and current Application Context in CLI requests. Resolves: #100019 Releases: main, 11.5 Change-Id: I754b766d7b130409dbb06baffb04213c4635518e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77962 Tested-by:
-
Thomas Hohn authored
Added null coalescing operator in case $lastImgResourceInfo[3] is not set. Resolves: #99004 Releases: main, 11.5 Change-Id: Ieca6d193db884917785705b2468fcfe3ced623e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78003 Tested-by:
-
- Mar 01, 2023
-
-
Markus Friedrich authored
FrontendRestrictionContainer supports the usage of a local Context, but isn't passing the frontend group settings to the FrontendGroupRestriction. This commit extends the FrontendRestrictionContainer and ensures the frontend groups from the local environment are passed, improving the possibility to use simulated environments. Resolves: #100023 Releases: main, 11.5 Change-Id: Ie43911cce244acd6bbed54dd56d7d74f6fd24466 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77993 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Jochen Roth authored
Currently it's possible to set the cropping to 0x0 in size. This leads to an error. This has been fixed by setting a minimal required width/height for the cropping. Resolves: #99943 Releases: main, 11.5 Change-Id: I3b6af446c3bfb02c1f752e0e721f63920fa94c5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77992 Tested-by:
-
Andreas Fernandez authored
DataHandler has an internal check that compares the sent payload with the state of the affected database record and removes fields from the payload that didn't change. Everytime a database record is updated, DataHandler resets the internal stage to "0" to start a new editing workflow, if the affected database table supports workspaces. This handling is unfortunately executed *after* the payload comparison is done, leading to a payload that always instructs to update the field `t3ver_stage`, even if the change is not necessary, leading to superfluous database updates. This has a massive negative performance impact in simple shared hosting environments, especially with tt_content records that have many file references attached. The payload comparison is now executed after setting `t3ver_stage` to filter out superfluous updates. Resolves: #100035 Releases: main, 11.5 Change-Id: Ie0e29f7efe8d6289849bf117fbc852108fac1dd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77987 Tested-by:
-
Thomas Hohn authored
Fix incorrect handling of result from call to method $this->moduleLoader->checkMod(). The method has string|array|bool as return value. The array value is returned in case a valid module where access is granted exists. The check should be adapted to reflect this. Resolves: #100040 Releases: 11.5 Change-Id: Ibb52febfb7a9f87f4bec31eb87478507b78564ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77975 Tested-by:
-
Benni Mack authored
With TYPO3 v9 and site handling, and speaking URLs that are supported in workspaces, there is no technical reason to avoid POST requests in Workspaces. This limitation was added by Kasper in TYPO3 v4.0 in the infamous "tslib_fe" class, whereas the current code base is much more structured and we can now safely say, that we have Cookie handling and POST requests under control via Site Handling, and middlewares. This way, forms can be tested and submitted in Workspace previews. Resolves: #100051 Releases: main, 11.5 Change-Id: I5ed6afd2384ef685453034f852373bb6e073c974 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77961 Reviewed-by:
-
Simon Schaufelberger authored
Matomo comes with some custom tracking parameters which should be excluded from cHash generation by default. Previously they were prefixed with pk_ from Piwik but with the name change, new parameters have been introduced. Matomo tracking parameters in default instance: mtm_campaign, mtm_keyword Resolves: #99999 Releases: main, 11.5, 10.4 Change-Id: I17cf6c7071f378bd9a439628036d19f265dc19d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77959 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Thomas Hohn authored
The method getFileContents has return type string. However it contains a call to file_get_contents, that can return a boolean in case of failure. Added a check for if the file is readable and a cast to string when returning the value of the call to file_get_contents. In case of failure it will return the empty string, which will be caught properly in the method loadAndParse. Afterwards the error handling could be improved in loadAndParse to be more specific. Resolves: #100048 Releases: main, 11.5 Change-Id: Icf72332cdc2429318692682bf23e6d230109bdb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77991 Reviewed-by:
-
Thomas Hohn authored
The method getFileContents has return value string. But since there is no guarantee that the file exists before calling file_get_contents, a call to is_readable has been added. This handles both the PHP Warning and ensures type correctness. Resolves: #99926 Releases: main, 11.5 Change-Id: I9786a6737d7e3b0c3d04272364d868fd4101307c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77989 Reviewed-by:
-
- Feb 27, 2023
-
-
Thomas Hohn authored
Added Null coalescing operator, when value of $row['uid'] and $row['pid'] is accessed in getRecordOverlay to avoid PHP warning. Resolves: #99993 Releases: main, 11.5 Change-Id: Ia5b9983f6679001734b81bbd4a56d697bb3ce454 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77958 Tested-by:
-
Thomas Hohn authored
Added a missing else case in getImageDimensions when image size can't be determined. Return null instead of a boolean. Resolves: #99998 Releases: main, 11.5 Change-Id: Idfe6bf49612392f66f1c3c60a47f2c463c6eb4ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77976 Reviewed-by:
-
Thomas Hohn authored
Added null coalescing operator, when value of $this->page['uid'] is accessed in resolveTranslatedPageId. This can occur if the default language record is hidden. Resolves: #99996 Releases: 11.5 Change-Id: Ibd0bd1fcd9d9915f14e0c7571913e391b4cc007d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77904 Tested-by:
-
Thomas Hohn authored
If $elementUid is 0 in ElementHistoryController::getEditLockFromElement it must be handled seperatly since the call to BackendUtility::getRecord will return null. Resolves: #100000 Releases: main, 11.5 Change-Id: Ib53a5d06cbb098b9548a8293337b365d768d8fa3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77973 Tested-by:
-
Thomas Hohn authored
Added a coalescing operator before accessing the value of $wrapper['showResultsNumbersWrap']. Resolves: #100024 Releases: main, 11.5 Change-Id: I166d8e300cc931f8d1788ef19954b55eab66f7b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77957 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Feb 25, 2023
-
-
calien666 authored
This change ensures that the original language record diff source (usually in the field l10n_diffsource as configured by transOrigDiffSourceField) is set correctly as soon as a localized record is created. To guard this, an additional test for pages is added, and several DataHandler tests are adjusted. TYPO3 displays the source language value of a field for a translated record. This information field can display a diff, if the source record value was changed. To accomplish this a shadow copy of localizable fields from the source language record is saved in the configurable language diff source field. Localization of a record creates a new record, adding the values of localizable fields value with a prefix and setting needed system fields like parent record id, language id and so on. This is updated if a localized field is changed in the localized language. `\TYPO3\CMS\Core\DataHandling\DataHandler` as the main actor in the backend is responsible for maintaining this source diff field along with other tasks. Due to an oversight, the source language record data was not set during record localization. Because of this, the field source display did not work until the localized record was saved again. This probably went undetected because in normal editorial work the record would be changed straight away. Extension authors using DataHandler hooks can influence which data is written, for example using translation tools and databases to localize records automatically during the translation process. Therefore, it is not really mandatory to change the value afterwards. In the past, that practice lead to a broken and invalid source diff field. The issue existed for pages and other records in the same way. Resolves: #99985 Releases: main, 11.5 Change-Id: I47d5262dfbcaaa1fa5108e950308f72319c41b5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77945 Reviewed-by:
-
- Feb 24, 2023
-
-
Thomas Hohn authored
In the method getWordPairsForLineBreak, there is a missing coalescing operator around $wordsArray[$index + 1]. In the last iteration for uneven values of $wordsCount it will be undefined. Resolves: #100006 Releases: main, 11.5 Change-Id: I624bf444b10a595c99bfc0cd19cd4f72692155cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77955 Tested-by:
-
- Feb 23, 2023
-
-
Markus Klein authored
If, for whatever reason, the avatar image is not available, its publicUrl is null. This value can't be processed in the avatar environment. Resolves: #100020 Releases: main, 11.5 Change-Id: I111ec90af23208c69d76eac6ff17ad05db0d687f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77954 Tested-by:
-
Thomas Hohn authored
Only set X-Mailer header if not already set. Resolves: #100016 Releases: main, 11.5 Change-Id: I78b1fcc6769420ccfd3f6a31cdf73374a0805c45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77953 Tested-by:
-
Oliver Bartsch authored
Resolves: #99994 Releases: main, 11.5 Change-Id: I82955eae0675820355798df99e698db692f7d8ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77952 Tested-by:
-
Oliver Bartsch authored
The PreviewUriBuilder is used in the backend to generate frontend URLs. Besides passing the exact page id, it's also possible to pass the default page id and the desired language id. In such cases, the PageRouter is responsible to resolve the id of the translated page. This is internally done, using the PageRepository. However, due to a missing visibility context does the PageRepository apply the whole FrontendRestrictionContainer, including start- and endtime restrictions. This is now fixed by passing a backend specific visibility option, which is evaluated by the PageRepository. Note: In v12 this is done via the "visibility" aspect. In v11, the "includeScheduledRecords" option is not available. Resolves: #100008 Releases: main, 11.5 Change-Id: Ieacca442588612491f0b3f0d80b30fa64f902e7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77928 Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Daniel Goerz <daniel.goerz@b13.com> Reviewed-by:
-
- Feb 22, 2023
-
-
Oliver Klee authored
The new version finds new problems. > composer req --dev phpstan/phpstan:^1.10.1 > composer req --dev phpstan/phpstan-phpunit:^1.3.7 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100007 Releases: main, 11.5 Change-Id: I6e76d4f01dc4f8d0b61f76d57b7c83fe3faadc8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77925 Tested-by:
-
- Feb 21, 2023
-
-
Oliver Bartsch authored
This reverts commit 7e10d6b5. Reason for revert: PageRepository->getPageOverlay() applies frontend access restrictions, which are wrong in this context, and which can not be skipped. Additionally, the WorkspaceRestriction is not applied. Resolves: #99992 Related: #99613 Releases: main, 11.5 Change-Id: I032f50b6465fbe2c3bf157cd13b9e99e558084db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77902 Reviewed-by:
-
- Feb 20, 2023
-
-
Andreas Fernandez authored
JavaScript has a native Set() object that ensures uniqueness of values by design and is therefore faster than any custom uniqueness implementation. The Install Tool had an obvious implementation that is superseded by `Set()`, being several milliseconds faster, depending on the client's CPU. Resolves: #99987 Releases: main, 11.5 Change-Id: I6b566b97c70b241070b78b841350a6b21b64a5a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77901 Tested-by:
-
