- Jul 11, 2023
-
-
Oliver Klee authored
`GeneralUtility::sanitizeLocalUrl` expects a string. So the fallback value when calling this method also needs to be a string, not null. This patch adjusts two of such calls. Resolves: #101310 Related: #101305 Releases: main, 12.4, 11.5 Change-Id: I737eea4910e95f653982cbe5b268c782cdf8a502 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79976 Reviewed-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Oliver Hader authored
Adds a basic test case for simulating the behavior of the eID script `tx_cms_showpic` in the frontend rendering process. Resolves: #100878 Releases: main, 12.4 Change-Id: I0caf70de88c57f592cd2db1716f94d243b9682f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79975 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Fernandez authored
With the upgrade to Bootstrap 5, modals unintentionally don't support the `data-content` attribute anymore as this was automatically migrated to the namespaced variant `data-bs-content`. While this is technically correct for Bootstrap 5, Core still needs to support the old variant as documented. Resolves: #98067 Releases: main, 12.4, 11.5 Change-Id: I544cbd779c808727c472575654adca3dc4c91197 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79974 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Klee authored
There already was a data provider for the negative case of this method, but no tests using this data provider. Resolves: #101308 Releases: main, 12.4, 11.5 Change-Id: If32b5f2943240f224031e20d9849f849275358a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79972 Tested-by:
-
Benjamin Franzke authored
Stage-change notification mails have only been delivered to the last recipient off the list of possible recipients, because Utility.convertFormToObject failed to detect checkbox elements from (other) frames. In this case the to-be-converted form elements are created on the top frame (modal contents are placed outside list frame on the top frame). Due to JavaScript being prototype based, instanceof checks do only operate per-frame. Prototypes are bound to the current window. `foo instanceof HTMLInputElement` is basically a shortcut and equivalent to `foo instanceof window.HTMLInputElement` while `window != top.window`. Instead of `instanceof` checks, we switch to a `tagName` comparision which is usable for cross-frame HTMLElement type detection. Resolves: #99784 Releases: main, 12.4, 11.5 Change-Id: If9bfd7be1e46d8c04619be3563d3bdba9d9de549 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79953 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Oliver Bartsch authored
Since a filelist instance is used in the link browser for the file and folder types, the link generation of the filelist need to keep corresponding parameters. Resolves: #101306 Releases: main, 12.4 Change-Id: I012a1c0cf22d1e97c0b82a59c189823314ccf912 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79958 Tested-by:
-
Oliver Bartsch authored
TO be consistent through the backend, filelist instances are used for all the various file and folder browsers in the backend. To enable sorting, the corresponding request parameters are now properly applied on initialization of the filelist instances. Resolves: #101307 Releases: main, 12.4 Change-Id: I86409831abb7f553875806a7e4f0e91f8d71d58e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79959 Tested-by:
-
- Jul 10, 2023
-
-
Nikita Hovratov authored
Resolves: #101304 Related: #100949 Releases: main, 12.4 Change-Id: I5ca63b7cdc8fb039392d29490f3e64facb0ba4c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79936 Tested-by:
-
Philipp Kuhlmay authored
Replace link to the documentation of the "crawler" community extension. Releases: main, 12.4, 11.5 Resolves: #101300 Change-Id: Ie284fcb1850f655fb3541653326f7c6c0ed79c9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79932 Tested-by:
Bj�rn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Nicole Cordes authored
The GlobalEventHandler changes the location of the current (target) window. The location is set to a given destination without any ability to interrupt. The existing ConsumerScope API isn't used even if the current window is the ContentContainer. This patch extends the handling of a navigation action by checking its target window and using proper ContentContainer API to set the location. Therefore registered listener can deny a location change and trigger own functions. Resolves: #95474 Resolves: #100114 Releases: main, 12.4, 11.5 Change-Id: If6a3b1cc546e1f2ff0b8e9fed3f83055f3f55e49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79922 Tested-by:
-
Benjamin Franzke authored
Since #94084 all module URLs are automatically framed by the TYPO3 main controller whenever they are opened in a Sec-Fetch-Dest aware request. (HTTPS or localhost domain) The intention of API is to allow module-links to be opened in a new tab by user intent – but due to technical limitation that feature is limited to secure contexts, and must therefore not be relied on as an API for internal redirects. sudo mode made use of this API and redirected via top.location to the privileged module, relying on the fact that iframe module-requests where detected to be loaded in the wrong context, to produce a redirect to the proper backend-frame, this didn't work for non HTTPS requests. This workaround has been done to remove "sudo-mode" from the URL bar. That workaround is no longer needed as #101287 added support for installtool URL bar synchronisation. ContentContainer API is now used to set the URL. Releases: main, 12.4 Resolves: #101288 Related: #101287 Change-Id: Id8b828662e3cd2739a93eda5f9517f896c65e941 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79921 Tested-by:
-
Benjamin Franzke authored
Map backend URLs like /typo3/install.php?install%5Bcontroller%5D=settings to /typo3/module/tools/settings for display in the browsers URL bar. Resolves: #101287 Releases: main, 12.4 Change-Id: I5177146e28b01011f946c578804a8141fe9a371f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79920 Reviewed-by:
-
Andreas Nedbal authored
Apply sorting params passed in the request to the element browser filelist. Resolves: #100949 Releases: main, 12.4 Change-Id: I60244c66f481ce26f03d672754935dd7902befc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79919 Tested-by:
-
Tomasz Woldański authored
When using GA4, Google's scripts add "_gl" param to track cross domain links. See https://support.google.com/analytics/answer/10071811?hl=en Resolves: #101302 Related: #101180 Releases: main, 12.4, 11.5 Change-Id: I6c32db355a7a1306710cff9768187f687ce4b5a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79934 Tested-by:
-
- Jul 08, 2023
-
-
Gerrit Mohrmann authored
Resolves: #98178 Releases: main, 12.4, 11.5 Change-Id: I6ebcbb67b9cc51d7d56b1da945fdd8b05d5081dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79868 Tested-by:
-
- Jul 07, 2023
-
-
Andreas Fernandez authored
flatpickr doesn't provide an easy possibility to set the today's date. To solve this issue, the plugin `shortcut-buttons-flatpickr` is added with a configuration for the today's date. Resolves: #100635 Releases: main, 12.4 Change-Id: I882f05ab4486d1b3073008cadb1d0275dd77c8ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79867 Reviewed-by:
-
Benjamin Kott authored
Resolves: #101276 Releases: main, 12.4 Change-Id: Ie9941076dc54fc3c123241cf51a50a19a9145ec6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79866 Tested-by:
-
Benjamin Kott authored
This patch streamlines the import module with the import command. While the CLI commands can import data from extensions, the interface has no option to perform this action. We are now listing available datasets from distributions in the import module. Resolves: #101256 Releases: main, 12.4 Change-Id: I6fac0d22bbb42a6ff8b682b6c3415a3d7e4982d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79863 Tested-by:
-
Benni Mack authored
This change adds the status quo for further MM-related work. This relates to some tests that had tests on "allowLanguageSynchronization" but not "l10n_mode=exclude" set. In addition, some MM-related tests were not added to all workspace-* tests anymore, which are now added: * copyContentToLanguageOfRelation * copyCategoryToLanguageOfRelation * localizeContentOfRelationWithLanguageExclude * localizeContentOfRelationAndAddCategoryWithLanguageSynchronization Resolves: #101285 Related: #80640 Releases: main, 12.4 Change-Id: Ib675b9bc263d519372a8028370db581e25a49edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79864 Tested-by:
-
Susanne Moog authored
When `open_basedir` is set (often the case on shared hosting), TYPO3 fails to find executables as it does a check for file existence first, which fails due to the restriction. Instead of checking file existence in all cases, a fallback has been added on *nix systems that will try execution of a given command and use the return code to decide whether the path is valid. This itself uses the command `which` which is not available on Windows. As nowadays `open_basedir` is mostly used on shared hosting environments based on *nix, this will not be fixed for Windows. Resolves: #70869 Resolves: #85174 Releases: main, 12.4 Change-Id: Ic01e822ae16b9ef1fa80be745a9de51e527ba059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79865 Tested-by:
-
Benjamin Kott authored
With #10551 a pretty cool new feature was introduced which will show you information about the status of non versionable records in list module of TYPO3 backend. These messages are now only be displayed, if extension workspaces is activated. Resolves: #101282 Releases: main, 12.4 Change-Id: I428535a2e301fa38b639fed99d70c8052dfaa6fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79849 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Stefano Kowalke authored
Releases: main, 12.4 Resolves: #101284 Change-Id: Idd633c9d764296c9ec2dfb482a75d59a9da3e2d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79860 Reviewed-by:
-
Jochen Roth authored
A click on open/recently used documents the returnUrl was not set which led to a blank content frame when the close button on the record was clicked. This issue is fixed by adding the EditDocumentController's returnUrl to the OpenDocs payload and re-using it in the toolbar items. However, this will not work with already existing entries and a consistent behavior cannot be assured due to potentially (dis)allowed modules for each backend user. Resolves: #94214 Releases: main, 12.4 Change-Id: I29680172735a5c28c46268cd14b7e26dd0997cd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79862 Tested-by:
-
Benjamin Kott authored
In sys_file_reference tables a standard basic palette is used for filetypes image, audio and video. Therefore no alternative field is shown in own tca field types file. Use specific file type palettes, to avoid rewriting in overrideChildTca in type=file fields. Resolves: #101277 Releases: main, 12.4 Change-Id: Ie47396e0876499be787f3d9ba9da94988d9f4e39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79859 Tested-by:
-
Benjamin Kott authored
We are removing the pagination arrows from the translation files since they needed to be marked with "aria-hidden" to avoid acessibility issues. This would extend the usage of markup that should not be placed in translation files in the first place. To allow integrators to change the apperance we are now adding css classes that can be used to apply special styling for the next and previous links. Resolves: #101283 Releases: main, 12.4 Change-Id: I090da2922dd644e161440e4e5a1e47ef0963d839 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79858 Reviewed-by:
-
Oliver Hader authored
Indexed Search pagination still uses `onclick="..."` inline event handlers. For being compatible with content security policy, the corresponding handlers are added as inline JavaScript, embedded with a CSP nonce value. Resolves: #101271 Releases: main, 12.4 Change-Id: Ic1202faf8be2d1d9e84b599f62e8c9a53aeef2fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79857 Tested-by:
-
Susanne Moog authored
The rootline may contain extendToSubpages settings for hidden or timed records which prevented previewing a page because the preview checks only considered the current page. The rootline is now taken into account. Resolves: #17599 Releases: main, 12.4 Change-Id: I0271caf8decd46fd9dedf31158d62a86e1e0028c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79856 Reviewed-by:
-
Riny van Tiggelen authored
In case mod.web_layout.allowInconsistentLanguageHandling is set, no warnings about inconsistent language usage should be displayed. This is now properly checked in ContentFetcher, which would otherwise add a warning message to the queue. Resolves: #99171 Releases: main, 12.4 Change-Id: If0f6cce36e5d35e0ec5ca3df865cc5736bb44005 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79853 Tested-by:
-
Jochen Roth authored
Currently, when the selected db has already tables an exception is thrown This has been changed by showing a nicely formatted error message like done for any other error in this command. Resolves: #101172 Releases: main, 12.4 Change-Id: I09fe21a5cce71ff860f965244bee86474ee5c398 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79854 Tested-by:
-
- Jul 06, 2023
-
-
Oliver Hader authored
Package symfony/polyfill-intl-normalizer can be removed again, since ext-intl is already a composer requirement. Executed commands: composer rem symfony/polyfill-intl-normalizer composer rem symfony/polyfill-intl-normalizer \ -d typo3/sysext/core --no-update Resolves: #101275 Releases: main, 12.4 Change-Id: Id60b90ad3300175d2287a23e062f94975ad5fe86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79844 Tested-by:Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Stephan Großberndt authored
Backend no longer crashes with an TableNotFoundException if a table has been removed and an according item is in the list of recent documents. The patch catches the exception. Releases: main, 12.4, 11.5 Resolves: #101139 Change-Id: I489d8cf1ee2bb10800fe2966ae4fc1cb0bcd57c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79852 Reviewed-by:
-
Sybille Peters authored
It is possible to rename a file with ResourseStorage::renameFile(). This is also used under the hood, if a file is renamed in the file list. RenameFile also performs a sanitation of the filename, in case the filename was not yet sanitized (e.g. convert chars like space, quote, ö, ê, ß or §). But if the target filename is the same as the current filename, the sanitation was not performed. This is now fixed so that the behaviour is more consistent and sanitizing files with renameFile() is possible. Resolves: #100683 Releases: main, 12.4 Change-Id: Ia35747f1381f4aac64af50c461e172c9f951cf83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79787 Tested-by:
-
Sybille Peters authored
The redirects documentation contains a link to the issues on the page "Known problems", using a category filter. This used to be "Link Handling, Site Handling & Routing", but redirects now have their own category "Redirects Handling", so we use this. Resolves: #101260 Releases: main, 12.4, 11.5 Change-Id: Ife6c4bbd7b2db1476054d5ce2558f84f32ab4800 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79829 Tested-by:
-
Johannes Nielsen authored
So far the setup command did not consider default values in non-interactive mode. This led to unexpected errors when not passing in parameters, which should have default values, as either CLI parameters or ENV variables. Resolves: #100945 Releases: main, 12.4 Change-Id: If811c5c1ef9b7d8a5c776af407fac7d2ced4e654 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79831 Tested-by:
-
Oliver Hader authored
The filename of uploaded files might not be encoded as normalized unicode. For instance, this happens when using umlauts in filenames on HFS+ filesystem (macOS). For instance the client sends an `ö`, which is sent in NFD as `0x6fcc88`, but should be normalized as `0xc3b6`. https://en.wikipedia.org/wiki/Unicode_equivalence#Normalization Executed commands: composer req symfony/polyfill-intl-normalizer:^1.27 composer req symfony/polyfill-intl-normalizer:^1.27 \ -d typo3/sysext/core --no-update Resolves: #101253 Releases: main, 12.4, 11.5 Change-Id: I8605481ffdc3b5d96f529850bf09a1fd75d09cd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79837 Tested-by:
-
Annett Jähnichen authored
If the pluginTitle wasn't set, a warning message was rendered in the page module as if the plugin wasn't configured. We now use the PluginName as default to create a visual difference between a plugin that is not configured. Resolves: #99775 Releases: main, 12.4 Change-Id: Ic069edce5a74989ee32b2d40b1e645dc5449690d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79828 Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
-
Benjamin Kott authored
The backend layout representation in the backend implements a table based layout. While the columns spanning was interpreted correctly, the definition of how wide a column is in the defined grid was missing, causing the cells to take up an unexpected amount of space. Resolves: #101041 Resolves: #100961 Related: #97306 Related: #94629 Releases: main, 12.4 Change-Id: I8ab426e0c6e136135bf1bcf6bcc0368f76d4f4b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79827 Tested-by:
-
Andreas Fernandez authored
In non-SVG trees, there are currently two icons representing the node's expansion state rendered that get toggled via CSS rules based on hard-coded aria attributes and icon identifiers, which is a bad practice. To solve this, a new web component `typo3-backend-tree-node-toggle` is added whose only responsibility is to render the correct icon based on its `aria-expanded` attribute Resolves: #100549 Releases: main, 12.4 Change-Id: I1a955731fc21da01a914b1ef721d7eb2d1e18ed5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79826 Tested-by:
-
Torben Hansen authored
The current backend password reset log message misses a `}` and logs the `user_id` if a password has been reset successfully. Logging the `user_id` is however not inline with other user related log messages, where always the `username` is logged. This patch streamlines the log message with other user related log messages by including the `username` instead of the `user_id`. Resolves: #99354 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: If18d3b4cd1a76008f56f5433e8ff5d591898d2ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79824 Reviewed-by:
-
Oliver Bartsch authored
In case a user did not pass necessary multi-factor authentication, this is handled as a login failure. Therefore, a webhook is now triggered for this scenario, like done for login failures of the first factor (usually username / password), providing basic information about the user and the used MFA provider. Resolves: #101263 Related: #100129 Releases: main, 12.4 Change-Id: I56b79a74d291beb94d78bb42305dcfba86ecaa26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79825 Tested-by:
-
