- Apr 27, 2024
-
-
Christian Kuhn authored
To further streamline the DataHandler/DataScenarios tests, the 'Regular' 'free mode' tests are extracted to an own scenario setup. This avoids importing multiple fixture files and separates the complex mix in 'Regular'. Resolves: #103742 Related: #103734 Releases: main Change-Id: I723c7f582910f3072fbbdcb3d7493f0eaf44e368 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84045 Tested-by:
André Buchmann <andy.schliesser@gmail.com> Reviewed-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Jasmina Ließmann authored
As in the backend module "Configuration", search results can be displayed as badges next to the search input field. When the search input field is displayed with a label instead of placeholder text, the badge was displayed out of place. This patch aligns the badge to the search input field. In addition, the search field now takes up full width for small breakpoints. Resolves: #103716 Releases: main Change-Id: I322b4ab4c62823fa6dcf9d00fc30bc8671c57f09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84013 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
André Buchmann authored
Tests in DataScenarios/Regular for the DataHandler are based on invalid source data. There are translated content elements on pages that have no translations. It's not possible to translate content elements without having a page translation first in the backend. A lot of the tests use workarounds and create those missing page translations first. The tests should be based on valid source data in order to check the pages and handling of the content. There is now a dedicated csv file containing tt_content and their related pages records to run tests with translations. For this reason, all tests that do not include a page translation process themselves import the default translations via a separate csv file. Accordingly, the tests localizePage*, localizeAndCopyPage*, localizeNestedPages* and movePageLocalized* do not import the default translations. It is also ensured that no content translation exist in the source data without a corresponding page translation. Resolves: #103734 Releases: main Change-Id: I9475c8e4fee53b1925a0d8bc4f33acd58dd29aa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83632 Tested-by:
Eric Harrer <info@eric-harrer.de> Reviewed-by:
-
- Apr 26, 2024
-
-
Jasmina Ließmann authored
Resolves: #103737 Releases: main, 12.4 Change-Id: I83278a84037a4fe46b85a8570b7ff345eabeb0a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84042 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
This is a relatively small add-on to RelationHandler when it reads MM relations initiated through start() in readMM(). In general, relations found by the read API are written to $this->itemArray, can be read from there, or further processed. readMM() of course queries the according MM table to find relations. Those MM rows typically have - next to local and foreign "uid" - the foreign table field "fieldname" the relation is attached to, plus both local and foreign sorting values. The patch adds these three to $this->itemArray items, next to existing "tablename" and "uid". This allows us to suppress a useless query to the MM table in consuming code, where sorting fields and foreign fieldname can be important to know - which is the case with an upcoming patch. The patch also cleans up some other details to make the code a bit better readable. Note RelationHandler and its pair class PlainDataResolver in general suffer from these problems: * Both always receive table-uids only and often need to fetch the full record, even though calling code often has the record at hand already. * The result never includes full relation rows but only uids, even if the full row is fetched in various scenarios. * Sorting out invalid workspace records needs additional queries. Together with the messy and hard to understand code including a long list of public properties, the very unfortunate main API start(), and some structural performance issues, a rewrite of RelationHandler and PlainDataResolver becomes more and more pressing. If done right, this would unblock a series of powerful performance improvements for instance in DataHandler. Resolves: #103735 Releases: main Change-Id: I7f793c27b3703cc3ce8bc2213d81d05e676c8823 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84040 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Stefan Bürk authored
Database field default values for TEXT, BLOB and JSON fields has been added with #103578 and default value normalization fixed with #103610 also including a direct bugfix for the reported and contributed `PostgreSQLSchemaManager` in Doctrine DBAL [1]. The Doctrine DBAL Team released `4.0.2` containing this bugfix, which has been ensured with #103729 and is now removed again to clean up the Core code base. [1] https://github.com/doctrine/dbal/pull/6358 Resolves: #103730 Related: #103729 Related: #103610 Related: #103578 Releases: main Change-Id: I77d8f595a18d648ddf14ddba98156f4cc337dd9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84025 Reviewed-by:
-
Stefan Bürk authored
Doctrine DBAL released a new bugfix version [1] of the `doctrine/dbal` package, including a required bugfix for TYPO3 v13 [2]. This change upgrades to `4.0.2` to ensure that the bugfix [2] is included and all changes from `3.8.1` up to `3.8.4`[3][4][5]. Used command(s): > \ composer req --no-update --no-install \ -d typo3/sysext/redirects \ "doctrine/dbal":"^4.0.2" ; \ composer req --no-update --no-install \ -d typo3/sysext/core \ "doctrine/dbal":"^4.0.2" ; \ composer req --no-update --no-install \ -d typo3/sysext/install \ "doctrine/dbal":"^4.0.2" ; \ composer req \ "doctrine/dbal":"^4.0.2" Note: The intermediate fix in our extended Platform classes will be removed with a follow up commit. [1] https://github.com/doctrine/dbal/releases/tag/4.0.2 [2] https://github.com/doctrine/dbal/pull/6358 [3] https://github.com/doctrine/dbal/releases/tag/3.8.4 [4] https://github.com/doctrine/dbal/releases/tag/3.8.3 [5] https://github.com/doctrine/dbal/releases/tag/3.8.2 Resolves: #103729 Releases: main Change-Id: Ie64a373f623ae102533661a44247aaac65e5a4d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84024 Tested-by:Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benjamin Kott authored
Both extensions core and linkvalidator do not ship css files. PostCSS cannot find any files to process here. Resolves: #103731 Releases: main, 12.4 Change-Id: Ibdfcecb4dd813b04e89bab5d2fcfe3a55b0bf4b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84033 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Anja Leichsenring authored
With #103523 site sets for ext:styleguide were introduced and the page tree generator received an option to create a frontend demo section using the shipped set. Now the click on this button will actually respect the user's wish and create the site using the set and not create a sys_template record. Resolves: #103732 Related: #103523 Releases: main Change-Id: I1560150c24f643a9ac1b7aefe3d7b0fbe109d62e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84034 Reviewed-by:
-
Benjamin Kott authored
We're enhancing our backend by introducing a refined system for shadows. The default and strong shadows remain for simple components, while tooltips, flyouts, dialogs, and windows have dedicated ones. This streamlines shadow definitions across elements, ensuring consistency. Shadows support both light and dark modes for visibility across all settings. Resolves: #103726 Releases: main Change-Id: Id02122a9f48833df03e28613642499b63c339b45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84019 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benjamin Franzke authored
Provide a new (default) EXT:styleguide frontend generator that uses site set infrastructure provided by #103437, #103439 and #103522. The old sys_template-root based renderer is preserved and tested independently Resolves: #103034 Related: #103437 Related: #103439 Related: #103522 Releases: main Change-Id: I53c986d7a47c8c2687b2a240410f9d4130fbae4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83696 Tested-by:
-
- Apr 25, 2024
-
-
Willi Wehmeier authored
The modal form to rename a file needs a proper label for the filename input field. Resolves: #103724 Releases: main, 12.4 Change-Id: I29018d288ced1de6001d38b841ef37a1231f7394 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84021 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benjamin Kott authored
We're currently in a mixed mode where some components support dark mode, while others don't. To facilitate the migration of components currently incompatible with dark mode, we're setting the default to light mode for now. This allows us to gradually migrate components and enable the dark mode switch once both a component and its context are ready for it. Resolves: #103723 Releases: main Change-Id: I39e31d9b7170ac5592f58afe9f9dced0fd14c4c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84020 Tested-by:
-
- Apr 24, 2024
-
-
David Hedden authored
Provide the current language fallback chain to new instance of LanguageAspect. So it can be used in PageRepository to let extbase records use the fallback chain. Resolves: #91781 Releases: main, 12.4 Change-Id: I291c73c05772533919a7bf6beaa767d156bc9d74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84017 Reviewed-by:
-
Andreas Kienast authored
The grunt module `grunt-newer` was introduced with #90200 to help improving build times on consecutive single builds by running tasks on changed files only. This is nowadays not required anymore in JS build context, as it's possible in TypeScript to compile changed files only, which is already incorporated for quite a while. Therefore, the usage of `newer` is now removed in this context. However, to avoid running `terser` multiple times on the same, previously compiled files, the directory `Build/JavaScript` now gets removed before each TypeScript compilation. The postcss calculation is fast enough to not require grunt-newer at all, therefore grunt-newer is dropped here as well. Executed commands: npm remove grunt-newer Resolves: #103712 Releases: main, 12.4 Change-Id: I1c6b88945a45cb9a394a2beaa2ec8198865880b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84006 Tested-by: -
Stefan Bürk authored
Wizards not marked as done, but not having updates, display a notice `No changes applied, marking wizard as done.` when using the CLI command `bin/typo3 upgrade:run <wizard-identifier>` and return an error exit code. This also happen when not specifying a single wizard, but running all available ones. The GUI based upgrade execution behaves different, as it does not return an exit code and does not display information about `no changes applied`, like its CLI counterpart. This change: * Adds new concrete exception classes for the `upgrade:run` command. * Modifies `UpgradeWizardCommand::getUpgradeWizard()` to throw now one of the new concrete exception or return a wizard instance to run. * Skips available upgrade wizards not eligible to be executed. Resolves: #103447 Releases: main, 12.4 Change-Id: Ib6eab07919bb2f6e11bac774ecfd333572c2205f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83944 Tested-by:
-
Stefan Bürk authored
TYPO3 provides the ability to configure different error handlers for specific (or all) error codes, as well as the error handler type to use (core handler or custom). The `\TYPO3\CMS\Core\Error\PageErrorHandler\PageContentErrorHandler` allows to specify a target using the link handler. The default config allows to define `LinkService::TYPE_PAGE` and `LinkService::TYPE_URL`. After implementing and stabilizing the TYPO3 sub-request feature, this particular error handler has been refactored to use an internal sub-request to resolve the error page content: An external URL not matching the same instance or having a page unavailable within the TYPO3 instance will not return any content. This change modifies the `PageContentErrorHandler` to send a Guzzle request for an external URL instead of using internal sub-requests, even if it would access the originating instance again. A limitation is that the requested URL **must** return a HTTP status-code 200. A custom request header is attached to this request. It is then checked to avoid recurring errors or loops in the page-resolving workflow. Resolves: #103399 Related: #98396 Related: #94402 Releases: main, 12.4 Change-Id: If09158abd2aa9246bcb7a4fa41a0ad6e4a0f942c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83947 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
-
- Apr 23, 2024
-
-
Oliver Bartsch authored
To be consistent with the other listings in the backend is the root page title of a site in the site configuration module now linked, allowing to edit the corresponding site configuration. Additionally does the link as well as the edit button now use a dedicated label instead of a generic one. Resolves: #103695 Releases: main, 12.4 Change-Id: Ice46e82587cdc36daa6275f6eec2c46909e8a071 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83950 Tested-by:
-
Oliver Bartsch authored
Since the button to create a new site configuration is already descriptive the non-translated title attribute is removed. Resolves: #103696 Releases: main, 12.4 Change-Id: I28c8945f9b2b8fba29461dbd8033c52eacc1f035 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83951 Tested-by:
-
Jasmina Ließmann authored
If no record was found in "Workspaces" backend module, an information is displayed. This text is now displayed in the typical infobox style instead of with specific Bootstrap styling classes. Resolves: #103714 Releases: main, 12.4 Change-Id: I78637defba53cebdfc659b2414c59b4f4dbb7bbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84010 Reviewed-by:
-
Daniel Siepmann authored
The existing solution using `array_diff` did not work, as it only respects values, not a combination with keys. Given an existing record with some empty values would prevent unsetting another value with an empty. The same would apply for setting another value to an existing value. That's why we change to `array_diff_assoc`, which handles proper diff of value in combination with key. Resolves: #103708 Releases: main, 12.4 Change-Id: I36adbc8279e5160c33e8feffcd8741c30c667adc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84000 Tested-by:
-
Andreas Nedbal authored
In the current frontend tooling, we invoke Rollup twice: * via grunt-rollup to build library modules * via the command line to build everything related to CKEditor This commit gets rid of the first way and moves the library compilation to a JS-backed configuration as well, so we can get rid of a grunt package and also unify the tooling a bit. We also make use of @rollup/plugin-terser instead of the deprecated rollup-plugin-terser module that was used in ckeditor build before. To match the new behaviour, the "exec:ckeditor" task also was renamed to "exec:rollup". Executed commands: npm remove grunt-rollup npm remove rollup-plugin-terser npm install @rollup/plugin-terser --save-dev npm run build Resolves: #103686 Releases: main, 12.4 Change-Id: I8057dcceae2d039c637c6db68cf51b3ef1f12406 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83942 Tested-by: -
Jasmina Ließmann authored
To improve the UX and accessibility of the "Workspaces" backend module the following changes are made: * Grouping and rearranging action buttons * Showing system language title in addition to the flag icon * Addition of a new "Action" column to represent the type of change and resolve the previous workspace state legend and colored record titles * Output notification messages with the icon if integrity issues exists * Removal of the live record column (This only contained the name of the live record and no other function. Additionally, records created in workspace were also displayed incorrectly in the live column even though they did not yet exist in live environment.) Resolves: #103670 Releases: main Change-Id: Ic7cd00fc46b638adaca9bd4cf4c6a97f2a53d787 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83924 Reviewed-by:
-
Ayke Halder authored
There is a checkbox in page module to show hidden content elements. If this checkbox is not selected the hidden content elements must be hidden. Additionally hidden elements must not be accessible/focusable by keyboard. Resolves: #103626 Releases: main, 12.4 Change-Id: Id8f4b98938ae27e3bd3d3e7903c3f50588d554b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83781 Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Christian Kuhn authored
ReferenceIndex does not write rows with 'ref_table' set to '_FILE' anymore since #87428. The patch removes some left over handling at a couple of places. Resolves: #103710 Related: #87428 Related: #102222 Releases: main Change-Id: Iccb94a57b7fb551da48ba516b668fe970b9fb5f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84001 Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Lina Wolf authored
Resolves: #103713 Releases: main Change-Id: I8735da3d64bb1697775dac561a9407c414dc631c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84007 Reviewed-by:
-
Oliver Hader authored
Given a static route argument mapper is used - for instance one that allows values in the range of 1 to 100 - then generating an URL from a route with an out of scope `&value=5000` was still generating an URL. However, HTTP request to that URL would result in an 404 error. This change skips routes using out of scope values during the URL generation process to avoid pointing to invalid resources. Resolves: #103400 Releases: main, 12.4, 11.5 Change-Id: I11e12f29e294ec86bec948d3a922d4a56b231771 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83470 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Christian Kuhn authored
There are two labels 'folderNotDeletedHasFilesWithReferences'. Those are in use, the two 'folderNotDeletedHasFiles' are not. Resolves: #103709 Releases: main Change-Id: I804f67b4dbcee127cf951588b43cbfd55093a45c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83999 Tested-by:
-
Benjamin Kott authored
With new web standards arising and getting shipped to the web platform, we are migrating the currently limited light and dark mode components to the web native color-scheme. See: https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme Instead of relying on preferred color scheme queries, we're adopting the light-dark color function, streamlining our CSS and ensuring compatibility with all major browsers, except Safari (for now). While Safari is slightly behind, we anticipate full support for light-dark mode by May 2024, with the feature already available in Safari 17.5 Beta. See: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value/light-dark See: https://developer.apple.com/documentation/safari-release-notes/safari-17_5-release-notes Note: Safari users will experience missing backgrounds and colors due to our decision not address this behavior. We're forward-facing and planning for the LTS release. If you intend to use Safari during development, please ensure you're using at least Safari 17.5 Beta. We're monitoring the situation closely and will implement a fallback if Safari hasn't released a compatible version before 13.2. Resolves: #103705 Releases: main Change-Id: I9f53e992f4d55efd86420a72a84da9d90b16e490 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83995 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Benni Mack authored
Change-Id: I06f3088f1b06adc56000391ea0af8bc199586cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83993 Tested-by:
-
Benni Mack authored
Change-Id: I0de3c394a9e37ca840c3d0aa6f6df745bca8ac3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83992 Tested-by:
-
Oliver Bartsch authored
To allow the use of "empty" attributes, such as `download` in the CKeditor, the RTEHtmlParser does now keep such attributes while processing. Resolves: #103698 Releases: main, 12.4 Change-Id: I331066c0abaa604ba68c19f0013b5a077fe8f5f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83953 Reviewed-by:
-
Christian Kuhn authored
The rootline calculation has been moved around with various patches in v12 & v13. Refactor some related tests and move them to a more appropriate place. This also avoids another TSFE access in tests. Resolves: #103701 Related: #102856 Related: #102715 Related: #103410 Releases: main Change-Id: I0da5f0484ce90eab3909d1c202a13ce79250b0bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83956 Tested-by:
-
Nikita Hovratov authored
It is possible that TCA items array is not set in DataHandler if 1. items is defined through types/*/columnsOverrides 2. DataHandler is triggered with context of another record type (e.g. by a translation request) This patch ensures we are always dealing with an array for items. Also, when passing it as parameter to `ItemProcessingService->getProcessingItems`. Resolves: #103472 Releases: main, 12.4 Change-Id: I364841982b7c2913e339bf5a504d811b3e050049 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83575 Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save chart.js@^4.4.2 npm run build Resolves: #103652 Releases: main, 12.4 Change-Id: Iddbfb5be5f998c7b9d693dac94fee88a1f242edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83851 Tested-by: -
Andreas Kienast authored
Executed commands: npm install --save alwan@^2.0.4 npm run build Resolves: #103651 Releases: main, 12.4 Change-Id: I56b52fdff9031eec2cabfaeb968469a20fa72bb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83850 Reviewed-by: -
Andreas Kienast authored
Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.7.0 \ @typescript-eslint/parser@^7.7.0 \ @typescript-eslint/typescript-estree@^7.7.0 \ eslint-plugin-wc@^2.1.0 \ sass@^1.75.0 \ sharp@^0.33.3 \ terser@^5.30.3 \ typescript@^5.4.5 npm run build Resolves: #103653 Releases: main, 12.4 Change-Id: I96bb9e96d12182adc33b5fafb52d53a4fecf6806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83872 Tested-by: -
Andreas Kienast authored
The "No results found" alert is rendered in a flex-row container, which caused a rendering bug where the alert box was stretched to a height of 100%, but its width is limited to its content. Use flex children modifiers to ensure correct positioning. Resolves: #103662 Releases: main, 12.4 Change-Id: I5b17950ca381fda841cd3a901d9f5e1a70e5562d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83919 Reviewed-by:
-
Chris Müller authored
Resolves: #103675 Releases: main Change-Id: Id576952b1390d5727643eb6c535ce56c50a20831 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83935 Reviewed-by:
-
- Apr 22, 2024
-
-
Sybille Peters authored
The TSconfig configuration option mod.linkvalidator.searchFields is documented in the documentation. Previously, it was only possible to check within fields, if at least one softref was configured. This was changed to include fields with the type "link" (see LinkAnalyzer class). This change updates the documentation to reflect that. Resolves: #103477 Related: #83835 Releases: main, 12.4 Change-Id: I83ceafca206b2b1821e622bc36867eb13a9a5984 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83584 Tested-by:
-
