Skip to content
Snippets Groups Projects
Commit 6a8173f4 authored by Stefan Bürk's avatar Stefan Bürk
Browse files

[BUGFIX] Mitigate invalid exit code for UpgradeWizard without updates

Wizards not marked as done, but not having updates, display a
notice `No changes applied, marking wizard as done.` when using
the CLI command `bin/typo3 upgrade:run <wizard-identifier>` and
return an error exit code. This also happen when not specifying
a single wizard, but running all available ones.

The GUI based upgrade execution behaves different, as it does not
return an exit code and does not display information about
`no changes applied`, like its CLI counterpart.

This change:

* Adds new concrete exception classes for the `upgrade:run`
  command.

* Modifies `UpgradeWizardCommand::getUpgradeWizard()` to
  throw now one of the new concrete exception or return a
  wizard instance to run.

* Skips available upgrade wizards not eligible to be executed.

Resolves: #103447
Releases: main, 12.4
Change-Id: Ib6eab07919bb2f6e11bac774ecfd333572c2205f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83944


Tested-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 36b63a8c
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment