[BUGFIX] Mitigate invalid exit code for UpgradeWizard without updates
Wizards not marked as done, but not having updates, display a notice `No changes applied, marking wizard as done.` when using the CLI command `bin/typo3 upgrade:run <wizard-identifier>` and return an error exit code. This also happen when not specifying a single wizard, but running all available ones. The GUI based upgrade execution behaves different, as it does not return an exit code and does not display information about `no changes applied`, like its CLI counterpart. This change: * Adds new concrete exception classes for the `upgrade:run` command. * Modifies `UpgradeWizardCommand::getUpgradeWizard()` to throw now one of the new concrete exception or return a wizard instance to run. * Skips available upgrade wizards not eligible to be executed. Resolves: #103447 Releases: main, 12.4 Change-Id: Ib6eab07919bb2f6e11bac774ecfd333572c2205f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83944 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/install/Classes/Command/Exception/WizardDoesNotNeedToMakeChangesException.php 27 additions, 0 deletions...and/Exception/WizardDoesNotNeedToMakeChangesException.php
- typo3/sysext/install/Classes/Command/Exception/WizardMarkedAsDoneException.php 27 additions, 0 deletions...Classes/Command/Exception/WizardMarkedAsDoneException.php
- typo3/sysext/install/Classes/Command/Exception/WizardNotFoundException.php 27 additions, 0 deletions...all/Classes/Command/Exception/WizardNotFoundException.php
- typo3/sysext/install/Classes/Command/UpgradeWizardRunCommand.php 45 additions, 32 deletions...ysext/install/Classes/Command/UpgradeWizardRunCommand.php
Please register or sign in to comment