- Mar 16, 2023
-
-
Benni Mack authored
The "BeforeRedirectEvent" in EXT:felogin did not allow to modify the actual redirectUrl, which is now modified, as the Event was not as powerful. Resolves: #96813 Releases: main, 11.5 Change-Id: I5716c9a3f8d58cd019dca5e3e9d47a242c9ec45e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78135 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
A new TCA type "uuid" is introduced, which allows to simplify the configuration when working with fields, containing a UUID. The functionality is based on the Uid symfony component. FormEngine will automatically create a UUID when non is defined yet. Same does the DataHandler in case an invalid UUID is defined, while the field is defined as "required", which is the default. The UUID is displayed as a readonly input field. Using the new TCA type, corresponding database columns are added automatically. Resolves: #100171 Releases: main Change-Id: Ic81d4cc0158e77988e38cdab6ddcc5d42aa47fcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76891 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
-
Jasmina Ließmann authored
To avoid an inconsistent appearance, the table columns in the planner table are given minimum widths and their content is positioned vertically. Furthermore, the state color of deactivated task groups and tasks changes from 'warning' to 'info'. Resolves: #100009 Releases: main Change-Id: Ibb215e797d413339410297b0c6bdddc8656f01b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77922 Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
Christian Kuhn authored
A misleading variable name is updated to make the method more clear and easier to read. Resolves: #100181 Related: #97816 Releases: main Change-Id: I12b646196cbb80d521eb8bb3a1bd175ef3d9bbdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78136 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Rémy DANIEL authored
Given the input width/heigth, getImageScale can return either int or float, depending of the calculated sizes. This can triggers strict type warnings in calling code, if width/heigth are expected to be integers. In order to fix this, returned width/height are now always integers. Resolves: #100076 Releases: main, 11.5 Change-Id: Ic29ba67f80a3a11a00a5b66f2644f923fa765064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78019 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Oliver Hader authored
This change introduces various representations of the Content-Security-Policy domain as PHP classes. The PSR-15 middlewares `ContentSecurityPolicyHeaders` are applying the corresponding HTTP headers to each response in the frontend and backend scope - in case no other component already added a `Content-Security-Policy` or `Content-Security-Policy-Report-Only` header, and only if the corresponding feature flag is enabled: + `security.backend.enforceContentSecurityPolicy` + `security.frontend.enforceContentSecurityPolicy` For new installations `security.backend.enforceContentSecurityPolicy` is enabled via factory default settings. Resolves: #100055 Related: #99499 Related: #97068 Releases: main Change-Id: I355393738f1d578b612e0e041e87be643f9e389a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77997 Tested-by:
-
- Mar 15, 2023
-
-
Christian Eßl authored
Since v3, Doctrine DBAL supports adding custom driver middlewares. These middlewares act as a decorator around the actual `Driver` component. Subsequently, the `Connection`, `Statement` and `Result` components can be decorated as well. A new setting is introduced to register custom driver middlewares that will automatically be added to a newly established Doctrine database connection. Resolves: #100089 Releases: main Change-Id: I4cf8e0252c3241f49ce1b9adb68cb85d978e164b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78029 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Nikita Hovratov authored
Tests for the "key" argument were duplicated. This patch aligns the comments with the actual input. Resolves: #100178 Releases: main Change-Id: I92d853e9b8d5890d4f54c24803ff4d3ce99f11c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78133 Reviewed-by:
-
Jochen Roth authored
Currently, it's possible to submit an empty page title in the inline edit feature. If an empty title was submitted, the entire element is gone. This has been fixed by adding the 'required' attribute to the input field. Resolves: #100177 Releases: main Change-Id: Ibdfa02da537301cf1f0bb65795356b090beb73d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78131 Tested-by:
-
Oliver Hader authored
Converting the class to an enum is possible since * the constructor is private, * property $type is not exposed, * public functions are kept. Resolves: #100172 Releases: main Change-Id: I2ce736fd93f64a288300cfd7f09c5a63d18552b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78129 Tested-by:
-
Oliver Bartsch authored
When using TCA type "json", corresponding database column is automatically generated - if not already defined. This column is now configured as nullable to prevent SQL errors in case no default value has been defined. Resolves: #100156 Related: #100154 Related: #100101 Related: #100088 Releases: main Change-Id: Ib9f6f17d33ed2af8f5b2128a68cb16d438feb22b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78109 Reviewed-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Hader authored
Unfortunately PHP emphasizes "weak" over "map" in their new PHP 8 data-structure `\WeakMap`. As a result it cannot be passed to other functions that would enrich an existing `\WeakMap` - since objects created in that function scope would not exist outside and thus directly trigger garbage collection of `\WeakMap`. `\SplObjectStorage` has a strange behavior when using an iteration like `foreach ($map as $key => $value)` - the `$value` is actually the `$key` for BC reasons. As a substitute, `\TYPO3\CMS\Core\Type\Map` is introduced which has a similar behavior and got an additional `Map::fromEntries()` factory. It acts as a wrapper of `\SplObjectStorage` with reduced features. Example: $map = new \TYPO3\CMS\Core\Type\Map(); $key = new \stdClass(); $value = new \stdClass(); $map[$key] = $value; foreach ($map as $key => $value) { ... } Resolves: #100168 Releases: main Change-Id: I5c26dc4aa9b4679112a27bd4cbebcfbe0899b094 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78127 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
TypeScript is updated to the current version 4.9, while TS 5.0 is around the corner. In the same run, eslint and its friends are updated as well to stay compatible with TypeScript 4.9. Executed commands: npm i --save-dev \ @typescript-eslint/eslint-plugin@^5.55.0 \ @typescript-eslint/parser@^5.55.0 \ @typescript-eslint/typescript-estree@^5.55.0 \ eslint@^8.36.0 \ typescript@~4.9.0 npm run build Resolves: #100169 Releases: main, 11.5 Change-Id: I79b73e6cc11a252bfa59c798bf7dcf4e2b959bd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78128 Tested-by:Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Mar 14, 2023
-
-
Alexander Schnitzler authored
Releases: main Resolves: #100091 Change-Id: I20e180f174ad4511d33800d2c38b071de5ea4b86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78031 Reviewed-by:
Dmitry Dulepov <9csxfqr4jy@liamekaens.com> Tested-by:
-
Torben Hansen authored
This change cleans up parts of ext:lowlevel by * using constructor property promotion where possible * using typesafe comparison for command option `dry-run` * removing superfluous typehints in doc headers * adding missing typehints in doc headers * using strict comparison where possible * adding function parameter type declaration where suitable * adding missing function return types * fixing a typo in `ProviderRegistry` Resolves: #100158 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I9a3cbf09652d1fec586f89965569c7d087bc7aa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78110 Reviewed-by:
-
Andreas Fernandez authored
The result container in LiveSearch used to use `TYPO3.Backend` to access the righthand module container of the TYPO3 backend scaffold, which is bad practice as the dependency is defined somewhere. It's better to explicitly import the `Viewport` module, providing the same functionality. Resolves: #100125 Releases: main Change-Id: I139b26370739d568b190ef7375527e491086a694 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78078 Reviewed-by:
-
Oliver Klee authored
Function callbacks are declared using the new PHP 8.1 feature "first class callable", which e.g. uses the named `trim(...)` function symbol, instead of the string `'trim'`. see https://www.php.net/manual/en/functions.first_class_callable_syntax.php Resolves: #100144 Releases: main Change-Id: I708f86e022e397f3fcf32596043336b430e9c9ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78097 Reviewed-by:
-
Christian Kuhn authored
Having an invalid wildcard import to a not existing directory should not raise a "No such file or directory" PHP warning: @import 'EXT:sitepackage/.../NonExistingFolder/*.tsconfig' Resolves: #100121 Releases: main Change-Id: Ice567b27cfd78c166e2de2e61801fc8c02cf8a72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78125 Tested-by:
-
Torben Hansen authored
Custom TYPO3 authentication services can now directly access the PSR-7 Request object via the $authInfo array, handed over to the initAuth() method of those services. This therefore allows to further reduce usages of PHP super globals and `GeneralUtility::getIndpEnv()`. Resolves: #100116 Releases: main Signed-off-by:
-
Benjamin Kott authored
Releases: main Resolves: #100163 Change-Id: Id4f8d3f871e6b2c2ae02fb6ee6ed114bc5d3da01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78118 Tested-by:
-
Christoph Lehmann authored
Hand over the overlayed page record from PageRepository::getSubpagesForPages() to the PageLinkBuilder in order to not fetch and overlay the target page twice. This reduces the amount of SQL queries when building menus. Resolves: #99612 Releases: main Change-Id: Ibb4505f9a5bf95594506730bb988dacdc27046ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77387 Reviewed-by:
-
Chris Müller authored
With the introduction of the new country API and the correspodning Fluid form viewhelper in #99618, is the form framework extendend for a new form element "country select". The form element allows several configuration options and renderes a single select element in the frontend, using the corresponding form viewhelper. Following configuration options are available: - First option: Defines the "empty option", i.e. the first element of the select. - Prioritized countries: Defines a list of countries, which should be listed on top. - Only countries: Defines the countries to be shown in the select list. - Exclude countries: Defines the countries not to be shown in the list. Resolves: #99735 Releases: main Change-Id: I27f135bb38ba727d25fb6bdc684555972f1e8f1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77623 Tested-by:
-
jakotadesigngroup authored
Resolves: #100131 Releases: main, 11.5 Change-Id: If23bfd25f95b328bee8227003e7983ef17f61dfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78083 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Oliver Klee authored
Also add the missing types and correctly use intersection types. Also reorder the type declarations for consistency. Also drop superfluous type annotations. Resolves: #100139 Releases: main Change-Id: I6b5337a0e02f36be84ff28a861c2afa58341093a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78091 Tested-by:
-
Alexander Schnitzler authored
- Introduce type declarations - Enhance type information for phpstan/psalm - Use modern PHP syntax in some places - Refactor redundancies Releases: main Resolves: #100120 Change-Id: Ia2a018c589b131980b09246ffd3730b322bddc1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78073 Tested-by:
-
Thomas Hohn authored
The logging in the method set_no_cache should not depend on the calling parameter $internal. Instead it should be notice in both cases. Since it's possible to change the general log level during development or debugging the entries will still be visible, just not on production systems which makes good sense. In addition the variable $internal was renamed to $internalRequest in order to make the purpose clearer. Resolves: #100067 Related: #97815 Releases: main, 11.5 Change-Id: I59af542e22c2a6ad65ad42e0fc3d2c64f0408f76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78010 Tested-by:
-
Thomas Hohn authored
Added some guards, isset(), to ensure that array keys that aren't defined are accessed and throws PHP warnings. Resolves: #99845 Releases: main, 11.5 Change-Id: I009f5d23a9bf3cd112dc786256d1144983736dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78041 Tested-by:
-
Christian Eßl authored
When opening a page in the view module, that belongs to a page tree with no valid site configuration, an exception was thrown, because the ModuleData clean-method was expecting at least one item in the language array. Resolves: #100092 Releases: main Change-Id: I60ae316e29ec87d62ba8728103283bbe0778f0c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78032 Reviewed-by:
-
Oliver Klee authored
Now the parameter names are consistent with those of the other explode-related methods. Resolves: #100145 Releases: main Change-Id: Ibd8fd736741a8f1cdad2e33ae3e777412cd383eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78098 Reviewed-by:
-
Thomas Hohn authored
The constructor of UnableToLinkException should be strictly typed, since the method getLinkText() is strictly typed. Also make the variable declaration of $linkText strictly typed. It will throw an error if $linkText isn't a string. Added a todo for TYPO3 v13. Resolves: #100119 Related: #100106 Releases: main Change-Id: Ifbb9a3f5b4aa1fd1588eb0596731377f41bc5ffd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78072 Tested-by:
-
Sybille Peters authored
Use alt text "Logo" (instead of "TYPO3 Logo") in the SystemEmail Fluid layout if a custom logo is used. The layout SystemEmail is used by default when sending Fluid emails. It is for example used when sending a test email via the "Environment" module in the install tool or "Admin Tools" in the backend. If an image is configured in the backend Extension Configuration login.loginLogo, this image is used and the text is added as alt text. Previously, "TYPO3 Logo" was always used as alt text, which is awkward if the alt text is displayed instead of the logo, which may happen for several reasons Resolves: #100081 Releases: main, 11.5 Change-Id: Ia7c1d7ab7a008fb6ed2f3851db5e1af171a4af9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78023 Tested-by:
-
Helmut Hummel authored
Instead of requiring strictly the TYPO3 implementation of a console Application, the property is allowed to hold an instance of the base application class. Releases: main Resolves: #100160 Change-Id: I40934ac7a5534f211021b0ab331ca9903a307243 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78116 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Mar 13, 2023
-
-
Torben Hansen authored
This change adds a native type declaration for the property `$contentFields` in `ContentVisibleFieldsTest`. Resolves: #100149 Releases: main Signed-off-by:
-
Stefan Bürk authored
Creating new `ext:reactions` records are broken and emits an sql error message. This happens when it's tried to switch to the core-shipped type. >> 2: SQL error: "Field 'fields' doesn't have a default value" Using a default value on database level does not work with all database backends TYPO3 v12 officially supports, which has been tried with #100088 and mitigated with #100101. So that's not an option here. This change bakes the default value for `json` type fields using TCA default setting again, which has been the way the original `type=user dbType=JSON` variant used with #99226. Resolves: #100154 Related: #100101 Related: #100088 Related: #99226 Related: #99062 Releases: main Change-Id: I07533f36cfbc1f627b14727195bbcbd5c4b1e35c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78107 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Torben Hansen authored
This change adds constructor property promotion in ext:opendocs `OpenDocumentController`. Resolves: #100150 Releases: main Signed-off-by:
-
Sybille Peters authored
The PHPDoc block in the ViewHelper source is used to render the ViewHelper documentation. Remove link to Changelog with incorrect formatting in asset.css ViewHelper, which never worked. As the Changelog is from version 10.4, there is little benefit and more risk of linking to outdated information in the future. Resolves: #100151 Releases: main, 11.5, 10.4 Change-Id: I0b11e7ec90ccfa8864ca4ddaa7ca83004fe266c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78105 Tested-by:
-
- Mar 10, 2023
-
-
Oliver Klee authored
Also fix some types as needed. Resolves: #100134 Releases: main Change-Id: I87cebe0a3a7e3cb97a9a1802640ed856d7939f39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78085 Reviewed-by:
-
Alexander Schnitzler authored
Releases: main Resolves: #100068 Change-Id: Ibc06f9c6b227f956290e02cc9bbd44587bac6f78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77851 Reviewed-by:
-
Torben Hansen authored
The cookie warning message in ext:felogin depends on conditions which are never met and can not be fixed easily. Additionally, failed authentication in ext:felogin already shows a similar message, so the non-working cookie message can safely be removed. This change removes code affecting the non-working cookie warning message. Resolves: #100135 Related: #99710 Releases: main Signed-off-by:
-
Christian Eßl authored
Fix a missing type cast, where on creating a site with only a digit number as identifier, both the backend and frontend would throw a type error. Resolves: #100083 Releases: main Change-Id: Ic91d45390449bf7a71779570bd89812fdfd33145 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78025 Tested-by:
-
