- Aug 13, 2020
-
-
Alexander Schnitzler authored
Updating phpstan to version 0.12.37 lets phpstan benefit from static reflection which does no longer come with the need to load analyzed classes and use the native reflection api of php. Instead, roave/better-reflection is used, which does a better job and reduces false positives. Since phpstan has been updated, the rules which have been copied over from the vendor package had to be updated as well. And since phpstan does find more errors now, a few rules had to be disabled again. Used commands: - composer require phpstan/phpstan:^0.12.37 --dev - composer require friendsoftypo3/phpstan-typo3:^0.4.0 --dev Releases: master Resolves: #91635 Change-Id: Ia6b68e7ed1428fbc40ae4d1b9eb3a13d212a3a5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64851 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Georg Ringer authored
Fix a typo in the variable name to show possible descriptions again. This is especially useful if a task failed because it contains the actual error message. It has been broken since the refactoring to fluid. Resolves: #91871 Releases: master, 10.4, 9.5 Change-Id: I8cd1ed8268e810ca505bc74728db62ac229c034f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65313 Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Aug 12, 2020
-
-
Christian Kuhn authored
If workspace records are present on deeply nested pages or have long titles the action buttons can not be reached. A vertical scroll bar will be the result. The patch uses existing server side crop methods. Change-Id: I0e6651ceab3c4b74aa3471ddecf56775a6e6be9c Resolves: #90918 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64041 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Kuhn authored
The "LIVE workspace" tab of the workspace module always showed wrong records from other workspaces. This issue has been resolved with the pid=-1 removal in v10. Since then, this tab never shows records. The patch removes the tab from the interface. Users, including admins, now see a "Please select a workspace first" message when calling the module in online / live workspace. Resolves: #91983 Related: #89122 Related: #13056 Releases: master, 10.4 Change-Id: Ib1029253d53745d82786f31276283e5f88ebf9b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65284 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
Oliver Hader authored
Canonical URL generation is tested using real requests to the website frontend instead of manually creating TSFE components. Resolves: #91982 Releases: master, 10.4, 9.5 Change-Id: I325af73d53af5ae9ccefd6a0c3d75776c4951893 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65281 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
The option "IPmaskMountGroups" allows to automatically assign usergroups to website visitors based on their incoming IP address / subnet. This feature is useful for intranets, but very limited in its functionality (e.g. auto-login for intranets is not possible, logging in from home with the same user does not show the information), where it is recommended to use more powerful third-party extensions instead. Resolves: #91974 Releases: master Change-Id: Idf219ba44242d37aca5212c50819aba964236a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65274 Tested-by:
-
- Aug 11, 2020
-
-
Andreas Fernandez authored
Due to recent changes in TypeScript builds, importing all modules into a single variable became obsolete for the used modules. However, two places were forgotten, which cause issues. The import statement are adjusted to ES6 style to fix issues with possibly (non-)existent default exports. Resolves: #91969 Related: #91954 Releases: master, 10.4 Change-Id: I3fc0e1a433521e5fc9b87dc11237e1a42e9e35f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65272 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
- Aug 10, 2020
-
-
Georg Ringer authored
AssetRenderer A call to `GeneralUtility::createVersionNumberedFilename` is required to avoid using outdated files from browser cache. Resolves: #91889 Releases: master, 10.4 Change-Id: I0963e4e8f447eff111314a8165038fd55c422edc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65238 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Simon Gilli authored
Currently it is possible to add an invalid cache configuration with empty identifiers. This change avoids this behavior by checking the indentifiers while changing the cache configuration at the CacheManager. Resolves: #91959 Resolves: #91773 Releases: master, 10.4 Change-Id: Icfb25ab52418da166582dba4bca389250325097b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65229 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
Christian Kuhn authored
When dealing with inline foreign field setups in workspaces and having a child table not workspace aware, the DataHandler still tries to create workspace copies of the not workspace aware child. In v9, it sets pid=-1 for those records, which succeeds if the pid db field is signed. In this case a dead record of the child is created. If the field is unsigned, the insertion fails and an error message is created. In v10 and master pid=-1 is gone and the real pid is set, the record is created and becomes a 1:1 duplicate in live workspace. The patch adds an according check to the DataHandler in workspace context to skip not workspace aware children. Resolves: #91680 Releases: master, 10.4, 9.5 Change-Id: Ifb8183f25e69a75ecc5b5ebac3c9a57c03265e7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65230 Tested-by:
David Steeb <david.steeb@b13.com> Tested-by:
-
Benni Mack authored
Due to the logic being based around SiteLanguages and the "All" language not being one, it was excluded from being rendered in the content header. Resolves: #90854 Releases: master, 10.4 Change-Id: I5152cedc80e2b1fd45b6eb626fd635d9be78a29b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64125 Tested-by:
-
Oliver Bartsch authored
Calling ShowImageController with old links containing serialized parameters leads to PHP warnings as the json_decode doesn't return an array in this case. To prevent this warnings we now ensure that parameters is a valid array in any case, prior to calling the foreach. Resolves: #91882 Releases: master, 10.4, 9.5 Change-Id: If33068f4f69bd858ff130ca4f31970df8fa1d624 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65137 Tested-by:
Stefan P <spo@snk.de> Tested-by:
-
Daniel Siepmann authored
In case sqlite is used, the uid is not of type integer. Therefore it is explicitly casted before passing to strictly typed method call. Resolves: #91950 Releases: master, 10.4 Change-Id: I4d9f8e4e526f861fd06f08c90c21d8b25832cc26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65222 Tested-by:
-
Benni Mack authored
This change moves the language evaluation of a page record much earlier in the frontend process. Before: * Resolve the page (determineId) based on permissions, visibility etc. * get TypoScript from Cache * Find a translation of the page and determine the content language Now: * Resolve the page based on permissions, visibility etc * Find the translation of the page * Get TypoScript from Cache This is a breaking change, as the hooks within settingLanguage() are now called at a different time of the processing logic for a frontend request, however it solves an issue that you can now use localized values for TypoScript conditions. Resolves: #23736 Releases: master Change-Id: Ia2db0233ce6680ae1cbcddb81574a41fa6333abf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65044 Tested-by:
-
Oliver Hader authored
The route configuration shown below using `ExtbaseEnhancer` is currently not evaluated anymore due to missing route variables in `routePath`. For this particular case in `ExtbaseEnhancer` the controller-action pair is implicitly defining variables. MyPlugin: type: Extbase extension: ... plugin: ... routes: - routePath: '/action' _controller: 'MyController::action' Resolves: #91880 Releases: master, 10.4, 9.5 Change-Id: Ib42f87c3c9f83acc7f2ceec4a93169d15777ed08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65134 Tested-by:Marco Bresch <marco.bresch@starfinanz.de> Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Tested-by:
-
Christian Kuhn authored
A missing restriction in PageRenderer->getSubpagesForPages() leads to the workspace preview of a page changed in a workspace to render both live and workspace versions as menu items in multi level menus. Adapt the query to fetch the correct combination of live and overlay records. Resolves: #91943 Related: #89555 Releases: master, 10.4 Change-Id: I924803fc2997a9a5c990bc4cf8a628113aae0b22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65212 Tested-by:
-
- Aug 09, 2020
-
-
Andreas Fernandez authored
jQuery 3.5 has been released a while ago, it's safe to update to the current version. However, as 3.5.0 introduced some deprecations, it should be updated in master only. Executed commands: yarn add jquery@^3.5.1 grunt build Resolves: #91953 Releases: master Change-Id: Ife43bc2679549757dede58b0b1fa92df9bce6d7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65224 Tested-by:
-
- Aug 08, 2020
-
-
Andreas Fernandez authored
The event listener registration for AjaxDataHandler events is faulty which causes event stacking when a workspace gets deleted. The registration now happens at a central place to solve this issue. Resolves: #91955 Related: #91948 Releases: master Change-Id: Ifafd8171ce3da20883e39c43d8300f92366866b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65227 Tested-by:
-
Andreas Fernandez authored
This patch fixed a long existing issue regarding workspaces. If a workspace is either created, updated or deleted, the topbar menu gets reloaded to update the workspace menu now. Resolves: #91948 Releases: master, 10.4 Change-Id: I316994c209d3bebc0e72e8e7ad956c5cf30502c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65221 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
Andreas Fernandez authored
Events sent via AjaxDataHandler are now broadcasted by using the Broadcast Service. This change allows e.g. the topbar to listen to these events and trigger a reload. Broadcasting has the nice side effect that the event is sent to all browser windows which allows multiple simultaneously opened backends (that share the same domain) to react on that event. To ease the integration of event listeners, the event payload sent via classic `dispatchEvent()` is adjusted to share the same structure with broadcasted messages. Resolves: #91947 Releases: master, 10.4 Change-Id: I04321f9ab3db309972890e037a1d3790d9b06f79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65220 Tested-by:
-
Andreas Fernandez authored
This changes the configuration of the TypeScript compiler to resolve modules in "node" style, which allows using TypeScript declaration files (*.d.ts) shipped with npm packages. Additionally the option "esModuleInterop" is enabled which allows us to use CommonJS modules in AMD modules without fiddling with incompatible exports. As a negative side-effect, all JavaScript have to get recompiled to reflect these changes. Resolves: #91954 Releases: master, 10.4 Change-Id: If6386f5062bfbe439615bb947e94cd728dfd5b2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65225 Tested-by:
-
- Aug 07, 2020
-
-
Benni Mack authored
This reverts commit fb61db41 as it contained various regressions, which should be fixed in the next iteration. Change-Id: I03b6ff9e63a1425fae3745f70bbd9b8a2a94c081 Releases: master, 10.4, 9.5 Resolves: #91949 Reverts: #88943 Reverts: #88098 Reverts: #88259 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65200 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Benni Mack authored
Classes without any special Extbase treatment (e.g. no injection) are migrated to GeneralUtility. This saves a bit performance, because ObjectManager in turn would call GeneralUtility as well for these classes. Areas in Extbase are not touched, as they will be migrated separately. Resolves: #91937 Releases: master, 10.4 Change-Id: I899af0d377f9d710621e2775f8a7f51887d130d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65189 Reviewed-by:
-
Oliver Hader authored
New `SecurityUtility. getRandomHexValue(20)` returns 20 hexadecimal characters provided by the Web Crypto API. see https://developer.mozilla.org/en-US/docs/Web/API/Web_Crypto_API Resolves: #91809 Releases: master, 10.4 Change-Id: Iaee1c7641b34e1316fccd069808c519d1c3ba2ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65046 Tested-by:
-
Christian Kuhn authored
The clipboard has a 'move' and a 'copy' mode. This can be changed in the list module where the clipboard is rendered. Using 'cut' in context menu, the state is forced to 'move', using 'copy' in context menu, the state is forced to 'copy'. If there is an element in the clipboard, 'paste' icons in list and page module appear. Their title tag is always 'paste' or 'paste after' or similar. Only the modal in page module distinguishes between copy and paste and changes its wording 'Do you really want to move' vs. 'Do you really want to copy', while the modal title is always 'paste'. This is odd from an UX point of view: Users learned they either 'cut + paste' or 'copy + paste': The decision to cut or paste is the first step when selecting the element, it's then either cut-out and moved to clipboard, or a copy in the clipboard is added. The second step is then just 'paste here'. The patch changes the modal wording to always use 'paste' as second step, just like the icons already do. Resolves: #83566 Releases: master, 10.4 Change-Id: Ia7b4296bbcee1d21b2be0d0ddb9e1019c93e9b4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65190 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Aug 06, 2020
-
-
Benni Mack authored
Previously, when using the "Split Preview" for comparing a workspace version, and a live workspace, in iframes, the workspace version received the GET Parameter "&ADMCMD_prev=1", and the live workspace the "ADMCMD_noBeUser=1" (= no backend user is logged in) for THESE requests. Navigating through the live workspace, the ADMCMD_* GET parameters are lost in both variants. This change replaces the ADMCMD_noBeUser=1 with ADMCMD_prev=LIVE making the options consistent naming-wise. In addition, when ADMCMD_prev=LIVE is set, the current BE_USER is kept but the workspace is set to "0" temporary (for this request), allowing for e.g. the admin panel to continue to work. When ADMCMD_prev=LIVE or ADMCMD_prev=IGNORE is set, the parameter is added to config.linkVars, allowing to keep using the ADMCMD_prev when browsing through the workspace and live versions in the iframes. Resolves: #34199 Releases: master, 10.4 Change-Id: Ifa732d56af1af1d6f01f00b6b4c035b6fdbc02ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65213 Tested-by:
-
Andreas Fernandez authored
This patch changes the behavior how workspaces are switched via the topbar menu. The switch now happens by explicitly requesting the workspace module with a new set `workspace` parameter. Previously, it was tried to reload the content iframe which may has a `workspace` parameter already set, resulting in simply reloading the previously requested iframe. Resolves: #91946 Releases: master, 10.4 Change-Id: I3e3dac98c5a12c3329ed5fc948c10bd36ef2d8d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65218 Tested-by:
-
Benni Mack authored
In order to ensure that the root page ID is always pointing to the live version, the SQL query is adapted to never include versioned records by ensuring to only include live workspace records in the SQL query for pages. Resolves: #72567 Releases: master, 10.4 Change-Id: I47f16d9ea2a65c70d732283b6b807b0fdc19e371 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65191 Tested-by:
-
Benni Mack authored
This change uses a "random" frontend user ID (currently 1337) to a very unlikely number PHP_INT_MAX to ensure that no usual frontend user is used to preview. This line can be removed completely once https://review.typo3.org/c/Packages/TYPO3.CMS/+/64441 is fixed as well. But 1337 is a no-go (that's why it needs to into 9.5) Resolves: #91837 Related: #90773 Releases: master, 10.4, 9.5 Change-Id: I70eebcf1220b216b3a9929a7b31eb83e999f282a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65215 Tested-by:
-
Christian Kuhn authored
Fixes an obvious PHP notice level error thrown in casual requests multiple times. Resolves: #91945 Releases: master, 10.4 Change-Id: I7d21c0e67ac680443cc0892bfa15ddd45c724b22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65217 Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Christian Kuhn authored
A last partial usage has been dropped during 6.2 times but the file has never been removed. Do that now to avoid further developer confusion. Resolves: #91944 Related: #49689 Releases: master, 10.4 Change-Id: I784eaa7cbcf32776db1c0b21ef4ca45cd5c08f2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65216 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Helmut Hummel authored
Only try to fetch translated uids for translated records, and provide is_siteroot field for slug helper, so that it can be checked if slug is generated for a site root. Resolves: #90736 Resolves: #89485 Releases: master, 10.4, 9.5 Change-Id: I707e5a1df2d06a81eea2dd491302b003d086e42a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65116 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Christian Kuhn authored
Another 'broken since ever' fix: Sorting a record in workspaces by moving it 'after itself', the record vanishes from the interface. While this action is kinda useless, it can for instance accidently happen by an editor. As with other move operations in workspaces, a move placeholder and the versioned data record is created. In case of inserting after itself, the move placeholder state is not correctly updated - both pid and sorting values end up with 0. The records then no longer belong to the correct pid and are not 'seen' by workspaces. The patch fixes this case by making sure the pid and sorting determination of the move placeholder does not accidently operate on itself as reference record. A series of functional DataHandler tests nail the correct state for pages and tt_content in non-workspace and workspace scenarios. Resolves: #53619 Releases: master, 10.4 Change-Id: I39b5e9f72bd05645dcd429bed3833d2a792efaec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65188 Tested-by:
-
Christian Kuhn authored
The row selection of records in JavaScript is not reset after execution of a publish action in the workspace module. If an editor tries to publish or disard another set of records without reloading the module, the already handled records from the first action are send again in the request payload, leading to server side exceptions. Resolves: #89927 Releases: master, 10.4 Change-Id: I8800c1df34fd749d84e63ea3e42c7b83513e1a38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65185 Tested-by:
-
- Aug 05, 2020
-
-
Markus Klein authored
Use the proper check to avoid adding JS libs more than once. Resolves: #91653 Releases: master Change-Id: I3b750e6b2341681b45a722ae8ecfacb1d17243da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64897 Reviewed-by:
-
- Aug 04, 2020
-
-
Jigal van Hemert authored
The variable $crazyRecursionLimiter actually limits the number of subpages that are rendered for each page and not the depth of recursive calls to getTree(). This limit only affects the browsable pagetree in for example the link browser and not the pagetree in the navigation pane. Resolves: #91853 Releases: master, 10.4, 9.5 Change-Id: Ib2ff5471226217bc880ddee3b278771393a09354 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65083 Tested-by:
-
Benni Mack authored
PropertyMapper (which is a singleton) previously created a new $messages instance every time "convert" was called. This works for most cases, however when using "getMessages()" only the last message was returned. It would be very useful to keep the messages in place until "resetMessages()" is called, which is used within each action of the Extbase controller validation to avoid some edge-case issues when using multiple actions on one request. Resolves: #70872 Releases: master Change-Id: I2fddc4261567cad2ebb12f91296ff3ec8d681ad8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65114 Tested-by:
-
Benni Mack authored
When fetching a frontenduser from the database, the constuctor is not called, but initializeObject is called. For this reason, the initialization of the FrontendUser happens on initializeObject() as well. Resolves: #83386 Releases: master, 10.4 Change-Id: I72e39b6485a4a072b7b94f96f947151222d68089 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65177 Tested-by:
-
Stephan Großberndt authored
This patch adds the directory `typo3conf/sites/` and for composer based installs `config/sites/` to the directory status check in the install tool. Resolves: #91488 Releases: master, 10.4 Change-Id: I059c92d7ec2d740ba3f7d3c5d81181cadc146681 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64577 Tested-by:
-
Benni Mack authored
When deleting a page with records an editor does not have access to, the error message "Attempt to delete records from disallowed tables" is shown which does not give a hint to the editor what tables are an issue. This change improves the error message to show the tables that are prohibited. Resolves: #55307 Releases: master, 10.4 Change-Id: Ibe451e7042b9832815e2d4a26104e06adc94656d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65175 Tested-by:
-
