- Nov 13, 2019
-
-
Benni Mack authored
The application context is stored in the Environment class since TYPO3 v9, which is the correct place instead of GeneralUtility::getApplicationContext(). Resolves: #89631 Releases: master Change-Id: I55de17ef3b9cbd0962a2c604913c736bd52ac6d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62247 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Nov 12, 2019
-
-
Jan authored
Fixed a broken link which points to the "register extension key" page. Releases: master, 9.5 Resolves: #89642 Change-Id: I5a5408b0690a0d3949cf27136ead1223a12a0304 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62297 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Benni Mack authored
A few places in TYPO3 Core do manual checks if there are non-cacheables on a page, which could be simplified by just using the $TSFE->isINTincScript() method. In addition, a safer check for a NON-empty INTincScript value is used, instead of just a typecheck of array. Resolves: #89652 Releases: master Change-Id: I24b2b55b3705927720e36181926cf6e752bf0f66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62303 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
In order to centralize USER_INT ("non-cacheables") into TSFE logic, some functionality is moved into TSFE regarding headerData, JS and CSS inclusions. Resolves: #89651 Releases: master Change-Id: Ib0f6daa2306f6cba90f27db6baff5bae38403842 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62302 Tested-by:Daniel Gorges <daniel.gorges@b13.com> Tested-by:
-
Stephan Großberndt authored
This patch adds a cast to the property `$mask` before handing it over to `IpAnonymizationUtility::anonymizeIp()` as this method requires `$mask` to be an `int`. This is necessary as when the task was created and saved in TYPO3 8 it was serialized as `string`. Resolves: #89646 Releases: master, 9.5 Change-Id: Ie0745028882991204bfa5c25ec1a4bbb7955b7c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62300 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Nov 11, 2019
-
-
Sebastian Klein authored
The word 'The' was misspelled. Additionally, the readability of the last sentence was slightly improved. Releases: master Resolves: #89637 Change-Id: I21c76732ef5572b26fc5762b5445ba3612aabaf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62294 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Andreas Fernandez authored
Due to the IRRE rewrite done in #88182 the avatar selection for backend users broke, since the Setup module doesn't use FormEngine, yet. The controller now adds dedicated JavaScript to listen to the `typo3:elementBrowser:elementInserted` message sent by the Element Browser to set the file reference uid correctly. Resolves: #89634 Related: #88182 Releases: master Change-Id: I5e6a56b35891ab380634540e9ed5ef0b3a96f082 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62292 Tested-by:
-
- Nov 10, 2019
-
-
Georg Ringer authored
Make it possible to set defaults vars for plugins based on the AbstractPlugin. Resolves: #17283 Releases: master Change-Id: Ic066fcf46f299554289e30eddf4529121c088881 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58846 Tested-by:
-
Kevin Appelt authored
The description field is one of the most important fields for SEO. When EXT:seo is installed, the description field can be found on the SEO tab of the page properties. If EXT:seo is not installed, the field will still be on the Metadata tab. Resolves: #86516 Releases: master Change-Id: I9d31f74bcc6e7f0f88a39e718b8437e2f92b30e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62102 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Susanne Moog authored
Resolves: #89630 Releases: master Change-Id: I00021fb1aaf64f2fcc9ee5c8557837c1c90cff4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62268 Tested-by:
-
- Nov 09, 2019
-
-
Susanne Moog authored
In case of IRRE in site context not the full form engine variables are available - therefor a fallback has been implemented. Resolves: #89628 Releases: master, 9.5 Change-Id: I0c499d41354e4dc369f5a53f2109d8559b5e3bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62265 Tested-by:
-
Devid Messner authored
Remove htmlspecialchars in GridDataService for path_Workspace and path_Live. Resolves: #87069 Releases: master, 9.5 Change-Id: I1d5eff4b62ea9657efbe3c88c4a61b8e1b7cf1e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59023 Tested-by:
-
Andreas Fernandez authored
This patch moves the inline JavaScript for clipboard handling into a separate module that is re-used in record list and in file list. Additionally, the function `editList` only used in record list context has been moved into the according module. Resolves: #89476 Releases: master Change-Id: I43c972aadd8cd097850139813a01c3560a9b202c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62041 Tested-by:
-
Aimeos authored
composer require "psr/http-message":"^1.0" composer require "psr/log":"^1.0" Releases: master Resolves: #89626 Change-Id: Ieeceddba8ea49da1eac66f113f1c22623f479582 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62260 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Fernandez authored
The value of `data-table-unique-original-value` was accidentally of type array. This causes runtime errors since a string is expected. This patch now creates a proper value passed to FormEngine to handle the original unique value. Resolves: #89588 Related: #87711 Releases: master, 9.5 Change-Id: I9184aa025f01196d0c206b5b86c712dc1049487f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62195 Tested-by:
-
Jörg Kummer authored
Change a variable name in migration example for getPagesTSconfig(). Adds further migration example for getPagesTSconfig() when retrieving a single value. Releases: master Resolves: #89394 Change-Id: I0180126cd531335a7775425d1f350587dd5f7be0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61947 Tested-by:
-
Georg Ringer authored
The export of extensions provided by https://extensions.typo3.org has been extended with the link to the documentation. This link is now shown in the list and detail view of extensions in the extensions manager. Resolves: #89458 Releases: master Change-Id: If1439bd7b97d9c60c2811716edef97a6e4ed870d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62032 Tested-by:
-
Gianluigi Martino authored
If the user has no access to edit the title of the page due to language restrictions, the pencil next to the title in the page module is no longer visible. Resolves: #88337 Releases: master, 9.5 Change-Id: Ia41821dd82821ad2c8d5a60dd053a43cadb0c361 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60837 Tested-by:
-
Benni Mack authored
The GifBuilder calculation does not need all of setup to calculate the values for the filename. Therefore, only the relevant parameters are used, making the shortMD5 call faster, according to the ticket author. Resolves: #64158 Releases: master Change-Id: I9ffd1e1f8a14c8f3904e83f251122225562de606 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62234 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Johannes Schlier authored
This commit adds an option to the slug input type which allows it to use the uid of a record when the update slug button is pressed in the FormEngine. Resolves: #89560 Releases: master, 9.5 Change-Id: Id645714f1b26e20e511022d1c74ea793964ffa19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62170 Reviewed-by:
Daniel Sattler <sattler@b13.de> Reviewed-by:
Wolfgang Klinger <wolfgang@wazum.com> Reviewed-by:
-
Riny van Tiggelen authored
The PageTitleProviders are now visible within the adminpanel debug panel. Since this information is in no way available when the page is cached, there's a message to view the page in uncached mode. Resolves: #88609 Releases: master Change-Id: I15b3187fb219ea488ea88950906545391994bc24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61116 Tested-by:
-
Oliver Hader authored
The `defaultController` setting is only applied if both `action` and `controller` parameters are empty. In Extbase context it happens that only `action` is defined, but `controller` is empty (since linking to the very same controller, just changing the action). The behavior now is the following: * set `action` and `controller` parameters to default if not given * set `controller` parameter to default if not given Resolves: #87337 Releases: master, 9.5 Change-Id: I3ee730f6bc665808c59cc07907467aa98c2de21a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59659 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Susanne Moog authored
The FAL Indexer uses the driver to get a hash for a file. In certain circumstances (and with 3rd party drivers) the hash generated might be null or invalid. In that case the ResourceStorage now throws an exception to alert the developer to the wrong return value. At the same time the Indexer catches and logs the exception to not interrupt the whole indexing flow because of it. For more information, please take a look at the ticket. Resolves: #66397 Releases: master Change-Id: I0f97cd23127e96b6d94161a9296750cbe3421075 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59893 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Oliver Hader authored
Only first level elements were considered when clearing assets in typo3temp/assets/ using corresponding functionality in maintenance section of the TYPO3 install tool. Resolves: #89569 Releases: master, 9.5 Change-Id: I9237aa3c6200b57cf4da256531b25062f52708ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62179 Tested-by:
-
Benni Mack authored
The original issue for endless redirect loops is already fixed via https://forge.typo3.org/issues/88032 whereas the query does not result in 307's anymore. Additional information on redirects is added as comment. Resolves: #87814 Releases: master, 9.5 Change-Id: I8c97b85cc30d217fe793608da1f26be52e8f68dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59815 Tested-by:
-
Daniel Siepmann authored
EXT:backend generates a URL to EXT:install, but has no dependency. This can lead to composer setups with EXT:backend but without EXT:install, leading to an exception while generating route. Therefore a suggest is added as a hint to install also EXT:install. Existing code is wrapped with an try / catch in order to work under both circumstances. Resolves: #89419 Releases: master, 9.5 Change-Id: Idedd299f218ae8f7ba9938800d2ac4a0c4e5614b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61999 Tested-by:
Karavas Aristeidis <aristeidis.karavas@gmail.com> Reviewed-by:
-
Helmut Hummel authored
When parsing HTML in parsefunc, we need to make sure that the attributes that are extracted for further processing are properly HTML decoded, as per definition they are encoded in the HTML being parsed. At the same time we revert a decode that was applied in ExternalUrlLinkBuilder, as this is the wrong place to handle HTML decoding, as the link builder is as well called with data from other contexts (TypoScript, data from link fields) that must not have the URL HTML encoded. This fix is required to allow email links to add subject and body arguments like: test@foo.test?subject=foo%20bar&body=baz and not have the ampersand in the url double encoded when generating links from RTE content. Additionally we need to properly encode the masked value for the JavaScript URI, to prevent browsers from url decoding wrong values. Releases: master, 9.5 Resolves: #89264 Related: #81625 Related: #80985 Change-Id: I3be2478df83cffc0dfe6af918eb224b4ee480b10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61799 Tested-by:
-
Christian Eßl authored
In AspectFactory::enrich(), the function would use class_uses() to determine, if an aspect uses the trait SiteLanguageAwareTrait. This however would only work on classes that use this trait, not on classes that inherit the class with the trait (For example XClasses). To fix this, a SiteLanguageAwareInterface was introduced, which is checked against. Resolves: #87380 Releases: master Change-Id: I55e90d40ec592dc15564c49f9437e7a2640ffb0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61893 Tested-by:
-
Christian Eßl authored
Forms in ext:form were previously not sorted in any manner, but just outputted in the order they were read from the filesystem's directories. Forms can now be sorted by multiple keys in either ascending or descending order. Two new yaml settings were introduced: `sortByKeys` and `sortAscending`. Resolves: #87798 Releases: master Change-Id: I2aae2e79cbd39394040a5b1280469a756bf0c7ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61896 Reviewed-by:
-
Michael Straschek authored
Dynamically fetching/applying additional data for the link explanation seems to be overdone, so we simply deactivate the toggle button and remove the icon after selection/modification of the link target. After persisting the record, the updated link explanation will be visible. Resolves: #88737 Releases: master, 9.5 Change-Id: I679abb2178aedfc8a29cccace99950a3a8acaab6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61422 Tested-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
-
Thorben Nissen authored
Removes enforcing of href attribute when storing RTE text into the database. Removes adding of absolute scheme on a tags without href attribute, when loading text from the database. Changes ContentObjectRenderer::typolink to render a tag without href anyway, if id or name attribute is present. Adds unit tests. Resolves: #87992 Releases: master, 9.5 Change-Id: I4dcd33e6f13dc6a1f364c96b425aa2f241653ae9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60324 Tested-by:
-
Alexander Stehlik authored
This prevents overwriting existing entries when a mount point and its target have the same parent. Resolves: #89402 Releases: master, 9.5 Change-Id: I1e527443410e0f875a95e803d4c3c026b089f5a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61962 Tested-by:
-
Ioulia Kondratovitch authored
Remove obsolete dot to make following setting work again: RTE.default.buttons.link.pageIdSelector.enabled = 1 This now renders an input field for a page ID again when setting a link via RTE. Resolves: #88656 Releases: master, 9.5 Change-Id: I25a9cd20fd269f3f4f683ee6474f424897601a86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61194 Tested-by:
-
Christian Eßl authored
In ext:form, string placeholders, like "{text-1}", can be used inside the finisher to place form inputs, made by the user, inside fields like the email subject, reploy to email and name, etc. These string substitutions however were not done for array keys (only array values). Resolves: #88550 Releases: master Change-Id: I727850f3e15479215b56be4cd136d93644b0d435 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61890 Tested-by: -
Martin authored
Add possibility to force UIDs from Command Line when importing a t3d/xml file. Releases: master Resolves: #87414 Change-Id: I2117079fb0a4af46355448256750978075749fb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59416 Reviewed-by:
-
Guido Schmechel authored
Add the property 'nomodule="nomodule"' to JavaScript files via TypoScript page.includeJSlibs.<array>.nomodule = 1 This patch affects the TypoScript PAGE properties * includeJSlibs * includeJSFooterlibs * includeJS * includeJSFooter Resolves: #86759 Releases: master Change-Id: I88db40ac973c17148a87504998f1070eba8d74af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58908 Tested-by:
-
Alexander Schnitzler authored
The AbstractController is an internal class which never really had any functionality than to provide some basic method for the ActionController. If users implemented their own controllers and extended the AbstractController directly, the further execution led to an exception. Unless people used the AbstractController and implemented the missing logic of the ActionController themselves, they didn't have a functional controller, therefore it's safe to assume that nobody extends the AbstractController directly. To be on the safe side however, the AbstractController is properly deprecated and will not be removed until TYPO3 11.0. People are - and always have been - encouraged to extend the ActionController. Releases: master Resolves: #89554 Change-Id: I86a45621f4d32249f94deec0d932a930d3a9824f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62162 Tested-by:
-
Sybille Peters authored
Broken file links are now marked in RTE with yellow background and red border. This patch uses the previously introduced event :php:`BrokenLinkAnalysisEvent`. The broken links are only detected if linkvalidator is installed and has checked for broken links (e.g. via scheduler). Resolves: #84990 Releases: master Change-Id: Iddebe7f9358901c70f90f9751298ce2905684662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62091 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Ioulia Kondratovitch authored
If richtextConfiguration is set via TCA for a specific text field (e.g. for custom elements or within TCA-overrides), respect the richtextConfiguration and prefer it over the general RTE.default.preset Removed 'richtextConfiguration' => 'default' from tt_content, since it is obsolete and breaks the logic of fallback. New fallback order: 1. preset defined for a specific field via PageTS 2. richtextConfiguration defined for a specific field via TCA 3. general preset defined via PageTS 4. default Resolves: #88655 Releases: master Change-Id: I54271732ba862be4c05ccf62352ee685d72fb985 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61193 Tested-by:
-
Susanne Moog authored
composer require doctrine/dbal:"^2.10" Releases: master Resolves: #89625 Change-Id: I1f0591d2544c34d1785c3cd3ee4b8a6d6643885f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62259 Tested-by:
-
