- Dec 05, 2017
-
-
Markus Klein authored
This cleanup should ease backporting future patches in that area. Releases: master, 8.7, 7.6 Resolves: #83189 Change-Id: I42b700d2fd17beadc4a9b8e64e500f3d3b93fd1f Reviewed-on: https://review.typo3.org/54901 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Dec 04, 2017
-
-
Christian Kuhn authored
Run core v7 acceptance, unit and lint tests on php 7.2, too. Change-Id: I2db7c3fb6cde92c6d2d0320ba39343679e57e126 Resolves: #83215 Releases: 7.6 Reviewed-on: https://review.typo3.org/54928 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
The update brings patches for PHP 7.2 compatibility. Change-Id: Ibdfc231cd336511e0327eae485003d818fd1cc1e Resolves: #83222 Releases: 7.6 Reviewed-on: https://review.typo3.org/54930 Tested-by:
-
Auer, Fabian authored
Latest 2.2 branch of the require-dev dependency of php-cs-fixer brings PHP 7.2 compatibility. The core has this dependency to run the cglFixMyCommit.sh script which needs a slight adaption with the version raise. Change-Id: I5c80b80716fdfa076ca77d281587cbb9c8d1068d Resolves: #83220 Releases: 7.6 Reviewed-on: https://review.typo3.org/54818 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Dec 03, 2017
-
-
Christian Kuhn authored
The CountViewHelper calls count() on non-arrays or non-Countable objects. This throws warnings on PHP 7.2 - sanitize this call. Change-Id: Ie1932c31a099577cb0d344824a6441509aefbc03 Resolves: #83214 Releases: 7.6 Reviewed-on: https://review.typo3.org/54927 Tested-by:
-
Christian Kuhn authored
Sanitize some view helper unit tests to not trigger PHP 7.2 warnings count()'ing non-arrays by proper mocking. Change-Id: I9929a02a03c9218ab73838f4a214165333d414aa Resolves: #83213 Releases: 7.6 Reviewed-on: https://review.typo3.org/54926 Tested-by:
-
Christian Kuhn authored
Unit test boostrap does not initialize constants TYPO3_REQUESTTYPE and TYPO3_REQUESTTYPE_*, but various tests rely on this basic constants being properly defined in core v7. With PHP 7.2, accessing undefined connstants throws warnings. Patch makes according bootstrap method public and calls it during unit test bootstrap. Change-Id: I450e440694385244c554adef00a9c74135d457f5 Resolves: #83211 Releases: 7.6 Reviewed-on: https://review.typo3.org/54925 Reviewed-by:
-
Christian Kuhn authored
adodb (v7 only) expects constant ADODB_ASSOC_CASE to be set. PHP 7.2 now throws warnings if constants are not defined. Patch defines ADODB_ASSOC_CASE in unit test setUp() if it not has been defined before. Change-Id: Ie338c3e871ae0eb2f8536515c65b556381bf65c3 Resolves: #83210 Releases: 7.6 Reviewed-on: https://review.typo3.org/54924 Tested-by:
-
Christian Kuhn authored
Test suite on core v7 with PHP 7.2 complains a lot about "Undefined constant OCI_COMMIT_ON_SUCCESS". This is found in the adodb oracle oci8 driver, used as property default value and thus evaluated as soon as the driver class is instantiated in tests. The test suite does not include oci8 in php. The php module sets constant OCI_COMMIT_ON_SUCCESS to hex '0x20' which is 32 in decimal. The patch uses decimal 32 to suppress the warning if oci8 module is not loaded for tests. Change-Id: I218e9758fe8b1bf8a92a8398f6782faa4ed4c9c9 Resolves: #83209 Releases: 7.6 Reviewed-on: https://review.typo3.org/54923 Tested-by:
-
Christian Kuhn authored
Raising this indirect require-dev dependency fixes ~330 unit tests on PHP 7.2 that otherwise throw a count() on non-array or countable warning. Change-Id: I3dce8ffe6d2180bf41740b0bc5fd8397425cc985 Resolves: #83207 Releases: 7.6 Reviewed-on: https://review.typo3.org/54921 Tested-by:
-
Christian Kuhn authored
Global function debug() initializes its 6th argument to constant E_DEBUG which does not exist and then defaults to string 'E_DEBUG'. This raises a PHP 7.2 warning. Relevant for v8 & v7 only, this argument has been removed in master already. Fix by defaulting to string 'E_DEBUG' in method signature. Change-Id: If04c9e55bb810980b19b924496680ea1758e4b24 Resolves: #83200 Related: #82640 Releases: 8.7, 7.6 Reviewed-on: https://review.typo3.org/54915 Tested-by:
-
Christian Kuhn authored
Sanitize a count() call in PreparedStatement (8.7, 7.6 only) for PHP 7.2 compatibility. Change-Id: I8d3cac3814093c7223c6be8f8ab8dc8c610d28e1 Resolves: #83196 Releases: 8.7, 7.6 Reviewed-on: https://review.typo3.org/54912 Tested-by:
-
Christian Kuhn authored
Raising this indirect require-dev dependency fixes a PHP 7.2 compatibility issue on core 7.6 branch: "Declaration of DOMNodeComparator::assertEquals() must be compatible with ..." Change-Id: I1c422edab82250b51ae9a0cc268110c62977ee08 Resolves: #83195 Resolves: #83120 Releases: 7.6 Reviewed-on: https://review.typo3.org/54910 Reviewed-by:
-
- Dec 02, 2017
-
-
Christian Kuhn authored
An array key is not used as string but as constant in two ConfigurationManager test cases. PHP 7.2 is more picky about this an throws warnings. Fix by creating proper strings. Change-Id: I64def6cf9b5d9df7e150d137929c721558c761d7 Resolves: #83190 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/54905 Tested-by:
-
- Dec 01, 2017
-
-
Wouter Wolters authored
During a backport of #80920 the file reference was not updated to the right location. Resolves: #83187 Releases: 7.6 Change-Id: I20637d1d1ee26f892084909c600cbe43a7c46a02 Reviewed-on: https://review.typo3.org/54900 Reviewed-by:
-
- Nov 30, 2017
-
-
Christoph Lehmann authored
TCEFORM.pages.categories.config.treeConfig.rootUid should filter the category tree. Non-Admin users with category mounts currently need every child category of rootUid in their category mounts since the rootline of rootUid is not checked against the category mounts. Resolves: #78274 Releases: master,8.7,7.6 Change-Id: Id02ae69111df7397207939a034ed05797eb160ad Reviewed-on: https://review.typo3.org/54138 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Nov 29, 2017
-
-
Benni Mack authored
When publishing a workspace, incorrect TCA might lead to a catchable fatal error. This happened, when TCA for a field did not contain a config-entry. Resolves: #77619 Releases: master, 8.7, 7.6 Change-Id: I81a3b727320ee984908c964d0729551c4c264f8d Reviewed-on: https://review.typo3.org/54855 Tested-by:
-
- Nov 28, 2017
-
-
Sebastian Hofer authored
Fix the identifier string, which is used to retrive the file object, a relative path instead of an absolute path is expected. Releases: 7.6 Fixes: #82672 Change-Id: I8786330f07996f1b341bb38fafa50709d364d25e Reviewed-on: https://review.typo3.org/54839 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Nov 27, 2017
-
-
Łukasz Uznański authored
Add 'Cache-Control: no-store' if conditions allowing client caching are not met. This change will prevent caching content by browser. Resolves: #81160 Releases: master, 8.7, 7.6 Change-Id: Ia91a339178b8cd8387706679bbea40ed0d1b0548 Reviewed-on: https://review.typo3.org/54794 Tested-by:
-
Christian Kuhn authored
The bamboo test setup relies on a funny solution to determine the gerrit patch id and patch set, used for reporting results back to gerrit. The regex based solution started behaving weird with latest bamboo versions and is now quoted slightly differently to fix that. Special thanks to atlassian support for being friendly, helpful, quick and providing a working solution to our issue. Change-Id: I51ec85be2133033777fac8ff1f12071a81c71efc Resolves: #83107 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/54777 Tested-by:
-
- Nov 24, 2017
-
-
Jigal van Hemert authored
Spaces added between attributes of boolean input fields. Resolves: #83040 Releases: 7.6 Change-Id: I28f24bbfbc46d992e452b7f0420c64575dda2df5 Reviewed-on: https://review.typo3.org/54738 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- Nov 22, 2017
-
-
Stefan Neufeind authored
Add for/id so clicking the label toggles the checkbox. Resolves: #83040 Releases: master, 8.7, 7.6 Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326 Reviewed-on: https://review.typo3.org/54721 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Nov 20, 2017
-
-
Markus Günther authored
Releases: master, 8.7, 7.6 Fixes: #83044 Change-Id: I2c16f160a18f4c0e58b87261b59fbde90aca2f82 Reviewed-on: https://review.typo3.org/54698 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Helmut Hummel authored
Because users have no access to deleted pages, the access check always fails, leading to delete page actions not being shown in the history despite being properly tracked. We now check this case and do a more lightweight check so that we still have the permissions checked, but can show deleted pages without disclosing unwanted information. Resolves: #45056 Releases: 7.6, 8.7, master Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c Reviewed-on: https://review.typo3.org/54610 Tested-by:
-
Markus Klein authored
Move the hidden form field out of the label tag to ensure clicking the label's content (eg. fa icon) really toggles the checkbox. Resolves: #82998 Releases: master, 8.7, 7.6 Change-Id: Id4293b4109c82a9e6410e113a5b5560ffd1b75d4 Reviewed-on: https://review.typo3.org/54683 Tested-by:
-
- Nov 08, 2017
-
-
Georg Ringer authored
The title of a translated page must be overlayed with the workspace version. Resolves: #65607 Releases: master, 8.7, 7.6 Change-Id: If10260f196776a16a53968b78542827ecbc145fe Reviewed-on: https://review.typo3.org/54585 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Nov 02, 2017
-
-
Markus Klein authored
With this fix the access module again returns to the correct page the user expects it to return to. Resolves: #82883 Releases: master, 8.7, 7.6 Change-Id: I76953aa1547365db6fbbea772d786e1ad9bfc184 Reviewed-on: https://review.typo3.org/54528 Tested-by:
-
Markus Klein authored
Resolves: #79915 Releases: master, 8.7, 7.6 Change-Id: Ie3b573857ff011295be198633a0f6868b1ff55b6 Reviewed-on: https://review.typo3.org/54527 Tested-by:
-
- Oct 30, 2017
-
-
Georg Ringer authored
Readd an image which has been removed during cleanups Resolves: #82857 Releases: 7.6 Change-Id: Idd487fec1d35dc919099bcf9477860976d346d38 Reviewed-on: https://review.typo3.org/54477 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
-
- Oct 20, 2017
-
-
Sebastian Hofer authored
Changes the rendering for li tags in RTE in sys ext css_styled_content. This change is based on a former bugifx for TYPO3 6.2: https://review.typo3.org/#/c/38681/ The fix was not ported to css_styled_content for TYPO3 7, so the issue is present in TYPO3 7 if no fluid_styled_content TypoScript is present. Releases: 7.6 Resolves: #65506 Change-Id: I1aa744b7f381681a01cb797ff6dd9c61f221934a Reviewed-on: https://review.typo3.org/54165 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Oct 18, 2017
-
-
Harry Glatz authored
The TypoScript of the CSC header element does not respect the global lib.parseTarget configuration Resolves: #36216 Releases: 8.7, 7.6 Change-Id: I08ea6c59829a4a63b4aca6bf90b89223921b3fdf Reviewed-on: https://review.typo3.org/54430 Tested-by:
-
Susanne Moog authored
When using PHP7 declarations of sub classes have to be compatible to their parent declarations. As the install tool has been completely refactored in newer TYPO3 version this patch implements only a workaround to prevent the PHP warning. Change-Id: I4128b3aef30a3a1bb9de6188509db1cdf4314b02 Resolves: #77203 Releases: 7.6 Reviewed-on: https://review.typo3.org/54417 Tested-by:
-
- Oct 15, 2017
-
-
Nicole Cordes authored
This patch adds missing functional tests for \TYPO3\CMS\Backend\Controller\FormInlineAjaxController::createAction Related: #82330 Releases: master, 8.7, 7.6 Change-Id: I61c8c07dd0d2c6a92bb445d7f2b6baee23251f5d Reviewed-on: https://review.typo3.org/54170 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Oct 12, 2017
-
-
Christian Kuhn authored
Setting / unsetting the checkbox "Use regular expression" fails with JavaScript error "jumpToUrl is not defined". Add that to the document body. Change-Id: I0a5928e008972493d070a35d1219a0acca579ce8 Resolves: #82746 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/54380 Tested-by:
-
- Oct 10, 2017
-
-
Marc Bastian Heinrichs authored
Because of a missing page uid in rte module window iframe urls, like for the BrowseLinks popup, the ConditionMatcher could not evaluate conditions in INCLUDE_TYPOSCRIPT that rely on the page uid, like PIDinRootline. Resolves: #81190 Releases: 7.6 Change-Id: I7952b910d9caa50ce5ca1abd6bf7309ad80c60b1 Reviewed-on: https://review.typo3.org/52756 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- Oct 09, 2017
-
-
Joshua Westerheide authored
Resolves: #82697 Releases: master, 8.7, 7.6 Change-Id: I64bf51d5efd0394f4d3269965820281cbaf2de90 Reviewed-on: https://review.typo3.org/54331 Tested-by:
-
- Oct 05, 2017
-
-
Christian Kuhn authored
The 6.0 to 6.1 upgrade allows us to specifiy last missing pieces via bamboo specs: mostly job cleanups, plugin configuration and plan permissions. Change-Id: If26aeb45b1109ba9797f3807087201033ea1f368 Resolves: #82679 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/54299 Tested-by:
-
- Sep 25, 2017
-
-
Georg Ringer authored
Allow 255 chars for a domain to be in sync with RFC 1035. Resolves: #82515 Releases: master, 8.7, 7.6 Change-Id: I63916cb115b00e50c62c1926cf890e29bf89de77 Reviewed-on: https://review.typo3.org/54191 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- Sep 23, 2017
-
-
Frank Naegler authored
Resolves: #82533 Releases: master, 8.7, 7.6 Change-Id: Ia47f604b9cb7fa53d3707e6150554709cbfdb763 Reviewed-on: https://review.typo3.org/54197 Tested-by:
-
- Sep 20, 2017
-
-
Markus Hoelzle authored
Disallow backend users to edit pages which doktypes are not allowed via backend usergroup permissions. Resolves: #79954 Releases: master, 8.7, 7.6 Change-Id: I527602e71c62bc8e33b0886a5758c7c8040b4720 Reviewed-on: https://review.typo3.org/53715 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
