- Nov 25, 2012
-
-
Steffen Ritter authored
Change-Id: Ib027351a353ca1fc5ee33bb13b18317d64267d8e Releases: 6.0 Resolves: #43287 Reviewed-on: http://review.typo3.org/16728 Reviewed-by: Steffen Ritter Tested-by: Steffen Ritter
-
TYPO3 Release Team authored
Change-Id: I7b1cefba3bdeb975caadcc403b520a91fdb312c9 Reviewed-on: http://review.typo3.org/16726 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
Jigal van Hemert authored
This reverts commit 8e0b7cba Change-Id: I03c5aa86d3ef07dab5a9de9f4c59f1c3b3fb9a48 Reviewed-on: http://review.typo3.org/16723 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Jigal van Hemert authored
PagePositionMap::printContentElementsColumns must call insertPositionIcon with fake row array instead of empty string as first parameter. Change-Id: I11afd7e8cad47b6892f0cd60feea8b53ff4d5945 Fixes: #43284 Releases: 6.0 Reviewed-on: http://review.typo3.org/16722 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Helmut Hummel authored
With 6.0 all Xclass inclusion in the classes have been removed and registration of Xclasses have previously been moved to the autoloader. This added additional complexity and another concern to the class loader. To enable extensions to override classes, an object implementation registry is now introduced, where you can now define which implementation class name should be used for an original class. This not only is a complete replacement for former Xclasses, but at the same time adds the possibility to have the implementation class name within the namespace and scope of the extension which registers the override. On top it would also be possible to register implementations for interfaces. Since only class names are mapped here, we again have a clear separation of concerns, where the class loader is only responsible to resolve paths for class names and the "object manager" method makeInstance for resolving the final class name to instantiate. The path of the target class can be resolved automatically by the class loader if naming conventions are met or the target class name is put into the autoloading registry. An implementation of a class can be registered like this: $TYPO3_CONF_VARS['SYS']['Objects']['originalClass'] = array('className' => 'targetClass'); The patch adjusts the ClassLoader and makeInstance. The unit tests for the ClassLoader are removed since it is not responsible for resolving Xclasses any more. Instead unit tests for makeInstance are added to test the new behavior. Resolves: #43269 Releases: 6.0 Change-Id: I04198b178aa41f02d7a5b7ee990ff24f483990f5 Reviewed-on: http://review.typo3.org/16712 Reviewed-by: Steffen Ritter Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Tested-by: Steffen Ritter Reviewed-by: Christian Kuhn Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Felix Kopp authored
Restores css styles for table header rows. Keeps newly introduced style for content element header. Change-Id: Ic368eeb5f98fa7026508f7273499e1c64d4ce30f Fixes: #43281 Releases: 6.0 Reviewed-on: http://review.typo3.org/16721 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
Philipp Gampe authored
The autoloader assumes that classes are located inside Classes, but the directory is still lower case classes. Rename the directory to conform to the default behavior. Fixes: #43280 Releases: 6.0 Change-Id: Id8fc4c4e2f5290a45d4aac62ca577d6fdbfb5266 Reviewed-on: http://review.typo3.org/16720 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Nov 24, 2012
-
-
Ivan Kartolo authored
Overwork the styling of the Page module: * New style for columns * Hide new icons by default, show on hover * Style Drag & Drop Thanks to Lars Zimmermann and Jens Hoffmann Change-Id: I7f06382c51561e8c9855af0ef15afea1a8dd6acb Resolves: #43208 Releases: 6.0 Reviewed-on: http://review.typo3.org/16700 Reviewed-by: Steffen Gebert Tested-by: Steffen Gebert Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Helmut Hummel authored
All versioning information and actions should be hidden if workspaces are used. One remaining selector is in the page module when a page has been versioned in a workspace. Hide this selector when workspaces extension is installed. Fixes: #43264 Related: #27969, #25962 Releases: 4.5, 4.6, 4.7, 6.0 Change-Id: If96f1fe99f2a7a5b5b48f1f8a1aca8f053a6622a Reviewed-on: http://review.typo3.org/16706 Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Nov 22, 2012
-
-
Christian Kuhn authored
The patch splits the FLUIDTEMPLATE content object to smaller and more readable code pieces. Additionally, 27 new unit tests are added for the public API method, checking all important code areas and documenting current behavior. Change-Id: I049718a7f00da20534d28353796878310871adf4 Resolves: #43182 Releases: 6.0 Reviewed-on: http://review.typo3.org/16639 Reviewed-by: Helge Funk Reviewed-by: Stefan Neufeind Tested-by: Stefan Neufeind Reviewed-by: Anja Leichsenring Tested-by: Anja Leichsenring Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Mattias Nilsson Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Michael Stucki authored
Change-Id: Ia4c9ec4cb174493810e90d018082a92d37485194 Resolves: #42422 Releases: 6.0 Reviewed-on: http://review.typo3.org/16684 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Michael Stucki authored
Change-Id: Ia1de8910ee216767dfc286590cb81a5cee9f640f Resolves: #42422 Releases: 6.0 Reviewed-on: http://review.typo3.org/16683 Reviewed-by: Ernesto Baschny Tested-by: Ernesto Baschny Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
- Nov 21, 2012
-
-
Helmut Hummel authored
The header thumbnail is not correctly rendered when inserting new images because the code tries to fetch the record which is not created yet. Use the data of the temporary record instead, to be able to correctly create the thumbnail in the header. Fixes: #43189 Releases: 6.0 Change-Id: Ic75fd6c70c8c10777a762f585c4c4b3ec467fe75 Reviewed-on: http://review.typo3.org/16657 Tested-by: Anja Leichsenring Reviewed-by: Anja Leichsenring Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Stefan Neufeind Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Jigal van Hemert authored
Fix a few typos. Change-Id: Id1087e7972e65f0d4463d6d4c7c0613039bbb98e Fixes: #43188 Releases: 6.0 Reviewed-on: http://review.typo3.org/16656 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert
-
TYPO3 Release Team authored
Change-Id: I4a43697dd6fa44910243b3a6b4ea57fe499df64b Reviewed-on: http://review.typo3.org/16649 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
TYPO3 Release Team authored
Change-Id: If2ba9153384609a7f87d8ab3e74c293ae0c77b3a Reviewed-on: http://review.typo3.org/16648 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
TYPO3 Release Team authored
Change-Id: Ibc293fdca09d424718f858e4b7585082ebf1e461 Reviewed-on: http://review.typo3.org/16647 Reviewed-by: TYPO3 Release Team Tested-by: TYPO3 Release Team
-
Oliver Hader authored
The jsfunc.placeholder.js file was introduced to have a fallback for Internet Explorer on the HTML5 placeholder feature. However, this handling is currently active in all browsers and results in broken NULL values for textarea, since textarea don't have a human readable representation like input fields. Fixes: #43183 Releases: 6.0 Thus, only activate the handling in Internet Explorer. Change-Id: Ie27c8e8544fa99cad14f3a74fa960524cc7e834a Reviewed-on: http://review.typo3.org/16644 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
Currently there's no possibility to handle NULL values in TypoScript. This is related to the feature "Add possibility to store NULL values (#41773)". Thus, two new elements are integrated: * (stdWrap).ifNull -> string/stdWrap * (stdWrap).if.isNull -> stdWrap Change-Id: I77a29341c66edaf3bef14de33f65c702fbbb9fbd Resolves: #43133 Releases: 6.0 Reviewed-on: http://review.typo3.org/16637 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
Deactivated textarea elements, fields that have a NULL value stored in the database, are not visualized correctly when loading the backend editing form. The status is currently set using JavaScript and triggered by TBE_EDITOR.fieldSet(). However, textareas don't have a human readable clone and thus fieldSet() is not called and thus no status is set. This issue is fixed by directly rendering the status in the FormEngine. Change-Id: I2dded816853f452b25f6edf6e7d7f6dca1387739 Fixes: #43175 Releases: 6.0 Reviewed-on: http://review.typo3.org/16636 Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
Change-Id: Ib1b9f2f4bc274bcb1f180507a8ca0257323fd4bc Releases: 6.0 Reviewed-on: http://review.typo3.org/16642 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Kai Vogel authored
This patch allows the configuration of the thumbnail image in IRRE record headers. It is possible to configure e.g. height and width using the TCA configuration in "headerThumbnail". Resolves: #42837 Releases: 6.0 Change-Id: I284e9d04676fb3d4031eac6d2f8548761e167e69 Reviewed-on: http://review.typo3.org/16377 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Helmut Hummel authored
Fixes: #42932 Related: #42806 Releases: 6.0 Change-Id: I05c179c917ed43cb70c2966984080670192713d4 Reviewed-on: http://review.typo3.org/16641 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
- Nov 20, 2012
-
-
Helmut Hummel authored
Fixes: #42930 Releases: 6.0 Change-Id: I71780306d8edcd0da769ba7c56d4d4e3e386b77c Reviewed-on: http://review.typo3.org/16640 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Oliver Hader authored
The fields title, description and alternative are available in file references and files. If those in file references are not defined, those of files shall be used. Besides that, some fields are not configured yet to be shown as placeholder element in the backend. The flaws are fixed by adding accordant TCA configuration and adding the fallback behaviour for the FileReference object. Change-Id: I28fa94faeb88958ce6c6cb942ba9a88bd555acdf Fixes: #43173 Releases: 6.0 Reviewed-on: http://review.typo3.org/16635 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Andreas Wolf authored
File processing is a central part of TYPO3's file usage, as e.g. all images in content elements have to be resized when they don't fit the requirements. However, the current implementation of file processing with FAL has several drawbacks and shortcomings, not to mention quite a few bugs. This patch brings a completely reworked infrastructure behind the File Processing Service, while keeping the external API unchanged. The processing to be done is described in tasks, which are part of a ProcessedFile's properties. The processing itself is now moved to processors, which could execute the tasks using different utilities, e.g. ImageMagick or some cloud image processing service. Currently, there is only a local image processor implementation, which relies on ImageMagick/GraphicsMagick (i.e. uses the same configuration as the old processing). The processed file class now also supports safe handling of unchanged files, i.e. files that should have been processed, but didn't need processing. Fixes: #43059 Fixes: #39904 Fixes: #40033 Fixes: #40669 Releases: 6.0 Change-Id: I186a46f9923dacd98be655d72be2bd89b43866c2 Reviewed-on: http://review.typo3.org/14310 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Christian Kuhn authored
EXT:fluid is a required extension since TYPO3 6.0. The isLoaded('fluid') call in FLUIDTEMPLATE content object can be removed. Change-Id: I514163bffc19fa264501dc2d88e1fe59f0e9a062 Fixes: #43172 Releases: 6.0 Reviewed-on: http://review.typo3.org/16633 Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Nicole Cordes authored
Some tests fail on Windows systems. Mostly this is because of a missing file and folder permission handling. Those tests have to be skipped. Furthermore there is some path fixing needed in basic class. Change-Id: Ib89e84539af2742dbb3a6e2f53ae5a0c121a0626 Fixes: #43126 Release: 6.0 Reviewed-on: http://review.typo3.org/16596 Reviewed-by: Oliver Klee Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Wouter Wolters Tested-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Marc Bastian Heinrichs authored
Passed $data in start method could be a non-array, e.g. in fluid CObjectViewHelper or in extensions. Migrate $data only if it's a not empty array and the table is set. Makes the fieldArray fallback to TSFE->page in getData working again. Change-Id: I469e8fa6131579a2de399516c65f4822275b187b Fixes: #43068 Fixes: #43055 Releases: 6.0 Reviewed-on: http://review.typo3.org/16546 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Nicole Cordes authored
In TYPO3 4.7 (and below) the default field of a configuration was a text field. With a wrong configuration type in ext_conf_template.txt now the field isn't rendered any more. There should be a fallback to a normal input field like it used to. Fixes: #43042 Releases: 6.0 Change-Id: Ic49c9b19a7f8f1795889f17ed5c1efa364dfd9b9 Reviewed-on: http://review.typo3.org/16503 Reviewed-by: Jigal van Hemert Tested-by: Jigal van Hemert Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Oliver Hader authored
The meta data (like description, title, ...) in File References cannot be used to disable the inherited data from the parent File object. Currently values can be blank which results in using data from the parent. To really override by using blanks, the new NULL feature for TCA fields needs to be used. Change-Id: I61e5f5e6a0d848e95e2e0402913778ef9f63a093 Fixes: #43132 Releases: 6.0 Reviewed-on: http://review.typo3.org/16602 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Nicole Cordes authored
In some queries backticks are used to generate the WHERE clause. Those backticks lead to an error when using dbal. Therefore they have to be removed. Change-Id: If6aa29f73fda93cfc122af51201730cc6475a8c1 Fixes: #43168 Release: 6.0 Reviewed-on: http://review.typo3.org/16629 Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Nicole Cordes authored
For the table sys_category_record_mm after the first KEY command there is a missing comma which leads to dbal crash. Change-Id: Ib5d88df46c166a9e7fffd5106e5158679cd947d8 Fixes: #43167 Release: 6.0 Reviewed-on: http://review.typo3.org/16628 Reviewed-by: Anja Leichsenring Reviewed-by: Philipp Gampe Reviewed-by: Wouter Wolters Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Oliver Hader authored
Activating a field that supports NULL values and just using a blank string ("") does not work. The problem is a strcmp() call that returns a false-positive on comparing NULL to blank strings Change-Id: I59417f5f5cd814db15e2b6b725f1778d098014f6 Fixes: #43139 Releases: 6.0 Reviewed-on: http://review.typo3.org/16599 Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
Oliver Hader authored
The BaseTestCase already has a possibility to create full blown accessible object proxies. However if one does not want to have the class stack cluttered with temporary existing classes, there shall be a possibility to directly invoke protected/private methods of a fixture object. The new method callInaccessibleMethod method is taken and rewritten from ModuleControllerTest. Example to use it in unit tests: $this->fixture = new \TYPO3\CMS\Core\SomeClassName(); $result = $this->callInaccessibleMethod( $this->fixture, 'privateMethod', $first, $second, $third, ... ); Change-Id: I2c90c136c350129b28809d8b8b88286149894a10 Resolves: #43145 Releases: 6.0 Reviewed-on: http://review.typo3.org/16598 Reviewed-by: Philipp Gampe Tested-by: Philipp Gampe Reviewed-by: Oliver Hader Tested-by: Oliver Hader
-
- Nov 19, 2012
-
-
Nicole Cordes authored
Some tests are failing in TYPO3\CMS\Core\Tests\Functional\Category\Collection\CategoryCollectionTest due to false CREATE TABLE statement. Change-Id: I8fe03b4d02c8f85fcddf8be06010eb8b2f079102 Fixes: #43122 Release: 6.0 Reviewed-on: http://review.typo3.org/16594 Reviewed-by: Wouter Wolters Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
Change-Id: I3f333615f87c7682d251987df1e58403720d331b Reviewed-on: http://review.typo3.org/16592 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
The 'old' class files before namespace switch are commented to be removed with TYPO3 7.0, but they should be scheduled for removal with 6.2. Change-Id: I2db757db54410c5764ab21aef90918a7771f2c92 Resolves: #43120 Releases: 6.0 Reviewed-on: http://review.typo3.org/16590 Reviewed-by: Christian Kuhn Tested-by: Christian Kuhn
-
Christian Kuhn authored
EXT:cms/ext_tables.sql and t3lib/stddb/tables.sql define an identical table schema of table cache_imagesizes. Since cache_imagesizes is used in core classes, the duplication in EXT:cms is removed with the patch. Change-Id: I67a861afe34f3e388f898fc3f0bad5b5c574d626 Resolves: #43119 Releases: 6.0 Reviewed-on: http://review.typo3.org/16583 Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-
Marc Bastian Heinrichs authored
The deprecated classes have been removed in Fluid. Remove them from the IDE file. Related: #43069 Releases: 6.0 Change-Id: I2d51053009fe0455e3d085645de37ac037363d41 Reviewed-on: http://review.typo3.org/16553 Reviewed-by: Oliver Klee Reviewed-by: Helmut Hummel Tested-by: Helmut Hummel
-