- Jun 09, 2022
-
-
André Buchmann authored
Some default fields (e.g. tt_content.bodytext) can contain null values. TYPO3 first fetches the data in the default language and then overlays the rows data with the translation values. The overlay method inspects each array item with the php isset() function. This validates not only the existence of the array key, but also the values. null and false values evaluated as false. Empty strings evaluate as true. This leads to inconsistent output in the frontend. The overlay now valides only the array key existence and applies also empty values. Resolves: #97616 Releases: main, 11.5, 10.4 Change-Id: I4b01c52e9ac7adde786b3395bce870bc0a354b58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74834 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Larry Garfield authored
More code paths identified as dead by PHPStan, or that PHPStan isn't understanding correctly. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97649 Releases: main, 11.5 Change-Id: I8ff67b7ebda5d64624d4e42a9775e4709bff3f08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74836 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Jun 07, 2022
-
-
Simon Schaufelberger authored
Searched for "/** @var " and went through all results manually. Skipped results where GeneralUtility::makeInstance is called with a variable. This reduces the PHPStan baseline further. Imported some namespaces on the go. Run commands: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline > Build/Scripts/runTests.sh -s cglGit Resolves: #97705 Releases: main,11.5 Change-Id: I700ba596234af8cd3d32507fb03d77cfe30c678a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74787 Tested-by:
-
Josua Vogel authored
Guard invalid argument type exception by using null coalescing operator in `\TYPO3\CMS\Form\Domain\Finishers\FinisherVariableProvider`. Resolves: #97699 Releases: main, 11.5 Change-Id: I6312fb35d52857004e0467a20e215fc4095e0037 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74832 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Jun 06, 2022
-
-
Simon Schaufelberger authored
Also add some (indirect) basic tests for GifBuilder::calculateValue. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97690 Releases: main, 11.5 Change-Id: I836db8570f64ecb2729c1707fcfe9fc1af672151 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74771 Reviewed-by:
-
Simon Schaufelberger authored
Sometimes it happens that the page tree is not updated within a certain amount of time resulting in failing tests. This patch will add a timeout and makes sure that the page tree is updated. Resolves: #97714 Releases: main, 11.5 Change-Id: Id28d955ccda6838701aea63e6aa97b5ee9c602b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74823 Tested-by:
-
Chris Müller authored
Resolves: #97658 Releases: main, 11.5 Change-Id: Ic4e18d64849e64404dca0eef240060d882476526 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74770 Tested-by:
-
Oliver Klee authored
This is now covered by the annotations using generics in the testing framework base class, and hence not needed anymore. (Removing it also helps get consistent behavior from PhpStorm's static type analysis.) Resolves: #97736 Releases: main, 11.5, 10.4 Change-Id: Ia7d7e790bb92eaf1c9b7ffa4f9d97b2b0a50dee3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74768 Reviewed-by:
-
- Jun 05, 2022
-
-
Oliver Bartsch authored
For translating / synchronizing (inline) records, the DataHandler dispatches the data map to the DataMapProcessor. This components' implementation of the translation prefix however differed from the one in DataHandler, leading to inconsistency, as some fields still got the "Translate to:" prefix added, while others did not. This is now fixed by aligning the functionality with the one used in the DataHandler. Resolves: #97721 Releases: main, 11.5 Change-Id: I425ca172f2c66cf43613fb62be0e35fa1dff76fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74767 Tested-by:
-
- Jun 04, 2022
-
-
Georg Ringer authored
The pagination links of the redirects module must respect a given ordering. Resolves: #97645 Releases: main, 11.5 Change-Id: Iaa65b8e365e9014796c463118504182f66b49ccb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74766 Tested-by:
-
Oliver Klee authored
For empty storages, we need to avoid accessing inexistent array elements. Resolves: #97417 Relates: #97554 Releases: main, 11.5 Change-Id: Ieee36b4c0ede9726ce936030f631a3322e3813a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74765 Tested-by:
-
- Jun 03, 2022
-
-
Sascha Egerer authored
The placeholder replacement in the yaml import method must receive the current configuration context to be able to replace placeholders with values that are already configured instead of the subvalues of the import statement. Resolves: #92956 Releases: main, 11.5 Change-Id: I4766bf1e6d268bb4c1bdd24e638c9b5056e600b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74764 Tested-by:
-
Marc Willmann authored
Even if the property 'crop' is not explicit set in the TypoScript code provide expected values to the stdWrap method (which expects a string and not NULL). Resolves: #97720 Releases: main, 11.5 Change-Id: Id8039ea5e379aa9a3ed81499f90160a5af8546f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74763 Tested-by:
-
Georg Ringer authored
Instead of checking for the array key `enablecolumns` the check must be done on the field `disabled` itself. Resolves: #97728 Releases: main, 11.5 Change-Id: I411b37d4d63eb1ad52592cd887a95c2552ab7bfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74762 Tested-by:
-
Oliver Klee authored
Also drop type annotations that already are present in the corresponding field in the superclass, and drop some type annotations that are redundant with the existing native type declarations. This helps resolves a bunch of new PHPStan warnings after the recent changes in the testing framework. It also helps static code analysis, and makes the code more succinct. Resolves: #97687 Releases: main, 11.5 Change-Id: I6f1b67f410f7e195b036bc5b5b528cb271a990b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74749 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Andreas Fernandez authored
If TCA with a file upload is used within IRRE (e.g. as done by EXT:news), creating a new record or opening an existing record now sets up the drag uploader. As the DragUploader module is loaded independently from the FormEngine main module, loading order may vary, rendering an event-based solution unstable. To solve this issue without any major refactorings, a MutationObserver is installed by the DragUploader module. Resolves: #97676 Releases: main, 11.5 Change-Id: I36a3922999842f4d0bddfc7e4b148ec39880d9df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74813 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Hader authored
+ npm package moment up to v2.29.2 contained a vulnerability (https://github.com/advisories/GHSA-8hfj-j24r-96c4) which only affected npm server users - in order to avoid confusion concerning security aspects, the package version is raised + npm package moment-timezone was upgraded to recent timezone data "IANA TZDB 2021" Executed commands: cd Build; \ nvm use; \ yarn upgrade moment moment-timezone; \ yarn exec grunt clear-build; \ yarn exec grunt build Resolves: #97723 Releases: main, 11.5, 10.4 Change-Id: I84ea9ca6b696d74aab70cfa45e6d41a95ae0159d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74803 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Jun 02, 2022
-
-
Oliver Klee authored
Also add a missing type cast. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97426 Releases: main, 11.5 Change-Id: I5a48c0737833792f99652cc54a90db9bcbe798b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74808 Tested-by:
-
Oliver Hader authored
composer req --dev composer/composer:^2.2.12 Resolves: #97722 Releases: main, 11.5 Change-Id: I526de4c62b5f9bc03230a8794cd42082e9f00560 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74801 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- May 31, 2022
-
-
Oliver Bartsch authored
The scheduler module contains a special task, which allows to select schedulable symfony commands. The corresponding field provider therefore adds the commands' configured arguments and options. Due to insufficient prefixing, it was not possible to display arguments and options with the same name. Additionally, using "action" as name always overwrote the "select schedulable commands" field. This is now resolved by adding proper prefixes. Resolves: #97691 Releases: main, 11.5 Change-Id: I0e2c958fc699065cad6c53c0876e2c9ef14fc1f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74761 Tested-by:
-
Larry Garfield authored
Based on the code, these parameters are nullable. The doc comments should reflect that. Doing so eliminates several PHPStan warnings. Whether these parameters ought to be nullable is a question for another time. Resolves: #97648 Releases: main, 11.5 Change-Id: Id0cc51d159ebb0321e94f7fb77a5d560950cfb05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74791 Tested-by:
-
- May 30, 2022
-
-
Torben Hansen authored
The switch structures in `Context` class are indented wrong. This patch corrects the indentation. Resolves: #97708 Releases: main, 11.5 Change-Id: I70b9f94b196b8bb94078df41956f67619cd4bc15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74760 Tested-by:
-
Oliver Klee authored
Used commands: > composer req --dev phpstan/phpstan:^1.7.3 > ./Build/Scripts/runTests.sh -s clean > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97706 Releases: main, 11.5 Change-Id: Ida82935064ad4ff5c2858d9a5a6696befd52e512 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74789 Tested-by:
-
Oliver Klee authored
Also adapt the callers accordingly. This resolves a few PHPStan warnings and allows simplifying some code. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97703 Releases: main, 11.5 Change-Id: I29b7278960a519dd7c5e0d3e2966b75933941a38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74788 Tested-by:
-
- May 29, 2022
-
-
Larry Garfield authored
This conversion got past the big conversion patch before, probably due to the negation. Resolves: #97640 Releases: main, 11.5 Change-Id: I67dd19c286ce25ad8cda71c1451fa84ed25dc971 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74784 Tested-by:
-
- May 28, 2022
-
-
Oliver Klee authored
Resolves: #97630 Releases: main, 11.5 Change-Id: Id31d1b28929eb85dd2adaa8a263e5d84a2a842b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74783 Tested-by:
-
Larry Garfield authored
According to PHPStan, these checks are all unnecessary. Most of them appear to be type checks that have been rendered unnecessary due later type additions. They are therefore removed without replacement. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97622 Releases: main, 11.5 Change-Id: I9aac41e98b22fcce55afb97f8aeaebe3209a8bfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74782 Tested-by:
-
Torben Hansen authored
Update copyright year to 2022 Resolves: #97704 Releases: main, 11.5, 10.4 Change-Id: I15e6c0674ac293eecad88f95379ec33679dda8d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74758 Tested-by:
-
- May 27, 2022
-
-
Chris Müller authored
The patch provides the following changes: - Use consistent header levels - Format code examples with the correct language - Use example.org as domain for example link - Apply takeaways from https://forge.typo3.org/issues/85035#note-8 (chapter "login process") Resolves: #97692 Related: #85035 Releases: main, 11.5 Change-Id: If6c7851c25210cf4e03fb07efeaf14973e667cb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74757 Tested-by:
-
Andreas Fernandez authored
The package guzzlehttp/guzzle has been updated to 7.4.3 and 6.5.6 respectively, both fixing a security vulnerability related to cross-domain cookie leakage [1]. Since TYPO3 is not affected by this issue by default, this is handled as a public bugfix. However, 3rd party code (e.g. thru extensions) may be affected by this issue, as long `'cookies' => true` is used in requests done by Guzzle. Executed commands: composer require \ guzzlehttp/guzzle:^7.4.3 \ -W composer require \ -d typo3/sysext/core \ guzzlehttp/guzzle:^7.4.3 \ --no-update [1] https://github.com/guzzle/guzzle/security/advisories/GHSA-cwmx-hcrq-mhc3 Resolves: #97694 Releases: main, 11.5, 10.4 Change-Id: I39071c917c7ed26392f66b0ea2f774ecbceead9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74751 Tested-by:
-
- May 25, 2022
-
-
Felix Nagel authored
When using stdWrap for setting the actual parameter value, all additional information (like target, class and title) is lost. With this change the expected behavior (keeping and rendering all additional information) is restored. Using stdWrap for parameter is a useful feature for changing the value depending on page or record properties. Think of changing the detail page of a news record based on the type of the news. To ensure functionality there are two new tests. One for testing the general functionality when using a stdWrap parameter and one to make sure additional information is processed. Resolves: #80896 Resolves: #90404 Releases: main, 11.5 Change-Id: I60c5ae43d5e27071be9cf244a0857a25adb8592b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74576 Tested-by:
-
Oliver Bartsch authored
If a table in recordlist only contains records which do not provide a checkbox, the "toggle all" action should be disabled as well, since using this action would have no effect. Resolves: #97685 Releases: main, 11.5 Change-Id: Id87bb5dd9df10c33acd03d0c5dbca179bb7f1cdd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74744 Tested-by:
-
Oliver Bartsch authored
Ensure to properly typecast optional parameters of throwStatus() before passing them to type hinted methods. Resolves: #97666 Releases: main, 11.5 Change-Id: Ifb6d43cffc97899cdd4ab72d48703bc3db23f0e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74756 Tested-by:
-
Oliver Bartsch authored
When creating bookmarks to the "new" view in FormEngine, those bookmark previously did not show up in the toolbar list, because the parent page access check failed. This is now fixed by also resolving the parent page for new record bookmarks properly. Additionally the shortcut title for those use cases does now match the title, displayed in FormEngine. Resolves: #97655 Releases: main, 11.5 Change-Id: If62391bffe4126c746b6c5650d1aa9d0821f2960 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74741 Tested-by:
-
Oliver Bartsch authored
Occurred on accessing the record history for records on pid=0. Resolves: #97682 Releases: main, 11.5 Change-Id: I041fd9c2dfa8f8cfda4f89c47d320e5bfa6e7f3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74734 Tested-by:
Henrik Ziegenhain <henrik@ziegenhain.me> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Larry Garfield authored
The code in ConjunctionValidator can be greatly simplified by taking advantage of the fact that an empty result object can be merged with a future one. That eliminates an unnecessary code path as well as phpstan warnings. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97623 Releases: main, 11.5 Change-Id: I6f10c25562044adb5cbe283255ea07e71effa9cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74740 Reviewed-by:
-
Helmut Hummel authored
When generating the identifier for the package artifact, not only the hash from the composer.lock must be taken into account, but also whether packages have been installed in dev mode or not. Since dev mode does not change the lock hash, it otherwise can happen that a stale DI cache with invalid set of packages is used, which obviously leads to fatal errors Releases: main, 11.5 Resolves: #97688 Change-Id: I29461c133a866fcbf16848a4540eef33aa52d450 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74755 Reviewed-by:
-
Simon Schaufelberger authored
GIFBUILDER processing doesn't return a processedFile Resolves: #97651 Releases: main, 11.5 Change-Id: I24964ec640636dc88b10a5433517bed0ce576ed0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74754 Tested-by:
-
- May 24, 2022
-
-
Rudy Gnodde authored
Resolves: #97686 Releases: master, 11.5 Change-Id: I0228126e4b7dd091b6eddc70bbbd8aade6142dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74753 Tested-by:
-
Torben Hansen authored
This patch fixes a typo in the description for BE.compressionLevel. A single `s` is missing in `_.htacces` Resolves: #97683 Releases: main, 11.5 Change-Id: I6ceab51140c8cad68d724cb13b5947d1ea38dba1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74752 Tested-by:
-
